Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100811/?format=api
{ "id": 100811, "url": "https://patches.dpdk.org/api/patches/100811/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211008091732.96415-1-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211008091732.96415-1-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211008091732.96415-1-srikanth.k@oneconvergence.com", "date": "2021-10-08T09:17:32", "name": "[v2,05/11] bus/vmbus: open subchannels", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "8f0a577e69aa1f2788e147b0a27446f358d8d157", "submitter": { "id": 2368, "url": "https://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211008091732.96415-1-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 19456, "url": "https://patches.dpdk.org/api/series/19456/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19456", "date": "2021-10-08T09:16:44", "name": null, "version": 2, "mbox": "https://patches.dpdk.org/series/19456/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/100811/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/100811/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 68964A034F;\n\tFri, 8 Oct 2021 12:59:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EAB5241223;\n\tFri, 8 Oct 2021 12:56:44 +0200 (CEST)", "from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id E0DBE4067B\n for <dev@dpdk.org>; Fri, 8 Oct 2021 11:17:44 +0200 (CEST)", "by mail-pj1-f52.google.com with SMTP id\n ls18-20020a17090b351200b001a00250584aso8507315pjb.4\n for <dev@dpdk.org>; Fri, 08 Oct 2021 02:17:44 -0700 (PDT)", "from srikanth-ThinkPad-T450.domain.name ([122.162.27.38])\n by smtp.gmail.com with ESMTPSA id s17sm1943302pge.50.2021.10.08.02.17.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 Oct 2021 02:17:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=RmSLGUR5kLe35pO5ZkaS/65oexYYSvRxJlRPGswVJXc=;\n b=V0ZsdFS/v8Hz0nmP+icaUmN6uOJpMOqhcQKHFXdBFhqMvuqilNxBxARBcVDGusQk/k\n 6+/TJOhqfWSUyivyEi2xcGF/m1SjJjpXdLGDumzgTe/ExsYvYFiZW4lmBuLiZVvzpihj\n 744QatE0tdr5BT9pJytQgYs1BdS9jG53OFtOU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=RmSLGUR5kLe35pO5ZkaS/65oexYYSvRxJlRPGswVJXc=;\n b=oLrwyqHjsv9rmbE+agbDmesBfUR8ZeByHxK3Cr3ZmaAPpm080VClpWGqHzH0VKl45u\n xK7PAsJMzsIOP93kF3GM1gr+9IaUVTw1eTqErEct3PyVIS5BI4y4iXUwaIwu+d+c3/Bh\n cVWc013/tHYdiqVNj/flOXoeDvA5HLkaoPaFc8hSjz/BFrBZ6OKo3EU0aaji5AijzWoK\n uU6KX9zazi1btJbQWN4jPDioK5+7a5iL4T4dFMsPnw32rIRXt9Z8TgFMOtkeKqfTPbFt\n TsvlZ2EVEXFGuQJthnXMpz4x0fh/OcIaY3TAeI1ac1WFlK/qa0ZsXcdc6e8QKe8aSOU4\n RJbQ==", "X-Gm-Message-State": "AOAM5312PCdnuT891j2qUU9WceEA7zEfLrq9PmKWk9nZwE0T6/5yZYn2\n Kx52RsmLvo5SeBfuHjX2bWQTpA==", "X-Google-Smtp-Source": "\n ABdhPJxefP9UwS1NL6jH01q5XO5lpPlwHz1WDTdxwje0q6MrRISkdvW/BvspnGsahDuOfXJuRMvdTw==", "X-Received": "by 2002:a17:902:e848:b0:13e:f908:155a with SMTP id\n t8-20020a170902e84800b0013ef908155amr8506394plg.13.1633684663965;\n Fri, 08 Oct 2021 02:17:43 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n srikanth-oc <srikanth.k@oneconvergence.com>", "Date": "Fri, 8 Oct 2021 14:47:32 +0530", "Message-Id": "<20211008091732.96415-1-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 08 Oct 2021 12:55:54 +0200", "Subject": "[dpdk-dev] [PATCH v2 05/11] bus/vmbus: open subchannels", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: srikanth-oc <srikanth.k@oneconvergence.com>\n\nIn FreeBSD, unlike Linux there is no sub-channel open callback that\ncould be called by HV_UIO driver, upon their grant by the hypervisor.\nThus, the PMD makes an IOCTL to the HV_UIO to open the granted\nsub-channels\n\nv2 - Added comment in linux/vmbus_uio.c\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/bus/vmbus/freebsd/vmbus_uio.c | 31 +++++++++++++++++++++++++++\n drivers/bus/vmbus/linux/vmbus_uio.c | 12 +++++++++++\n drivers/bus/vmbus/private.h | 1 +\n drivers/bus/vmbus/rte_bus_vmbus.h | 10 +++++++++\n drivers/bus/vmbus/version.map | 1 +\n drivers/bus/vmbus/vmbus_channel.c | 5 +++++\n 6 files changed, 60 insertions(+)", "diff": "diff --git a/drivers/bus/vmbus/freebsd/vmbus_uio.c b/drivers/bus/vmbus/freebsd/vmbus_uio.c\nindex fdd37dac3a..022ac85302 100644\n--- a/drivers/bus/vmbus/freebsd/vmbus_uio.c\n+++ b/drivers/bus/vmbus/freebsd/vmbus_uio.c\n@@ -12,6 +12,7 @@\n #include <sys/mman.h>\n #include <sys/types.h>\n #include <sys/sysctl.h>\n+#include <sys/ioctl.h>\n \n #include <rte_log.h>\n #include <rte_bus.h>\n@@ -26,6 +27,9 @@\n /** Pathname of VMBUS devices directory. */\n #define SYSFS_VMBUS_DEVICES \"/sys/bus/vmbus/devices\"\n \n+/* ioctl */\n+#define HVIOOPENSUBCHAN _IOW('h', 14, uint32_t)\n+\n const char *driver_name = \"hv_uio\";\n static void *vmbus_map_addr;\n \n@@ -515,3 +519,30 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n \tclosedir(chan_dir);\n \treturn err;\n }\n+\n+int vmbus_uio_subchan_open(struct rte_vmbus_device *dev, uint32_t subchan)\n+{\n+\tstruct mapped_vmbus_resource *uio_res;\n+\tint fd, err = 0;\n+\n+\tuio_res = vmbus_uio_find_resource(dev);\n+\tif (!uio_res) {\n+\t\tVMBUS_LOG(ERR, \"cannot find uio resource\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfd = open(uio_res->path, O_RDWR);\n+\tif (fd < 0) {\n+\t\tVMBUS_LOG(ERR, \"Cannot open %s: %s\",\n+\t\t\t\tuio_res->path, strerror(errno));\n+\t\treturn -1;\n+\t}\n+\n+\tif (ioctl(fd, HVIOOPENSUBCHAN, &subchan)) {\n+\t\tVMBUS_LOG(ERR, \"open subchan ioctl failed %s: %s\",\n+\t\t\t\tuio_res->path, strerror(errno));\n+\t\terr = -1;\n+\t}\n+\tclose(fd);\n+\treturn err;\n+}\ndiff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c\nindex b52ca5bf1d..29e889347a 100644\n--- a/drivers/bus/vmbus/linux/vmbus_uio.c\n+++ b/drivers/bus/vmbus/linux/vmbus_uio.c\n@@ -451,3 +451,15 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n \tclosedir(chan_dir);\n \treturn err;\n }\n+\n+/*\n+ * This is a stub function and it should always succeed.\n+ * The Linux UIO kernel driver opens the subchannels implicitly.\n+ */\n+int vmbus_uio_subchan_open(struct rte_vmbus_device *dev,\n+\t\t\t uint32_t subchan)\n+{\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(subchan);\n+\treturn 0;\n+}\ndiff --git a/drivers/bus/vmbus/private.h b/drivers/bus/vmbus/private.h\nindex 528d60a42f..968f0b6f23 100644\n--- a/drivers/bus/vmbus/private.h\n+++ b/drivers/bus/vmbus/private.h\n@@ -107,6 +107,7 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n int vmbus_uio_map_rings(struct vmbus_channel *chan);\n int vmbus_uio_map_secondary_subchan(const struct rte_vmbus_device *dev,\n \t\t\t\t const struct vmbus_channel *chan);\n+int vmbus_uio_subchan_open(struct rte_vmbus_device *device, uint32_t subchan);\n \n void vmbus_br_setup(struct vmbus_br *br, void *buf, unsigned int blen);\n \ndiff --git a/drivers/bus/vmbus/rte_bus_vmbus.h b/drivers/bus/vmbus/rte_bus_vmbus.h\nindex 6bcff66468..60c5812706 100644\n--- a/drivers/bus/vmbus/rte_bus_vmbus.h\n+++ b/drivers/bus/vmbus/rte_bus_vmbus.h\n@@ -404,6 +404,16 @@ void rte_vmbus_chan_dump(FILE *f, const struct vmbus_channel *chan);\n */\n void rte_vmbus_unregister(struct rte_vmbus_driver *driver);\n \n+/**\n+ * Perform IOCTL to VMBUS device\n+ *\n+ * @param device\n+ *\tA pointer to a rte_vmbus_device structure\n+ * @param subchan\n+ *\tCount of subchannels to open\n+ */\n+int rte_vmbus_ioctl(struct rte_vmbus_device *device, uint32_t subchan);\n+\n /** Helper for VMBUS device registration from driver instance */\n #define RTE_PMD_REGISTER_VMBUS(nm, vmbus_drv)\t\t\\\n \tRTE_INIT(vmbusinitfn_ ##nm)\t\t\t\\\ndiff --git a/drivers/bus/vmbus/version.map b/drivers/bus/vmbus/version.map\nindex 3cadec7fae..3509d4fc14 100644\n--- a/drivers/bus/vmbus/version.map\n+++ b/drivers/bus/vmbus/version.map\n@@ -23,6 +23,7 @@ DPDK_22 {\n \trte_vmbus_subchan_open;\n \trte_vmbus_unmap_device;\n \trte_vmbus_unregister;\n+\trte_vmbus_ioctl;\n \n \tlocal: *;\n };\ndiff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c\nindex f67f1c438a..f53a1b6511 100644\n--- a/drivers/bus/vmbus/vmbus_channel.c\n+++ b/drivers/bus/vmbus/vmbus_channel.c\n@@ -367,6 +367,11 @@ int rte_vmbus_max_channels(const struct rte_vmbus_device *device)\n \t\treturn 1;\n }\n \n+int rte_vmbus_ioctl(struct rte_vmbus_device *device, uint32_t subchan)\n+{\n+\treturn vmbus_uio_subchan_open(device, subchan);\n+}\n+\n /* Setup secondary channel */\n int rte_vmbus_subchan_open(struct vmbus_channel *primary,\n \t\t\t struct vmbus_channel **new_chan)\n", "prefixes": [ "v2", "05/11" ] }