Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100797/?format=api
{ "id": 100797, "url": "https://patches.dpdk.org/api/patches/100797/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211007184350.73858-30-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211007184350.73858-30-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211007184350.73858-30-srikanth.k@oneconvergence.com", "date": "2021-10-07T18:43:38", "name": "[v2,29/41] net/mlx5: added stats support", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "2f680b4d59eec6f7348e89e834a6270158be41bb", "submitter": { "id": 2368, "url": "https://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211007184350.73858-30-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 19455, "url": "https://patches.dpdk.org/api/series/19455/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19455", "date": "2021-10-07T18:43:09", "name": "add MLX5 FreeBSD support", "version": 2, "mbox": "https://patches.dpdk.org/series/19455/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/100797/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/100797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C0EEA034F;\n\tFri, 8 Oct 2021 12:58:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7BDD8411DE;\n\tFri, 8 Oct 2021 12:56:30 +0200 (CEST)", "from mail-pf1-f171.google.com (mail-pf1-f171.google.com\n [209.85.210.171])\n by mails.dpdk.org (Postfix) with ESMTP id 4BD0641217\n for <dev@dpdk.org>; Thu, 7 Oct 2021 20:45:33 +0200 (CEST)", "by mail-pf1-f171.google.com with SMTP id p1so6065277pfh.8\n for <dev@dpdk.org>; Thu, 07 Oct 2021 11:45:33 -0700 (PDT)", "from srikanth-ThinkPad-T450.domain.name ([136.185.113.102])\n by smtp.gmail.com with ESMTPSA id c11sm3311586pji.38.2021.10.07.11.45.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 Oct 2021 11:45:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=cTFUC21T25Hn2d7bIakzFL4yig0aCCoezo7K+xdhJzM=;\n b=K1WwRoKzJ2nnxyPWqlyy0wM9Q54/5a2XVrwaEV0DhrEFy/FQLf95LIdLG73xnFMKPd\n kZkC40ftlkSVEMrkTpRzWVm9zptbZ4Q17pwbztc1E65vV0FYsldw4djINrAOlWjtFy/Q\n ATuAFEWnYXkmeAQMhVODbBR7+59gwwlC4odI4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=cTFUC21T25Hn2d7bIakzFL4yig0aCCoezo7K+xdhJzM=;\n b=PUow5DNH/wSdwRuGCoXsNarf8gf9UK7jcuBQjIIHa4f2RHQWUqtXTNoT+nnuTUSYpr\n FiYiJdxJ2go6sYCmJLuPDR70ik1911DASAZrL4H1Kur2pXCgb5v3cFsJI0EBC+Sz/SqH\n J9OvfsWAu4pwg5TZqbdY4PjdioHAiyGSw2SZL+2qMxKDAvE8VD60vWsnzGbIchh0tjVO\n UxRdBjfpSoBoLcXodv2ehaGN4KaFgQnPZPTiFSFqSsf4lEDkYfAf43QE0f2GQh1uNdd5\n BLtowHVBYME/MQWyyXticuAsUDIHaUP6UeSeoLEgFRWLekohhBOiY42qX/5DOJ8le64Z\n waFg==", "X-Gm-Message-State": "AOAM533hJJh3zBiuJ0mG5cBwKyhwNC8bSox1mIKzxS6dhWU+xp6EzH/P\n iPKHP/mb48pqlJw/aNzd5EOXIQ==", "X-Google-Smtp-Source": "\n ABdhPJxNOgcL9qw+55alHVuexEiTqwCuD+af12nd6bwLXLERR5+4AENRqZ5dZFPayV1YPrN4z0D9dg==", "X-Received": "by 2002:a63:e216:: with SMTP id q22mr954569pgh.3.1633632332441;\n Thu, 07 Oct 2021 11:45:32 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Date": "Fri, 8 Oct 2021 00:13:38 +0530", "Message-Id": "<20211007184350.73858-30-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211007184350.73858-1-srikanth.k@oneconvergence.com>", "References": "<20211007184350.73858-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 08 Oct 2021 12:55:54 +0200", "Subject": "[dpdk-dev] [PATCH v2 29/41] net/mlx5: added stats support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Initialize device stats and fetch them using sysctl.\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 217 ++++++++++++++++++++++\n 1 file changed, 217 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\nindex db16027244..a6e28ea4bb 100644\n--- a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\n+++ b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\n@@ -6,6 +6,7 @@\n #include <stdio.h>\n #include <stdint.h>\n #include <net/if_media.h>\n+#include <sys/sysctl.h>\n #include <sys/ioctl.h>\n #include <time.h>\n \n@@ -18,6 +19,8 @@\n \n #include \"mlx5.h\"\n \n+static unsigned int xstats_n;\n+\n /**\n * Get interface name from private structure.\n *\n@@ -721,6 +724,220 @@ int mlx5_get_module_eeprom(struct rte_eth_dev *dev,\n \treturn -ENOTSUP;\n }\n \n+/**\n+ * Read device counters table.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param[in] pf\n+ * PF index in case of bonding device, -1 otherwise\n+ * @param[out] stats\n+ * Counters table output buffer.\n+ */\n+static void\n+_mlx5_os_read_dev_counters(struct rte_eth_dev *dev, uint64_t *stats)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tstruct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;\n+\tchar stat_key[RTE_ETH_XSTATS_NAME_SIZE + 16];\n+\tunsigned int i;\n+\tsize_t len = sizeof(uint64_t);\n+\tuint64_t val;\n+\tint ibvindex, ret;\n+\n+\tibvindex = mlx5_get_ibvindex(priv->sh->ibdev_path);\n+\n+\tfor (i = 0; i != xstats_ctrl->mlx5_stats_n; ++i) {\n+\t\tsnprintf(stat_key, sizeof(stat_key), \"dev.mce.%d.%s\",\n+\t\t\t ibvindex, xstats_ctrl->info[i].ctr_name);\n+\t\tret = sysctlbyname(stat_key, &val, &len, NULL, 0);\n+\t\tif (ret == -1) {\n+\t\t\tDRV_LOG(WARNING, \"port %u failed to get statistics: %s\",\n+\t\t\t\tdev->data->port_id, strerror(errno));\n+\t\t\tcontinue;\n+\t\t}\n+\t\tstats[i] += val;\n+\t}\n+}\n+\n+/**\n+ * Read device counters.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param[out] stats\n+ * Counters table output buffer.\n+ */\n+int\n+mlx5_os_read_dev_counters(struct rte_eth_dev *dev, uint64_t *stats)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tstruct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;\n+\tint i;\n+\n+\tmemset(stats, 0, sizeof(*stats) * xstats_ctrl->mlx5_stats_n);\n+\t_mlx5_os_read_dev_counters(dev, stats);\n+\t/* Read IB counters. */\n+\tfor (i = 0; i != xstats_ctrl->mlx5_stats_n; ++i) {\n+\t\tif (!xstats_ctrl->info[i].dev)\n+\t\t\tcontinue;\n+\t\txstats_ctrl->xstats[i] = stats[i];\n+\t}\n+\treturn 0;\n+}\n+\n+/**\n+ * Query the number of statistics.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ *\n+ * @return\n+ * Number of statistics on success.\n+ */\n+int\n+mlx5_os_get_stats_n(struct rte_eth_dev *dev)\n+{\n+\tRTE_SET_USED(dev);\n+\treturn xstats_n;\n+}\n+\n+static const struct mlx5_counter_ctrl mlx5_counters_init[] = {\n+\t{\n+\t\t.dpdk_name = \"rx_port_unicast_bytes\",\n+\t\t.ctr_name = \"vstats.rx_unicast_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_port_multicast_bytes\",\n+\t\t.ctr_name = \"vstats.rx_multicast_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_port_broadcast_bytes\",\n+\t\t.ctr_name = \"vstats.rx_broadcast_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_port_unicast_packets\",\n+\t\t.ctr_name = \"vstats.rx_unicast_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_port_multicast_packets\",\n+\t\t.ctr_name = \"vstats.rx_multicast_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_port_broadcast_packets\",\n+\t\t.ctr_name = \"vstats.rx_broadcast_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_port_unicast_bytes\",\n+\t\t.ctr_name = \"vstats.tx_unicast_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_port_multicast_bytes\",\n+\t\t.ctr_name = \"vstats.tx_multicast_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_port_broadcast_bytes\",\n+\t\t.ctr_name = \"vstats.tx_broadcast_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_port_unicast_packets\",\n+\t\t.ctr_name = \"vstats.tx_unicast_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_port_multicast_packets\",\n+\t\t.ctr_name = \"vstats.tx_multicast_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_port_broadcast_packets\",\n+\t\t.ctr_name = \"vstats.tx_broadcast_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_wqe_err\",\n+\t\t.ctr_name = \"vstats.rx_wqe_err\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_crc_align_errors\",\n+\t\t.ctr_name = \"pstats.crc_align_errors\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_in_range_len_errors\",\n+\t\t.ctr_name = \"pstats.in_range_len_errors\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_symbol_err\",\n+\t\t.ctr_name = \"pstats.symbol_err\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_errors_packets\",\n+\t\t.ctr_name = \"vstats.tx_error_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_out_of_buffer\",\n+\t\t.ctr_name = \"vstats.rx_out_of_buffer\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"lro_bytes\",\n+\t\t.ctr_name = \"vstats.lro_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"lro_packets\",\n+\t\t.ctr_name = \"vstats.lro_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tso_bytes\",\n+\t\t.ctr_name = \"vstats.tso_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tso_packets\",\n+\t\t.ctr_name = \"vstats.tso_packets\",\n+\t},\n+\t/* Representor only */\n+\t{\n+\t\t.dpdk_name = \"rx_packets\",\n+\t\t.ctr_name = \"vstats.rx_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"rx_bytes\",\n+\t\t.ctr_name = \"vstats.rx_bytes\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_packets\",\n+\t\t.ctr_name = \"vstats.tx_packets\",\n+\t},\n+\t{\n+\t\t.dpdk_name = \"tx_bytes\",\n+\t\t.ctr_name = \"vstats.tx_bytes\",\n+\t},\n+};\n+\n+/**\n+ * Init the structures to read device counters.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ */\n+void\n+mlx5_os_stats_init(struct rte_eth_dev *dev)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tstruct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;\n+\tstruct mlx5_stats_ctrl *stats_ctrl = &priv->stats_ctrl;\n+\tunsigned int i, idx;\n+\n+\txstats_n = RTE_DIM(mlx5_counters_init);\n+\txstats_ctrl->mlx5_stats_n = 0;\n+\n+\tfor (i = 0; i != xstats_n; ++i) {\n+\t\tidx = xstats_ctrl->mlx5_stats_n++;\n+\n+\t\txstats_ctrl->dev_table_idx[idx] = i;\n+\t\txstats_ctrl->info[idx] = mlx5_counters_init[i];\n+\t}\n+\txstats_ctrl->stats_n = xstats_n;\n+\tmlx5_os_read_dev_counters(dev, xstats_ctrl->base);\n+\tstats_ctrl->imissed = 0;\n+}\n+\n /**\n * Get MAC address by querying netdevice.\n *\n", "prefixes": [ "v2", "29/41" ] }