Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100783/?format=api
{ "id": 100783, "url": "https://patches.dpdk.org/api/patches/100783/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211007184350.73858-16-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211007184350.73858-16-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211007184350.73858-16-srikanth.k@oneconvergence.com", "date": "2021-10-07T18:43:24", "name": "[v2,15/41] common/mlx5: add PF_INET socket interface", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "068ee0af6595adc62985b64be6853459dc898df9", "submitter": { "id": 2368, "url": "https://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211007184350.73858-16-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 19455, "url": "https://patches.dpdk.org/api/series/19455/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19455", "date": "2021-10-07T18:43:09", "name": "add MLX5 FreeBSD support", "version": 2, "mbox": "https://patches.dpdk.org/series/19455/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/100783/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/100783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1DF84A034F;\n\tFri, 8 Oct 2021 12:57:23 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7866B41184;\n\tFri, 8 Oct 2021 12:56:14 +0200 (CEST)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id C2D0541217\n for <dev@dpdk.org>; Thu, 7 Oct 2021 20:44:54 +0200 (CEST)", "by mail-pl1-f180.google.com with SMTP id y1so4464876plk.10\n for <dev@dpdk.org>; Thu, 07 Oct 2021 11:44:54 -0700 (PDT)", "from srikanth-ThinkPad-T450.domain.name ([136.185.113.102])\n by smtp.gmail.com with ESMTPSA id c11sm3311586pji.38.2021.10.07.11.44.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 Oct 2021 11:44:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Z/GCr1Gmrqb47FTOGlulB/mWkM38APJNgJ3L24MfYFE=;\n b=gsqCoTNuo0oA9Liu3YrFX98hRfapxF3aQspzpnh0ofmGLFDpGP5grQSRSK3SKNkMJD\n o7qIB3YHPpRvf5Qeyvzwk4O1OW9NmWSKG7Z0vYlxsjndPrZSv3BwqgsdXj/xMk89dfnc\n ArSqkMHx5Jfgs/uHy0Gb7/Yp+/6UxqNrRxIOc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Z/GCr1Gmrqb47FTOGlulB/mWkM38APJNgJ3L24MfYFE=;\n b=K8BP8K9yJshts5CeE/8rDWGhxzpD5vNBAvz2iy7az+IT9aHInF9R68K6i5+/KRqBqK\n rlJhGTrUULeInlLJO4HK3TW01eFl6CJ8tbc/Pu/4el6muYFx3ERjCAJhO8+8qmA7T/wL\n vwRSs3D99zoWuy567N4Zr2sS+8obWupJR0JZtVkNa6G0sge4KV0HN0N93bYdBEeLH36p\n CKziuVXt5QmjsgEQdzlTd0caQgHy9p1qjpS2uHLgAicZ4W+mcb8ofZ6Hg47pbyRg1nDB\n AGmo0tAtK+WrqeTUM4dIQ8b43vKXSArPX1NaEDLKSOaSDWJPoFtTcSKtFdF5LOCpqI3p\n hFjQ==", "X-Gm-Message-State": "AOAM533Z3TliHo//xuWff25xTNSGPfRMt1b03C0HVblr6oYDe3R8FYSq\n ejxZzFgV8T7Vb8q1jlPZL40OvQ==", "X-Google-Smtp-Source": "\n ABdhPJwwsC3GTJVqjq14CTR1wB795HTMAXyjZ4qz/GXqqtKfdSotHxXaviYrI/bIJBxaRyhzYLP/Tg==", "X-Received": "by 2002:a17:90b:17d0:: with SMTP id\n me16mr7352936pjb.152.1633632293917;\n Thu, 07 Oct 2021 11:44:53 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Date": "Fri, 8 Oct 2021 00:13:24 +0530", "Message-Id": "<20211007184350.73858-16-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211007184350.73858-1-srikanth.k@oneconvergence.com>", "References": "<20211007184350.73858-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 08 Oct 2021 12:55:54 +0200", "Subject": "[dpdk-dev] [PATCH v2 15/41] common/mlx5: add PF_INET socket\n interface", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Similar to NETLINK ROUTE socket in Linux, PF_INET sockets\nare used to communicate with FreeBSD network stack\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/common/mlx5/freebsd/meson.build | 1 +\n drivers/common/mlx5/freebsd/mlx5_inet.c | 308 ++++++++++++++++++++++++\n drivers/common/mlx5/freebsd/mlx5_inet.h | 49 ++++\n 3 files changed, 358 insertions(+)\n create mode 100644 drivers/common/mlx5/freebsd/mlx5_inet.c\n create mode 100644 drivers/common/mlx5/freebsd/mlx5_inet.h", "diff": "diff --git a/drivers/common/mlx5/freebsd/meson.build b/drivers/common/mlx5/freebsd/meson.build\nindex 4112fdb155..bee2ce7861 100644\n--- a/drivers/common/mlx5/freebsd/meson.build\n+++ b/drivers/common/mlx5/freebsd/meson.build\n@@ -31,6 +31,7 @@ if not cc.has_header('infiniband/mlx5dv.h')\n subdir_done()\n endif\n \n+sources += files('mlx5_inet.c')\n sources += files('mlx5_common_os.c')\n sources += files('mlx5_glue.c')\n sources += files('mlx5_common_verbs.c')\ndiff --git a/drivers/common/mlx5/freebsd/mlx5_inet.c b/drivers/common/mlx5/freebsd/mlx5_inet.c\nnew file mode 100644\nindex 0000000000..f721877256\n--- /dev/null\n+++ b/drivers/common/mlx5/freebsd/mlx5_inet.c\n@@ -0,0 +1,308 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright 2018 Mellanox Technologies, Ltd\n+ */\n+\n+#include <sys/ioctl.h>\n+#include <sys/socket.h>\n+#include <net/if.h>\n+#include <net/if_types.h>\n+#include <err.h>\n+#include <errno.h>\n+\n+#include <rte_errno.h>\n+\n+#include \"mlx5_inet.h\"\n+#include \"mlx5_common_log.h\"\n+#include \"mlx5_common_utils.h\"\n+#include \"mlx5_malloc.h\"\n+\n+/**\n+ * Check all multicast mode is enabled in driver through Socket.\n+ *\n+ * @param inetsk_fd\n+ * Inet socket file descriptor.\n+ * @param ifname\n+ * ifname buffer of mlx5_get_ifname(dev, ifname) function.\n+ * @param port_id\n+ * port_id of the port .\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_inet_check_allmulti_flag(int inetsk_fd, char *ifname, uint16_t port_id)\n+{\n+\tstruct ifreq ifr;\n+\tint value;\n+\n+\tif (inetsk_fd < 0)\n+\t\treturn 0;\n+\n+\tmemset(&ifr, 0, sizeof(ifr));\n+\t(void)strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name));\n+\n+\tif (ioctl(inetsk_fd, SIOCGIFFLAGS, (caddr_t)&ifr) < 0)\n+\t\treturn -errno;\n+\n+\tvalue = (ifr.ifr_flags & 0xffff) | (ifr.ifr_flagshigh << 16);\n+\tif (!(value & IFF_ALLMULTI)) {\n+\t\tDRV_LOG(WARNING,\n+\t\t\t\"port %u allmulti mode not enabled from kernel, \"\n+\t\t\t\"please disable it from DPDK\", port_id);\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n+/**\n+ * Enable promiscuous / all multicast mode through Socket.\n+ * We make a copy of ifreq to avoid SIOCIGIFFLAGS overwriting on the union\n+ * portion of the ifreq structure.\n+ *\n+ * @param inetsk_fd\n+ * Inet socket file descriptor.\n+ * @param ifname_output\n+ * ifname buffer of mlx5_get_ifname(dev, ifname) function.\n+ * @param flags\n+ * IFF_PPROMISC for promiscuous, IFF_ALLMULTI for allmulti.\n+ * @param enable\n+ * Nonzero to enable, disable otherwise.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_inet_device_flags(int inetsk_fd, char *ifname, int flags, int enable)\n+{\n+\tstruct ifreq ifr;\n+\tint value;\n+\n+\tassert(!(flags & ~(IFF_PPROMISC)));\n+\tif (inetsk_fd < 0)\n+\t\treturn 0;\n+\n+\tmemset(&ifr, 0, sizeof(ifr));\n+\t(void)strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name));\n+\n+\tif (ioctl(inetsk_fd, SIOCGIFFLAGS, (caddr_t)&ifr) < 0)\n+\t\treturn -errno;\n+\n+\tvalue = (ifr.ifr_flags & 0xffff) | (ifr.ifr_flagshigh << 16);\n+\tif (enable)\n+\t\tvalue |= flags;\n+\telse\n+\t\tvalue &= ~flags;\n+\n+\tifr.ifr_flags = value & 0xffff;\n+\tifr.ifr_flagshigh = value >> 16;\n+\n+\tif (ioctl(inetsk_fd, SIOCSIFFLAGS, (caddr_t)&ifr) < 0)\n+\t\treturn -errno;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * Enable promiscuous mode through INET Socket.\n+ *\n+ * @param inetsk_fd\n+ * Inet socket file descriptor.\n+ * @param ifname_output\n+ * ifname buffer of mlx5_get_ifname(dev, ifname) function.\n+ * @param enable\n+ * Nonzero to enable, disable otherwise.\n+ * @param port_id\n+ * port_id of the interface\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_inet_promisc(int inetsk_fd, char *ifname, int enable, uint16_t port_id)\n+{\n+\tint ret;\n+\n+\tret = mlx5_inet_device_flags(inetsk_fd, ifname, IFF_PPROMISC, enable);\n+\tif (ret)\n+\t\tDRV_LOG(DEBUG,\n+\t\t\t\"port %u cannot %s promisc mode: Socket error %s\",\n+\t\t\tport_id, enable ? \"enable\" : \"disable\",\n+\t\t\tstrerror(rte_errno));\n+\treturn ret;\n+}\n+\n+/**\n+ * Modify the MAC address neighbour table with INET Socket.\n+ *\n+ * @param inetsk_fd\n+ * Inet socket file descriptor.\n+ * @param ifname_output\n+ * ifname buffer of mlx5_get_ifname(dev, ifname) function.\n+ * @param mac\n+ * MAC address to consider.\n+ * @param port_id\n+ * port_id of the interface\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_inet_mac_addr_modify(int inetsk_fd, char *ifname,\n+\t\t\t struct rte_ether_addr *mac, uint16_t port_id)\n+{\n+\tstruct ifreq ifr;\n+\n+\tif (inetsk_fd < 0)\n+\t\treturn 0;\n+\n+\tmemset(&ifr, 0, sizeof(ifr));\n+\t(void)strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name));\n+\tifr.ifr_addr.sa_family = AF_LINK;\n+\tmemcpy(ifr.ifr_addr.sa_data, mac, RTE_ETHER_ADDR_LEN);\n+\tifr.ifr_addr.sa_len = RTE_ETHER_ADDR_LEN;\n+\n+\tif (ioctl(inetsk_fd, SIOCSIFLLADDR, &ifr) < 0) {\n+\t\trte_errno = errno;\n+\t\tgoto error;\n+\t}\n+\n+\treturn 0;\n+error:\n+\tDRV_LOG(DEBUG,\n+\t\t\"port %u cannot add MAC address %02X:%02X:%02X:%02X:%02X:%02X %s\",\n+\t\tport_id,\n+\t\tmac->addr_bytes[0], mac->addr_bytes[1],\n+\t\tmac->addr_bytes[2], mac->addr_bytes[3],\n+\t\tmac->addr_bytes[4], mac->addr_bytes[5],\n+\t\tstrerror(rte_errno));\n+\treturn -rte_errno;\n+}\n+\n+/**\n+ * Set a MAC address.\n+ *\n+ * @param inetsk_fd\n+ * Inet socket file descriptor.\n+ * @param ifname_output\n+ * ifname buffer of mlx5_get_ifname(dev, ifname) function.\n+ * @param mac\n+ * MAC address to register.\n+ * @param index\n+ * MAC address index.\n+ * @param port_id\n+ * port_id of the interface\n+ * @param mac_own\n+ * Current MAC address.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_inet_mac_addr_set(int inetsk_fd, char *ifname,\n+\t\tstruct rte_ether_addr *mac, uint32_t index,\n+\t\tuint16_t port_id, uint64_t *mac_own)\n+{\n+\tint ret;\n+\n+\tret = mlx5_inet_mac_addr_modify(inetsk_fd, ifname, mac, port_id);\n+\tif (!ret)\n+\t\tBITFIELD_SET(mac_own, index);\n+\tif (ret == -EEXIST)\n+\t\treturn 0;\n+\treturn ret;\n+}\n+\n+/**\n+ * DPDK callback to add a MAC address.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ * @param mac_addr\n+ * MAC address to register.\n+ * @param index\n+ * MAC address index.\n+ * @param vmdq\n+ * VMDq pool index to associate address with (ignored).\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_inet_mac_addr_add(struct rte_ether_addr *mac __rte_unused,\n+\t\t\tuint32_t index __rte_unused,\n+\t\t\tuint32_t vmdq __rte_unused,\n+\t\t\tuint16_t port_id)\n+{\n+\tDRV_LOG(INFO, \"port %u add MAC not supported in FreeBSD\",\n+\t\tport_id);\n+\treturn -EOPNOTSUPP;\n+}\n+\n+/**\n+ * Before exiting, make interface LLADDR same as HWADDR\n+ *\n+ * @param inetsk_fd\n+ * Inet socket file descriptor.\n+ * @param ifname_output\n+ * ifname buffer of mlx5_get_ifname(dev, ifname) function.\n+ * @param lladdr\n+ * @param port_id\n+ * port_id of the interface\n+ */\n+void\n+mlx5_inet_mac_addr_flush(int inetsk_fd, char *ifname,\n+\t\t\tstruct rte_ether_addr *lladdr,\n+\t\t\tuint16_t port_id)\n+{\n+\tstruct ifreq ifr;\n+\n+\tif (inetsk_fd < 0)\n+\t\treturn;\n+\n+\tmemset(&ifr, 0, sizeof(ifr));\n+\t(void)strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name));\n+\tifr.ifr_addr.sa_family = AF_LINK;\n+\n+\tif (ioctl(inetsk_fd, SIOCGHWADDR, &ifr) < 0)\n+\t\treturn;\n+\n+\tif (memcmp(ifr.ifr_addr.sa_data, lladdr, RTE_ETHER_ADDR_LEN) == 0)\n+\t\treturn;\n+\n+\tmlx5_inet_mac_addr_modify(inetsk_fd, ifname,\n+\t\t\t(struct rte_ether_addr *)&ifr.ifr_addr.sa_data,\n+\t\t\tport_id);\n+}\n+\n+/**\n+ * Remove a MAC address.\n+ *\n+ * @param mac\n+ * MAC address to remove.\n+ * @param index\n+ * MAC address index.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+void\n+mlx5_inet_mac_addr_remove(uint16_t port_id, uint32_t index __rte_unused)\n+{\n+\tDRV_LOG(INFO,\n+\t\t\"port %u cannot remove MAC. Operation not supported in FreeBSD\",\n+\t\tport_id);\n+}\n+\n+/* No bind required on this socket as there are no incoming messages */\n+int\n+mlx5_inet_init(void)\n+{\n+\tint s;\n+\n+\ts = socket(PF_INET, SOCK_DGRAM, 0);\n+\tif (s < 0) {\n+\t\trte_errno = errno;\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn s;\n+}\ndiff --git a/drivers/common/mlx5/freebsd/mlx5_inet.h b/drivers/common/mlx5/freebsd/mlx5_inet.h\nnew file mode 100644\nindex 0000000000..cc6a05928e\n--- /dev/null\n+++ b/drivers/common/mlx5/freebsd/mlx5_inet.h\n@@ -0,0 +1,49 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright 2019 Mellanox Technologies, Ltd\n+ */\n+\n+#ifndef RTE_PMD_MLX5_INET_H_\n+#define RTE_PMD_MLX5_INET_H_\n+\n+#include <net/if.h>\n+#include <netinet/in.h>\n+\n+#include <rte_ether.h>\n+\n+#include \"mlx5_common.h\"\n+\n+int\n+mlx5_inet_check_allmulti_flag(int inetsk_fd, char *ifname, uint16_t port_id);\n+\n+int\n+mlx5_inet_device_flags(int inetsk_fd, char *ifname, int flags, int enable);\n+\n+int\n+mlx5_inet_promisc(int inetsk_fd, char *ifname, int enable, uint16_t port_id);\n+\n+int\n+mlx5_inet_mac_addr_modify(int inetsk_fd, char *ifname,\n+\t\t\tstruct rte_ether_addr *mac, uint16_t port_id);\n+\n+int\n+mlx5_inet_mac_addr_set(int inetsk_fd, char *ifname,\n+\t\t\tstruct rte_ether_addr *mac, uint32_t index,\n+\t\t\tuint16_t port_id, uint64_t *mac_own);\n+\n+int\n+mlx5_inet_mac_addr_add(struct rte_ether_addr *mac __rte_unused,\n+\t\t\tuint32_t index __rte_unused,\n+\t\t\tuint32_t vmdq __rte_unused,\n+\t\t\tuint16_t port_id);\n+\n+void\n+mlx5_inet_mac_addr_flush(int inetsk_fd, char *ifname,\n+\t\t\tstruct rte_ether_addr *lladdr,\n+\t\t\tuint16_t port_id);\n+\n+void\n+mlx5_inet_mac_addr_remove(uint16_t port_id, uint32_t index __rte_unused);\n+\n+int\n+mlx5_inet_init(void);\n+#endif /* RTE_PMD_MLX5_INET_H_ */\n", "prefixes": [ "v2", "15/41" ] }