Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100733/?format=api
{ "id": 100733, "url": "https://patches.dpdk.org/api/patches/100733/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211007220013.355530-8-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211007220013.355530-8-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211007220013.355530-8-maxime.coquelin@redhat.com", "date": "2021-10-07T22:00:06", "name": "[RFC,07/14] vhost: remove useless fields in async iterator struct", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "215ab510dfffad4009532f92748dbb40b23d5ea8", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211007220013.355530-8-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 19439, "url": "https://patches.dpdk.org/api/series/19439/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19439", "date": "2021-10-07T22:00:01", "name": "vhost: clean-up and simplify async implementation", "version": 1, "mbox": "https://patches.dpdk.org/series/19439/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/100733/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/100733/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5D50A0C43;\n\tFri, 8 Oct 2021 00:14:14 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 84A0B41470;\n\tFri, 8 Oct 2021 00:14:06 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id BF1BC41459\n for <dev@dpdk.org>; Fri, 8 Oct 2021 00:14:03 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-598-05Kdo1_QN1maIMYpzV9sDQ-1; Thu, 07 Oct 2021 18:14:00 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7F3C961152;\n Thu, 7 Oct 2021 22:00:37 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.18])\n by smtp.corp.redhat.com (Postfix) with ESMTP id CB5AA5C1B4;\n Thu, 7 Oct 2021 22:00:35 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1633644843;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xvejkVjPXKUm/4sEHk+Ul6AHf7CX74VtirVioP89gyk=;\n b=hQCqgiMHhux3HuWPDa/giJ77DqinebDNvFnCJgBW73VZgLtJIxKcNYlCcRsNFE0Dfaz5I4\n UQ5sHQLCQ+F2k8p8ugN6ZzLKjii0bnmiSvYrmker8UN3fuU40jnma0O+SaNu4yavqIrtgk\n XzgkmSFZAgFkvFdpTBHXdStTylZ5+xQ=", "X-MC-Unique": "05Kdo1_QN1maIMYpzV9sDQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, jiayu.hu@intel.com,\n yuanx.wang@intel.com, wenwux.ma@intel.com, bruce.richardson@intel.com,\n john.mcnamara@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 8 Oct 2021 00:00:06 +0200", "Message-Id": "<20211007220013.355530-8-maxime.coquelin@redhat.com>", "In-Reply-To": "<20211007220013.355530-1-maxime.coquelin@redhat.com>", "References": "<20211007220013.355530-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [RFC 07/14] vhost: remove useless fields in async\n iterator struct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Offset and count fields are unused and so can be removed.\nThe offset field was actually in the Vhost example, but\nin a way that does not make sense.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n examples/vhost/ioat.c | 6 ++----\n lib/vhost/rte_vhost_async.h | 4 ----\n lib/vhost/virtio_net.c | 19 ++++---------------\n 3 files changed, 6 insertions(+), 23 deletions(-)", "diff": "diff --git a/examples/vhost/ioat.c b/examples/vhost/ioat.c\nindex dcbcf65e4e..a8c588deff 100644\n--- a/examples/vhost/ioat.c\n+++ b/examples/vhost/ioat.c\n@@ -142,10 +142,8 @@ ioat_transfer_data_cb(int vid, uint16_t queue_id,\n \t\t\t\tbreak;\n \t\t\twhile (i_seg < iter->nr_segs) {\n \t\t\t\trte_ioat_enqueue_copy(dev_id,\n-\t\t\t\t\t(uintptr_t)(iter->iov[i_seg].src_addr)\n-\t\t\t\t\t\t+ iter->offset,\n-\t\t\t\t\t(uintptr_t)(iter->iov[i_seg].dst_addr)\n-\t\t\t\t\t\t+ iter->offset,\n+\t\t\t\t\t(uintptr_t)(iter->iov[i_seg].src_addr),\n+\t\t\t\t\t(uintptr_t)(iter->iov[i_seg].dst_addr),\n \t\t\t\t\titer->iov[i_seg].len,\n \t\t\t\t\t0,\n \t\t\t\t\t0);\ndiff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h\nindex d7bb77bf90..4ea5cfab10 100644\n--- a/lib/vhost/rte_vhost_async.h\n+++ b/lib/vhost/rte_vhost_async.h\n@@ -20,10 +20,6 @@ struct rte_vhost_iovec {\n * iovec iterator\n */\n struct rte_vhost_iov_iter {\n-\t/** offset to the first byte of interesting data */\n-\tsize_t offset;\n-\t/** total bytes of data in this iterator */\n-\tsize_t count;\n \t/** pointer to the iovec array */\n \tstruct rte_vhost_iovec *iov;\n \t/** number of iovec in this iterator */\ndiff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex 7b1c52ea7d..ae7dded979 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -933,19 +933,10 @@ async_fill_vec(struct rte_vhost_iovec *v, void *src, void *dst, size_t len)\n }\n \n static __rte_always_inline void\n-async_fill_iter(struct rte_vhost_iov_iter *it, size_t count,\n-\tstruct rte_vhost_iovec *vec, unsigned long nr_seg)\n+async_fill_iter(struct rte_vhost_iov_iter *it, struct rte_vhost_iovec *vec, unsigned long nr_seg)\n {\n-\tit->offset = 0;\n-\tit->count = count;\n-\n-\tif (count) {\n-\t\tit->iov = vec;\n-\t\tit->nr_segs = nr_seg;\n-\t} else {\n-\t\tit->iov = 0;\n-\t\tit->nr_segs = 0;\n-\t}\n+\tit->iov = vec;\n+\tit->nr_segs = nr_seg;\n }\n \n static __rte_always_inline void\n@@ -971,7 +962,6 @@ async_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \tuint32_t cpy_len, buf_len;\n \tint error = 0;\n \n-\tuint32_t tlen = 0;\n \tint tvec_idx = 0;\n \tvoid *hpa;\n \n@@ -1076,7 +1066,6 @@ async_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\t\t(void *)(uintptr_t)rte_pktmbuf_iova_offset(m,\n \t\t\t\tmbuf_offset), hpa, (size_t)mapped_len);\n \n-\t\t\ttlen += (uint32_t)mapped_len;\n \t\t\tcpy_len -= (uint32_t)mapped_len;\n \t\t\tmbuf_avail -= (uint32_t)mapped_len;\n \t\t\tmbuf_offset += (uint32_t)mapped_len;\n@@ -1086,7 +1075,7 @@ async_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t}\n \t}\n \n-\tasync_fill_iter(iter, tlen, iovec, tvec_idx);\n+\tasync_fill_iter(iter, iovec, tvec_idx);\n out:\n \treturn error;\n }\n", "prefixes": [ "RFC", "07/14" ] }