Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100726/?format=api
https://patches.dpdk.org/api/patches/100726/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211007220013.355530-6-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211007220013.355530-6-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211007220013.355530-6-maxime.coquelin@redhat.com", "date": "2021-10-07T22:00:04", "name": "[RFC,05/14] vhost: remove async batch threshold", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "579ed948c973ff59bc381aa7447a8144ccc84bf9", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211007220013.355530-6-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 19439, "url": "https://patches.dpdk.org/api/series/19439/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19439", "date": "2021-10-07T22:00:01", "name": "vhost: clean-up and simplify async implementation", "version": 1, "mbox": "https://patches.dpdk.org/series/19439/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/100726/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/100726/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8D18EA0C43;\n\tFri, 8 Oct 2021 00:13:29 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D8513413D1;\n\tFri, 8 Oct 2021 00:13:25 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id A77ED411FE\n for <dev@dpdk.org>; Fri, 8 Oct 2021 00:13:23 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-458-kXVnUH8eNRKar7xSM1Hr5g-1; Thu, 07 Oct 2021 18:13:19 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4485A95C478;\n Thu, 7 Oct 2021 22:00:29 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.18])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 74CA45C1B4;\n Thu, 7 Oct 2021 22:00:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1633644803;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nPiOlUzKgb0I3XgyfsmMPvVhnOS3ZCVkyJXTT5xJnFE=;\n b=KmrLZMaP/ChZFbx3H+YCl0FEH9+pjj6O2GGZUXO9Q7yEHGjrCT/UtwYdW1mS/RQ2YMA/p8\n fszZUTIJgBmuGy1hr4Jn5ywEYoBHrv4SNxZYPZtdcvRyHSRANP3u3U9sAY6aK0LEobx7N+\n iirIik4spNod4g+Uer2faejwRbkHXgA=", "X-MC-Unique": "kXVnUH8eNRKar7xSM1Hr5g-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, jiayu.hu@intel.com,\n yuanx.wang@intel.com, wenwux.ma@intel.com, bruce.richardson@intel.com,\n john.mcnamara@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 8 Oct 2021 00:00:04 +0200", "Message-Id": "<20211007220013.355530-6-maxime.coquelin@redhat.com>", "In-Reply-To": "<20211007220013.355530-1-maxime.coquelin@redhat.com>", "References": "<20211007220013.355530-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [RFC 05/14] vhost: remove async batch threshold", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reaching the async batch threshold was one of the condition\nto trigger the DMA transfer. However, this condition was\nnever met since the threshold value is 32, same as the\nMAX_PKT_BURST value.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/virtio_net.c | 14 ++++----------\n 1 file changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex e2a9e138b7..a939481eaf 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -25,8 +25,6 @@\n \n #define MAX_BATCH_LEN 256\n \n-#define VHOST_ASYNC_BATCH_THRESHOLD 32\n-\n static __rte_always_inline bool\n rxvq_is_mergeable(struct virtio_net *dev)\n {\n@@ -1565,12 +1563,10 @@ virtio_dev_rx_async_submit_split(struct virtio_net *dev,\n \t\tvq->last_avail_idx += num_buffers;\n \n \t\t/*\n-\t\t * conditions to trigger async device transfer:\n-\t\t * - buffered packet number reaches transfer threshold\n+\t\t * condition to trigger async device transfer:\n \t\t * - unused async iov number is less than max vhost vector\n \t\t */\n-\t\tif (unlikely(pkt_burst_idx >= VHOST_ASYNC_BATCH_THRESHOLD ||\n-\t\t\t(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX))) {\n+\t\tif (unlikely(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX)) {\n \t\t\tn_xfer = async->ops.transfer_data(dev->vid,\n \t\t\t\t\tqueue_id, tdes, 0, pkt_burst_idx);\n \t\t\tif (likely(n_xfer >= 0)) {\n@@ -1864,12 +1860,10 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev,\n \t\tvq_inc_last_avail_packed(vq, num_descs);\n \n \t\t/*\n-\t\t * conditions to trigger async device transfer:\n-\t\t * - buffered packet number reaches transfer threshold\n+\t\t * condition to trigger async device transfer:\n \t\t * - unused async iov number is less than max vhost vector\n \t\t */\n-\t\tif (unlikely(pkt_burst_idx >= VHOST_ASYNC_BATCH_THRESHOLD ||\n-\t\t\t(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX))) {\n+\t\tif (unlikely(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX)) {\n \t\t\tn_xfer = async->ops.transfer_data(dev->vid,\n \t\t\t\t\tqueue_id, tdes, 0, pkt_burst_idx);\n \t\t\tif (likely(n_xfer >= 0)) {\n", "prefixes": [ "RFC", "05/14" ] }{ "id": 100726, "url": "