Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10049/?format=api
{ "id": 10049, "url": "https://patches.dpdk.org/api/patches/10049/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1453476464-31767-5-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1453476464-31767-5-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1453476464-31767-5-git-send-email-david.marchand@6wind.com", "date": "2016-01-22T15:27:39", "name": "[dpdk-dev,4/9] pci: rework sysfs parsing for driver", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4b0356d20ba6aa489041ac7d2a1bfda90d8dac82", "submitter": { "id": 3, "url": "https://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1453476464-31767-5-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10049/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10049/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6ADEC91D6;\n\tFri, 22 Jan 2016 16:27:58 +0100 (CET)", "from mail-wm0-f44.google.com (mail-wm0-f44.google.com\n\t[74.125.82.44]) by dpdk.org (Postfix) with ESMTP id EDA3691C2\n\tfor <dev@dpdk.org>; Fri, 22 Jan 2016 16:27:55 +0100 (CET)", "by mail-wm0-f44.google.com with SMTP id l65so265467981wmf.1\n\tfor <dev@dpdk.org>; Fri, 22 Jan 2016 07:27:55 -0800 (PST)", "from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net.\n\t[78.126.77.144]) by smtp.gmail.com with ESMTPSA id\n\tw73sm3359464wmw.21.2016.01.22.07.27.54\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 22 Jan 2016 07:27:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Q/CHoeU3Sn3dKwYDSnt6FZkisQDyzL1ADXYkEnzrPf4=;\n\tb=qd6rv6qqXui7OJ1Qs+UeQBWsdIgF46RhvyA1Fymbdfal4bv0C82j5OH0xPxsH454xL\n\tRfiQ0tWr27szaBBn8DyKwIYaqZmywf8LMjvDZWd7UKE1RnhmaREkCdZhG8VE5SgGP6Jy\n\tzScXCoHCJ22h5xcDXOwCgLL4qKMJ+vGfmfBrCyfxkZHHLtCXx500TNbGGsEob/t2RG/w\n\t8fGwsn89197H9U/sCaCJjiG73dKZxgZYVYIxF/TQ3jANxxT3YgZl4crZE2NaUHva/33A\n\tS8NShnEZoC1O8tlnPAkq6aYOiTP3d6u0tOT93IFuSDhAeuo8bI84E+XMj/8/oMnfOUX2\n\tQbAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Q/CHoeU3Sn3dKwYDSnt6FZkisQDyzL1ADXYkEnzrPf4=;\n\tb=Tm6f7JxGBn9rlgEfFGtOINzW/w5CMOB2hO72/hlAQmIFg6W7/bBuh26kCEuk35bhET\n\tNDIzQee8OQGb/EHyI2oAso7dlF660CFN9duSVDqh3urnonkiqJpRxdWkc8v0A8/WY+2g\n\tRXS7QROYxd7W0QDI/Ak8XZ56VMjqXTiAz5qbx3v62gYIm7t/gdMZQS0nzVhJ/rytGR4j\n\tpZcnOvVVEra1BL8NsBrosJzAYyo8uTFiWousGKURFqTZ8kJz+zMe/+FOG1CmZ6m60JJl\n\tnW8yvqi6pGW2MQKG+YVh67kqnuF7UxwwLl+3r5wuGp56FrPpsyLVSRv+hWgGl74mhPxs\n\tGgcw==", "X-Gm-Message-State": "AG10YOQ+Mcj9e6RO+9W6OrGpB9vcNCUX01K7azU2BPImIzPl+xFO/VbL/2Sm8EIp0GelnJ1K", "X-Received": "by 10.28.17.8 with SMTP id 8mr3916015wmr.65.1453476475732;\n\tFri, 22 Jan 2016 07:27:55 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 22 Jan 2016 16:27:39 +0100", "Message-Id": "<1453476464-31767-5-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1453476464-31767-1-git-send-email-david.marchand@6wind.com>", "References": "<1453476464-31767-1-git-send-email-david.marchand@6wind.com>", "Cc": "viktorin@rehivetech.com", "Subject": "[dpdk-dev] [PATCH 4/9] pci: rework sysfs parsing for driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no use for pci_get_kernel_driver_by_path() apart recognising\nkernel driver and fill kdrv field.\nIf driver parsing fails, report \"none\" driver rather than \"unknown\".\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/linuxapp/eal/eal_pci.c | 48 ++++++++++++++---------------------\n 1 file changed, 19 insertions(+), 29 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c\nindex 7bec30f..00fdee7 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c\n@@ -94,32 +94,37 @@ error:\n }\n \n static int\n-pci_get_kernel_driver_by_path(const char *filename, char *dri_name)\n+pci_parse_sysfs_driver(const char *filename, struct rte_pci_device *dev)\n {\n \tint count;\n \tchar path[PATH_MAX];\n \tchar *name;\n \n-\tif (!filename || !dri_name)\n-\t\treturn -1;\n-\n \tcount = readlink(filename, path, PATH_MAX);\n \tif (count >= PATH_MAX)\n \t\treturn -1;\n \n-\t/* For device does not have a driver */\n-\tif (count < 0)\n-\t\treturn 1;\n+\tdev->kdrv = RTE_KDRV_NONE;\n \n-\tpath[count] = '\\0';\n+\tif (count > 0) {\n+\t\tdev->kdrv = RTE_KDRV_UNKNOWN;\n \n-\tname = strrchr(path, '/');\n-\tif (name) {\n-\t\tstrncpy(dri_name, name + 1, strlen(name + 1) + 1);\n-\t\treturn 0;\n+\t\tpath[count] = '\\0';\n+\t\tname = strrchr(path, '/');\n+\t\tif (name) {\n+\t\t\tname[0] = '\\0';\n+\t\t\tname++;\n+\t\t}\n+\n+\t\tif (!strcmp(name, \"vfio-pci\"))\n+\t\t\tdev->kdrv = RTE_KDRV_VFIO;\n+\t\telse if (!strcmp(name, \"igb_uio\"))\n+\t\t\tdev->kdrv = RTE_KDRV_IGB_UIO;\n+\t\telse if (!strcmp(name, \"uio_pci_generic\"))\n+\t\t\tdev->kdrv = RTE_KDRV_UIO_GENERIC;\n \t}\n \n-\treturn -1;\n+\treturn 0;\n }\n \n /* Map pci device */\n@@ -260,8 +265,6 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,\n \tunsigned long tmp;\n \tstruct rte_pci_device *dev;\n \tstruct rte_pci_device *dev2;\n-\tchar driver[PATH_MAX];\n-\tint ret;\n \n \tdev = malloc(sizeof(*dev));\n \tif (dev == NULL)\n@@ -341,25 +344,12 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,\n \n \t/* parse driver */\n \tsnprintf(filename, sizeof(filename), \"%s/driver\", dirname);\n-\tret = pci_get_kernel_driver_by_path(filename, driver);\n-\tif (ret < 0) {\n+\tif (pci_parse_sysfs_driver(filename, dev) < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Fail to get kernel driver\\n\");\n \t\tfree(dev);\n \t\treturn -1;\n \t}\n \n-\tif (!ret) {\n-\t\tif (!strcmp(driver, \"vfio-pci\"))\n-\t\t\tdev->kdrv = RTE_KDRV_VFIO;\n-\t\telse if (!strcmp(driver, \"igb_uio\"))\n-\t\t\tdev->kdrv = RTE_KDRV_IGB_UIO;\n-\t\telse if (!strcmp(driver, \"uio_pci_generic\"))\n-\t\t\tdev->kdrv = RTE_KDRV_UIO_GENERIC;\n-\t\telse\n-\t\t\tdev->kdrv = RTE_KDRV_UNKNOWN;\n-\t} else\n-\t\tdev->kdrv = RTE_KDRV_UNKNOWN;\n-\n \tdev2 = pci_find_device(&dev->addr);\n \tif (!dev2)\n \t\tpci_add_device(dev);\n", "prefixes": [ "dpdk-dev", "4/9" ] }