Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10037/?format=api
{ "id": 10037, "url": "https://patches.dpdk.org/api/patches/10037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1453377431-25850-2-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1453377431-25850-2-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1453377431-25850-2-git-send-email-david.marchand@6wind.com", "date": "2016-01-21T11:57:10", "name": "[dpdk-dev,1/2] ethdev: remove useless null checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "569856bba3457d88d3309b2bea8e2f84d8b709b0", "submitter": { "id": 3, "url": "https://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1453377431-25850-2-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10037/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2A9B48E98;\n\tThu, 21 Jan 2016 12:57:37 +0100 (CET)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 190FA3005\n\tfor <dev@dpdk.org>; Thu, 21 Jan 2016 12:57:33 +0100 (CET)", "by mail-wm0-f52.google.com with SMTP id l65so216848611wmf.1\n\tfor <dev@dpdk.org>; Thu, 21 Jan 2016 03:57:33 -0800 (PST)", "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tu4sm1178591wjz.4.2016.01.21.03.57.31\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tThu, 21 Jan 2016 03:57:32 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=o7EfMP5OenXOh+P4+I1oFtg39JY/JzClhXZr2UBAMYk=;\n\tb=sJT0KNRLJIMuUbHAcRb63R/wyCWidXlIfLFnPvsjrqw7yzDgD6JLeUvRBjVGJO9mda\n\t7y4ZUdzQzCa4ImsJ7orvpbqifJ4JOwyhUJOx0KNfl8QowiuN39HzK/Tb5w17LQIF0PiO\n\tEWGgbxBrB6Z0Npig5st9RZyTkisZvsQ1nuUSjDXbG91Jxn9icjqA+5jZbqk0HppPLiyQ\n\t78XBjSOJG487cSF+6rLvq7mYGS2p8y3j7bhY2/bFd8WziRNsckB5KhACCzswWuRs9K4Q\n\tuZPRWJRJWsjeu+Z0zVqZ+O3c+ZET/U2Jo5AB1N/1wH++JkIPX9NjpBOA0ni5LrmgASDp\n\tmn9g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=o7EfMP5OenXOh+P4+I1oFtg39JY/JzClhXZr2UBAMYk=;\n\tb=aIHTzcY+bBXHn5nB0qy1fVTgM16ROKYXp2D8eq9qOUl2/AT6hNFE3izlxS2fSw434q\n\tJxupFKtuin2pdAzbVS8EZCL4/8y24/YRT9Iug+3sucCTgQI116P35tjzFt5MiRK6ssWi\n\tFw9RwH4/vjuv4sc0VuFSKUD2i4Njpra0gyeUi776+eh+HZN3z5YnMH6AeEUgcNfeFgBT\n\tu1GG6uaJ9JxYWQuNQGc2S9wJ8lz6l5j23vt1Tak+T21jRb7t05AF9O5NSvyVW02muSao\n\ttw0R2FVGVYRmZWxm6EYw/VPKI/EPn/KI/vK0Flro1Dgmzzw+gMfVH7ycHEpqnTkwxu9R\n\tB++w==", "X-Gm-Message-State": "AG10YOS4YoRVbMXE/xcrJRly8QGNQvxRf5TPElIOk/CPKDp2XkBKMLuqYKtYxX+SNRYRz+OJ", "X-Received": "by 10.194.173.65 with SMTP id bi1mr31409298wjc.110.1453377452946;\n\tThu, 21 Jan 2016 03:57:32 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 21 Jan 2016 12:57:10 +0100", "Message-Id": "<1453377431-25850-2-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1453377431-25850-1-git-send-email-david.marchand@6wind.com>", "References": "<1453377431-25850-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH 1/2] ethdev: remove useless null checks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We are in static functions and those passed arguments can't be NULL.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_ether/rte_ethdev.c | 15 ---------------\n 1 file changed, 15 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex af990e2..951fb1c 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -220,9 +220,6 @@ rte_eth_dev_create_unique_device_name(char *name, size_t size,\n {\n \tint ret;\n \n-\tif ((name == NULL) || (pci_dev == NULL))\n-\t\treturn -EINVAL;\n-\n \tret = snprintf(name, size, \"%d:%d.%d\",\n \t\t\tpci_dev->addr.bus, pci_dev->addr.devid,\n \t\t\tpci_dev->addr.function);\n@@ -505,9 +502,6 @@ rte_eth_dev_is_detachable(uint8_t port_id)\n static int\n rte_eth_dev_attach_pdev(struct rte_pci_addr *addr, uint8_t *port_id)\n {\n-\tif ((addr == NULL) || (port_id == NULL))\n-\t\tgoto err;\n-\n \t/* re-construct pci_device_list */\n \tif (rte_eal_pci_scan())\n \t\tgoto err;\n@@ -531,9 +525,6 @@ rte_eth_dev_detach_pdev(uint8_t port_id, struct rte_pci_addr *addr)\n \tstruct rte_pci_addr freed_addr;\n \tstruct rte_pci_addr vp;\n \n-\tif (addr == NULL)\n-\t\tgoto err;\n-\n \t/* check whether the driver supports detach feature, or not */\n \tif (rte_eth_dev_is_detachable(port_id))\n \t\tgoto err;\n@@ -566,9 +557,6 @@ rte_eth_dev_attach_vdev(const char *vdevargs, uint8_t *port_id)\n \tchar *name = NULL, *args = NULL;\n \tint ret = -1;\n \n-\tif ((vdevargs == NULL) || (port_id == NULL))\n-\t\tgoto end;\n-\n \t/* parse vdevargs, then retrieve device name and args */\n \tif (rte_eal_parse_devargs_str(vdevargs, &name, &args))\n \t\tgoto end;\n@@ -600,9 +588,6 @@ rte_eth_dev_detach_vdev(uint8_t port_id, char *vdevname)\n {\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n \n-\tif (vdevname == NULL)\n-\t\tgoto err;\n-\n \t/* check whether the driver supports detach feature, or not */\n \tif (rte_eth_dev_is_detachable(port_id))\n \t\tgoto err;\n", "prefixes": [ "dpdk-dev", "1/2" ] }