Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10032/?format=api
{ "id": 10032, "url": "https://patches.dpdk.org/api/patches/10032/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1453374478-30996-3-git-send-email-mukawa@igel.co.jp/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1453374478-30996-3-git-send-email-mukawa@igel.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/1453374478-30996-3-git-send-email-mukawa@igel.co.jp", "date": "2016-01-21T11:07:55", "name": "[dpdk-dev,RFC,2/5] virtio: move rte_eal_pci_unmap_device() to virtio_pci.c", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "30576e7db41d46fbb37fa80d9945148f7d56d5f7", "submitter": { "id": 64, "url": "https://patches.dpdk.org/api/people/64/?format=api", "name": "Tetsuya Mukawa", "email": "mukawa@igel.co.jp" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1453374478-30996-3-git-send-email-mukawa@igel.co.jp/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10032/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10032/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 390C49190;\n\tThu, 21 Jan 2016 12:08:17 +0100 (CET)", "from mail-pa0-f53.google.com (mail-pa0-f53.google.com\n\t[209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 955048E97\n\tfor <dev@dpdk.org>; Thu, 21 Jan 2016 12:08:14 +0100 (CET)", "by mail-pa0-f53.google.com with SMTP id cy9so21731182pac.0\n\tfor <dev@dpdk.org>; Thu, 21 Jan 2016 03:08:14 -0800 (PST)", "from localhost.localdomain (napt.igel.co.jp. [219.106.231.132])\n\tby smtp.gmail.com with ESMTPSA id\n\twa17sm1792640pac.38.2016.01.21.03.08.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Jan 2016 03:08:13 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=igel-co-jp.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=VwY/8Mqn8Spto+7hAGHhUsugKg8CPD0utHQV/Yk00ro=;\n\tb=hVGaDDfIVwF6+ZojLEdLwk22VXaWZyXbq945m3dlXRwVQN4G4OKolpqedhl8v1HEl2\n\tBAfq2pkI4Ptn9Tue4edbw+2JN1tXKSJtvh257CSH83PpVHhQ4860rxPSy27K1VXeczNf\n\tfulu7LDarpzRcnw9/7XDM+4uDmuqsihIsnigSXwmsUkOIco9ZHf/BBCIKjeUAna6vATn\n\tm+kq8M1otV5rtJbUxZ5Vtz1bHJiTi8DlXCAmA/j72S/6Mk4fI9sZDSpOxtqHvjjrvZ7P\n\tZAXXDrZqZUJ1+vny29UE9OqqrJtX4Ul159ngv5/FqaEsZh7LkXvts38o74hIutra68N0\n\tbaFg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=VwY/8Mqn8Spto+7hAGHhUsugKg8CPD0utHQV/Yk00ro=;\n\tb=WYzkScKE/1GqZ+JMLnw2HUx64tCoDsSaxxeIPsnsK7qF254l7XUM4mHmWLsNjt2CUD\n\tn0LHbf+hSo/usndKlqj9PC67+jHcqNjWkj3jaZ91VFRrdzHz2rfSYcch0/eyfccqD+M6\n\tF2pZgRdpn5ndzirI5JLCe/quvIxbdIQf6Ezsv/fNun1KmFesWjJiWG6rIHkEx4fI/6zu\n\tPGUtLNQhBc/LwwAEwFtYU++CFbXcM5d5M6jjSupP32U518CUbukjvWSKHNWuoSoHibcq\n\tjIfAWl2iB/gZxMveCzr+HTy2btuQkMX3dlIgrycw4xk4PCtHyCEfA/UWdH4kzFvzWtBD\n\tWA8A==", "X-Gm-Message-State": "ALoCoQld5luSsgdl4InclZy51JBcUlB8t0LJmvLQD3qYs0FHOX86KS1Zd0eajhH6xe8EKpiRg4/kO2o/fh8aU7QyDCPK8MdoVw==", "X-Received": "by 10.66.164.102 with SMTP id yp6mr59288708pab.25.1453374494029; \n\tThu, 21 Jan 2016 03:08:14 -0800 (PST)", "From": "Tetsuya Mukawa <mukawa@igel.co.jp>", "To": "dev@dpdk.org,\n\tyuanhan.liu@linux.intel.com,\n\tjianfeng.tan@intel.com", "Date": "Thu, 21 Jan 2016 20:07:55 +0900", "Message-Id": "<1453374478-30996-3-git-send-email-mukawa@igel.co.jp>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<1453374478-30996-1-git-send-email-mukawa@igel.co.jp>", "<1453108389-21006-2-git-send-email-mukawa@igel.co.jp>" ], "References": [ "<1453374478-30996-1-git-send-email-mukawa@igel.co.jp>", "<1453108389-21006-2-git-send-email-mukawa@igel.co.jp>" ], "Subject": "[dpdk-dev] [RFC PATCH 2/5] virtio: move rte_eal_pci_unmap_device()\n\tto virtio_pci.c", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To abstract pci access method, the patch moves below function\nto \"virtio_pci.c\".\n - rte_eal_pci_unmap_device()\n\nSigned-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>\n---\n drivers/net/virtio/virtio_ethdev.c | 2 +-\n drivers/net/virtio/virtio_pci.c | 11 +++++++++++\n drivers/net/virtio/virtio_pci.h | 1 +\n 3 files changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex deb0382..37833a8 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1177,7 +1177,7 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n \t\trte_intr_callback_unregister(&pci_dev->intr_handle,\n \t\t\t\t\t\tvirtio_interrupt_handler,\n \t\t\t\t\t\teth_dev);\n-\trte_eal_pci_unmap_device(pci_dev);\n+\tvtpci_uninit(pci_dev, hw);\n \n \tPMD_INIT_LOG(DEBUG, \"dev_uninit completed\");\n \ndiff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex 0aeffb7..7d7ef06 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -878,3 +878,14 @@ vtpci_init(struct rte_pci_device *dev, struct virtio_hw *hw)\n \n \treturn 0;\n }\n+\n+void\n+vtpci_uninit(struct rte_pci_device *dev, struct virtio_hw *hw)\n+{\n+\thw->dev = NULL;\n+\thw->vtpci_ops = NULL;\n+\thw->use_msix = 0;\n+\thw->io_base = 0;\n+\thw->modern = 0;\n+\trte_eal_pci_unmap_device(dev);\n+}\ndiff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h\nindex 0544a07..17c7972 100644\n--- a/drivers/net/virtio/virtio_pci.h\n+++ b/drivers/net/virtio/virtio_pci.h\n@@ -328,6 +328,7 @@ vtpci_with_feature(struct virtio_hw *hw, uint64_t bit)\n * Function declaration from virtio_pci.c\n */\n int vtpci_init(struct rte_pci_device *, struct virtio_hw *);\n+void vtpci_uninit(struct rte_pci_device *dev, struct virtio_hw *);\n void vtpci_reset(struct virtio_hw *);\n \n void vtpci_reinit_complete(struct virtio_hw *);\n", "prefixes": [ "dpdk-dev", "RFC", "2/5" ] }