Cover Detail
Show a cover letter.
GET /api/covers/897/?format=api
{ "id": 897, "url": "https://patches.dpdk.org/api/covers/897/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20240430162743.1525484-1-yoan.picchi@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240430162743.1525484-1-yoan.picchi@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240430162743.1525484-1-yoan.picchi@arm.com", "date": "2024-04-30T16:27:39", "name": "[v9,0/4] hash: add SVE support for bulk key lookup", "submitter": { "id": 3196, "url": "https://patches.dpdk.org/api/people/3196/?format=api", "name": "Yoan Picchi", "email": "yoan.picchi@arm.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20240430162743.1525484-1-yoan.picchi@arm.com/mbox/", "series": [ { "id": 31846, "url": "https://patches.dpdk.org/api/series/31846/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31846", "date": "2024-04-30T16:27:39", "name": "hash: add SVE support for bulk key lookup", "version": 9, "mbox": "https://patches.dpdk.org/series/31846/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/897/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3D1343F00;\n\tTue, 30 Apr 2024 18:27:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3D7AA40262;\n\tTue, 30 Apr 2024 18:27:55 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 999C8400EF\n for <dev@dpdk.org>; Tue, 30 Apr 2024 18:27:54 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 407C82F4;\n Tue, 30 Apr 2024 09:28:20 -0700 (PDT)", "from octeon10-1.usa.Arm.com (unknown [10.118.91.161])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC5BB3F73F;\n Tue, 30 Apr 2024 09:27:53 -0700 (PDT)" ], "From": "Yoan Picchi <yoan.picchi@arm.com>", "To": "", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tYoan Picchi <yoan.picchi@arm.com>", "Subject": "[PATCH v9 0/4] hash: add SVE support for bulk key lookup", "Date": "Tue, 30 Apr 2024 16:27:39 +0000", "Message-Id": "<20240430162743.1525484-1-yoan.picchi@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231020165159.1649282-1-yoan.picchi@arm.com>", "References": "<20231020165159.1649282-1-yoan.picchi@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patchset adds SVE support for the signature comparison in the cuckoo\nhash lookup and improves the existing NEON implementation. These\noptimizations required changes to the data format and signature of the\nrelevant functions to support dense hitmasks (no padding) and having the\nprimary and secondary hitmasks interleaved instead of being in their own\narray each.\n\nBenchmarking the cuckoo hash perf test, I observed this effect on speed:\n There are no significant changes on Intel (ran on Sapphire Rapids)\n Neon is up to 7-10% faster (ran on ampere altra)\n 128b SVE is about 3-5% slower than the optimized neon (ran on a graviton\n 3 cloud instance)\n 256b SVE is about 0-3% slower than the optimized neon (ran on a graviton\n 3 cloud instance)\n\nV2->V3:\n Remove a redundant if in the test\n Change a couple int to uint16_t in compare_signatures_dense\n Several codding-style fix\n\nV3->V4:\n Rebase\n\nV4->V5:\n Commit message\n\nV5->V6:\n Move the arch-specific code into new arch-specific files\n Isolate the data struture refactor from adding SVE\n\nV6->V7:\n Commit message\n Moved RTE_HASH_COMPARE_SVE to the last commit of the chain\n\nV7->V8:\n Commit message\n Typos and missing spaces\n\nV8->V9:\n Use __rte_unused instead of (void)\n Fix an indentation mistake\n\nYoan Picchi (4):\n hash: pack the hitmask for hash in bulk lookup\n hash: optimize compare signature for NEON\n test/hash: check bulk lookup of keys after collision\n hash: add SVE support for bulk key lookup\n\n .mailmap | 2 +\n app/test/test_hash.c | 99 ++++++++---\n lib/hash/arch/arm/compare_signatures.h | 117 +++++++++++++\n lib/hash/arch/common/compare_signatures.h | 37 ++++\n lib/hash/arch/x86/compare_signatures.h | 53 ++++++\n lib/hash/rte_cuckoo_hash.c | 199 ++++++++++++----------\n lib/hash/rte_cuckoo_hash.h | 1 +\n 7 files changed, 393 insertions(+), 115 deletions(-)\n create mode 100644 lib/hash/arch/arm/compare_signatures.h\n create mode 100644 lib/hash/arch/common/compare_signatures.h\n create mode 100644 lib/hash/arch/x86/compare_signatures.h" }