Cover Detail
Show a cover letter.
GET /api/covers/87288/?format=api
{ "id": 87288, "url": "https://patches.dpdk.org/api/covers/87288/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20210126101639.250481-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126101639.250481-1-maxime.coquelin@redhat.com", "date": "2021-01-26T10:15:55", "name": "[v4,00/44] net/virtio: Virtio PMD rework", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20210126101639.250481-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 14950, "url": "https://patches.dpdk.org/api/series/14950/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14950", "date": "2021-01-26T10:15:55", "name": "net/virtio: Virtio PMD rework", "version": 4, "mbox": "https://patches.dpdk.org/series/14950/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/87288/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DAFCA052A;\n\tTue, 26 Jan 2021 11:16:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A40514130C;\n\tTue, 26 Jan 2021 11:16:55 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 9E79F141309\n for <dev@dpdk.org>; Tue, 26 Jan 2021 11:16:53 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-593-CKTdL1g1N9WKdAUNfv3dfw-1; Tue, 26 Jan 2021 05:16:50 -0500", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91FF318C8C18;\n Tue, 26 Jan 2021 10:16:49 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 76AE27216D;\n Tue, 26 Jan 2021 10:16:41 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1611656212;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=xDflrF67ch876TAN0W6tHeF/d6EB603DNsMyhz0CUJQ=;\n b=csNKoc99GhTHI6PRnryFLGKEzu8sS+LJMYDjRxnVbkAdxWvfFYF84XL8Ofj+6KCod3ZPF3\n PJWZ/S4xwSPgOHLoYEGWLyFiXXXxowByJ7dj5p8uhj7VARS5/2WF4siShVeUzuKkHnUMpb\n s9EyZ3DDHRIyRvAwEMC8SsB+vEnQkZA=", "X-MC-Unique": "CKTdL1g1N9WKdAUNfv3dfw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 26 Jan 2021 11:15:55 +0100", "Message-Id": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v4 00/44] net/virtio: Virtio PMD rework", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This V3 fixes comments from Chenbo on patch 44 and\nimplements the ABI exception in patch 2.\n\nThis series significantly rework Virtio PMD to improve\nthe Virtio-user PMD and its backends integration.\n\nFirst part of the series removes the dependency of\nVirtio-user ethdev on Virtio PCI, by creating generic\nfiles, adding per-bus meta data, ...\n\nMain (if not single) functionnal change of this first\npart is to remove the hack for Virtio-user to work in\nIOVA as PA mode, this hack being very fragile.\n\nSecond part of the series reworks Virtio-user internal,\nby reworking the requests handling so that vDPA and Kernel\nbackends no more hack into being Vhost-user backend. It\nimplies implementing new ops for all the request types.\nAlso, all the backend specific actions are moved from the\nvirtio_user_dev.c and virtio_user_ethdev.c to their\nbackend files.\n\nOnly functionnal change in this second part is making the\nVhost-user server mode blocking at init time, as long as\na client is not connected. The goal of this change is to\nmake the Vhost-user support much more robust, as without\nblocking, the driver has to assume features that are going\nto be supported by the client, which is very fragile and\nerror prone. As a side-effect, it also simplifies the\nlogic nin several place of the virtio-user PMD.\n\nMain changes in v4:\n- Add ABI exception (David)\n- Close FDs only up to max_queue_pairs\n- virtio_user_dev_uninit_notify() to return void\n\nMain changes in v3:\n- Rename .intr_event to .intr_detect\n- Rework last patch, properly clean allocated resources\n on failure.\n- Rebase on top of latest net-next/main\n- Minor typo fixes in comments and log improvements\n\nMain changes in v2:\n===================\n- Introduce vdev driver flag for drivers to require IOVA VA mode\n- Rebase on top of -rc1 changes\n- Fix regressions introduced in V1 (vhost-kernel broken, vhost-user reconnect...)\n- Various minor issues & typos fixed\n- Fix status feature issue introduced in v20.11, only reproduceable now that server\n mode is made blocking\n- Improve failure handling in Virtio-user\n- Improve logging\n\nTesting coverage (All passed)\n=============================\n- Virtio-pci PMD\n * Virtio PMD in guest with Vhost-user backend in host\n * Virtio PMD in guest with Vhost-kernel backend in host\n- Virtio-user PMD with Vhost-user backend\n * Vhost-user PMD server <-> Virtio-user client PMD IO loopback\n * Vhost-user PMD client <-> Virtio-user server PMD IO loopback\n * Vhost-user PMD client <-> Virtio-user server PMD reconnect\n- Virtio-user PMD with Vhost-kernel backend\n * iperf test case\n * Txonly testpmd\n- Virtio-user PMD with Vhost-vDPA backend\n * vdpa-sim (IO loopback)\n * CX-6 DX Kernel vDPA (Tx only)\n\nMaxime Coquelin (44):\n bus/vdev: add helper to get vdev from ethdev\n bus/vdev: add driver IOVA VA mode requirement\n net/virtio: fix getting old status on reconnect\n net/virtio: introduce Virtio bus type\n net/virtio: refactor virtio-user device\n net/virtio: introduce PCI device metadata\n net/virtio: move PCI device init in dedicated file\n net/virtio: move PCI specific dev init to PCI ethdev init\n net/virtio: move MSIX detection to PCI ethdev\n net/virtio: force IOVA as VA mode for Virtio-user\n net/virtio: store PCI type in Virtio device metadata\n net/virtio: add callback for device closing\n net/virtio: validate features at bus level\n net/virtio: remove bus type enum\n net/virtio: move PCI-specific fields to PCI device\n net/virtio: pack virtio HW struct\n net/virtio: move legacy IO to Virtio PCI\n net/virtio: introduce generic virtio header\n net/virtio: move features definition to generic header\n net/virtio: move virtqueue defines in generic header\n net/virtio: move config definitions to generic header\n net/virtio: make interrupt handling more generic\n net/virtio: move vring alignment to generic header\n net/virtio: remove last PCI refs in non-PCI code\n net/virtio: make Vhost-user request sender consistent\n net/virtio: add Virtio-user ops to set owner\n net/virtio: add Virtio-user features ops\n net/virtio: add Virtio-user protocol features ops\n net/virtio: add Virtio-user memory tables ops\n net/virtio: add Virtio-user vring setting ops\n net/virtio: add Virtio-user vring file ops\n net/virtio: add Virtio-user vring address ops\n net/virtio: add Virtio-user status ops\n net/virtio: remove useless request ops\n net/virtio: improve Virtio-user errors handling\n net/virtio: move Vhost-user requests to Vhost-user backend\n net/virtio: make server mode blocking\n net/virtio: move protocol features to Vhost-user\n net/virtio: introduce backend data\n net/virtio: move Vhost-user specifics to its backend\n net/virtio: move Vhost-kernel data to its backend\n net/virtio: move Vhost-vDPA data to its backend\n net/virtio: improve Vhost-user error logging\n net/virtio: handle Virtio-user setup failure properly\n\n devtools/libabigail.abignore | 2 +\n drivers/bus/vdev/rte_bus_vdev.h | 6 +\n drivers/bus/vdev/vdev.c | 29 +\n drivers/net/virtio/meson.build | 6 +-\n drivers/net/virtio/virtio.c | 71 ++\n drivers/net/virtio/virtio.h | 246 +++++\n drivers/net/virtio/virtio_ethdev.c | 457 +++------\n drivers/net/virtio/virtio_ethdev.h | 6 +-\n drivers/net/virtio/virtio_pci.c | 448 +++++----\n drivers/net/virtio/virtio_pci.h | 286 +-----\n drivers/net/virtio/virtio_pci_ethdev.c | 226 +++++\n drivers/net/virtio/virtio_ring.h | 2 +-\n drivers/net/virtio/virtio_rxtx.c | 90 +-\n drivers/net/virtio/virtio_rxtx_packed.h | 10 +-\n drivers/net/virtio/virtio_rxtx_packed_avx.h | 10 +-\n drivers/net/virtio/virtio_rxtx_packed_neon.h | 10 +-\n drivers/net/virtio/virtio_rxtx_simple.h | 3 +-\n drivers/net/virtio/virtio_user/vhost.h | 79 +-\n drivers/net/virtio/virtio_user/vhost_kernel.c | 461 ++++++---\n .../net/virtio/virtio_user/vhost_kernel_tap.c | 25 +-\n .../net/virtio/virtio_user/vhost_kernel_tap.h | 1 +\n drivers/net/virtio/virtio_user/vhost_user.c | 898 ++++++++++++++----\n drivers/net/virtio/virtio_user/vhost_vdpa.c | 323 +++++--\n .../net/virtio/virtio_user/virtio_user_dev.c | 573 ++++++-----\n .../net/virtio/virtio_user/virtio_user_dev.h | 21 +-\n drivers/net/virtio/virtio_user_ethdev.c | 301 +-----\n drivers/net/virtio/virtqueue.c | 6 +-\n drivers/net/virtio/virtqueue.h | 45 +-\n 28 files changed, 2742 insertions(+), 1899 deletions(-)\n create mode 100644 drivers/net/virtio/virtio.c\n create mode 100644 drivers/net/virtio/virtio.h\n create mode 100644 drivers/net/virtio/virtio_pci_ethdev.c" }