Cover Detail
Show a cover letter.
GET /api/covers/78565/?format=api
{ "id": 78565, "url": "https://patches.dpdk.org/api/covers/78565/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20200923132541.21417-1-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200923132541.21417-1-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200923132541.21417-1-l.wojciechow@partner.samsung.com", "date": "2020-09-23T13:25:33", "name": "[v3,0/8] fix distributor synchronization issues", "submitter": { "id": 1628, "url": "https://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20200923132541.21417-1-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 12442, "url": "https://patches.dpdk.org/api/series/12442/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12442", "date": "2020-09-23T13:25:33", "name": "fix distributor synchronization issues", "version": 3, "mbox": "https://patches.dpdk.org/series/12442/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/78565/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C8C0AA04B1;\n\tWed, 23 Sep 2020 15:25:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D812C1DA20;\n\tWed, 23 Sep 2020 15:25:45 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 6F1C61D37F\n for <dev@dpdk.org>; Wed, 23 Sep 2020 15:25:45 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200923132544euoutp02a7a1fc67df4764de77708b3bc1b58df5~3bIziCpni1049510495euoutp02w\n for <dev@dpdk.org>; Wed, 23 Sep 2020 13:25:44 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200923132544eucas1p21b40ecdf6c87d51adc3175de989b4759~3bIzYXvBo2884028840eucas1p2C;\n Wed, 23 Sep 2020 13:25:44 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 92.B3.06456.8DC4B6F5; Wed, 23\n Sep 2020 14:25:44 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200923132544eucas1p29470697e7cb6621cc65e6e676c3e5d69~3bIzERfOt0346103461eucas1p2n;\n Wed, 23 Sep 2020 13:25:44 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200923132544eusmtrp15fe170e19c2d66f750d508874701d8aa~3bIzDzK2v3185331853eusmtrp1l;\n Wed, 23 Sep 2020 13:25:44 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 72.FA.06017.8DC4B6F5; Wed, 23\n Sep 2020 14:25:44 +0100 (BST)", "from Padamandas.fritz.box (unknown [106.210.88.70]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200923132543eusmtip2965d5e2b7c384dec634881207269dfb8~3bIyqx-pr2716427164eusmtip2H;\n Wed, 23 Sep 2020 13:25:43 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200923132544euoutp02a7a1fc67df4764de77708b3bc1b58df5~3bIziCpni1049510495euoutp02w", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1600867544;\n bh=BsdQbbJrYchi0rSMMZ62olnwP4DS5iFrlDgGgAJ10M4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=r0COzBvs0k/sI7SN+U4wkm0V7Hygzb+rCWXtiC6fDys2shpbTxiRS4skKq/XjWTH4\n lFCTdibCJjxczg2ZufTjsHJYM4PmeDW440T+OsisSWsTjqoyaAO87KvpZlS9BTZxrp\n pOybY/yhvKS0kXoTpIF+hQ/yBHjjfsp+EiRk0sQM=", "X-AuditID": "cbfec7f2-809ff70000001938-17-5f6b4cd8fb23", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org, l.wojciechow@partner.samsung.com", "Date": "Wed, 23 Sep 2020 15:25:33 +0200", "Message-Id": "<20200923132541.21417-1-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200923014713.16932-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFrrMIsWRmVeSWpSXmKPExsWy7djP87o3fLLjDS4c0rJ492k7k8WznnWM\n DkwevxYsZfU4+G4PUwBTFJdNSmpOZllqkb5dAlfG3+YtbAVPuCsOTLrH2MC4jLOLkZNDQsBE\n 4uH85SwgtpDACkaJu13eXYxcQPYXRokvc9+wQzifGSXa3/1kguk4u+45E0RiOaPEnsNPodo/\n MUq87tcDsdkEbCWOzPzKCmKLCLBIrPz+HayGWcBI4mX3RGYQW1jATuLo1AZGEJtFQFVi9qX1\n YAt4BVwlZiw7D7VMXmL1hgNA9RwcnAJuEk//yYPslRDYwSZx8voNqBoXiRffvkLZwhKvjm9h\n h7BlJE5P7mGBaNjGKHH1909GCGc/o8T13hVQVdYSh//9ZgPZwCygKbF+lz5E2FFizu+7YGEJ\n AT6JG28FIe7nk5i0bTozRJhXoqNNCKJaT+Jpz1RGmLV/1j5hgbA9JPq6XjJCwmomo8TbjWtZ\n JzDKz0JYtoCRcRWjeGppcW56arFhXmq5XnFibnFpXrpecn7uJkZgVJ/+d/zTDsavl5IOMQpw\n MCrx8HLoZscLsSaWFVfmHmKU4GBWEuF1Ons6Tog3JbGyKrUoP76oNCe1+BCjNAeLkjiv8aKX\n sUIC6YklqdmpqQWpRTBZJg5OKWDgV/xMncUiumPtngk8u+S3RllZlvNVzy4Lme3329yl6yH/\n At+tgkzPdzvOfLlv8dey+ob8F0vD6i553/DrNYoPOyrgo7P4hnPyrv7wub0dV9bN1v7lem7F\n jjJLxrvcv4zYN+YcK70umG2t+cDXIjQkIUzksIOdgrbVrniHzrMLHKad6lbr5lZiKc5INNRi\n LipOBABoUvkX5gIAAA==", "\n H4sIAAAAAAAAA+NgFtrCLMWRmVeSWpSXmKPExsVy+t/xe7o3fLLjDa5vFbV492k7k8WznnWM\n DkwevxYsZfU4+G4PUwBTlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1N\n SmpOZllqkb5dgl7G3+YtbAVPuCsOTLrH2MC4jLOLkZNDQsBE4uy650xdjFwcQgJLGSWO7FnA\n 1sXIAZSQkfhwSQCiRljiz7UuNoiaD4wSXx40M4Mk2ARsJY7M/MoKYosIsEis/P6dBcRmBhp6\n e14TG4gtLGAncXRqAyOIzSKgKjH70nomEJtXwFVixrLzTBAL5CVWbzjADLKXU8BN4uk/eZCw\n EFBJ34lvbBMY+RYwMqxiFEktLc5Nzy020itOzC0uzUvXS87P3cQIDLFtx35u2cHY9S74EKMA\n B6MSDy+Hbna8EGtiWXFl7iFGCQ5mJRFep7On44R4UxIrq1KL8uOLSnNSiw8xmgLdNJFZSjQ5\n Hxj+eSXxhqaG5haWhubG5sZmFkrivB0CB2OEBNITS1KzU1MLUotg+pg4OKUaGFM/fnUz2HXF\n 5VbJZ8OTJbOmf0rovCxmYlhrs1NG94X0yh1Zb2z0YpwDj2wW2FW8KjJQO+4P69McHzF/AR+7\n nL3eO9c0cfM/Ept1t3hu3ecV58r8Ko8U3EiJK2s8G9navEjQdnWzrK3ljJ0yh2L8IqOaX8yc\n pPXxWNaLRxnJXC90H4tMXSe/X4mlOCPRUIu5qDgRAPbrjaVHAgAA" ], "X-CMS-MailID": "20200923132544eucas1p29470697e7cb6621cc65e6e676c3e5d69", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200923132544eucas1p29470697e7cb6621cc65e6e676c3e5d69", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200923132544eucas1p29470697e7cb6621cc65e6e676c3e5d69", "References": "<20200923014713.16932-1-l.wojciechow@partner.samsung.com>\n <CGME20200923132544eucas1p29470697e7cb6621cc65e6e676c3e5d69@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v3 0/8] fix distributor synchronization issues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During review and verification of the patch created by Sarosh Arif:\n\"test_distributor: prevent memory leakages from the pool\" I found out\nthat running distributor unit tests multiple times in a row causes fails.\nSo I investigated all the issues I found.\n\nThere are few synchronization issues that might cause deadlocks\nor corrupted data. They are fixed with this set of patches for both tests\nand librte_distributor library.\n\n---\nv3:\n* add missing acked and tested by statements from v1\n\nv2:\n* assign NULL to freed mbufs in distributor test\n* fix handshake check on legacy single distributor\n rte_distributor_return_pkt_single()\n* add patch 7 passing NULL to legacy API calls if no bufs are returned\n* add patch 8 fixing API documentation\n\nLukasz Wojciechowski (8):\n app/test: fix deadlock in distributor test\n app/test: synchronize statistics between lcores\n app/test: fix freeing mbufs in distributor tests\n app/test: collect return mbufs in distributor test\n distributor: fix missing handshake synchronization\n distributor: fix handshake deadlock\n distributor: do not use oldpkt when not needed\n distributor: align API documentation with code\n\n app/test/test_distributor.c | 113 +++++++++++-------\n lib/librte_distributor/rte_distributor.c | 27 ++++-\n lib/librte_distributor/rte_distributor.h | 23 ++--\n .../rte_distributor_single.c | 4 +\n 4 files changed, 110 insertions(+), 57 deletions(-)" }