Cover Detail
Show a cover letter.
GET /api/covers/68802/?format=api
https://patches.dpdk.org/api/covers/68802/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/cover.1587137703.git.grive@u256.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cover.1587137703.git.grive@u256.net>", "list_archive_url": "https://inbox.dpdk.org/dev/cover.1587137703.git.grive@u256.net", "date": "2020-04-17T16:42:05", "name": "[v1,0/2] bonding: fix port id check and PCI addr cmp", "submitter": { "id": 1560, "url": "https://patches.dpdk.org/api/people/1560/?format=api", "name": "Gaëtan Rivet", "email": "grive@u256.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/cover.1587137703.git.grive@u256.net/mbox/", "series": [ { "id": 9478, "url": "https://patches.dpdk.org/api/series/9478/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9478", "date": "2020-04-17T16:42:05", "name": "bonding: fix port id check and PCI addr cmp", "version": 1, "mbox": "https://patches.dpdk.org/series/9478/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/68802/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D1D2A0597;\n\tFri, 17 Apr 2020 18:42:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9267B1EA6A;\n\tFri, 17 Apr 2020 18:42:19 +0200 (CEST)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n [217.70.183.201]) by dpdk.org (Postfix) with ESMTP id EF75B1EA1A\n for <dev@dpdk.org>; Fri, 17 Apr 2020 18:42:17 +0200 (CEST)", "from inocybe.home (lfbn-idf2-1-566-132.w86-246.abo.wanadoo.fr\n [86.246.31.132]) (Authenticated sender: grive@u256.net)\n by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6EEAA1BF205\n for <dev@dpdk.org>; Fri, 17 Apr 2020 16:42:16 +0000 (UTC)" ], "X-Originating-IP": "86.246.31.132", "From": "Gaetan Rivet <grive@u256.net>", "To": "dev@dpdk.org", "Date": "Fri, 17 Apr 2020 18:42:05 +0200", "Message-Id": "<cover.1587137703.git.grive@u256.net>", "X-Mailer": "git-send-email 2.26.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 0/2] bonding: fix port id check and PCI addr\n\tcmp", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Found these two bugs while reading the bonding code.\n\nThe first bug is mostly usability: if a user gives an incorrect port id\nas a slave, it will error-out later. The error will simply be less\nclear.\n\nI'm partially responsible for the second one. I don't see why we did not\nwrote it properly at the time: the comment about lacking the proper\nrte_bus_pci impl was already not correct anymore when the check on the kdrv\nwas removed. The necessary functions were already available I think.\n\nGaetan Rivet (2):\n bonding: fix port id validity check on parsing\n bonding: fix PCI address comparison on non-pci ports\n\n drivers/net/bonding/rte_eth_bond_args.c | 63 +++++++++++--------------\n 1 file changed, 27 insertions(+), 36 deletions(-)" }{ "id": 68802, "url": "