Cover Detail
Show a cover letter.
GET /api/covers/68442/?format=api
{ "id": 68442, "url": "https://patches.dpdk.org/api/covers/68442/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20200414194426.1640704-1-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200414194426.1640704-1-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200414194426.1640704-1-dmitry.kozliuk@gmail.com", "date": "2020-04-14T19:44:15", "name": "[v3,00/10] Windows basic memory management", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20200414194426.1640704-1-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 9374, "url": "https://patches.dpdk.org/api/series/9374/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9374", "date": "2020-04-14T19:44:15", "name": "Windows basic memory management", "version": 3, "mbox": "https://patches.dpdk.org/series/9374/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/68442/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB9BCA0577;\n\tTue, 14 Apr 2020 21:44:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D5ABF1D173;\n\tTue, 14 Apr 2020 21:44:42 +0200 (CEST)", "from mail-lj1-f196.google.com (mail-lj1-f196.google.com\n [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 392201D15C\n for <dev@dpdk.org>; Tue, 14 Apr 2020 21:44:41 +0200 (CEST)", "by mail-lj1-f196.google.com with SMTP id q22so1179927ljg.0\n for <dev@dpdk.org>; Tue, 14 Apr 2020 12:44:41 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.googlemail.com with ESMTPSA id\n h14sm11272426lfm.60.2020.04.14.12.44.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2020 12:44:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=A0Awuq44jBkjSznmOAcHiEupZPcUrs+Crv2Y4t1Xmpk=;\n b=MeqMVMUhFsTy0ofXlrSwL3VLXTq//jHcuXfQWmE68Ls6rwrzoZYF+2SqIedooj/yj3\n 9pVbSi7v0JPoK88bFf6BK1/zci4iv4NJ8yzz+ppbuJqmlotpm7FrxXkVfjbZ9jaQSFj+\n 5B5vkJjEBVHGOlCckLzLdiXnF7FacyQQ6rMTQfegea6fBXhSyl/+ZjY0jIllX1wbLP8X\n KvptSuWgNWxK3pQQDeO6p/W6U7crzQolJKd7ubG+qumZs07AShPDuiOLWY2d4zSmT20I\n 8WJKijThVa1GvwQAWZoeLuj7uRmgzt3EhtJ/uACZ4keEc0RjfZXiklsFofMlfwCZM0Ut\n AakQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=A0Awuq44jBkjSznmOAcHiEupZPcUrs+Crv2Y4t1Xmpk=;\n b=hSD/Ve3wbRIqhoItYeLioNfC9vx4xPiFw75Zr36dlGKvAnsAFuesxixzqFP8o0w98h\n w/LqVmAHfWfR08XkMYK0BeaKtcbwJ+ziK9X10aS6ZxioVNwwnM0JOiiuSrOx97jew+8q\n jeh4in4SEuE6LfFL5G582kq16R7Ldj71Jj8h/MjrXaKzTks1bKLy3imVA1opon344h9a\n JqEaJXVl/snmA1/jwl5CcS7UqzmRrTo7xOVRx1JmNqBWV0ei2h5vujONazWoJB9I6Uh0\n ymtr20ADMK4LKYMQJb3jzFiXLu0bYa0r9JepXrLBYk9QBEG1LU8d/XS5MWL/deOF2mhd\n bUFw==", "X-Gm-Message-State": "AGi0PuaBj3GePERLi5WoWLWu/6oZEz9aEtIW7yNUmAYkwB55NBrbASsk\n WLvylot1kMMErqhlEae5wfhzvS3/h74qSQ==", "X-Google-Smtp-Source": "\n APiQypLcWchV1asJkCs5TSsFgD6jEJ6bKVsMO5XcvLP4lQuzSB09unKlT99bX0G+h12Tb++45LB/9A==", "X-Received": "by 2002:a05:651c:449:: with SMTP id\n g9mr1069411ljg.278.1586893480129;\n Tue, 14 Apr 2020 12:44:40 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "\"Dmitry Malloy (MESHCHANINOV)\" <dmitrym@microsoft.com>,\n Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,\n Fady Bader <fady@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Date": "Tue, 14 Apr 2020 22:44:15 +0300", "Message-Id": "<20200414194426.1640704-1-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200410164342.1194634-1-dmitry.kozliuk@gmail.com>", "References": "<20200410164342.1194634-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 00/10] Windows basic memory management", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Note: no changes in cover letter since v2.\n\nThis patchset implements basic MM with the following features:\n\n* Hugepages are dynamically allocated in user-mode.\n* Only 2MB hugepages are supported.\n* IOVA is always PA, obtained through kernel-mode driver.\n* No 32-bit support (presumably not demanded).\n* Ni multi-process support (it is forcefully disabled).\n* No-huge mode for testing with IOVA unavailable.\n\n\nThe first commit introduces a new kernel-mode driver, virt2phys.\nIt translates user-mode virtual addresses into physical addresses.\nOn Windows community call 2020-04-01 it was decided this driver can be\nused for now, later netUIO may pick up its code/interface or not.\n\n\nNew EAL public functions for memory mapping are introduced\nto mitigate OS differences in DPDK libraries and applications:\n\n* rte_mem_map\n* rte_mem_unmap\n* rte_mem_lock\n\nTo support common MM routines, internal wrappers for low-level\nmemory reservation and file management are introduced. These changes\naffect Linux and FreeBSD EAL. Shared code is placed unded /unix/\nsubdirectory (suggested by Thomas).\n\nAlso, entire <sys/queue.h> is imported from FreeBSD, replacing existing\npartial import. There is already a license exception for this file.\n\n\nWindows MM duplicates quite a lot of code from Linux EAL:\n\n* eal_memalloc_alloc_seg_bulk\n* eal_memalloc_free_seg_bulk\n* calc_num_pages_per_socket\n* rte_eal_hugepage_init\n\nPerhaps this should be left as-is until Windows MM evolves into having\nsome specific requirements for these parts.\n\n\nNotes on checkpatch warnings:\n\n* No space after comma / no space before closing parent in macros---\n definitely a false-positive, unclear how to suppress this.\n\n* Issues from imported BSD code---probably should be ignored?\n\n* Checkpatch is not run against dpdk-kmods (Windows drivers).\n\n---\n\nv3:\n\n * Fix Linux build on and aarch64 and 32-bit x86 (reported by CI).\n * Fix logic and error handling while allocating segments.\n * Fix Unix rte_mem_map(): return NULL on failure.\n * Fix some checkpatch.sh issues:\n * Do not return positive errno, use DWORD for GetLastError().\n * Make dpdk-kmods source files non-executable.\n * Improve GSG for Windows Server (suggested by Ranjit Menon).\n\nv2:\n\n * Rebase on ToT. Move all new code shared between Linux and FreeBSD\n to /unix/ subdirectory, also factor out some existing code there.\n * Improve description of Clang issue with rte_page_sizes on Windows.\n Restore -fstrict-enum for EAL. Check running, not target compiler.\n * Use EAL prefix for private facilities instead if RTE.\n * Improve documentation comments for new functions.\n * Remove co-installer for virt2phys. Add a typecast for clarity.\n * Document virt2phys in user guide, improve its own README.\n * Explicitly and forcefully disable multi-process.\n\nDmitry Kozlyuk (9):\n eal/windows: do not expose private EAL facilities\n eal/windows: improve CPU and NUMA node detection\n eal/windows: initialize hugepage info\n eal: introduce internal wrappers for file operations\n eal: introduce memory management wrappers\n eal: extract common code for memseg list initialization\n eal/windows: fix rte_page_sizes with Clang on Windows\n eal/windows: replace sys/queue.h with a complete one from FreeBSD\n eal/windows: implement basic memory management\n\n config/meson.build | 12 +-\n doc/guides/windows_gsg/build_dpdk.rst | 20 -\n doc/guides/windows_gsg/index.rst | 1 +\n doc/guides/windows_gsg/run_apps.rst | 84 ++\n lib/librte_eal/common/eal_common_fbarray.c | 57 +-\n lib/librte_eal/common/eal_common_memory.c | 104 +-\n lib/librte_eal/common/eal_private.h | 134 +-\n lib/librte_eal/common/malloc_heap.c | 1 +\n lib/librte_eal/common/meson.build | 9 +\n lib/librte_eal/freebsd/eal_memory.c | 55 +-\n lib/librte_eal/include/rte_memory.h | 74 ++\n lib/librte_eal/linux/eal_memory.c | 68 +-\n lib/librte_eal/meson.build | 4 +\n lib/librte_eal/rte_eal_exports.def | 119 ++\n lib/librte_eal/rte_eal_version.map | 4 +\n lib/librte_eal/unix/eal.c | 47 +\n lib/librte_eal/unix/eal_memory.c | 113 ++\n lib/librte_eal/unix/meson.build | 7 +\n lib/librte_eal/windows/eal.c | 160 +++\n lib/librte_eal/windows/eal_hugepages.c | 108 ++\n lib/librte_eal/windows/eal_lcore.c | 187 ++-\n lib/librte_eal/windows/eal_memalloc.c | 418 ++++++\n lib/librte_eal/windows/eal_memory.c | 1141 +++++++++++++++++\n lib/librte_eal/windows/eal_mp.c | 103 ++\n lib/librte_eal/windows/eal_thread.c | 1 +\n lib/librte_eal/windows/eal_windows.h | 129 ++\n lib/librte_eal/windows/include/meson.build | 2 +\n lib/librte_eal/windows/include/pthread.h | 2 +\n lib/librte_eal/windows/include/rte_os.h | 48 +-\n .../windows/include/rte_virt2phys.h | 34 +\n lib/librte_eal/windows/include/rte_windows.h | 43 +\n lib/librte_eal/windows/include/sys/queue.h | 663 +++++++++-\n lib/librte_eal/windows/include/unistd.h | 3 +\n lib/librte_eal/windows/meson.build | 6 +\n 34 files changed, 3611 insertions(+), 350 deletions(-)\n create mode 100644 doc/guides/windows_gsg/run_apps.rst\n create mode 100644 lib/librte_eal/unix/eal.c\n create mode 100644 lib/librte_eal/unix/eal_memory.c\n create mode 100644 lib/librte_eal/unix/meson.build\n create mode 100644 lib/librte_eal/windows/eal_hugepages.c\n create mode 100644 lib/librte_eal/windows/eal_memalloc.c\n create mode 100644 lib/librte_eal/windows/eal_memory.c\n create mode 100644 lib/librte_eal/windows/eal_mp.c\n create mode 100644 lib/librte_eal/windows/eal_windows.h\n create mode 100644 lib/librte_eal/windows/include/rte_virt2phys.h\n create mode 100644 lib/librte_eal/windows/include/rte_windows.h" }