Cover Detail
Show a cover letter.
GET /api/covers/45148/?format=api
{ "id": 45148, "url": "https://patches.dpdk.org/api/covers/45148/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/1537550255-252066-1-git-send-email-yipeng1.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537550255-252066-1-git-send-email-yipeng1.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537550255-252066-1-git-send-email-yipeng1.wang@intel.com", "date": "2018-09-21T17:17:28", "name": "[v2,0/7] hash: add extendable bucket and partial key hashing", "submitter": { "id": 754, "url": "https://patches.dpdk.org/api/people/754/?format=api", "name": "Wang, Yipeng1", "email": "yipeng1.wang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/1537550255-252066-1-git-send-email-yipeng1.wang@intel.com/mbox/", "series": [ { "id": 1449, "url": "https://patches.dpdk.org/api/series/1449/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1449", "date": "2018-09-21T17:17:28", "name": "hash: add extendable bucket and partial key hashing", "version": 2, "mbox": "https://patches.dpdk.org/series/1449/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/45148/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0C2584C95;\n\tSat, 22 Sep 2018 02:22:13 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id A48F1A49\n\tfor <dev@dpdk.org>; Sat, 22 Sep 2018 02:22:11 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Sep 2018 17:22:10 -0700", "from skx-yipeng.jf.intel.com ([10.54.81.175])\n\tby orsmga006.jf.intel.com with ESMTP; 21 Sep 2018 17:22:10 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,287,1534834800\"; d=\"scan'208\";a=\"76346596\"", "From": "Yipeng Wang <yipeng1.wang@intel.com>", "To": "bruce.richardson@intel.com", "Cc": "dev@dpdk.org, yipeng1.wang@intel.com, michel@digirati.com.br,\n\thonnappa.nagarahalli@arm.com", "Date": "Fri, 21 Sep 2018 10:17:28 -0700", "Message-Id": "<1537550255-252066-1-git-send-email-yipeng1.wang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1536253745-133104-1-git-send-email-yipeng1.wang@intel.com>", "References": "<1536253745-133104-1-git-send-email-yipeng1.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial\n\tkey hashing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The first four commits of the patch set try to fix small issues of\nprevious code.\n\nThe other commits make two major optimizations over the current rte_hash\nlibrary.\n\nFirst, it adds Extendable Bucket Table feature: a new structure that can\naccommodate keys that failed to get inserted into the main hash table due to\nthe unlikely event of excessive hash collisions. The hash table buckets will\nget extended using a linked list to host these keys. This new design will\nguarantee insertion of 100% of the keys for a given hash table size with\nminimal overhead. A new flag value is added for user to indicate if the\nextendable bucket feature should be enabled or not. The linked list buckets is\nsimilar concept to the extendable bucket hash table in packet framework.\nIn details, for insertion, the linked buckets will be used to store the keys\nthat fail to get in the primary and the secondary bucket and the cuckoo path\ncould not find an empty location for the maximum path length (small\nprobability). For lookup, the key is checked first in the primary, then the\nsecondary, then if the secondary is extended the linked list is traversed\nfor a possible match.\n\nSecond, the patch set changes the current hashing algorithm to be \"partial-key\nhashing\". Partial-key hashing is the concept from Bin Fan, et al.'s paper\n\"MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter\nHashing\". Instead of storing both 32-bit signature and alternative signature\nin the bucket, we only store a small 16-bit signature and calculate the\nalternative bucket index by XORing the signature with the current bucket index.\nThis doubles the hash table memory efficiency since now one bucket\nonly occupies one cache line instead of two in the original design.\n\nV1->V2:\n1. hash: Rewrite rte_hash_get_last_bkt to be more concise.\n2. hash: Reorder the rte_hash struct to align cache line better.\n3. test: Minor changes in auto test to add key insertion failure check during\niteration test.\n4. test: Add new commit to fix read-write test non-consecutive core issue.\n4. hash: Add a new commit to remove unnecessary code introduced by previous\npatches.\n5. hash: Comments improvement and coding style improvements over multiple\nplaces.\n\nSigned-off-by: Yipeng Wang <yipeng1.wang@intel.com>\n\nYipeng Wang (7):\n test/hash: fix bucket size in hash perf test\n test/hash: more accurate hash perf test output\n test/hash: fix rw test with non-consecutive cores\n hash: fix unnecessary code\n hash: add extendable bucket feature\n test/hash: implement extendable bucket hash test\n hash: use partial-key hashing\n\n lib/librte_hash/rte_cuckoo_hash.c | 516 +++++++++++++++++++++++++++-----------\n lib/librte_hash/rte_cuckoo_hash.h | 13 +-\n lib/librte_hash/rte_hash.h | 8 +-\n test/test/test_hash.c | 151 ++++++++++-\n test/test/test_hash_perf.c | 126 +++++++---\n test/test/test_hash_readwrite.c | 78 +++---\n 6 files changed, 672 insertions(+), 220 deletions(-)" }