Cover Detail
Show a cover letter.
GET /api/covers/122439/?format=api
{ "id": 122439, "url": "https://patches.dpdk.org/api/covers/122439/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20230123090229.3392071-1-adwivedi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230123090229.3392071-1-adwivedi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230123090229.3392071-1-adwivedi@marvell.com", "date": "2023-01-23T09:02:23", "name": "[v7,0/6] add trace points in ethdev library", "submitter": { "id": 1561, "url": "https://patches.dpdk.org/api/people/1561/?format=api", "name": "Ankur Dwivedi", "email": "adwivedi@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20230123090229.3392071-1-adwivedi@marvell.com/mbox/", "series": [ { "id": 26628, "url": "https://patches.dpdk.org/api/series/26628/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26628", "date": "2023-01-23T09:02:23", "name": "add trace points in ethdev library", "version": 7, "mbox": "https://patches.dpdk.org/series/26628/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/122439/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C93C242466;\n\tMon, 23 Jan 2023 10:05:32 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A7EE4400EF;\n\tMon, 23 Jan 2023 10:05:32 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 1B6AB400D4\n for <dev@dpdk.org>; Mon, 23 Jan 2023 10:05:31 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 30MLPwur021696; Mon, 23 Jan 2023 01:03:00 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3n8ger8fup-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 23 Jan 2023 01:02:59 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Mon, 23 Jan 2023 01:02:57 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Mon, 23 Jan 2023 01:02:57 -0800", "from localhost.localdomain (unknown [10.28.36.185])\n by maili.marvell.com (Postfix) with ESMTP id 6CA553F706D;\n Mon, 23 Jan 2023 01:02:35 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=dNb8s0IXMFEXeYG6+cwIU9IJ8Cf6/1QRKRu/0ArAdTk=;\n b=Yqr+UlvTsJPF9dK3rH3zt2jClxLjbi51feT1eEqYiZKDndkDlEcn+YTFKv0s1UfSxAdj\n SUvvvN9g3CqQwhvQ/UEPy7rPZx0zr89YrjbceaXmcjEuXPN3g5KZeunw3FL9WflrjF3E\n u1STnqF4eCCyfhvF1ar2AHkp3vOM8LViaIcM/fz1i8h8QwiyAfUKCFngWBh3979WuSzM\n 9ybw2hoXdp3mSRmlOA6DCFl9x1sRGfIn44Y5ZQEPCHQBR2WV7DbbnxVIFtlrmfcleUjD\n d11+Tfms4vC0vZQgc43SXpbZL4UDlMaEKENOUVdkFY+T6ysb8PsEquZd2X8K5XsuFDcA GQ==", "From": "Ankur Dwivedi <adwivedi@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>, <mdr@ashroe.eu>,\n <orika@nvidia.com>, <ferruh.yigit@amd.com>, <chas3@att.com>,\n <humin29@huawei.com>, <linville@tuxdriver.com>,\n <ciara.loftus@intel.com>, <qi.z.zhang@intel.com>, <mw@semihalf.com>,\n <mk@semihalf.com>, <shaibran@amazon.com>, <evgenys@amazon.com>,\n <igorch@amazon.com>, <chandu@amd.com>, <irusskikh@marvell.com>,\n <shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>,\n <john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>,\n <somnath.kotur@broadcom.com>, <jerinj@marvell.com>,\n <mczekaj@marvell.com>, <sthotton@marvell.com>,\n <srinivasan@marvell.com>, <hkalra@marvell.com>,\n <rahul.lakkireddy@chelsio.com>, <johndale@cisco.com>,\n <hyonkim@cisco.com>, <liudongdong3@huawei.com>,\n <yisen.zhuang@huawei.com>, <xuanziyang2@huawei.com>,\n <cloud.wangxiaoyun@huawei.com>, <zhouguoyang@huawei.com>,\n <simei.su@intel.com>, <wenjun1.wu@intel.com>, <qiming.yang@intel.com>,\n <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,\n <xiao.w.wang@intel.com>, <jingjing.wu@intel.com>,\n <junfeng.guo@intel.com>, <rosen.xu@intel.com>,\n <ndabilpuram@marvell.com>, <kirankumark@marvell.com>,\n <skori@marvell.com>, <skoteshwar@marvell.com>, <lironh@marvell.com>,\n <zr@semihalf.com>, <radhac@marvell.com>, <vburru@marvell.com>,\n <sedara@marvell.com>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <longli@microsoft.com>, <spinler@cesnet.cz>,\n <chaoyong.he@corigine.com>, <niklas.soderlund@corigine.com>,\n <hemant.agrawal@nxp.com>, <sachin.saxena@oss.nxp.com>,\n <g.singh@nxp.com>, <apeksha.gupta@nxp.com>, <sachin.saxena@nxp.com>,\n <aboyer@pensando.io>, <rmody@marvell.com>, <shshaikh@marvell.com>,\n <dsinghrawat@marvell.com>, <andrew.rybchenko@oktetlabs.ru>,\n <jiawenwu@trustnetic.com>, <jianwang@trustnetic.com>,\n <jbehrens@vmware.com>, <maxime.coquelin@redhat.com>,\n <chenbo.xia@intel.com>, <steven.webster@windriver.com>,\n <matt.peters@windriver.com>, <bruce.richardson@intel.com>,\n <mtetsuyah@gmail.com>, <grive@u256.net>, <jasvinder.singh@intel.com>,\n <cristian.dumitrescu@intel.com>, <jgrajcia@cisco.com>,\n <mb@smartsharesystems.com>, Ankur Dwivedi <adwivedi@marvell.com>", "Subject": "[PATCH v7 0/6] add trace points in ethdev library", "Date": "Mon, 23 Jan 2023 14:32:23 +0530", "Message-ID": "<20230123090229.3392071-1-adwivedi@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230120084059.2926575-1-adwivedi@marvell.com>", "References": "<20230120084059.2926575-1-adwivedi@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "glEVkcyfscw785i1Fyrk7Xm5RlaB0WLD", "X-Proofpoint-ORIG-GUID": "glEVkcyfscw785i1Fyrk7Xm5RlaB0WLD", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1\n definitions=2023-01-23_05,2023-01-20_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This series adds trace points for functions in the ethdev library.\nThe trace points are added in ethdev, flow, mtr and tm files.\n\nv7:\n - Resolves build failure.\n - Changes in rte_trace_point_emit_blob() function in rte_trace_point.h\n and rte_trace_point_register.h.\n\nv6:\n - Resolves compilation error with 32 bit build.\n - Resolves a bug found in v5 in the trace autotest application where\n the traces where not getting generated after the first blob test case.\n The trace size needs to be known at trace point register, so a dynamic\n length array cannot be implemented with current implementation.\n So changing the metadata of blob to make the array as 64 bytes. The\n length will denote the blob length(passed by the application). The\n trailing unused fields will be set to zero if length is less than 64.\n\n For example, the following is the ctf metadata created to display\n a mac addr array in rte_eth_trace_macaddr_get():\n struct {\n ...\n uint8_t len;\n uint8_t mac_addr_addr_bytes[64];\n };\n - Minor changes in the subject of patches (2/6) and (3/6).\n\nv5:\n - The rte_trace_point_emit_char_array function is renamed to \n rte_trace_point_emit_blob. With this function an array of\n any length upto 65535 bytes can be captured.\n For example, the following is the ctf metadata created to display\n a mac addr array in rte_eth_trace_macaddr_get():\n struct {\n ...\n uint16_t len;\n uint8_t mac_addr_addr_bytes[len];\n };\n - Added additional test cases for rte_eal_trace_generic_blob\n test case.\n - Capturing of return value of a function is added to tracepoint \n for flow, mtr and tm patches.\n - In ehdev patch (1/6), removed extra line. Also added rx_pkts and\n tx_pkts pointer in trace point.\n\nv4:\n - Adds tracepoint function to emit char array. Also adds the\n test case.\n - Resolved review comments on \"ethdev: add trace point\" patch.\n This patch is divided into 2 patches to minimize per patch\n size.\n - From the earlier version (v3), few tracepoints in ethdev,\n flow, mtr, tm are made as fast path tracepoints. For the \n tracepoint which i was unsure, i have made it as fastpath.\n All the fast path tracepoints can be found in \n rte_ethdev_trace_fp.h and rte_ethdev_trace_fp_burst.h.\n All the slow path tracepoints can be found in rte_ethdev_trace.h.\n - Capturing of return value is added to tracepoint in ethdev.\n For flow, mtr and tm these changes are still yet to bde done.\n Will do it in the next versions.\n - Moved the trace functions from INTERNAL to EXPERIMENTAL in\n version.map.\n\nv3:\n - Moved the trace functions from EXPERIMENTAL to INTERNAL in\n version.map.\n - Moved trace functions call to the end, in ethdev and flow trace.\n - Added code to print the input value of features in\n rte_eth_trace_rx_metadata_negotiate().\n - Added code to capture return value in flow trace.\n\nAnkur Dwivedi (6):\n eal: trace: add trace point emit for blob\n ethdev: add trace points for ethdev (part one)\n ethdev: add trace points for ethdev (part two)\n ethdev: add trace points for flow\n ethdev: add trace points for mtr\n ethdev: add trace points for tm\n\n app/test/test_trace.c | 11 +\n doc/guides/prog_guide/trace_lib.rst | 12 +\n lib/eal/common/eal_common_trace_points.c | 2 +\n lib/eal/include/rte_eal_trace.h | 6 +\n lib/eal/include/rte_trace_point.h | 31 +\n lib/eal/include/rte_trace_point_register.h | 9 +\n lib/eal/version.map | 3 +\n lib/ethdev/ethdev_private.c | 5 +\n lib/ethdev/ethdev_trace_points.c | 715 ++++++++++\n lib/ethdev/meson.build | 1 +\n lib/ethdev/rte_ethdev.c | 711 ++++++++--\n lib/ethdev/rte_ethdev.h | 2 +-\n lib/ethdev/rte_ethdev_cman.c | 30 +-\n lib/ethdev/rte_ethdev_trace.h | 1450 ++++++++++++++++++++\n lib/ethdev/rte_ethdev_trace_fp.h | 1005 +++++++++++++-\n lib/ethdev/rte_ethdev_trace_fp_burst.h | 44 +\n lib/ethdev/rte_flow.c | 314 ++++-\n lib/ethdev/rte_mtr.c | 156 ++-\n lib/ethdev/rte_tm.c | 247 +++-\n lib/ethdev/version.map | 235 ++++\n 20 files changed, 4753 insertions(+), 236 deletions(-)\n create mode 100644 lib/ethdev/rte_ethdev_trace_fp_burst.h" }