Cover Detail
Show a cover letter.
GET /api/covers/115349/?format=api
{ "id": 115349, "url": "https://patches.dpdk.org/api/covers/115349/?format=api", "web_url": "https://patches.dpdk.org/project/dts/cover/20220823055939.4186198-1-ke1.xu@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20220823055939.4186198-1-ke1.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20220823055939.4186198-1-ke1.xu@intel.com", "date": "2022-08-23T05:59:37", "name": "[V1,0/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance", "submitter": { "id": 2810, "url": "https://patches.dpdk.org/api/people/2810/?format=api", "name": "Ke Xu", "email": "ke1.xu@intel.com" }, "mbox": "https://patches.dpdk.org/project/dts/cover/20220823055939.4186198-1-ke1.xu@intel.com/mbox/", "series": [ { "id": 24388, "url": "https://patches.dpdk.org/api/series/24388/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=24388", "date": "2022-08-23T05:59:37", "name": "tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance", "version": 1, "mbox": "https://patches.dpdk.org/series/24388/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/115349/comments/", "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6185DA04FD;\n\tTue, 23 Aug 2022 08:01:05 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5B901406A2;\n\tTue, 23 Aug 2022 08:01:05 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 826AE400D6\n for <dts@dpdk.org>; Tue, 23 Aug 2022 08:01:03 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Aug 2022 23:01:02 -0700", "from unknown (HELO DPDK-XUKE-LAB.sh.intel.com) ([10.67.116.226])\n by orsmga003.jf.intel.com with ESMTP; 22 Aug 2022 23:01:00 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1661234463; x=1692770463;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=w0vn8rgtkK1oOUTFRdA0NTgTeUbdcKbcgSJCpS2jmq8=;\n b=DsRUUI/fxTaaXnMQ2cSD57vI4mfrsEYg4YajbQibvly2is0f2o1I50gI\n uM51SMv9eSse3oSlEejjHJgODMTHoxZ49cgscFarhqzarlL1TS6aqoqhR\n DDyyTwwEWBZi+QvPv0XJacXi1EOHhnEAvYdBzLacPtgCKt2dGJEM7LIh5\n Azsf4pw15HfhSyW5zWeL0tf/qyowInYD0ENhOaD074KTxaaIXEJLsbq/j\n jQfixAnA8yvNpsST+Wes9lW5+dJ3i+/1lvAt0Ac1Mm9NGOlndBxnkWpdB\n 6Axo+6L7iU9+RWH/WFuK3yGkEe88GOtYC30fCKVGSQywd8k+Q2KgDh6tT Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10447\"; a=\"273985472\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"273985472\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"560034847\"" ], "X-ExtLoop1": "1", "From": "Ke Xu <ke1.xu@intel.com>", "To": "dts@dpdk.org", "Cc": "qi.fu@intel.com,\n\tke1.xu@intel.com", "Subject": "[dts][PATCH V1 0/2] tests/tso: modify get_chksum_value_and_verify to\n fix a checksum-verify error and improve the performance", "Date": "Tue, 23 Aug 2022 05:59:37 +0000", "Message-Id": "<20220823055939.4186198-1-ke1.xu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Function get_chksum_value_and_verify in test suite TSO case test_tso_tunneling \n cannot verify checksum error. Duplicated call to packet.read_pcapfile will\n change the packet sequence stored in packet.pktgen.pkts, leading to a wrongly\n organized packet sequence writen to file, and fails the following checksum\n verifying.\n\nThe wrongly used methods also lead to a low effeciency. Duplicated call to\n packet.read_pcapfile will lengthen the packet sequence stored in\n packet.pktgen.pkts. Duplicated call to packet.save_pcapfile is also time\n consuming.\n\nThere is also a misuse of show method that *.show() will print a packet info,\n but will not return a string. The *.show will return a method object, and the\n following str(out) will turn the method object into a string, so here when use\n out = x.show, checksum looking up in str(out) it is equivalent to that in\n repr(x).\n\nIn the first commit, the checksum verifying problem is fixed.\n\nIn the second commit, this function is improved that the case running time is\n decresed by 2 minutes.\n\nKe Xu (2):\n tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify\n error\n tests/tso: modify get_chksum_value_and_verify to improve the\n performance\n\n tests/TestSuite_tso.py | 26 +++++++++++++++-----------\n 1 file changed, 15 insertions(+), 11 deletions(-)" }