Cover Detail
Show a cover letter.
GET /api/covers/108929/?format=api
https://patches.dpdk.org/api/covers/108929/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/cover/20220328121758.26632-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220328121758.26632-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220328121758.26632-1-david.marchand@redhat.com", "date": "2022-03-28T12:17:53", "name": "[RFC,0/5] vhost lock annotations", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/cover/20220328121758.26632-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 22266, "url": "https://patches.dpdk.org/api/series/22266/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22266", "date": "2022-03-28T12:17:53", "name": "vhost lock annotations", "version": 1, "mbox": "https://patches.dpdk.org/series/22266/mbox/" } ], "comments": "https://patches.dpdk.org/api/covers/108929/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2F656A0501;\n\tMon, 28 Mar 2022 14:18:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C5DAD427EA;\n\tMon, 28 Mar 2022 14:18:14 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 5293E41104\n for <dev@dpdk.org>; Mon, 28 Mar 2022 14:18:13 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-632-MyrQU609N66GYtlqyfOeqw-1; Mon, 28 Mar 2022 08:18:09 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com\n [10.11.54.8])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 469E4811E76;\n Mon, 28 Mar 2022 12:18:09 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.195.27])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8BDB0C15D58;\n Mon, 28 Mar 2022 12:18:06 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1648469892;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=+l1/bnJXFoTriKp5745kk/dpg7pUEsvhBY47ncN9ksg=;\n b=Lgxcnmm7hG3zwghXxrAD8EqHIR63P4FF+oL+xEUNbkNF/qmanspg+myctCxeE5yV0y8J+L\n aJ03EGEXA1Xdvc8cDyQOpAxXTUMBs0rDzwSYQWzAXZoIFOrSd7nhaxoz500sgUm8YEt+lp\n i1ZHeETnAmEW3ZmvP/e76fEji93fMPM=", "X-MC-Unique": "MyrQU609N66GYtlqyfOeqw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Subject": "[RFC PATCH 0/5] vhost lock annotations", "Date": "Mon, 28 Mar 2022 14:17:53 +0200", "Message-Id": "<20220328121758.26632-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.8", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "vhost internals involves multiple locks to protect data access by\nmultiple threads.\n\nThis series is a try at using clang thread safety checks [1] to catch\nissues during compilation: spinlock and rwlock are wrapped into vhost types\nand annotations are put all over the code.\n\n\nPatch 1 is a fix from Maxime that I had to take in the series so\nthat the CI won't fail.\n\nPatch 2 annotates existing manipulations of the access_lock vq lock.\nIt does the minimal stuff, more annotations are used/introduced later\nin the series.\n\nPatch 4 is an example of extending the work by annotating the async field.\nThis patch raised the issues fixed in patch 3.\n\nPatch 5 further extends this by annotating rwlocks used in IOTLB.\nThis raised two suspicious call sites (in vdpa and vhost_crypto code,\nsee added FIXME). Because of a limitation in the check, the IOTLB lock is\nchanged to be always taken. I don't expect a big impact, but this needs a\nconfirmation.\n\n\nThis is still a work in progress.\nThose annotations are quite heavy to maintain because the full path of\ncode must be annotated, but I think it would be worth using.\n\n\n1: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html" }{ "id": 108929, "url": "