From patchwork Tue May 5 19:17:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 69778 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDB91A04A4; Tue, 5 May 2020 21:17:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 351BB1D6C0; Tue, 5 May 2020 21:17:48 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 4C3D61D6C0 for ; Tue, 5 May 2020 21:17:46 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9F76A30C0B4; Tue, 5 May 2020 12:17:14 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 9F76A30C0B4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1588706234; bh=yelA+tRLe+NlcW5e7HMycsK+yfFi3/1go2y8nRArgdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nr5ng+Ypsmr3fyCjmUyMftH8OcLLt7nAgjlU/HFAy3iFl1L1Ue9E2dwrR2Kbm4cOG cOeqbTGUx3vaVyU6I2Y3aNVExva3c5M62tBe/2ZGmi/6fhY+5HO6dPGTfug8IL8Ins 5U2YH5LRiFcyZP7MhVTxpXkTRakue6hINyAEFoZw= Received: from localhost.localdomain (unknown [10.230.26.175]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id AA337140069; Tue, 5 May 2020 12:17:41 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Michael Baucom Date: Tue, 5 May 2020 12:17:37 -0700 Message-Id: <20200505191738.58219-2-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200505191738.58219-1-ajit.khaparde@broadcom.com> References: <20200505191738.58219-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kishore Padmanabha Fix a buffer overrun issue spotted by coverity while accessing the array ulp_device_params. Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init") Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_template_db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db.c b/drivers/net/bnxt/tf_ulp/ulp_template_db.c index 86384169f..e89aefad4 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_template_db.c +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db.c @@ -321,7 +321,7 @@ struct bnxt_ulp_def_ident_info ulp_def_ident_tbl[] = { } }; -struct bnxt_ulp_device_params ulp_device_params[] = { +struct bnxt_ulp_device_params ulp_device_params[BNXT_ULP_DEVICE_ID_LAST] = { [BNXT_ULP_DEVICE_ID_WH_PLUS] = { .global_fid_enable = BNXT_ULP_SYM_YES, .byte_order = (enum bnxt_ulp_byte_order) From patchwork Tue May 5 19:17:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 69779 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A19FA04A4; Tue, 5 May 2020 21:17:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 921041D6D1; Tue, 5 May 2020 21:17:49 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 46B5A1D6B6 for ; Tue, 5 May 2020 21:17:46 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id B6BBC30C0B8; Tue, 5 May 2020 12:17:14 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com B6BBC30C0B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1588706234; bh=aEIcAiaMAlUUwNWA4EJ9DxX0DS2vilmXB415CMuvcL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kkhythWU0A5dlp4gpLPtzSO2TsvzXX0i/qlrEknbN8Jm+iskZVtN+MnkiLRt5w3kK aLFAsA8A8HgbNEhxQDHj3m5PGNKaat2C+ygPJqopri7bMSN2cmR6jCUHrCw0WTfGq+ MudhIqyuYBamBLjUoU99ZLGHUWy0HrZGmBZ/LTbg= Received: from localhost.localdomain (unknown [10.230.26.175]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 1224814008E; Tue, 5 May 2020 12:17:42 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Somnath Kotur , Randy Schacher Date: Tue, 5 May 2020 12:17:38 -0700 Message-Id: <20200505191738.58219-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200505191738.58219-1-ajit.khaparde@broadcom.com> References: <20200505191738.58219-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix uninitialized variable error reported by coverity. Fixes: d33b68154fa4 ("net/bnxt: add tf_core table scope support") Coverity issue: 357771 Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Randy Schacher --- drivers/net/bnxt/tf_core/tf_tbl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c index 93f387e86..d900c9c09 100644 --- a/drivers/net/bnxt/tf_core/tf_tbl.c +++ b/drivers/net/bnxt/tf_core/tf_tbl.c @@ -539,7 +539,7 @@ tf_em_ctx_reg(struct tf *tfp, { struct tf_em_ctx_mem_info *ctxp = &tbl_scope_cb->em_ctx_info[dir]; struct tf_em_table *tbl; - int rc; + int rc = 0; int i; for (i = KEY0_TABLE; i < MAX_TABLE; i++) {