From patchwork Mon Apr 27 09:57:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 69375 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 355AFA00BE; Mon, 27 Apr 2020 11:58:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CAFE1C439; Mon, 27 Apr 2020 11:57:58 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 3A7CA1C437 for ; Mon, 27 Apr 2020 11:57:55 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200427095754euoutp02599c7b053742c288a526cb872d84b22f~JpLzDVRlX1999619996euoutp02C for ; Mon, 27 Apr 2020 09:57:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200427095754euoutp02599c7b053742c288a526cb872d84b22f~JpLzDVRlX1999619996euoutp02C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587981474; bh=6QG3nTWgBM+UdAT06i01J64mPudMRemN0uiP97ewDGU=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=tiAkUmqjtSnHbJIGqjOeByKxMinTGc3+S5uTJeMJfsihUc8arsz0NW3i2N+koVJj4 P9d3DzMVK4qnAQTzU3EEe25sFTqa+Lmcky1IHait8mp09cwlVNFU/YwXQKfcpUPB1m FpqFUHVAKhvyUS07luWfYyKwhH+5/V5RaXcWOOE4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200427095753eucas1p2a4f363e00203fd29dae840fe24030a96~JpLytHq4g3010530105eucas1p2_; Mon, 27 Apr 2020 09:57:53 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id E5.E3.60679.1ACA6AE5; Mon, 27 Apr 2020 10:57:53 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200427095753eucas1p24327f9862457d9f3bc892a60c8645814~JpLyVHf0W2020820208eucas1p2n; Mon, 27 Apr 2020 09:57:53 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200427095753eusmtrp1cd54fc18ba374f98943bae788dce4f9f~JpLyUcc782257022570eusmtrp1i; Mon, 27 Apr 2020 09:57:53 +0000 (GMT) X-AuditID: cbfec7f4-0e5ff7000001ed07-0c-5ea6aca161c3 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 5A.D2.08375.1ACA6AE5; Mon, 27 Apr 2020 10:57:53 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200427095752eusmtip11a4497025d9aaaf5aa7b7d905deb8d5f~JpLx1JwjT1355513555eusmtip1h; Mon, 27 Apr 2020 09:57:52 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 27 Apr 2020 12:57:23 +0300 Message-Id: <20200427095737.11082-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200427095737.11082-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPKsWRmVeSWpSXmKPExsWy7djP87oL1yyLM9jRZGzxYMpdNovtK7rY LN592s5kcWfvaXaLWZea2C0+PTjBYnH65mZ2B3aPXwuWsnos3vOSyePYzWnsHu/3XWXz6Nuy itFj9ZMfbAFsUVw2Kak5mWWpRfp2CVwZT9ovsBS8lKhYfcO7gfGrcBcjB4eEgInE/ANaXYxc HEICKxglrnXcZexi5ARyvjBKbJscD5H4zCjxaO0fJpAESMOBNTdYIRLLGSXm921hhuj4yigx uVMMxGYT0JA43TGPCaRIRGAZo8TxV7/AioQFLCQWrWtmAbFZBFQlfl5fzg5i8wpYSvQfvcAI sUFeYvWGA8wg53EKWEk8+58MYgoJKEt8vpoAUS0ocXLmE7ApzEDVzVtnM4OskhBYxy6xf84c dogxLhLLdkyEGiks8er4Fqi4jMTpyT0sEHa1xPdN19khmjsYJe4taoUqspfY8vocO8hiZgFN ifW79CHCjhJzL75khoQcn8SNt4IQN/BJTNo2HSrMK9HRJgRRrSRx4OQlqLCExN/fPBBhD4mH K5exTWBUnIXkmVlInpmFsHYBI/MqRvHU0uLc9NRio7zUcr3ixNzi0rx0veT83E2MwGRz+t/x LzsYd/1JOsQowMGoxMPLsX1pnBBrYllxZe4hRgkOZiUR3kcZy+KEeFMSK6tSi/Lji0pzUosP MUpzsCiJ8xovehkrJJCeWJKanZpakFoEk2Xi4JRqYOR916s3+0HXKjXVw2UKq1df7778N/Gg HQvPu1X35i483nLn/2zXn11We+rCpqc6tSU3delbztoXd78upWyJvUS3G7tIqNGfvNLUxtn+ 12Yru75/2nn8hnOOeclq1hlsqmGbM5bzfBFzjLx75eoEQY3I30kLe4vVWi4V/hDPiElhjehf tLhATYmlOCPRUIu5qDgRACfAFSoyAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t/xu7oL1yyLMzjdJG3xYMpdNovtK7rY LN592s5kcWfvaXaLWZea2C0+PTjBYnH65mZ2B3aPXwuWsnos3vOSyePYzWnsHu/3XWXz6Nuy itFj9ZMfbAFsUXo2RfmlJakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWp Rfp2CXoZT9ovsBS8lKhYfcO7gfGrcBcjJ4eEgInEgTU3WLsYuTiEBJYySqy7+Im9i5EDKCEh 8foJM0SNsMSfa11sILaQwGdGiXuv2EFsNgENidMd85hAekUE1jFKfJz5BqxBWMBCYtG6ZhYQ m0VAVeLn9eVgDbwClhL9Ry8wQgyVl1i94QAzyC5OASuJZ/+TIeaHS1y88hssLCSgLPH5agJE p6DEyZlPWEDCzALqEuvnCYGEmYGGNG+dzTyBUXAWkqpZCFWzkFQtYGRexSiSWlqcm55bbKhX nJhbXJqXrpecn7uJERhF24793LyD8dLG4EOMAhyMSjy8HNuXxgmxJpYVV+YeYpTgYFYS4X2U sSxOiDclsbIqtSg/vqg0J7X4EKMp0JMTmaVEk/OBEZ5XEm9oamhuYWlobmxubGahJM7bIXAw RkggPbEkNTs1tSC1CKaPiYNTqoExyuFPocmnSbl7lQ+cYO/jPpHieDriI39w5M3yyB1pDeZH 0ksZD6xWzND8P5XfSord3Lqcy0l0phWbuMfJY8l8bMVfb6wWeG0Yn/vryBTv9GVxf9Z4/WBr nrT0+BWtN1ukikLi69KcHKdIJPj8qGD4uPm0bDWHyr4uuyO3v/e1B1z6dHxVwwIlluKMREMt 5qLiRAD7h4D1uAIAAA== X-CMS-MailID: 20200427095753eucas1p24327f9862457d9f3bc892a60c8645814 X-Msg-Generator: CA X-RootMTR: 20200427095753eucas1p24327f9862457d9f3bc892a60c8645814 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200427095753eucas1p24327f9862457d9f3bc892a60c8645814 References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v1 1/6] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 4816966.qqrk5fENW1@thomas.org List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link informations, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 0f6d0530d..2f94a09d4 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -301,6 +301,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_50G 50000 /**< 50 Gbps */ #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2260,15 +2261,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link informations written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2277,15 +2279,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link informations written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Mon Apr 27 09:57:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 69376 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C98DA00BE; Mon, 27 Apr 2020 11:58:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3F4D1D146; Mon, 27 Apr 2020 11:57:59 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 04EA41C437 for ; Mon, 27 Apr 2020 11:57:56 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200427095755euoutp0163230a5a8c6dac07a0c8d21218bfadfd~JpL0eXwkF2146921469euoutp018 for ; Mon, 27 Apr 2020 09:57:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200427095755euoutp0163230a5a8c6dac07a0c8d21218bfadfd~JpL0eXwkF2146921469euoutp018 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587981475; bh=l0UqQNYOimhXpsqdExA0ttkj8rMw40IIUs3Vkj8BSbk=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=caCeZ1C5f2hYBnGZY6T2ul/jBUpjg+Ew+R7Woqqol3uk1LoIP4Ifci+oo+xOw3DwF mvve7le/mFuEBx0QpwD7+8Yq+253A7aKuUZQqRlUNR/hVQFwRqTP4s3W4GKJ49Kcrn QXirg0PPrPQi6G8F3fwICahcK7g2Twro1vhgPVFw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200427095755eucas1p177425551b55fff34961acd4ce6a0845f~JpL0F1ZtM1937119371eucas1p1a; Mon, 27 Apr 2020 09:57:55 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 24.B8.60698.3ACA6AE5; Mon, 27 Apr 2020 10:57:55 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200427095754eucas1p2fb7a4e57cfa9006aebdd0e7a5d4d5e58~JpLzuf3021607716077eucas1p2q; Mon, 27 Apr 2020 09:57:54 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200427095754eusmtrp1086d0a0dc52a6d923b5acf1f851bcbaa~JpLzt6Q0Z2279822798eusmtrp1C; Mon, 27 Apr 2020 09:57:54 +0000 (GMT) X-AuditID: cbfec7f5-a0fff7000001ed1a-94-5ea6aca3145b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AB.D2.08375.2ACA6AE5; Mon, 27 Apr 2020 10:57:54 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200427095754eusmtip123762c4902241c11b3888baf6a0c426e~JpLzM5VSH1184111841eusmtip1x; Mon, 27 Apr 2020 09:57:54 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 27 Apr 2020 12:57:24 +0300 Message-Id: <20200427095737.11082-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200427095737.11082-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUhTURzGOXu597pcXq/C/pllLQSVfCn7MKPSIHBJSPQxSF16UclN2fUl rWAV1hxaVr6EtJqKJi4yljqTOWSSs2ZChqhR4nu+lJY6ZjM1t7vo2+8853nOc/6HQ3CpTV4A kanIpZUKWZYYE/Dae38PhNe/aEyKcmgoyXjFV0xibNJgkqUVI0fypcuGS2oGb+GSlfE+nsQ2 +hqPw6VOXQNfWm+a50h7R6tw6bJ5CJPea21GUv30OnYeuyg4kUZnZebTyshTKYKMrWcbKGeC d3Wo5gOuQiNcDfIigDwG5rvLSIMEBEU2IZh834WxizUExavTyOWiyFUExo/7NYhwJ/Rj4azn OYJt+xMO67EjuD+1z8UYGQI29VOOy+RPNiKwLjjddX5kArTMlLmZRwZDWaXVHRaSMWA0dSH2 SkGgf9XNdZV5kcdhdjvVhRR5CFaHUlxHAunAYLH2pWeCM2Cat/NZ9oMFayvOciDYHpXyWL4G DsMwzobVCMbqij2mWGhdHMBdBVwyFFo6I1n5NFRUmHF23t0w8sPXJXN38GF7NZeVhaC+Q7Fu MXS/G/TIAJsb3qwshb65Lc9r6hFsTN/kl6Ogmv9dOoSakYjOY+TpNBOtoAsiGJmcyVOkR6Rm yw1o51PYtqz2DmT+c9mCSAKJvYWEsSGJ4svymUK5BQHBFfsLJzMakyhhmqywiFZmJyvzsmjG gvYSPLFIGF03f4ki02W59BWazqGV/3Y5hFeACmnFu4pNxHDHYmXwA9UbIre2TNk2E9xfcK7T xykSVqt/9h+8Pfm9JD7uZOnZoqOakF7dxCendpZTJEk0jD/+tWfJceBCQGG5KjH8W8pyjyNZ eyO2zlcXkzPnp9UzyQZl/3rPdUzTORUYW5WgOdwQOuFTWmIJS40XfW5bg4G3UWIekyE7EsZV MrK/9BqfURADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsVy+t/xu7qL1iyLM9i20sriwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstS i/TtEvQy/s3/zVjwkKXi6qyz7A2MN5i7GDk4JARMJFbf0+1i5OIQEljKKPGm+RlUXELi9RMg kxPIFJb4c62LDaLmM6PE9Rf32UASbAIaEqc75jGBJEQE1jFKfJz5BqxDWMBLYv3TXjCbRUBV onfqcSYQm1fAUmL7nr2MEFPlJVZvOAC2jFPASuLZ/2SQsJBAuMTFK7/BwkICyhKfryZMYORb wMiwilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzB0tx37uXkH46WNwYcYBTgYlXh4ObYvjRNi TSwrrsw9xCjBwawkwvsoY1mcEG9KYmVValF+fFFpTmrxIUZToPMmMkuJJucD4yqvJN7Q1NDc wtLQ3Njc2MxCSZy3Q+BgjJBAemJJanZqakFqEUwfEwenVANj0O2SH6XsX7pYWQwLXK90P1Po y3m+1cdSoqLnFLdEbMc7zqUBykEfvdvcry16c7jG23b61kYdfoXY5RumHHm7hte28Mq27R9N RUpqJ1ee5m1nXBhqm17CXJxgkJUpuXEeH7OxaqeeSqJckFPINtG1Z922rmg8zsrwg2fyOva/ H/qnGT1YulKJpTgj0VCLuag4EQCFcQ/KcwIAAA== X-CMS-MailID: 20200427095754eucas1p2fb7a4e57cfa9006aebdd0e7a5d4d5e58 X-Msg-Generator: CA X-RootMTR: 20200427095754eucas1p2fb7a4e57cfa9006aebdd0e7a5d4d5e58 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200427095754eucas1p2fb7a4e57cfa9006aebdd0e7a5d4d5e58 References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v1 2/6] app/procinfo: fix printf format specifier for uint X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 4816966.qqrk5fENW1@thomas.org List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..b1a025a36 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -685,7 +685,7 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," + printf("\t -- link speed %u duplex %d," " auto neg %d status %d\n", link.link_speed, link.link_duplex, From patchwork Mon Apr 27 09:57:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 69377 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B2BDA00BE; Mon, 27 Apr 2020 11:58:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACA911D14A; Mon, 27 Apr 2020 11:58:02 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E339D1C214 for ; Mon, 27 Apr 2020 11:57:57 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200427095757euoutp01b3d1cc1881ad3e934f1d28e18e609ac1~JpL1sL--s2146821468euoutp01I for ; Mon, 27 Apr 2020 09:57:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200427095757euoutp01b3d1cc1881ad3e934f1d28e18e609ac1~JpL1sL--s2146821468euoutp01I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587981477; bh=ZGoFlO2KRKyDlr5e/G863Cd5W5vwoSYGu6qYAPXw56E=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=XxsOfnsfCfjfaZiq7jfFKkdy68m1VbG4wtKMTVj7jzUxrym9ub9mtGMoAO7dinlYb W8noceG8wcGotue8OjRhO0Z0ebvZ4Coe74RQV9nA7sVzohl4/TfyeWX1RPURMOq/qU GS0UunVmIKcJJw6FoNiP3HWs3RuQtpxfz5Uj7lsM= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200427095756eucas1p28544693476804e086f0cdf4941c4d556~JpL1iJ4P61047110471eucas1p2V; Mon, 27 Apr 2020 09:57:56 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 76.B8.60698.4ACA6AE5; Mon, 27 Apr 2020 10:57:56 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200427095756eucas1p208ef420a6cb9b3f3fc6b7ce09210c973~JpL1GcXIh1047910479eucas1p2L; Mon, 27 Apr 2020 09:57:56 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200427095756eusmtrp17ed371b9810c8e01b48fefcbc1e7188f~JpL1F39RS2270622706eusmtrp16; Mon, 27 Apr 2020 09:57:56 +0000 (GMT) X-AuditID: cbfec7f5-a0fff7000001ed1a-9c-5ea6aca46f7c Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id ED.D2.08375.4ACA6AE5; Mon, 27 Apr 2020 10:57:56 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200427095755eusmtip19721ca05b94d1ae82f5cbf4bf405b2b4~JpL0j3xrV1184111841eusmtip1y; Mon, 27 Apr 2020 09:57:55 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 27 Apr 2020 12:57:25 +0300 Message-Id: <20200427095737.11082-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200427095737.11082-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsWy7djP87pL1iyLM2j+bmjxYMpdNovtK7rY LN592s5kcWfvaXaLWZea2C0+PTjBYnH65mZ2B3aPXwuWsnos3vOSyePYzWnsHu/3XWXz6Nuy itFj9ZMfbAFsUVw2Kak5mWWpRfp2CVwZvZtamQtec1aceeTUwPiNvYuRg0NCwETi4zbvLkYu DiGBFYwSN241MUE4Xxgl7t3qZYZwPjNKXPjTC5ThBOs4f6GDDSKxnFFiwcZpLBDOV0aJP2f+ MYJUsQloSJzumAc2S0RgGaPE8Ve/mEESwgKOEj2vz7OALGcRUJV4O00AxOQVsJQ49TkZYoG8 xOoNB5hBwpwCVhLP/ieDmEICyhKfryaADJQQ+MwmcfXjKnaIcheJjpXPoGxhiVfHt0DZMhKn J/ewQNjVEt83XWeHaO4A+mxRK1SRvcSW1+fAQcEsoCmxfpc+RNhR4v3DFhZICPFJ3HgrCBJm BjInbZvODBHmlehoE4KoVpI4cPISVFhC4u9vHoiwh8SFKatZIWGzmlFi6fXtTBMY5Wch7FrA yLiKUTy1tDg3PbXYOC+1XK84Mbe4NC9dLzk/dxMjME2c/nf86w7GfX+SDjEKcDAq8fBybF8a J8SaWFZcmXuIUYKDWUmE91HGsjgh3pTEyqrUovz4otKc1OJDjNIcLErivMaLXsYKCaQnlqRm p6YWpBbBZJk4OKUaGAND5cvm5V0VuOWq+3vpGeYvjXGZPqd6OWWaBS12q/PuFWy3LLq67aw3 d+LDY0cEUwqNzSVCOa9OVGMT8Xe3uVzh8e+rqErRnoAN5zp8Pt1ak/pgDpfg3DdX+Fcl7Ej/ UrN6pYvpU6O51bcChVoDtv5ncL64rb6h4uWcfsWrzwXj1IzOzTf5ocRSnJFoqMVcVJwIAIur I1sPAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t/xu7pL1iyLM5jQI2nxYMpdNovtK7rY LN592s5kcWfvaXaLWZea2C0+PTjBYnH65mZ2B3aPXwuWsnos3vOSyePYzWnsHu/3XWXz6Nuy itFj9ZMfbAFsUXo2RfmlJakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWp Rfp2CXoZvZtamQtec1aceeTUwPiNvYuRk0NCwETi/IUOti5GLg4hgaWMEo/75wI5HEAJCYnX T5ghaoQl/lzrgqr5zCjxp/U9E0iCTUBD4nTHPCaQhIjAOkaJjzPfgHUICzhK9Lw+zwIyiEVA VeLtNAEQk1fAUuLU52SImfISqzccYAYJcwpYSTz7DxYWEgiXuHjlN1hYSEBZ4vPVhAmMfAsY GVYxiqSWFuem5xYb6hUn5haX5qXrJefnbmIEhu22Yz8372C8tDH4EKMAB6MSDy/H9qVxQqyJ ZcWVuYcYJTiYlUR4H2UsixPiTUmsrEotyo8vKs1JLT7EaAp03ERmKdHkfGBM5ZXEG5oamltY GpobmxubWSiJ83YIHIwREkhPLEnNTk0tSC2C6WPi4JRqYAx1SShykduhPklBpLhB/o73+1gN /pUnTTT4VHc073pYlNRdftg4WkDtyLsViQYFCoff/hA0EUtTUExdUj39ukKhuN60RwXTiyQS 9D8sPKhy7uCy+sbFl1qfK6jPTMtP/yu75/CnhQnzJn6KUXRt0yy49SzEa/2ehAkC77ZM8avJ F/xzx0hTT4mlOCPRUIu5qDgRAGnOGgZxAgAA X-CMS-MailID: 20200427095756eucas1p208ef420a6cb9b3f3fc6b7ce09210c973 X-Msg-Generator: CA X-RootMTR: 20200427095756eucas1p208ef420a6cb9b3f3fc6b7ce09210c973 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200427095756eucas1p208ef420a6cb9b3f3fc6b7ce09210c973 References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v1 3/6] ethdev: remove extra 'new line' in output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 4816966.qqrk5fENW1@thomas.org List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Ivan Dyukov Acked-by: Andrew Rybchenko --- app/test-pmd/testpmd.c | 2 +- app/test/test_pmd_perf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 99bacddbf..d4df23a93 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3005,7 +3005,7 @@ check_all_ports_link_status(uint32_t port_mask) "Port%d Link Up. speed %u Mbps- %s\n", portid, link.link_speed, (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex\n")); + ("full-duplex") : ("half-duplex")); else printf("Port %d Link Down\n", portid); continue; diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index d61be58bb..352cd4715 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -151,7 +151,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) "Port%d Link Up. Speed %u Mbps - %s\n", portid, link.link_speed, (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex\n")); + ("full-duplex") : ("half-duplex")); if (link_mbps == 0) link_mbps = link.link_speed; } else From patchwork Mon Apr 27 09:57:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 69378 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DC7FA00BE; Mon, 27 Apr 2020 11:58:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 242991D154; Mon, 27 Apr 2020 11:58:11 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 813761C43C for ; Mon, 27 Apr 2020 11:57:58 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200427095758euoutp012f81d35c526fd6e74a1a706ed885b9f4~JpL22380d2146821468euoutp01J for ; Mon, 27 Apr 2020 09:57:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200427095758euoutp012f81d35c526fd6e74a1a706ed885b9f4~JpL22380d2146821468euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587981478; bh=zT5qY4BY9j+9Y3BeMHnwJNGNq9T9sltZCrlGFrgOmlo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=D0+G63FJuCtc82aRYNPvIRBnlO8wk77VJ4ntVwwgNRp/q320ZJBdy4fRSuL5r2qpj D+/UgBFyqWvyTfquD9G1PYUJh1Gvm7W+zki6l+CqkokZRw/rEOoZDOSKxo5XG4gnQv IzFPcFTV9JwnpRRXCsWA0hDFPDkWxc921mqdBei8= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200427095758eucas1p29eecf1b54b9c9912634a83a63e8f9472~JpL2qHQFG3009630096eucas1p2C; Mon, 27 Apr 2020 09:57:58 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 69.E3.60679.6ACA6AE5; Mon, 27 Apr 2020 10:57:58 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200427095757eucas1p272442bb5f00d143ef6498bf3c264fcf4~JpL2aV4Gi3009630096eucas1p2B; Mon, 27 Apr 2020 09:57:57 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200427095757eusmtrp1a0c3aafe0aa077828a24314b9749abd7~JpL2Z0ynd2279822798eusmtrp1N; Mon, 27 Apr 2020 09:57:57 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-1f-5ea6aca6b4ff Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id BF.9F.07950.5ACA6AE5; Mon, 27 Apr 2020 10:57:57 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200427095757eusmtip19bbc5880252e063710331a2bb315bfde~JpL137DM91789417894eusmtip1Q; Mon, 27 Apr 2020 09:57:57 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 27 Apr 2020 12:57:26 +0300 Message-Id: <20200427095737.11082-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200427095737.11082-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLIsWRmVeSWpSXmKPExsWy7djPc7rL1iyLM1i1icXiwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYorhsUlJzMstSi/TtErgytrzpYS14ylFx7NgZpgbGjexdjJwcEgImEs27HgHZ XBxCAisYJV6s3wnlfGGUONR6nQ3C+cwo0fH2MStMy71H05ggEssZJX7e/A/V8pVR4n/jfTaQ KjYBDYnTHfPAqkQEljFKHH/1ixkkISzgJPFjyQPGLkYODhYBVYl5d91ATF4BS4k/j/whFshL rN5wgBkkzClgJfHsfzKIKSSgLPH5agJExW82ic2H6yBsF4nW/Z1Q3whLvDq+BcqWkTg9uYcF wq6W+L7pOtiVEgIdjBL3FrVCFdlLbHl9jh1kPrOApsT6XfoQYUeJn1uPM4GEJQT4JG68FQQJ MwOZk7ZNZ4YI80p0tAlBVCtJHDh5CSosIfH3Nw9E2EPi4JRd0HBazSjxaX0b0wRG+VkIuxYw Mq5iFE8tLc5NTy02ykst1ytOzC0uzUvXS87P3cQITBSn/x3/soNx15+kQ4wCHIxKPLwc25fG CbEmlhVX5h5ilOBgVhLhfZSxLE6INyWxsiq1KD++qDQntfgQozQHi5I4r/Gil7FCAumJJanZ qakFqUUwWSYOTqkGxj7xE7aPj2rHJ8y6JGXepm2u+UDvumTglzvHZ+4LrtXbk6D/N9s9pvYV i4m6Rcj/5hVXl+xSfbZY0p+j0rX7z4ugM66Wb9/o7FFxXqNo012rK3vGcEFc63az8EoO/1gl 9jYhQbXYON+Kc2zRts6Ssw51scjwFLSLC5rvnrflziKnjkT38HtKLMUZiYZazEXFiQArydUq EAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t/xu7pL1yyLM1g51cjiwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstS i/TtEvQytrzpYS14ylFx7NgZpgbGjexdjJwcEgImEvceTWPqYuTiEBJYyihx4tkfxi5GDqCE hMTrJ8wQNcISf651sUHUfGaUaN+xhAkkwSagIXG6Yx5Ys4jAOkaJjzPfgHUICzhJ/FjyAGwQ i4CqxLy7biAmr4ClxJ9H/hAz5SVWbzjADBLmFLCSePY/GSQsJBAucfHKb7CwkICyxOerCRMY +RYwMqxiFEktLc5Nzy020itOzC0uzUvXS87P3cQIDNxtx35u2cHY9S74EKMAB6MSDy/H9qVx QqyJZcWVuYcYJTiYlUR4H2UsixPiTUmsrEotyo8vKs1JLT7EaAp03ERmKdHkfGBU5ZXEG5oa mltYGpobmxubWSiJ83YIHIwREkhPLEnNTk0tSC2C6WPi4JRqYAy4suVFj7qvx+aAdxfZwoP+ aN753HZBI8rv4v5ph/LWXl+gbuN084zGlyt/rirzXvXoC+aoLWDdt/2p7LcdlouXJS/9k33K eLXR2X/awbaCJ/ap/oyS6TL7dOFu5l/l+Ttunfil/fu/wPWDs+avnip7JkFcwGlhU+YE3n1T biRwBkvXl67fzVSuxFKckWioxVxUnAgAK0ZuC3ICAAA= X-CMS-MailID: 20200427095757eucas1p272442bb5f00d143ef6498bf3c264fcf4 X-Msg-Generator: CA X-RootMTR: 20200427095757eucas1p272442bb5f00d143ef6498bf3c264fcf4 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200427095757eucas1p272442bb5f00d143ef6498bf3c264fcf4 References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v1 4/6] app/testpmd: remove extra type conversions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 4816966.qqrk5fENW1@thomas.org List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" link_speed is uint32_t. There are no needs to convert it. Signed-off-by: Ivan Dyukov --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 72f25d152..661297ddd 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -577,7 +577,7 @@ port_infos_display(portid_t port_id) printf("\nmemory allocation on the socket: %u",port->socket_id); printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); + printf("Link speed: %u Mbps\n", link.link_speed); printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); @@ -727,7 +727,7 @@ port_summary_display(portid_t port_id) mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + link.link_speed); } void From patchwork Mon Apr 27 09:57:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 69379 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC776A00BE; Mon, 27 Apr 2020 11:58:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A1B61D15A; Mon, 27 Apr 2020 11:58:12 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5953A1D149 for ; Mon, 27 Apr 2020 11:58:00 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200427095800euoutp0116cd35a1354f904d7ee56a94e6b1dc6e~JpL4iNuk32278222782euoutp01E for ; Mon, 27 Apr 2020 09:58:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200427095800euoutp0116cd35a1354f904d7ee56a94e6b1dc6e~JpL4iNuk32278222782euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587981480; bh=24vhzuYrFyoFTzA7/ptzh82/T81JJiCQy0buwIrHJao=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=pSA832JcCFuN8OCHOfmuJWzLlGPH4se78Qqrx5t/U4xC8/l5KGkpZyMI5f6U0yooT uO3g4BmOh0sPJZEt/TE+XlZomoZYSQIX3XSPCwxENNPun2bj78R3UiBl+I7ed91Q8l ffpTq7LIulVUUYWaQWKLNFc15Ri112YZzApMwtik= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200427095759eucas1p1bd5de413dbf0cc96727b7439613306d8~JpL4DFIDf3113231132eucas1p1p; Mon, 27 Apr 2020 09:57:59 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id D8.B8.60698.7ACA6AE5; Mon, 27 Apr 2020 10:57:59 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200427095759eucas1p146d501188af3d1215707e664672076bf~JpL3wdSXz2367923679eucas1p1H; Mon, 27 Apr 2020 09:57:59 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200427095759eusmtrp1a874e04d135a5a4c5f822d63e76eff62~JpL3vmd0v2282722827eusmtrp1B; Mon, 27 Apr 2020 09:57:59 +0000 (GMT) X-AuditID: cbfec7f5-a29ff7000001ed1a-a9-5ea6aca7926c Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 31.AF.07950.7ACA6AE5; Mon, 27 Apr 2020 10:57:59 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200427095758eusmtip13146ef0e97362d0a581d46caa40cc53c~JpL3PXU021820118201eusmtip1C; Mon, 27 Apr 2020 09:57:58 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 27 Apr 2020 12:57:27 +0300 Message-Id: <20200427095737.11082-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200427095737.11082-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsWy7djP87rL1yyLM+j6oGzxYMpdNovtK7rY LN592s5kcWfvaXaLWZea2C0+PTjBYnH65mZ2B3aPXwuWsnos3vOSyePYzWnsHu/3XWXz6Nuy itFj9ZMfbAFsUVw2Kak5mWWpRfp2CVwZq049Yit4zVHR8vcyYwPja7YuRk4OCQETib5vM4Bs Lg4hgRWMEntmTGSCcL4wSnxfeRLK+cwosf7BAmaYltOvu6ASyxklLq14B9X/lVFi3YPZYFVs AhoSpzvmgVWJCCxjlDj+6hdYQljAUWLyzv9g21kEVCXuzt0LFucVsJQ4cvAl1FXyEqs3HACK c3BwClhJPPufDGIKCShLfL6aADJSQuA3m8Svw4+gLnKRePz6FROELSzx6vgWdghbRuL05B4W CLta4vum6+wQzR2MEvcWtUIV2UtseX2OHWQBs4CmxPpd+hBhR4mfLdfAwhICfBI33gqChJmB zEnbpjNDhHklOtqEIKqVJA6cvAQVlpD4+5sHIuwh8fPqdbAjhQRWM0r8/Ws0gVF+FsKqBYyM qxjFU0uLc9NTi43zUsv1ihNzi0vz0vWS83M3MQKTxel/x7/uYNz3J+kQowAHoxIPL8f2pXFC rIllxZW5hxglOJiVRHgfZSyLE+JNSaysSi3Kjy8qzUktPsQozcGiJM5rvOhlrJBAemJJanZq akFqEUyWiYNTqoFxV4iH0Kv+/zcdF2xSl/daMX3yZMMu56Rfh2Z5xxw375908fG5U6sr117+ pOA4ZVr3rU3vknYriJeyyYXdvLKvJSXHJ0xKXWSpyDTRZ/Nq3wgv/MawWOm4ZtirHS1B8omq /4z0HwUfFitvf5Get3j9+fbbM2JSOLaLibysDzPe7PLitqpxj8ExJZbijERDLeai4kQAczF8 gxIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t/xu7rL1yyLM1hyQdDiwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstS i/TtEvQyVp16xFbwmqOi5e9lxgbG12xdjJwcEgImEqdfdzF1MXJxCAksZZR4dfk4SxcjB1BC QuL1E2aIGmGJP9e62CBqPjNKfF66mh0kwSagIXG6Yx5Ys4jAOkaJjzPfgHUICzhKTN75H2wD i4CqxN25e8HivAKWEkcOvoTaLC+xesMBZpBlnAJWEs/+J4OEhQTCJS5e+Q0WFhJQlvh8NWEC I98CRoZVjCKppcW56bnFRnrFibnFpXnpesn5uZsYgcG77djPLTsYu94FH2IU4GBU4uHl2L40 Tog1say4MvcQowQHs5II76OMZXFCvCmJlVWpRfnxRaU5qcWHGE2BzpvILCWanA+MrLySeENT Q3MLS0NzY3NjMwslcd4OgYMxQgLpiSWp2ampBalFMH1MHJxSDYx2WTyvGNqX3z686+MbxmcH WPYsOun9JOfy5ts38ty+aPzOUbl0Wd3c6bWR2UepyE3v+92m7uv8p35eaUOEsI/bpLIcT2WV zh0P7nIf/c9Yf3BRdbD7m93aZ9p+L3OtkT3pxLR5zcHAC4Lvbnmq8Pi9vT8tdHJg/sygyfG3 LHYllNssiVL4cuGSEktxRqKhFnNRcSIAmWeAFHQCAAA= X-CMS-MailID: 20200427095759eucas1p146d501188af3d1215707e664672076bf X-Msg-Generator: CA X-RootMTR: 20200427095759eucas1p146d501188af3d1215707e664672076bf X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200427095759eucas1p146d501188af3d1215707e664672076bf References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v1 5/6] doc: update sample app with unknown speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 4816966.qqrk5fENW1@thomas.org List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Ivan Dyukov --- doc/guides/sample_app_ug/link_status_intr.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 5283be8b7..6ebc707b7 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -177,7 +177,8 @@ An example callback function that has been written as indicated below. printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, + printf("Port %d Link Up - speed %u%s - %s\n\n", port_id, (unsigned)link.link_speed, + (link.link_speed == UINT32_MAX) ? ("(UNKNOWN)") : (" Mbps"), (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); } else printf("Port %d Link Down\n\n", port_id); From patchwork Mon Apr 27 09:57:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 69380 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83325A00BE; Mon, 27 Apr 2020 11:58:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECF461D160; Mon, 27 Apr 2020 11:58:13 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 6237F1D14A for ; Mon, 27 Apr 2020 11:58:01 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200427095801euoutp012329dc4b14a72b47c9b5730c6ff7ebb1~JpL5gJYGc2274222742euoutp01L for ; Mon, 27 Apr 2020 09:58:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200427095801euoutp012329dc4b14a72b47c9b5730c6ff7ebb1~JpL5gJYGc2274222742euoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587981481; bh=XnHqu+IdM/7bZbkoAb33eDgSbMCwNbJNnFgWiM2eKm0=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=BWM0cDdeGMLeLAzaiSm/N0cvIvx1OUWQGMX76638pu1x+sdGt4zQnUCA0o9ywKfJI bQ8wQ8p9/NgRYI9pdlzvFyOGgkC3OJO1vBzXYsRBP1f+7Nq4vUFdXkRgxaMoYoH+e5 dpAtfJULPLVxzUfkG40eb4OYTGqFIriRsvZz4w8o= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200427095800eucas1p237dfffd010b0c0c319274af7bc15b561~JpL5SBYL30741307413eucas1p2E; Mon, 27 Apr 2020 09:58:00 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 1D.E3.60679.8ACA6AE5; Mon, 27 Apr 2020 10:58:00 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200427095800eucas1p16c30ec18649efe66b831728fe661703f~JpL5DWyzF3112831128eucas1p1R; Mon, 27 Apr 2020 09:58:00 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200427095800eusmtrp11d4d58f403ceb49099b5d966bf29bfb7~JpL5CvdSN2270622706eusmtrp1N; Mon, 27 Apr 2020 09:58:00 +0000 (GMT) X-AuditID: cbfec7f4-0e5ff7000001ed07-2e-5ea6aca85f12 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B2.AF.07950.8ACA6AE5; Mon, 27 Apr 2020 10:58:00 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200427095800eusmtip19013d37ed95f3da1f93db71ba12fc8f6~JpL4kKYLN1184111841eusmtip13; Mon, 27 Apr 2020 09:58:00 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 27 Apr 2020 12:57:28 +0300 Message-Id: <20200427095737.11082-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200427095737.11082-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsWy7djPc7or1iyLM3i0zsLiwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYorhsUlJzMstSi/TtErgyJj6ULtilUjHv5WTWBsYe2S5GTg4JAROJq7fPMXcx cnEICaxglFi5fhaU84VR4unc9UwQzmdGiSVdt9lhWhomr2CBSCxnlFjwcTojhPOVUeLMsiks IFVsAhoSpzvmgbWLCCxjlDj+6hczSEJYwF6ib8VKRhCbRUBVomttAxOIzStgKTGrYTkbxAp5 idUbDgDVc3BwClhJPPufDGIKCShLfL6aAFHxnU2i+7g9hO0iMev1VEYIW1ji1fEtUIfKSJye 3MMCYVdLfN90nR3kHAmBDkaJe4taoYrsJba8PscOMp9ZQFNi/S59EFNCwFFi0TVXCJNP4sZb QZBiZiBz0rbpzBBhXomONiGIGUoSB05eggpLSPz9zQMR9pC4fnIL2NdCAqsZJb6vl53AKD8L YdMCRsZVjOKppcW56anFRnmp5XrFibnFpXnpesn5uZsYgWni9L/jX3Yw7vqTdIhRgINRiYeX Y/vSOCHWxLLiytxDjBIczEoivI8ylsUJ8aYkVlalFuXHF5XmpBYfYpTmYFES5zVe9DJWSCA9 sSQ1OzW1ILUIJsvEwSnVwBj6X63RMvTBSZPTt7Y8fP8m6vEVdVOlOctdr5THOmr3R+Q2RXFv Y/ra9rGe3e7Mk5YXiyZxaEnMOG9lv+dBUG//Kc9zTW2bFXWqFvPO+5Z9ZkLbU+tPos/bSuUX t/w+VXRkr03Vub6zhWGFIZrcIte51uzpzOE96nhoW5d8/4esn5dOLDB+qqrEUpyRaKjFXFSc CACfCnvDDwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsVy+t/xu7or1iyLM/i4UtPiwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstS i/TtEvQyJj6ULtilUjHv5WTWBsYe2S5GTg4JAROJhskrWLoYuTiEBJYySixacAvI4QBKSEi8 fsIMUSMs8edaFxtEzWdGiX/7VjKCJNgENCROd8xjAkmICKxjlPg48w1Yh7CAvUTfCogiFgFV ia61DUwgNq+ApcSshuVsEFPlJVZvOMAMsoxTwEri2f9kkLCQQLjExSu/wcJCAsoSn68mTGDk W8DIsIpRJLW0ODc9t9hIrzgxt7g0L10vOT93EyMwdLcd+7llB2PXu+BDjAIcjEo8vBzbl8YJ sSaWFVfmHmKU4GBWEuF9lLEsTog3JbGyKrUoP76oNCe1+BCjKdB5E5mlRJPzgXGVVxJvaGpo bmFpaG5sbmxmoSTO2yFwMEZIID2xJDU7NbUgtQimj4mDU6qB0ZFR+HbP9Cmz9vw5s/xqqpHu 5fO6/z0el5su/X7tot6xgPUzbf7xlIpWNtw8ouOT42SjpirVPzPyxpdzETUZlnVnnycw3pQu Md9sxs8u3i9zPOT/wbc2VhHz9n7xb28PtZqm8Yrhjxmrdpi6vs6ShxvjL2yKLj1wncfk0/bs FX6xOw/9qAzqVWIpzkg01GIuKk4EAJhr6d9zAgAA X-CMS-MailID: 20200427095800eucas1p16c30ec18649efe66b831728fe661703f X-Msg-Generator: CA X-RootMTR: 20200427095800eucas1p16c30ec18649efe66b831728fe661703f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200427095800eucas1p16c30ec18649efe66b831728fe661703f References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v1 6/6] ethdev: UNKNOWN link speed print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 4816966.qqrk5fENW1@thomas.org List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 7 ++++++- app/test-pipeline/init.c | 14 ++++++++------ app/test-pmd/config.c | 10 ++++++---- app/test-pmd/testpmd.c | 4 +++- app/test/test_pmd_perf.c | 4 +++- 5 files changed, 26 insertions(+), 13 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index b1a025a36..27065a231 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -685,10 +685,15 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %u duplex %d," + printf("\t -- link speed %u%s duplex %d%s," " auto neg %d status %d\n", link.link_speed, + (link.link_speed == UINT32_MAX) ? + ("(UNKNOWN)") : (" Mbps"), link.link_duplex, + (link.link_duplex == + ETH_LINK_FULL_DUPLEX) ? + ("(full)") : ("(half)"), link.link_autoneg, link.link_status); } diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..09b762a4e 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -173,12 +173,14 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", - port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + if (link.link_speed == UINT32_MAX) + RTE_LOG(INFO, USER1, "Port %u (UNKNOWN Gbps) %s\n", + port, link.link_status ? "UP" : "DOWN"); + else + RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + port, + link.link_speed / 1000, + link.link_status ? "UP" : "DOWN"); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 661297ddd..96e668ae5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -577,7 +577,8 @@ port_infos_display(portid_t port_id) printf("\nmemory allocation on the socket: %u",port->socket_id); printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", link.link_speed); + printf("Link speed: %u%s\n", link.link_speed, + (link.link_speed == UINT32_MAX) ? ("(UNKNOWN)") : (" Mbps")); printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); @@ -722,12 +723,13 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %u%s\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - link.link_speed); + link.link_speed, + (link.link_speed == UINT32_MAX) ? ("(UNKNOWN)") : (" Mbps")); } void @@ -3787,7 +3789,7 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != UINT32_MAX && rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index d4df23a93..9b47886f7 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3002,8 +3002,10 @@ check_all_ports_link_status(uint32_t port_mask) if (print_flag == 1) { if (link.link_status) printf( - "Port%d Link Up. speed %u Mbps- %s\n", + "Port%d Link Up. speed %u%s- %s\n", portid, link.link_speed, + (link.link_speed == UINT32_MAX) ? + ("(UNKNOWN)") : (" Mbps"), (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); else diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..c8124676d 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -148,8 +148,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) if (print_flag == 1) { if (link.link_status) { printf( - "Port%d Link Up. Speed %u Mbps - %s\n", + "Port%d Link Up. Speed %u%s - %s\n", portid, link.link_speed, + (link.link_speed == UINT32_MAX) ? + ("(UNKNOWN)") : (" Mbps"), (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); if (link_mbps == 0)