From patchwork Mon Apr 27 07:14:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhao1, Wei" X-Patchwork-Id: 69362 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25642A00BE; Mon, 27 Apr 2020 09:38:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CB6F1C128; Mon, 27 Apr 2020 09:37:48 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 46EDA1BF7D; Mon, 27 Apr 2020 09:37:42 +0200 (CEST) IronPort-SDR: weFxpv2DZ9fFXM2w05uzOaIV9G1D40eohoJe7ZqE9USZWsLWOhgEj8SPqDq9if7Ycbn0plc1sy PRp3EsGNMaxg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 00:37:40 -0700 IronPort-SDR: aPoqWQbDntJDhm+388b1qXfz0bBuktdFDrn9e78tvRmKPP0F7dmumvYf3PJgmPdYc75irLdqGP K4jlhdt7yW8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,323,1583222400"; d="scan'208";a="458244988" Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([172.16.182.123]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2020 00:37:31 -0700 From: Wei Zhao To: dev@dpdk.org Cc: beilei.xing@intel.com, maxime.leroy@6wind.com, stable@dpdk.org, Wei Zhao Date: Mon, 27 Apr 2020 15:14:58 +0800 Message-Id: <20200427071500.14767-2-wei.zhao1@intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20200427071500.14767-1-wei.zhao1@intel.com> References: <20200427071500.14767-1-wei.zhao1@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I have try to enable ARP ethertype for FDIR filter, it work well for ARP for FDIR filter, so delete it. Bugzilla ID: 402 Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") Cc: stable@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_flow.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 7e64ae53a..1533d5abb 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -2666,7 +2666,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ether_type == RTE_ETHER_TYPE_IPV4 || ether_type == RTE_ETHER_TYPE_IPV6 || - ether_type == RTE_ETHER_TYPE_ARP || ether_type == outer_tpid) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, @@ -2711,7 +2710,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, if (ether_type == RTE_ETHER_TYPE_IPV4 || ether_type == RTE_ETHER_TYPE_IPV6 || - ether_type == RTE_ETHER_TYPE_ARP || ether_type == outer_tpid) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, From patchwork Mon Apr 27 07:14:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhao1, Wei" X-Patchwork-Id: 69361 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF1ECA00BE; Mon, 27 Apr 2020 09:37:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9A0C1C00D; Mon, 27 Apr 2020 09:37:44 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C1DC81BF7D for ; Mon, 27 Apr 2020 09:37:41 +0200 (CEST) IronPort-SDR: VQmEvwlMy12BuAfSX2ElavNn/OiPhjyLqzOQh7oq73zVfku5Xhi+zcP37su1IndKg7+KfZGQXt 0v+XA4qzEocA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 00:37:40 -0700 IronPort-SDR: bE/Xys390sH7z+9n1cqV6WDRXOgzLOSLlp42R5iC+4g4WIJz/I/7aKkp40hjdfI41ZX0WZ8mep mHxMf4ttF5VQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,323,1583222400"; d="scan'208";a="458244990" Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([172.16.182.123]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2020 00:37:33 -0700 From: Wei Zhao To: dev@dpdk.org Cc: beilei.xing@intel.com, maxime.leroy@6wind.com, Wei Zhao Date: Mon, 27 Apr 2020 15:14:59 +0800 Message-Id: <20200427071500.14767-3-wei.zhao1@intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20200427071500.14767-1-wei.zhao1@intel.com> References: <20200427071500.14767-1-wei.zhao1@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/3] doc: input set requirement of each pctype for FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add input set requirement info to i40e doc. Bugzilla ID: 403 Signed-off-by: Wei Zhao --- doc/guides/nics/i40e.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 416b3904e..ad5f51c38 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -747,6 +747,13 @@ Use 16 Bytes RX Descriptor Size As i40e PMD supports both 16 and 32 bytes RX descriptor sizes, and 16 bytes size can provide helps to high performance of small packets. Configuration of ``CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC`` in config files can be changed to use 16 bytes size RX descriptors. +input set requirement of each pctype for FDIR +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +Each pctype packet can only have one specific input set for FDIR, for example if you download 2 rte_flow rules of different input set for one specific pctype, +it is will fail and return the info "Conflict with the first rule's input set", that means the first type of input set conflict with the current one, +this limitaition is required by hardware. + Example of getting best performance with l3fwd example ------------------------------------------------------ From patchwork Mon Apr 27 07:15:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhao1, Wei" X-Patchwork-Id: 69363 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6B98A00BE; Mon, 27 Apr 2020 09:38:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F09661C18F; Mon, 27 Apr 2020 09:37:49 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 628391BF81; Mon, 27 Apr 2020 09:37:42 +0200 (CEST) IronPort-SDR: r4EAzXmUiSktWc0yiv2QSR7GB9J3gnnq1ia5cbdxL7mT4tiE/o8G6GdUBTLL8nPtMtN2Q9Arr6 j6mpKZmhXnKQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 00:37:40 -0700 IronPort-SDR: 3nhgrNgopPtuOUI0I+4d3noCmzErMDmimj/m/W/somuYvGFUovpK4bWZwE2faA7885h8sRllYg VC8YBGfBwvgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,323,1583222400"; d="scan'208";a="458244993" Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([172.16.182.123]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2020 00:37:34 -0700 From: Wei Zhao To: dev@dpdk.org Cc: beilei.xing@intel.com, maxime.leroy@6wind.com, stable@dpdk.org, Wei Zhao Date: Mon, 27 Apr 2020 15:15:00 +0800 Message-Id: <20200427071500.14767-4-wei.zhao1@intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20200427071500.14767-1-wei.zhao1@intel.com> References: <20200427071500.14767-1-wei.zhao1@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/3] net/i40e: remove teardown when flush FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When we flush FDIR filter, we can not call i40e_fdir_teardown() function as it will free vsi used for FDIR, then the vsi->base_queue will be freed from pf->qp_pool, but vsi->base_queue can only get once when do dev init in i40e_pf_setup(). If we free it, it will never be alloc again. Bugzilla ID: 404 Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") Cc: stable@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_flow.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 1533d5abb..65f877866 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev, /* If the last flow is destroyed, disable fdir. */ if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) { - i40e_fdir_teardown(pf); i40e_fdir_rx_proc_enable(dev, 0); } break; @@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) pf->fdir.inset_flag[pctype] = 0; } - i40e_fdir_teardown(pf); - return ret; }