From patchwork Tue Mar 31 17:31:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67519 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E935DA0562; Tue, 31 Mar 2020 19:31:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C73A91C0BF; Tue, 31 Mar 2020 19:31:24 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 39FF81C0BD for ; Tue, 31 Mar 2020 19:31:22 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id g20so1171181pgk.10 for ; Tue, 31 Mar 2020 10:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3Jr3fjP0rIx5UsynO3o27dxl+xUKTyA0kBPWq6+Ex1M=; b=Xhg9YJ0MjCQXWmgIliYhy0hgEkWoBKeX2Ep8c6p/F9KSUe4DGk6Nwcl12Lj/7jw/AU uoOr8lfS6GvtWqYuqEaL0R6H0zojkTwikdO0iUlY3NA8nbqYyHnDhS6ssht7jw8jDq1r soHNppgnA7AstT0CcFIQyXG7Kamk4baOSGk28YSxieEUDQqwlNhWy/9nI1pXE5T3/SRK i3kG5dhpZdRX92j/OUjb9o/rF8NLiUS5nlCWKrsrc6Eb+H1yzCRWOBJmSfnNsXYSrG9q tjJGmXq/Ic/mLpfTHQDxGMMaJJGf4HIBWYDPZfltvfNL03LQYvmstJp7dn6LlCCAKwbj QXMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Jr3fjP0rIx5UsynO3o27dxl+xUKTyA0kBPWq6+Ex1M=; b=BM25WjEn41WQVH6/XJ8ob7YT8vC/Y0BX9xYO8FEj7qvKpZ/Rwy+fLt1JLKMRuV+noJ Y6c2xslbOeWOgqV+RorxZ3fImmk4hYr1z6VquXje463AnoUkpGk4fvS9TwLrv8Geu9rM M8od+MHmeWBE2uuFygBwZptwt/IUDHZmwMIb46WMFrmMhw5NYpRfJvc7WVV4/JTz9hTG FVwBWq0RN8QUb4mUlWC/cHVH4crEZywJ+rcTnKpmLOZE++PVANcn42quxTEDqqy7NjmU Pl+Ivegsna+GV5Z3jJNXBoxlPKTmdb0/KTHLlaLa8y/778b9q6/dhvVpuNWguYV0eq26 ueYA== X-Gm-Message-State: ANhLgQ2g2Ih+kdi7aWI/zohLZomLRz/gUt7I7pyZgd0Wy8mOLaTwo7Cy iF1rTu5bt+i6LoK3pFN8pb+yY6zrNCt4WQ== X-Google-Smtp-Source: ADFU+vvfYH7nMv5RyIjU22HcuoYRlEhjdGkZPQDnKQungDZI973IdGYzrmaVVxDviAqYrs/urDYz/A== X-Received: by 2002:a63:4766:: with SMTP id w38mr19724674pgk.364.1585675880852; Tue, 31 Mar 2020 10:31:20 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:19 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , nsamsono@marvell.com Date: Tue, 31 Mar 2020 10:31:04 -0700 Message-Id: <20200331173110.25746-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/7] net/mvneta: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD logtype is legacy and should not be used. Fixes: 3378383dceab ("net/mvneta: support statistics reset") Cc: nsamsono@marvell.com Signed-off-by: Stephen Hemminger --- drivers/net/mvneta/mvneta_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c index 865ad61aed1c..4aea87648814 100644 --- a/drivers/net/mvneta/mvneta_ethdev.c +++ b/drivers/net/mvneta/mvneta_ethdev.c @@ -751,7 +751,7 @@ mvneta_stats_reset(struct rte_eth_dev *dev) ret = mvneta_stats_get(dev, &priv->prev_stats); if (unlikely(ret)) - RTE_LOG(ERR, PMD, "Failed to reset port statistics"); + MVNETA_LOG(ERR, "Failed to reset port statistics"); return ret; } From patchwork Tue Mar 31 17:31:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67520 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FE76A0562; Tue, 31 Mar 2020 19:31:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 676BC1C0C6; Tue, 31 Mar 2020 19:31:26 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 8EE551C0BE for ; Tue, 31 Mar 2020 19:31:23 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id jz1so1165790pjb.0 for ; Tue, 31 Mar 2020 10:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MsYKPhlOawbFQs+xEOzXBIqaNoVvXo+uTGLPRaNTWZA=; b=DN3b2F3j2FrVkqjdV+NWzHcBB/rvATmIF94xc8FVYUN5WbyNFpXo32WovkX7OHUxqv bMYu2JLKuYoUSlmgsNv5COUBvlJmOZk4xRATJNv27uCQCGzWX3oc+9RbZHTZF9CaNfZu sdW6CBqy1fmU2jG17cLh1mQGAXg41f14CKM8Kg5jqYgfRCGEYoRBrUtUIGGOxXL1WsaQ Llmb/qWVFvrjAZk2J+i36zbBZkgs+rqHFvbkwDDQxUS8MxXlBCBahtJmnbPnD9ro2hao CJOjL6HuDBwrUaywYnjR4vCJt49ANEUcbcNDC/e9HlyXLSPbtp2iK0l96arHdPFPNlc1 aWgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MsYKPhlOawbFQs+xEOzXBIqaNoVvXo+uTGLPRaNTWZA=; b=BTVymjaT/Vt35fp1WcBXlpPm9VKx+n6PTORbLnv5AN5Ug4HLUgV4oFo0rF/zfJnSPl UMgb2yhV7ghsWQQitczzqu6ThW64FR3O19PHyh2fy7UaAc9iFDz29GcaSpT9cXdBe2cI 4yzlm30vYNHIoz0qHpW2X+PCjfsMBoJDQm79tCV02SRtMGtm8B0SQ73ACkI1kq5wM7Fl nw28J9CzjG5nMvIRH7lqIT++2ztA0E1DhvjlGOsdqD6RglqwaGMeC+s5s2iTUyXl7JSk G4hvilAcPrAL8MPrX8CBti96Af1dAIY3JXams4+8r+md/Vmd7nSGbxuvHkyua2h3VkVr xcuw== X-Gm-Message-State: AGi0PuZAMSdvWoWglABR2g6h08Iq3JD0ZWf/v6v/1gNbJXY6NnoemG/L IeAPOdVEdoVBCHb4oNK28WvF1P17zBI1Kg== X-Google-Smtp-Source: APiQypLbGsZgbjnyrHiQsJqNNA1ILH8vxLc1EWxcofBVbHt5t9MpJa1DCjoBvPh/8v4h0BoyVMSvcA== X-Received: by 2002:a17:90a:4d43:: with SMTP id l3mr5093109pjh.165.1585675882282; Tue, 31 Mar 2020 10:31:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 31 Mar 2020 10:31:05 -0700 Message-Id: <20200331173110.25746-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/7] net/virtio: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Virtio driver has its own logtype adn should not use legacy PMD logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 6 +++--- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 752faa0f6e7e..060410577af4 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1085,7 +1085,7 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, RTE_MIN(vq->vq_nentries / 4, DEFAULT_TX_FREE_THRESH); if (tx_free_thresh >= (vq->vq_nentries - 3)) { - RTE_LOG(ERR, PMD, "tx_free_thresh must be less than the " + PMD_DRV_LOG(ERR, "tx_free_thresh must be less than the " "number of TX entries minus 3 (%u)." " (tx_free_thresh=%u port=%u queue=%u)\n", vq->vq_nentries - 3, @@ -1133,7 +1133,7 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_recv_refill(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } @@ -1145,7 +1145,7 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_refill_inorder(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index e61af4068322..5637001dfccb 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -561,7 +561,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev) const char *name = rte_vdev_device_name(dev); eth_dev = rte_eth_dev_attach_secondary(name); if (!eth_dev) { - RTE_LOG(ERR, PMD, "Failed to probe %s\n", name); + PMD_INIT_LOG(ERR, "Failed to probe %s", name); return -1; } From patchwork Tue Mar 31 17:31:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67521 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DF88A0562; Tue, 31 Mar 2020 19:31:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2577C1C0CE; Tue, 31 Mar 2020 19:31:29 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id EE9EA1C0B7 for ; Tue, 31 Mar 2020 19:31:24 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id a24so3800294pfc.8 for ; Tue, 31 Mar 2020 10:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4STHvn45VW3tSwuQaAkxb8w0CsvHEqi7ZK830XrKDMg=; b=ZJwbn61Uf3OFTqMMZjrCD5L4hVR0uyFXYIBGE6Y59k5NG6T5YUm/qZwswvL9Rt+I6s l5T+MRfID4+/BoP3ThELmbXSGii6XyxV0OFEpMOs636A9qTnoKVeYYabPElEEN6Xe5vC Nr7syQmAgolMoTnmMhQ8WVviJfkasp2iutDTfbI456+7C0VrBrnmL2qF8rtGq1C+4l6r +AsBV2lmqlLiyxcsi+aCZQBk4dTfSLLUHVxMKem6SRP5Aj+IDhoeKNYeb/jME9X9ws1Z EuKdSJ8GMg/7uYh9WI1qJieZ0gCu6ILl/CnZtcNla+MjF7XttbLA3tMG9T201y/WtUxe amrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4STHvn45VW3tSwuQaAkxb8w0CsvHEqi7ZK830XrKDMg=; b=TEcXZcj5Unb3eBcZ8cKNd374FrdK6NewxkiAc12cEI90ePf0MxKkUzvFCbKzu3fuit /+zDrvOmsZ0onsxwXaIiPR0+d8VRrpPXjZ2UL6sWGP9j0wGhcE+BcB/AWSxFhtbarfb/ w7wHpjI2DIpuq3b8OaNth1sdwqBGLV/Rbx7GHf4NsOquj8QT/IjcmHNQmz8sVG71TRMx yghmPfgo7IhG1kohWk2YRaZMMycE4Ah7Hj21s5uC8z0GbDyGhhaijOvZOT7Axl26Em0w tcDmoSXyVPhmY7iUWaL6q5oN3sm05J5DeYG6EtH84haBhS5f6uVZdwnbKqet/DCQr2S4 eP2A== X-Gm-Message-State: ANhLgQ3w7ri1jxNgZhcTaAUVYP9raklMwHtcBTNwAyNRsxqgvbF6Ayel mO+lVo3zGbmc+4KBe+6k6+w1b5Xs13R5iQ== X-Google-Smtp-Source: ADFU+vsLL8Lfr67s9lGWh8hM+RTDQnvhaHrc4REbGtt/BH1YkTxqLTcxrHnotJEhSl2s33Ap3rKeIA== X-Received: by 2002:a63:82c6:: with SMTP id w189mr18317813pgd.357.1585675883786; Tue, 31 Mar 2020 10:31:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:22 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ophirmu@mellanox.com Date: Tue, 31 Mar 2020 10:31:06 -0700 Message-Id: <20200331173110.25746-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 3/7] net/tap: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD logtype is legacy and drivers should use their own logtype. Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") Cc: ophirmu@mellanox.com Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 05470a211588..2c9fb76b63de 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -778,7 +778,7 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request, case SIOCSIFMTU: break; default: - RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + TAP_LOG(WARNING, "%s: ioctl() called with wrong arg", pmd->name); return -EINVAL; } @@ -1301,7 +1301,9 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) SOCKET_ID_ANY); if (!mp) { struct pmd_internals *pmd = dev->data->dev_private; - RTE_LOG(DEBUG, PMD, "%s: failed to create mbuf pool for device %s\n", + + TAP_LOG(ERR, + "%s: failed to create mbuf pool for device %s\n", pmd->name, dev->device->name); return -1; } From patchwork Tue Mar 31 17:31:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67522 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26955A0562; Tue, 31 Mar 2020 19:32:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A88911C0D6; Tue, 31 Mar 2020 19:31:30 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id AD1DE1C0CC for ; Tue, 31 Mar 2020 19:31:26 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id o26so10630383pgc.12 for ; Tue, 31 Mar 2020 10:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZyZfhZ5DpSzXyTh/4YlHeDyF8WAHch7RaLsHQIFNklw=; b=ZMudX4p9KqVSuKFF1gXXS8xfsXlsps4bxBMebBdp7L2+sRaRHowBVT2IM3UJKLm3FI MFHEL/a9o5c+FE9PmoebBgbOLAhTr0KcHh0IDQR1RptJ5zg7ldpT1UAlxKE78zowZSTB yxp8wlqmuNyXWqsxaIiMeMiOM4MtsHk4avYBwSIQuk2VIHnzx0Lzu8xq7k9RXoYd3OhZ tBZCw3UQrW/9LhMYwM1dH+o2XRbpVO1amFI4WHeq5ViuzP54OTLfWbD6bO1aFTQn4kJ1 B72B790j8456FeHJliq2tPDDyAONB6yyXSQ1NDyUe6IBVtaPg+tLLTrTiJkA8FdxLym6 4hpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZyZfhZ5DpSzXyTh/4YlHeDyF8WAHch7RaLsHQIFNklw=; b=XubquLSbv6Z56lVAzuwEPbRCf9uvOIajrJqTTZCHqiEHdzb5xXlKBw7Vnnk1zNlbQF x8AEJuMGChYZ6j56e+HO5FWhOafPBPNOOzyHgom/uLxuLHWOua9quj4LN3n4GEKe5pyL A6kc4jOF5MzEzQ3eI3ytwkwcZjnpxKLb5uwUerUrDrGOOzRZ9xkE/OEx7kzqsvWs61+R W5K5Gst+PEOsweCGL0pjLs1h+jiK92puQjRxYk1O/V37AxTmPBHCHglwY+ToUNZwjApS CgjXT6P9xnwMElYKqszwqA2K7oSWIp/ayqLXeM9L3CFxk2sjQZG2Esez9JBUJHnJ/EuJ M9Ww== X-Gm-Message-State: ANhLgQ36Ux6WogmW7w/qfJU/x9rIj4RdsMuS0GATg/7THRFufJDnXk6S 6Zhy2U/Rw5QLxGWXhzhjvuavCc3nwfvn5A== X-Google-Smtp-Source: ADFU+vuG8aI3uQZstE4VMWeRLVZZj8Q6ajGXpoz4+2NCZlLStHs2pMhm49tfrZZsX2+z8kxXZzm9Vw== X-Received: by 2002:a63:a70b:: with SMTP id d11mr18873460pgf.358.1585675885096; Tue, 31 Mar 2020 10:31:25 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:24 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , g.singh@nxp.com Date: Tue, 31 Mar 2020 10:31:07 -0700 Message-Id: <20200331173110.25746-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 4/7] net/pfe: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD logtype is a legacy from original DPDK logging. All drivers must use their own dynamic log type. Fixes: b1bc1afa4a0e ("net/pfe: support dynamic logging") Cc: g.singh@nxp.com Signed-off-by: Stephen Hemminger --- drivers/net/pfe/pfe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c index 940347819875..59b5b8387b9d 100644 --- a/drivers/net/pfe/pfe_ethdev.c +++ b/drivers/net/pfe/pfe_ethdev.c @@ -990,7 +990,7 @@ pmd_pfe_probe(struct rte_vdev_device *vdev) if (rc < 0) return -EINVAL; - RTE_LOG(INFO, PMD, "Initializing pmd_pfe for %s Given gem-id %d\n", + PFE_PMD_LOG(INFO, "Initializing pmd_pfe for %s Given gem-id %d", name, init_params.gem_id); if (g_pfe) { @@ -1118,7 +1118,7 @@ pmd_pfe_probe(struct rte_vdev_device *vdev) else gem_id = init_params.gem_id; - RTE_LOG(INFO, PMD, "Init pmd_pfe for %s gem-id %d(given =%d)\n", + PFE_PMD_LOG(INFO, "Init pmd_pfe for %s gem-id %d(given =%d)", name, gem_id, init_params.gem_id); rc = pfe_eth_init(vdev, g_pfe, gem_id); From patchwork Tue Mar 31 17:31:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67523 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D342CA0562; Tue, 31 Mar 2020 19:32:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C7BA1C0DA; Tue, 31 Mar 2020 19:31:32 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id 3E39B1C0CD for ; Tue, 31 Mar 2020 19:31:28 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id c20so8087860pfi.7 for ; Tue, 31 Mar 2020 10:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wO6IY/wlv7lUEjktkkD7Fjq4/897tIP5+E0ot3LFeCE=; b=GebScCoxylnGW5eg3RkdYrTuD0dRmzPTp3Bwz3T1MF9FFm4b0/imRsBkVB/giKh12H JKZFnOQ2GaMJ6XQj1VRKrqQeF+IneRHMtaYblLQgyBOxfGFS1YwKFOgk+t5sNUhoQPFe lOhtXlaZ0UHYSPk7mHMPdfa/2E9ATcP7OXd4nADh16dByDYGkNCPtg8UsB6KVyYLR4Vl d/3Gra62m0c/VvDc8ShngaiROW/XO2tHuZPNiRaPM4PYX3kPGmcZy4XCji2FHeks9LLE sif4Clqm7il3Synj4Ydc/PgX4x6lPnxzsinLQCxTBSmnsha5IJO07IcP1R/F41B8l8V5 s3wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wO6IY/wlv7lUEjktkkD7Fjq4/897tIP5+E0ot3LFeCE=; b=gKmHIBh1qDLhxCRkj63pVtgU55XVnV4oO9ioUVXNLenMuXIIXGHBAMwKSUazrJ6Mwi Za7ZuTqsWfTPrut7Qt2X1uOIzQ2yMMpfFojUWq7aq/18fcYYGU4tO2HlPyuunZmbdXj+ i2MAPJy+bDNtTv9zIv4ep8tH1iTCSVfI2g3+c+StZiGUIMKL/rG1hccQweFKlflJekyT 8+4JngPOJE3X5H4vFY1IVXvUCs4DcwxfZVNSNZYKU4shry2PohioUrQUDOZQytcHa6E1 9HTXPXDvEHg01tEQkxBgfNLvP/HzzvDKiwSa2CpTY6IQ4Dt3OPOiscO+YJlvoCHzaTjJ UhKw== X-Gm-Message-State: ANhLgQ31E3qIuqCubS+PyJtTh1pVlCWdf3bgoHZcH9d0uuCuONpFDS/k vExMIbDbYGGJ0/3WdVI8b9p2QBwOsjmYlg== X-Google-Smtp-Source: ADFU+vszcXVWNZP97NXYOuhSSrvflD+UOrfYDNY/7Y1kC+OMVWHl2weDlcTsUrZmt25hQTE37X08ag== X-Received: by 2002:a63:778e:: with SMTP id s136mr18180960pgc.155.1585675886767; Tue, 31 Mar 2020 10:31:26 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:25 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ajit.khaparde@broadcom.com Date: Tue, 31 Mar 2020 10:31:08 -0700 Message-Id: <20200331173110.25746-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 5/7] net/bnxt: don't use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Accidental use of PMD logtype rather than per-driver logtype. Fixes: 14255b351537 ("net/bnxt: fix queue start/stop operations") Cc: ajit.khaparde@broadcom.com Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index d6e4e8a28138..1999cd7861b8 100644 --- a/drivers/net/bnxt/bnxt_ring.c +++ b/drivers/net/bnxt/bnxt_ring.c @@ -598,7 +598,7 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index) if (rxq->rx_started) { if (bnxt_init_one_rx_ring(rxq)) { - RTE_LOG(ERR, PMD, + PMD_DRV_LOG(ERR, "bnxt_init_one_rx_ring failed!\n"); bnxt_rx_queue_release_op(rxq); rc = -ENOMEM; From patchwork Tue Mar 31 17:31:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67524 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C9F4A0562; Tue, 31 Mar 2020 19:32:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 769001C10E; Tue, 31 Mar 2020 19:31:34 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id A6E021C0D2 for ; Tue, 31 Mar 2020 19:31:29 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id 142so10628472pgf.11 for ; Tue, 31 Mar 2020 10:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1wt2KltLzYbHaCbMJ3n6lmj/ONew3Mlz5BQiSMlwJsQ=; b=wPtwOZt3eox14PvGXDxD2FamuxI1XP6om22RBgIbLwP3ksM7ZDdnDUc4M/FlP3h9bN y+cxLhj7eQcJeDDevQXFFF+D8rpdhhv0mQ2bwt7NHwQ3Gk3cw+B6GGawjPrWGDO7E46p 4EQy5A8FDNnMnuQYCMVjs1Yj+xzNJ8nkiiADNermWEVHsMfaAStpQTrW50Zp1tfrEll8 NBOY22fYgWhFrVWoQ3nNtVSY4xfZ8RnV5WKk0uWpP5zBV33lWGbcTZ9yHCSmvCJD57ej XyzB6a7Fnk1lJjLpVPZaCyqajFRUmMo26qlOdA8Rb9u5/Kd/36a5TO1CM/PEGNEx/S3U ey7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1wt2KltLzYbHaCbMJ3n6lmj/ONew3Mlz5BQiSMlwJsQ=; b=Z+GF7plG1tLM0P25trP0RP5+VPccz/Y2JHzhwkCJCqpUaePPxzjwoH5iMoGkU+m/CD xLnq6UQhKZS9Qh94/N5uekz20pgC57GAjRFzWvqUiBb15WUQo99QS6ht0pxAkmGm5n9T jbQUnn166ladUAEj9yM6WUr5HSp1ljivbWcWwoCBMb5XMkxySRtiOx1unlUVPIqDE8S8 /IYRaSOwK8dzSg3WhpYniOq1tcd8qBA3L1Xjx9uWpiXbYOz4rJPKq84pjTVxJul6k2bP wRhIFbXaOCB8dbR3Uvm8zW3jb+U7lB214SroDmJZhj/N9j1885RZxoosNyG9AHebptWK E7Lw== X-Gm-Message-State: ANhLgQ3k2bhRopajN1FZyNHKXRBYjGgBLXKI4MOCU+pxwcTIxcCOq0El XIlG6Tp6WSv+WqVAilEk3RcgiKuYpWRNOQ== X-Google-Smtp-Source: ADFU+vvEc+uedxDdK8EmUJpmjGec8tZdj3rzlvfyED8aOlmErpBLlJaA9S9dliS/CHmPAngG33fmzQ== X-Received: by 2002:a63:6d3:: with SMTP id 202mr18733750pgg.445.1585675888328; Tue, 31 Mar 2020 10:31:28 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:27 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , shreyansh.jain@nxp.com Date: Tue, 31 Mar 2020 10:31:09 -0700 Message-Id: <20200331173110.25746-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 6/7] net/dpaa: use dynamic logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The static PMD logtype should not be used by drivers. Instead, use existing log macros in this driver. Also use standard rte_ether routine to format ether address. Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") Cc: shreyansh.jain@nxp.com Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index fce9ce2feb9d..5f81968d80e1 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -881,8 +881,8 @@ dpaa_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id) PMD_INIT_FUNC_TRACE(); if (qman_query_fq_frm_cnt(rxq, &frm_cnt) == 0) { - RTE_LOG(DEBUG, PMD, "RX frame count for q(%d) is %u\n", - rx_queue_id, frm_cnt); + DPAA_PMD_DEBUG("RX frame count for q(%d) is %u", + rx_queue_id, frm_cnt); } return frm_cnt; } @@ -996,8 +996,7 @@ dpaa_dev_add_mac_addr(struct rte_eth_dev *dev, ret = fman_if_add_mac_addr(dpaa_intf->fif, addr->addr_bytes, index); if (ret) - RTE_LOG(ERR, PMD, "error: Adding the MAC ADDR failed:" - " err = %d", ret); + DPAA_PMD_ERR("Adding the MAC ADDR failed: err = %d", ret); return 0; } @@ -1023,7 +1022,7 @@ dpaa_dev_set_mac_addr(struct rte_eth_dev *dev, ret = fman_if_add_mac_addr(dpaa_intf->fif, addr->addr_bytes, 0); if (ret) - RTE_LOG(ERR, PMD, "error: Setting the MAC ADDR failed %d", ret); + DPAA_PMD_ERR("Setting the MAC ADDR failed %d", ret); return ret; } @@ -1306,6 +1305,7 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) struct fman_if *fman_intf; struct fman_if_bpool *bp, *tmp_bp; uint32_t cgrid[DPAA_MAX_NUM_PCD_QUEUES]; + char eth_buf[RTE_ETHER_ADDR_FMT_SIZE]; PMD_INIT_FUNC_TRACE(); @@ -1457,15 +1457,9 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) /* copy the primary mac address */ rte_ether_addr_copy(&fman_intf->mac_addr, ð_dev->data->mac_addrs[0]); + rte_ether_format_addr(eth_buf, sizeof(eth_buf), &fman_intf->mac_addr); - RTE_LOG(INFO, PMD, "net: dpaa: %s: %02x:%02x:%02x:%02x:%02x:%02x\n", - dpaa_device->name, - fman_intf->mac_addr.addr_bytes[0], - fman_intf->mac_addr.addr_bytes[1], - fman_intf->mac_addr.addr_bytes[2], - fman_intf->mac_addr.addr_bytes[3], - fman_intf->mac_addr.addr_bytes[4], - fman_intf->mac_addr.addr_bytes[5]); + DPAA_PMD_INFO("net: dpaa: %s: %s", dpaa_device->name, eth_buf); /* Disable RX mode */ fman_if_discard_rx_errors(fman_intf); @@ -1578,8 +1572,7 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, if (!is_global_init && (rte_eal_process_type() == RTE_PROC_PRIMARY)) { if (access("/tmp/fmc.bin", F_OK) == -1) { - RTE_LOG(INFO, PMD, - "* FMC not configured.Enabling default mode\n"); + DPAA_PMD_INFO("* FMC not configured.Enabling default mode"); default_q = 1; } From patchwork Tue Mar 31 17:31:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67525 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E87ECA0562; Tue, 31 Mar 2020 19:32:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C47481C119; Tue, 31 Mar 2020 19:31:35 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 09D2C1C0D7 for ; Tue, 31 Mar 2020 19:31:31 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id m15so1361295pje.3 for ; Tue, 31 Mar 2020 10:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9ToMg0lSj5c30+yWXFwD29RxpRRHhuhw6ZagmuwaulQ=; b=uOTrT1X9ole0kv+iVXLLGgG0ybw0lQqvyvij2pxLuPbGPCsIRJtiHzkqjpSp/7XSi5 7QU9ruvbvJh9olGGvDFjwWf436plRzwHhRsZ/7s8wlYdEnbqyPbnIpAtjwDD4lybDdKN QEkGEvcujcGwamjNRh6NyQr61iyuQS+zpDaxdw7cZzcJBtIjch1ErKQWCTN0U4wp23yN DpQHdzGMnB523XUoVUOZO/AJ9N9/WVoTGIUD4zF/uj0i9M6FkKlhoQUyBGlRPFRi0EzS SUB+cR0yQqQ09HQ/5/gqUdPJKMVfWfLGDv9kWwoAbeU+PWlGekcoLSRjAcCz5xfga0wZ 9x9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9ToMg0lSj5c30+yWXFwD29RxpRRHhuhw6ZagmuwaulQ=; b=PZrxYaoklIqwS0IortMlKNBl4VAnqjw5IZ14Q/rdSRYRiaH/IBbhlBzvFlpxjn4L9B ufesxwOcW4A9zp7rRTTtv0zHBBIhF3rG6k+t2OMrUIX4HyScKdVtNAihoVPOJeJpMZTh HJwYr9eKFIrkp8QFED6u14vZbe22FDxk+lb33BDalx0qD+smji09M6xVhzx7pV2Xy7Yz F1MXpDy2KJlRCfXuNAuXdtGOL8enX/n2+YEY6k8aLcX0QVBd8k0pGr2h4pxod2u3yPvr Oqb/e2pYuauUvBxsD4ioNNmCPcXVTjxJo7rI1DYUAllzLTBFcQ+W9zzMBVXpkonLqkV8 4w2g== X-Gm-Message-State: AGi0PuYpNV1Sg5FBu6tZBkY/1PAd7rtxJKtmSkg5rGwHr2YMXgpGw8MR BoN9d64heIMT3hcYy0dotn5jLmTjK7Zdag== X-Google-Smtp-Source: APiQypJ765mBHPZf/wx0ADSAj5QvrrhBlSnLFTUZaacu6/ZtyeVG8VDHXwkF1X0wRc+/Xy+rD7uSRw== X-Received: by 2002:a17:90a:c207:: with SMTP id e7mr5312094pjt.117.1585675889789; Tue, 31 Mar 2020 10:31:29 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:28 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , jerin.jacob@caviumnetworks.com Date: Tue, 31 Mar 2020 10:31:10 -0700 Message-Id: <20200331173110.25746-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 7/7] net/thunderx: use dynamic logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD static logtype is original DPDK legacy and should not be used. Fixes: 43362c6a7647 ("net/thunderx: support RSS and RETA query and update") Cc: jerin.jacob@caviumnetworks.com Signed-off-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_ethdev.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index 6f43541a5d42..bfda0ab0ede8 100644 --- a/drivers/net/thunderx/nicvf_ethdev.c +++ b/drivers/net/thunderx/nicvf_ethdev.c @@ -496,9 +496,10 @@ nicvf_dev_reta_query(struct rte_eth_dev *dev, int ret, i, j; if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) { - RTE_LOG(ERR, PMD, "The size of hash lookup table configured " - "(%d) doesn't match the number hardware can supported " - "(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); + PMD_DRV_LOG(ERR, + "The size of hash lookup table configured " + "(%u) doesn't match the number hardware can supported " + "(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); return -EINVAL; } @@ -526,9 +527,9 @@ nicvf_dev_reta_update(struct rte_eth_dev *dev, int ret, i, j; if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) { - RTE_LOG(ERR, PMD, "The size of hash lookup table configured " - "(%d) doesn't match the number hardware can supported " - "(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); + PMD_DRV_LOG(ERR, "The size of hash lookup table configured " + "(%u) doesn't match the number hardware can supported " + "(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); return -EINVAL; } @@ -569,8 +570,8 @@ nicvf_dev_rss_hash_update(struct rte_eth_dev *dev, if (rss_conf->rss_key && rss_conf->rss_key_len != RSS_HASH_KEY_BYTE_SIZE) { - RTE_LOG(ERR, PMD, "Hash key size mismatch %d", - rss_conf->rss_key_len); + PMD_DRV_LOG(ERR, "Hash key size mismatch %u", + rss_conf->rss_key_len); return -EINVAL; }