From patchwork Wed Mar 25 19:18:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduard Serra X-Patchwork-Id: 67111 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2CF3A058B; Wed, 25 Mar 2020 20:19:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A49682C15; Wed, 25 Mar 2020 20:19:06 +0100 (CET) Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-eopbgr750088.outbound.protection.outlook.com [40.107.75.88]) by dpdk.org (Postfix) with ESMTP id 9B1BC2BAE for ; Wed, 25 Mar 2020 20:19:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dw0a0Jd9d6O2l+ci/YP5qWQPlmxGoxZyAMFIJC1NZR+5Nblie90ycTcfDpWxdlSmlPxQGCWotjDf1w1GE1wvQzm3pyv2/c9RT7GFw29sBuqMVlRaOtY/2k9nAdrZdv+xkKVAkmGbIXVkQ1OBytix9u8WyNlUEvEF6UIEGKWC+PL3w3FXiuMHJWNY21agl71autDmC1fmIy63cMAQcvkAu/kqm6XVb/Vag3LGPZi7eynSqFJ9EBC7/vN3eumAVfuyNpWrHFjQfdhp3SovsQnJd60fiwogbeQfvoYjY7VCV1NHXHDD5fNme4LJh8QbpLJJg/QumXiviqcevzvCkw8QJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBjKpZ7FNa2eXTt8nGEoKTJy6a2YL+KVfmZ6s0WX66c=; b=jO7aNoaLQ+lxvp2M5fmyFvpeCvAdUjRyOws+XujnMfr4tFIFiOXKztKRIZ9DMDXgmnpmeabpYU85JMAj+nbkchMXWO91oTaAp0yF7pO0OJ4BqT/2BWSG5SJHprO1Wr3csTyWirqSY5lwLNExOElsJaam9mUESNbOXRLSTNVbtUeN4vZv5exDg8UGBmvgSNCRChkFCStlE0qU0r+sj2so7PTSCGQs8UdPslnZDjhU4A0PMHBsWj/FuAX+O+1NyR9DYJxVkkhShZQY387iZMOBhxR+WV8FLCtcuvimc/og1+vad9/OaWC2RpORZ36ifNaLP7SHg1Ltzdk/xr5EJiKBzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBjKpZ7FNa2eXTt8nGEoKTJy6a2YL+KVfmZ6s0WX66c=; b=qYIbJ3GXpEEYMJX7Uz0egu0q4KFsDq0ltQhbX8dIFpyG/fIu5mQB5c8dCPYD4XRyHLeZt622FIX1M328K5s+adIEcHg0LM4XyFZtCJZwBR/PNxvgR1KThJU+UT+LujxI66TjFmbkW6OVLLeX2IfhhTMbJW1lQLcjU6+Vi0tudW8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=eserra@vmware.com; Received: from BYAPR05MB3989.namprd05.prod.outlook.com (2603:10b6:a02:86::31) by BYAPR05MB6408.namprd05.prod.outlook.com (2603:10b6:a03:c7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.15; Wed, 25 Mar 2020 19:18:59 +0000 Received: from BYAPR05MB3989.namprd05.prod.outlook.com ([fe80::f1be:e437:3f14:2f1a]) by BYAPR05MB3989.namprd05.prod.outlook.com ([fe80::f1be:e437:3f14:2f1a%7]) with mapi id 15.20.2856.017; Wed, 25 Mar 2020 19:18:59 +0000 From: Eduard Serra To: dev@dpdk.org Cc: yongwang@vmware.com Date: Wed, 25 Mar 2020 12:18:51 -0700 Message-Id: <1585163931-27895-1-git-send-email-eserra@vmware.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1585161984-25276-1-git-send-email-eserra@vmware.com> References: <1585161984-25276-1-git-send-email-eserra@vmware.com> X-ClientProxiedBy: BYAPR01CA0053.prod.exchangelabs.com (2603:10b6:a03:94::30) To BYAPR05MB3989.namprd05.prod.outlook.com (2603:10b6:a02:86::31) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from dev.localdomain (76.14.29.240) by BYAPR01CA0053.prod.exchangelabs.com (2603:10b6:a03:94::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2835.19 via Frontend Transport; Wed, 25 Mar 2020 19:18:59 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [76.14.29.240] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b0c936ef-9c53-4342-8f7c-08d7d0f15f08 X-MS-TrafficTypeDiagnostic: BYAPR05MB6408:|BYAPR05MB6408: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0353563E2B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(346002)(376002)(136003)(396003)(107886003)(8676002)(52116002)(36756003)(6486002)(966005)(2906002)(478600001)(6512007)(6506007)(4326008)(6916009)(81156014)(81166006)(316002)(956004)(8936002)(6666004)(66946007)(2616005)(86362001)(186003)(5660300002)(16526019)(26005)(66556008)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR05MB6408; H:BYAPR05MB3989.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; Received-SPF: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mWW+diPPBWBE+mD9Ov+ZcCpgkSUwUQi9kQfl/swCSPq7QCE4yTxETsq/iI/HnO1L77EnEoccN1rsboJWgXunIh3xM37K57gU1kaxCs56TLXf6ZA6nzIovr7Av3+ciBP22jqhSHA0CI2DP0jZRFscvjY1I/CWcgt0AeJ0LHR61VHhyC0MzEpDp2v1EZ2fCo8Wb9RIiGV58jIeIz1Z1RbyTzgHRjaRnuShCAgzmy+koBlKBoJCzcf64xCI0rtX8KWSGDybDigs9j7i4zPD6cCrCjsPRk31PaB/RXVf3w+8GgfJXk3rUKHfE8HxcmU8cvZnSISzmvMA3LK6EqeBYH8GLKbXfSdl0rOOCjwa61PhW1Lj914AXEg1AOvjy9eLNFD4BvsJsGTSbBynYo8fgbJve5+a0b+yPto4JzN8wlnXMqLIHZ2YVreqaDpJ91ulcdYtu0q8IECYRu7YRsFPHq4dste0CsW5gy2UoEoT0lRJ6bQfDPnr19uyflyv9Fq7SZOqsTsEs4l9nV5FzlhRVtpt5w== X-MS-Exchange-AntiSpam-MessageData: qQy0mYpGJhKJeJXU7SO+qu4hU6lh4Guw7O3Po8ozRt+w8ecGUC8bYWqkcJIGhRHE0RxbuLxpIeYaWgkRw45T574uNW6rwtZMZyzFgQtrpWg084ybUjhwtlvj180r/ykKRqhTwy149rbusr2SuN2XNQ== X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0c936ef-9c53-4342-8f7c-08d7d0f15f08 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2020 19:18:59.8265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0JJG6Lbz9UzFc7Nh3w1aeBBmvFKybOBOxTc5rQnnTdBBK7g3wlJ0/NQJOLeE68kW+uJNx0aSKyB+mROqwC+nyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB6408 Subject: [dpdk-dev] [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" (Picked up from @Charles Myers patch https://patchwork.dpdk.org/patch/57771/) When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() fails with -ENOTSUP and mtu is not stored in the mtu field in the rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is shared with hypervisor to always be set to 1500. This may cause issues receiving jumbo frames on Enhanced Data Path N-VDS. Signed-off-by: Eduard Serra Acked-by: Yong Wang Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 705e976..c6e11ad 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -87,6 +87,7 @@ static int vmxnet3_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info); static const uint32_t * vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev); +static int vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); static int vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on); static int vmxnet3_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask); @@ -124,6 +125,7 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = { .mac_addr_set = vmxnet3_mac_addr_set, .dev_infos_get = vmxnet3_dev_info_get, .dev_supported_ptypes_get = vmxnet3_dev_supported_ptypes_get, + .mtu_set = vmxnet3_dev_mtu_set, .vlan_filter_set = vmxnet3_dev_vlan_filter_set, .vlan_offload_set = vmxnet3_dev_vlan_offload_set, .rx_queue_setup = vmxnet3_dev_rx_queue_setup, @@ -1166,6 +1168,8 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev, dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES; dev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM; dev_info->max_rx_pktlen = 16384; /* includes CRC, cf MAXFRS register */ + dev_info->min_mtu = VMXNET3_MIN_MTU; + dev_info->max_mtu = VMXNET3_MAX_MTU; dev_info->speed_capa = ETH_LINK_SPEED_10G; dev_info->max_mac_addrs = VMXNET3_MAX_MAC_ADDRS; @@ -1212,6 +1216,18 @@ vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev) } static int +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, __rte_unused uint16_t mtu) +{ + if (dev->data->dev_started) { + PMD_DRV_LOG(ERR, "Port %d must be stopped to configure MTU", + dev->data->port_id); + return -EBUSY; + } + + return 0; +} + +static int vmxnet3_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr) { struct vmxnet3_hw *hw = dev->data->dev_private;