From patchwork Sat Mar 7 13:22:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 66363 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07EF6A0564; Sat, 7 Mar 2020 14:35:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBCD51BFE6; Sat, 7 Mar 2020 14:35:18 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 77B211BFE2; Sat, 7 Mar 2020 14:35:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2020 05:35:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,526,1574150400"; d="scan'208";a="352980466" Received: from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.201]) by fmsmga001.fm.intel.com with ESMTP; 07 Mar 2020 05:35:15 -0800 From: Xiaolong Ye To: maxime.coquelin@redhat.com, Tiwei Bie , Zhihong Wang Cc: dev@dpdk.org, Xiaolong Ye , stable@dpdk.org Date: Sat, 7 Mar 2020 21:22:34 +0800 Message-Id: <20200307132235.210168-2-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200307132235.210168-1-xiaolong.ye@intel.com> References: <20200307132235.210168-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH v1 1/2] net/virtio: fix for out of date comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix the comment that's incorrect as the code evolves. Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory") Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index f9d0ea70d..35203940a 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) } if (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) { - PMD_INIT_LOG(ERR, "split virtqueue size is not powerof 2"); + PMD_INIT_LOG(ERR, "split virtqueue size is not power of 2"); return -EINVAL; } @@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) hw->cvq = cvq; } - /* For virtio_user case (that is when hw->dev is NULL), we use - * virtual address. And we need properly set _offset_, please see + /* For virtio_user case (that is when hw->virtio_user_dev is not NULL), + * we use virtual address. And we need properly set _offset_, please see * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information. */ if (!hw->virtio_user_dev) From patchwork Sat Mar 7 13:22:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 66364 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DE6DA0564; Sat, 7 Mar 2020 14:35:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A72841BFF7; Sat, 7 Mar 2020 14:35:22 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C51741BFF0; Sat, 7 Mar 2020 14:35:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2020 05:35:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,526,1574150400"; d="scan'208";a="352980477" Received: from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.201]) by fmsmga001.fm.intel.com with ESMTP; 07 Mar 2020 05:35:17 -0800 From: Xiaolong Ye To: maxime.coquelin@redhat.com, Tiwei Bie , Zhihong Wang Cc: dev@dpdk.org, Xiaolong Ye , stable@dpdk.org Date: Sat, 7 Mar 2020 21:22:35 +0800 Message-Id: <20200307132235.210168-3-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200307132235.210168-1-xiaolong.ye@intel.com> References: <20200307132235.210168-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH v1 2/2] vhost: remove unused variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" VHOST_FEATURES has been removed in previous refactor. Fixes: 0917f9d1f059 ("vhost: use new APIs to handle features") Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 2087d1400..507dbf214 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_vhost/vhost.h @@ -543,7 +543,6 @@ extern int vhost_data_log_level; #define PRINT_PACKET(device, addr, size, header) do {} while (0) #endif -extern uint64_t VHOST_FEATURES; #define MAX_VHOST_DEVICE 1024 extern struct virtio_net *vhost_devices[MAX_VHOST_DEVICE];