From patchwork Wed Feb 12 23:08:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 65775 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64F58A0542; Thu, 13 Feb 2020 00:08:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69C951BEE5; Thu, 13 Feb 2020 00:08:26 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 7E4B2DE3 for ; Thu, 13 Feb 2020 00:08:22 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id 2so1967167pfg.12 for ; Wed, 12 Feb 2020 15:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TQ1foTVxg+p0Z34hPpUt3AbAs5O+/GOEYxwluwUJ5WI=; b=m7ApAhTdNMkC5iXzXs0BrexJbKE12mmUY7KpZMg3MW5W+wrMvDM82i/QvZxzcXpjBW ZZyxK47O+O731HrHcwDXrL1JVXN7zyJIeTOjYyeOlwH1/KV12/ByODwYhC1AAK6zk4d9 pB5JN/0ioAchBCFSYc0YZWB0NYmiZbFJ0Awum0NLqt7ycb90XwgFAsvD0LjNJXcq8ISP 5ONQOLsiQ0XMHJqwYYTmo0HlU/Q1Jx1Ospz/BLjIlV7Uw3YZOFoB/ChDML/URomwNpKi 1NuEclvoUscpTxuYtAqNEdeEhibgDGEjpb16yfIgt/KOxBh8K1ZgEvgH+v2qBknjYl58 8xqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TQ1foTVxg+p0Z34hPpUt3AbAs5O+/GOEYxwluwUJ5WI=; b=NF1L4Q7EXlksMc8ci7piSCCP67i9ukwEeZUYFDxBsXdw7R8QfrwBfpT1kDSeX64lrl GnGtuyJdeKbVyavvBSK3oW4wDTmNPJOYJOukYS/7kPjQr3btn4n8gymrm2+yLWZAsWaP euDyYvyv8ARhZefRPLRgXxnM1QCgWwh+Ep4fmjDiDs0Dl+szd4zOLgF5DYpp4oKM430e CyPvhDQyCbl/Nxt1ucEcVcivrL3em4qP4MMYmQbDo7l/cneRMfuQ6JDZLFrS1rbNffKy R47vcUgV5vCcqXiB5xJYKqErk+R+DuDbaVzUAtaIASUUCFbZgsr5QXoPiwzTXPwfATor MzOA== X-Gm-Message-State: APjAAAWe2dTL+U0b54pu6A3ok44UJRnV7FMJR3vHv9TGOt1zBJW/9fm2 GlUcsMAvWSDF9N+6pyr5dF/uWfRu7T4= X-Google-Smtp-Source: APXvYqxaD/TdUM4RZtI9Q0hlLDT+BLOYl7RIgebHP3PMnNqxBWSIytqbTYgFGsY6GLLzy3Tq/GMp7A== X-Received: by 2002:a63:4385:: with SMTP id q127mr13973929pga.404.1581548901028; Wed, 12 Feb 2020 15:08:21 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 15:08:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 12 Feb 2020 15:08:07 -0800 Message-Id: <20200212230810.2837-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200212230810.2837-1-stephen@networkplumber.org> References: <20200212230810.2837-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [RFC 1/4] ring: future proof flag settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_ring/rte_ring.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c index 77e5de099b81..6cd8831649ea 100644 --- a/lib/librte_ring/rte_ring.c +++ b/lib/librte_ring/rte_ring.c @@ -100,6 +100,13 @@ rte_ring_init(struct rte_ring *r, const char *name, unsigned count, RTE_BUILD_BUG_ON((offsetof(struct rte_ring, prod) & RTE_CACHE_LINE_MASK) != 0); + /* future proof flags, only allow supported values */ + if (flags & ~(RING_F_SP_ENQ | RING_F_SC_DEQ)) { + RTE_LOG(ERR, RING, + "Unsupported flags requested %d\n", flags); + return -EINVAL; + } + /* init the ring structure */ memset(r, 0, sizeof(*r)); ret = strlcpy(r->name, name, sizeof(r->name)); From patchwork Wed Feb 12 23:08:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 65776 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52874A0542; Thu, 13 Feb 2020 00:08:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF0311BF8E; Thu, 13 Feb 2020 00:08:27 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by dpdk.org (Postfix) with ESMTP id F1E201BE94 for ; Thu, 13 Feb 2020 00:08:23 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id b35so1852577pgm.13 for ; Wed, 12 Feb 2020 15:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jwFO6sSmu+SCeWP4DmHibzOitYajREV6wKXeSiQbxpQ=; b=PJQB60zD512/Vw0ZwGfoCiedGxgfUVAlGAbDGQb2P2lLhURCykhAeRdQqrtuEp09uA qJHmsUeQAKxDNgeOlLhwnkSUSInqi9CJncHCbefg1bXafex5czQ/cZOHgZ+Jnh/nBw+s 7EDKbB1OBqa7JgVDqGHY6qKETgkgK4cc0vCsRYZC4hiE9pip35yccyb1rJH5P78sia5G EFC/Dw9/tDvk73HdTJysMoqiABK8NQRoQKcSUQh+kjJWb5xrnc2j2lT8yxIZVc+BEild Kgq5xq5bqwy6J3LstBlpPsxBdA9Nm61a/xPn7tsnisnGIEJYyXHVH8K/lBZi873zko2J Ctqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jwFO6sSmu+SCeWP4DmHibzOitYajREV6wKXeSiQbxpQ=; b=Qx4e0B20PyiUrYPajYzimm5TzwxKaxTpeW2s93VMUFYX1JXHT5fzzecAKHAjYyV7da p3dZqw2i6wKYFdkfLsWLB/xsyZaP5F1Swi241ZeJIqX0xX9I2X0P8Y0XVgUAq1BmHQ+F OZapaMlIomnsEUQAIHTqyjj2lVcd/OrN2Cm9PW3aVm9OrSJqC6Wx+Ut7hq4zA5WtlljA 8H26R11y0LK6zgmI6HpCZNy90ii8+45ZetL4E7+mgKqMXl1a+BzyeUWG5gK6+1EvO5p0 e+D4Wdr8veuRsI88lfRgOgJOEniBh8X88K3vnbb6+gEDI/W9/taLGKNMFGyW/roZfBRa 8LXw== X-Gm-Message-State: APjAAAUj5clI53D7ccTf7BNXoEhbbGw9eQLOm6i3Ck7tZE2l3jSFHH5S PRwiIttDlxShqCozIHgpJzOwCqa20cc= X-Google-Smtp-Source: APXvYqyo6voklbtVAh84VTFCh/Kx1Wy7eyuyWaBu5OvhhmllcUX+1iIrdwLMhvAjf0SlCBEPkyNTwQ== X-Received: by 2002:a62:15d8:: with SMTP id 207mr3481415pfv.40.1581548902554; Wed, 12 Feb 2020 15:08:22 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 15:08:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 12 Feb 2020 15:08:08 -0800 Message-Id: <20200212230810.2837-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200212230810.2837-1-stephen@networkplumber.org> References: <20200212230810.2837-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [RFC 2/4] hash: check flags on creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_hash/rte_cuckoo_hash.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index 6af8ca42e94f..ab9cd91b4955 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c @@ -32,6 +32,9 @@ #include "rte_hash.h" #include "rte_cuckoo_hash.h" +/* Mask of all flags supported by this version */ +#define RTE_HASH_EXTRA_FLAGS_MASK 0x2f + #define FOR_EACH_BUCKET(CURRENT_BKT, START_BUCKET) \ for (CURRENT_BKT = START_BUCKET; \ CURRENT_BKT != NULL; \ @@ -164,6 +167,12 @@ rte_hash_create(const struct rte_hash_parameters *params) return NULL; } + if (params->extra_flag & ~RTE_HASH_EXTRA_FLAGS_MASK) { + rte_errno = EINVAL; + RTE_LOG(ERR, HASH, "rte_hash_create: unsupported extra flags\n"); + return NULL; + } + /* Validate correct usage of extra options */ if ((params->extra_flag & RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY) && (params->extra_flag & RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF)) { From patchwork Wed Feb 12 23:08:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 65777 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2333CA0542; Thu, 13 Feb 2020 00:08:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 456791BFA0; Thu, 13 Feb 2020 00:08:29 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 5385F1BE94 for ; Thu, 13 Feb 2020 00:08:25 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id j15so1996941pgm.6 for ; Wed, 12 Feb 2020 15:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2HjE9Fdln2VqbWx5zdMwbDOEwGuLxlBznt/D/+mv+9U=; b=wElqKNNUKsio7pZ8X5OhP9iXIT7WVT+MI13bpz+BcsbFA2a9J7AI1Mb7QsVbmcaduG 0E00veLhnC2+rNRTTZkGq7bJMJXZavp14qFcopniHW+2bqnsCVH8Y1uJ0iYLpxygtGZK ylD3TF4tmxochgX4WuuPwyxmfSoqf85m6aKo5vPVOQXh+Aamcf5/5jp+AjX6Cchc9hxi qWmPk++bJtTlXUipZllG6RZTMTr1T6C6B5qeHjS0Yphhk1wd8zNmPpTWx8P5ZbdPZV/E jBqhBtn/5kThbZtz2vEAn6ZFjWZw+lf9gANVS/pfrRw6FOPmvH48C17Xyoy1S2VXdT98 3H3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2HjE9Fdln2VqbWx5zdMwbDOEwGuLxlBznt/D/+mv+9U=; b=s9Ja7q+lTZ5loMvF6DXs7o973ZSpcQZWmrfni0vdlBlyS0tjpwkf66xiTYKjgNCx4g aSdPBFZSWAAibbBYb3MiNHEhVnJackC7I2QrNt3QIgodujjcf6I0GS2RQpv4HzxrDF0Y EHHeM+q9HF9CdVe91U1C9Ea4/1sqALPiLz9qw8KmQbKxzrKRMR9AIMa4LIWt6q7o8uJM JpStrAWsj3k0ShO4MKQnR9bIIPa1UvFsNrnV7EvmH3VdjM6Mpt2ebm95n4dDq/d/vXO3 jm3Dw9txJUanewUpk5Fcfhm1FOKboBUvhhpPLTPtVq/OPvCb12f8Pvq0HtEpMSvesPFD u0tg== X-Gm-Message-State: APjAAAWZp7ypYraBsTf2H5VWi62ImA5PLgBUWWAZBGZgYk65l/GPMEMZ zpjDioAExMELvDTciYA0k1iVFeWpKsw= X-Google-Smtp-Source: APXvYqymi8eyEthUl0Q0+NiSuy4P6OinDCr768nwl7/ssneB9DnFduEJCFbjiahw0zvDWnOIB9B9Kw== X-Received: by 2002:aa7:8bda:: with SMTP id s26mr10964829pfd.194.1581548903971; Wed, 12 Feb 2020 15:08:23 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 15:08:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 12 Feb 2020 15:08:09 -0800 Message-Id: <20200212230810.2837-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200212230810.2837-1-stephen@networkplumber.org> References: <20200212230810.2837-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [RFC 3/4] stack: check flags on creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_stack/rte_stack.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/librte_stack/rte_stack.c b/lib/librte_stack/rte_stack.c index d19824f00439..4b09ff30d6bd 100644 --- a/lib/librte_stack/rte_stack.c +++ b/lib/librte_stack/rte_stack.c @@ -59,6 +59,11 @@ rte_stack_create(const char *name, unsigned int count, int socket_id, unsigned int sz; int ret; + if (flags & ~(RTE_STACK_F_LF)) { + STACK_LOG_ERR("Unsupported stack flags %#x\n", flags); + return NULL; + } + #ifdef RTE_ARCH_64 RTE_BUILD_BUG_ON(sizeof(struct rte_stack_lf_head) != 16); #else From patchwork Wed Feb 12 23:08:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 65778 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45DBCA0542; Thu, 13 Feb 2020 00:09:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D7021BFAD; Thu, 13 Feb 2020 00:08:31 +0100 (CET) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 8FA961BF76 for ; Thu, 13 Feb 2020 00:08:26 +0100 (CET) Received: by mail-pj1-f66.google.com with SMTP id j17so1531684pjz.3 for ; Wed, 12 Feb 2020 15:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SPNYYAZx0glh7yrtX1B0LIV4voFt/De2gvQJUOke2a4=; b=JvKXHcTW23IV5yPuIJwhHFFFNAanLwvEStI61jVlCWGp5ddVyBnnSHR97Vbo3F3mBW DtqKfIXP/rD0wwiRjFqRcFPOAf1pe4q5jOUO9vlNqpfIoT99Snn8RAEACYkUPZAxXNwE jMxibwlE+nBbus4ga4gaqsFPGamhh8Fr6ZSJc0LMYxIMfwiXvlzoNPA4cgESs2QuvX8F KQyFcSgiA0EW3QPKzQ3auElOZ6pZvdHqlZEXPDgPmU6cPXzxcIqTpwulCBHkKACLySSn Puat93N1tFApj+4a5uV3JHCYQsCwnkIi1+eUwEGVVKR1/ffOXadQ1BlEPLNXyF5TS4q2 fv4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SPNYYAZx0glh7yrtX1B0LIV4voFt/De2gvQJUOke2a4=; b=RUdXvXCIQ0C5aPaVcIwM7KNiKEiPRM6q+SLk8c4byah6BfD4gzRSoC7YNOf2pFk1Jd htHJTU0toNvdJ3HbNYLrnB7eOSYdDm22Drx1Am+9q8P3XTQr+Hmdwp/zZ1TDATln6JD4 Omtkwx+SgO+V/aImgTijtYUzmDuyn0Jhq6dlV9e09o2mky9pI3LjQTTAJMui4MyHEbiV t1womVEjVwZi175CzFXrNGIO3INaTVoNymO3pIaxL0AKiglTznXZkO51xcKaMlrR1E3e QUJQWmooBvmOe1p4S3WVYbYxMAi52Pu9WcBad9v7RvGDjp5VHzEPbKaPzt5JBuD8MwnI jhEQ== X-Gm-Message-State: APjAAAUTmOja3raQBmOASeMYOULII08xuetZt8pbQwGnBTKICgIY6X7x fQ9ycNMjiS9LzmU0IVO76QbvIqpmNq4= X-Google-Smtp-Source: APXvYqxwkn7PHA8/cp7BaOqTdxek5S4lDKfUp4eYxxfwK6BuAv0ycyfZ/L//h3q2HHEqwe8JZF3niA== X-Received: by 2002:a17:90b:3c9:: with SMTP id go9mr1612174pjb.7.1581548905293; Wed, 12 Feb 2020 15:08:25 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 15:08:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 12 Feb 2020 15:08:10 -0800 Message-Id: <20200212230810.2837-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200212230810.2837-1-stephen@networkplumber.org> References: <20200212230810.2837-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [RFC 4/4] cfgfile: check flags value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_cfgfile/rte_cfgfile.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c index 9049fd9c2319..cec82c82ee20 100644 --- a/lib/librte_cfgfile/rte_cfgfile.c +++ b/lib/librte_cfgfile/rte_cfgfile.c @@ -272,6 +272,10 @@ rte_cfgfile_create(int flags) int i; struct rte_cfgfile *cfg; + /* future proof flags usage */ + if (flags & ~(CFG_FLAG_GLOBAL_SECTION | CFG_FLAG_EMPTY_VALUES)) + return NULL; + cfg = malloc(sizeof(*cfg)); if (cfg == NULL)