From patchwork Wed Aug 1 04:07:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chas Williams <3chas3@gmail.com> X-Patchwork-Id: 43496 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19F2A58C4; Wed, 1 Aug 2018 06:07:43 +0200 (CEST) Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id DA2755689 for ; Wed, 1 Aug 2018 06:07:41 +0200 (CEST) Received: by mail-qk0-f195.google.com with SMTP id c192-v6so11809722qkg.12 for ; Tue, 31 Jul 2018 21:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ChE0ddNoc3S3g/7rGLjtfGmCNIiz89H9SvCQtglXcJ4=; b=h4S7gk4ZX/YpWY+dFn88jy8eAhUTngZ9snDqhaIaHj/QtlEe1ZlGsUc8MaYbh9hbRF TuRQjJ+A93tmJuCSNQTLinWLLqaBeILNBp0+VF3pADFx80KSueUn0+TN/rn9ddsE87E/ Imf+r++KN/AxMdmBO0Uf2qGA36CtZWBJHFwBQ2IHjHTT1x7kHeGnOBkTcvWK1uaVFdRV D2FuwFsjdhPE1DcFg1udKtqFAn5zfLmAe6a0O/kUT1aAX1PfzPnhaYTYxOc5+FXmy+yO Y68mMsvZ/7jNtgIoLTWRRGJnuX+3m2Sz4+wUX4Ia/dn/4yRyMXtvjJUXvn/dL6cKfIIx 3pEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ChE0ddNoc3S3g/7rGLjtfGmCNIiz89H9SvCQtglXcJ4=; b=TwN4Ey9R2sjboVI26OBkmpEwipw13nTL+LoFjwo12pWiT04KMZHB8+1ButDlaD2XjY oKdKNSMPvTm7DWfsU/KEUx9pWwY6eBuMolD/iDNVxVvytnahao1bSdEdKavRBrOV8Uwl ePht+sTcV7rZHI2zMv6yxKMvSxObMApIPisRykJPVYoMvvEl+u8YBwkpmmKquvSkIfju hDgjKWm2nLkZdjTlQMk++46ZZ0jAs77y6NMDKNySrgCFWJpwkQxZJ5JkCaj0e7OOsuxz SdpH7iOEYpxcx6wvbTNS9DyuIFoRUmV9bUPth5XwfAH5gOQiPK4Wfv3u/wY9ucDyrjfY Gfnw== X-Gm-Message-State: AOUpUlGzZh9Opio0xJMRYX1dYj4S5Tgfu5E2PrWfEfWhn3rXaorPxnRf WJUhIQH7+s2mTHZzJfKafk/V23L4 X-Google-Smtp-Source: AAOMgpfXndlklzXPZZsCsy5qFbqoITEYusSJY6AtWUSTiHfgUyAoPpVWqnzkO25eYnngZKjATaQ2wQ== X-Received: by 2002:a37:9904:: with SMTP id b4-v6mr22533042qke.102.1533096461174; Tue, 31 Jul 2018 21:07:41 -0700 (PDT) Received: from monolith.fios-router.home (pool-173-79-169-217.washdc.fios.verizon.net. [173.79.169.217]) by smtp.gmail.com with ESMTPSA id i67-v6sm3958172qkd.29.2018.07.31.21.07.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jul 2018 21:07:40 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, "Charles (Chas) Williams" Date: Wed, 1 Aug 2018 00:07:12 -0400 Message-Id: <20180801040712.13792-1-3chas3@gmail.com> X-Mailer: git-send-email 2.14.4 Subject: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Charles (Chas) Williams" From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction Update: Starting from NVM 5.02, if the Set Local LLDP MIB command is received while the DCBx specific agent is stopped, the command returns an EPERM error. If the command is received while the LLDP agent is stopped, it sets the local MIB without exchanging LLDP with peer, and returns SUCCESS. This results in the harmless, but annoying, diagnostic: default dcb config fails. err = -53, aq_err = 1. So, always stop the lldp daemon when we are in software mode before we attempt to call i40e_set_dcb_config. Signed-off-by: Chas Williams --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index a340540ef..03bedf5c1 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -11237,6 +11237,7 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb) * i40e_init_dcb we expect is failure with I40E_AQ_RC_EPERM * adminq status. Otherwise, it should return success. */ + i40e_aq_stop_lldp(hw, TRUE, NULL); if ((ret == I40E_SUCCESS) || (ret != I40E_SUCCESS && hw->aq.asq_last_status == I40E_AQ_RC_EPERM)) { memset(&hw->local_dcbx_config, 0,