From patchwork Wed Feb 5 12:50:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timothy Redaelli X-Patchwork-Id: 65578 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28700A04FA; Wed, 5 Feb 2020 13:51:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F0991C1C7; Wed, 5 Feb 2020 13:51:05 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 768401C1A6 for ; Wed, 5 Feb 2020 13:51:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580907062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NBgpqzYTt76cPObabY39Lkjr1E+Z7xNkl2kHvcdQfZs=; b=B9SJAoLgDqh9b+2oYLUaRINkLYjEjdHRJ+0WhrWoWKN/5Ic4RKr1i8BPKhOE0Etzf3HXxJ G4x98ge58MrrEX+1eKspi47aeYsN05iVJV1iRw2ClhliTr3HO3hSoKYATEOGQmWUJlNYjE /oBILSLTbFzczG9zQl2AsRsyfTOiZiU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-mEFKBy19OfSwSSSKnULggg-1; Wed, 05 Feb 2020 07:50:58 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E7DF801A03; Wed, 5 Feb 2020 12:50:57 +0000 (UTC) Received: from aldebaran.drizzt.lan (dhcp19-189-71.ntdv.lab.eng.bos.redhat.com [10.19.189.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19D7D790C0; Wed, 5 Feb 2020 12:50:55 +0000 (UTC) From: Timothy Redaelli To: dev@dpdk.org Cc: anoobj@marvell.com, stable@dpdk.org Date: Wed, 5 Feb 2020 13:50:41 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: mEFKBy19OfSwSSSKnULggg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton") Cc: anoobj@marvell.com Cc: stable@dpdk.org Signed-off-by: Timothy Redaelli Acked-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev.c | 2 ++ drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +- drivers/crypto/octeontx2/otx2_cryptodev_ops.h | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c index 7fd216bb3..957bcd720 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev.c +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c @@ -24,6 +24,8 @@ int otx2_cpt_logtype; +uint8_t otx2_cryptodev_driver_id; + static struct rte_pci_id pci_id_cpt_table[] = { { RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h b/drivers/crypto/octeontx2/otx2_cryptodev.h index 8e0ebc292..c0aa661b3 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev.h +++ b/drivers/crypto/octeontx2/otx2_cryptodev.h @@ -38,6 +38,6 @@ extern int otx2_cpt_logtype; /* * Crypto device driver ID */ -uint8_t otx2_cryptodev_driver_id; +extern uint8_t otx2_cryptodev_driver_id; #endif /* _OTX2_CRYPTODEV_H_ */ diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h index a2724f722..f83e36b48 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h +++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h @@ -16,6 +16,6 @@ enum otx2_cpt_egrp { OTX2_CPT_EGRP_AE = 2 }; -struct rte_cryptodev_ops otx2_cpt_ops; +extern struct rte_cryptodev_ops otx2_cpt_ops; #endif /* _OTX2_CRYPTODEV_OPS_H_ */ From patchwork Wed Feb 5 12:50:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timothy Redaelli X-Patchwork-Id: 65580 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0050A04FA; Wed, 5 Feb 2020 13:51:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B3EC11C1F6; Wed, 5 Feb 2020 13:51:09 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 5CC4E1C1DB for ; Wed, 5 Feb 2020 13:51:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580907066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HSvXBfsfcl+Zq+uIOYuHy2ChyjOjs+3myOrisqB6Xoo=; b=RyXUYJ+YhMEGzyI9hS0eTH8uNPkuA8CR1S6dfU4RTMKtSCmgOzlB7XxI7MeVTm2AI7hN2u UlRhWH1GQ5FiR1phx6eFe+wryIvTrIkeYVkYKOCiuITohElgrlE8LgXTcCehYLmW4JoCAZ 53QzV35JWODYSaP3qerhQatzDE891q8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-iUeFytDFMrOcgv5poW3xFg-1; Wed, 05 Feb 2020 07:51:00 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ECBD91081FA2; Wed, 5 Feb 2020 12:50:58 +0000 (UTC) Received: from aldebaran.drizzt.lan (dhcp19-189-71.ntdv.lab.eng.bos.redhat.com [10.19.189.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id A744F790C0; Wed, 5 Feb 2020 12:50:57 +0000 (UTC) From: Timothy Redaelli To: dev@dpdk.org Cc: vladimir.medvedkin@intel.com, stable@dpdk.org Date: Wed, 5 Feb 2020 13:50:42 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: iUeFytDFMrOcgv5poW3xFg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 2/3] app/test: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 08e0c7581468 ("test/fib: add performance autotests") Cc: vladimir.medvedkin@intel.com Cc: stable@dpdk.org Signed-off-by: Timothy Redaelli Acked-by: Vladimir Medvedkin --- app/test/test_fib_perf.c | 2 +- app/test/test_lpm_perf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_fib_perf.c b/app/test/test_fib_perf.c index 573087c3c..dd2e54db8 100644 --- a/app/test/test_fib_perf.c +++ b/app/test/test_fib_perf.c @@ -35,7 +35,7 @@ struct route_rule { uint8_t depth; }; -struct route_rule large_route_table[MAX_RULE_NUM]; +static struct route_rule large_route_table[MAX_RULE_NUM]; static uint32_t num_route_entries; #define NUM_ROUTE_ENTRIES num_route_entries diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index a2578fe90..489719c40 100644 --- a/app/test/test_lpm_perf.c +++ b/app/test/test_lpm_perf.c @@ -34,7 +34,7 @@ struct route_rule { uint8_t depth; }; -struct route_rule large_route_table[MAX_RULE_NUM]; +static struct route_rule large_route_table[MAX_RULE_NUM]; static uint32_t num_route_entries; #define NUM_ROUTE_ENTRIES num_route_entries From patchwork Wed Feb 5 12:50:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timothy Redaelli X-Patchwork-Id: 65579 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 794F8A04FA; Wed, 5 Feb 2020 13:51:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B68421C1DB; Wed, 5 Feb 2020 13:51:07 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id C59271C1CB for ; Wed, 5 Feb 2020 13:51:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580907065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fFjtr+IKy/hAZkW90Sh2FjGNVkjpA0sd2oV5iw8jK1Y=; b=LxD1c5nL1aFWlUTUkU3fFxa32wjTWUJTR23NiiUv/SBGl79GpDOt7Wjb6sZIdY2lB5K5Vw Gs+bGiLYZ1hSsxkfJ3cjvGbE/UoI/G8SRpSVU4A+IFuLOw8QZtHb8f6mgTKSOEuGbBpmXt THyhj3gJebJ0Hw0buV7q8xgvTCKympc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-hq4cSgTvNKyYAbMn5bPy8A-1; Wed, 05 Feb 2020 07:51:01 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C22ADBA3; Wed, 5 Feb 2020 12:51:00 +0000 (UTC) Received: from aldebaran.drizzt.lan (dhcp19-189-71.ntdv.lab.eng.bos.redhat.com [10.19.189.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61C1C790C0; Wed, 5 Feb 2020 12:50:59 +0000 (UTC) From: Timothy Redaelli To: dev@dpdk.org Cc: cristian.dumitrescu@intel.com, stable@dpdk.org Date: Wed, 5 Feb 2020 13:50:43 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: hq4cSgTvNKyYAbMn5bPy8A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 3/3] app/test-pipeline: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") Cc: cristian.dumitrescu@intel.com Cc: stable@dpdk.org Signed-off-by: Timothy Redaelli --- app/test-pipeline/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c index 28ac9fcc0..42c6ed9b2 100644 --- a/app/test-pipeline/config.c +++ b/app/test-pipeline/config.c @@ -42,7 +42,7 @@ #include "main.h" -struct app_params app; +extern struct app_params app; static const char usage[] = "\n";