From patchwork Wed Jan 22 17:55:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 65055 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 256CDA0532; Wed, 22 Jan 2020 18:56:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21FB42C6A; Wed, 22 Jan 2020 18:56:10 +0100 (CET) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 9E50F2BBE for ; Wed, 22 Jan 2020 18:56:07 +0100 (CET) Received: by mail-pj1-f66.google.com with SMTP id d15so237848pjw.1 for ; Wed, 22 Jan 2020 09:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x1QWBWesceyiv3X85OwiXQwsGvAqndMrEL4xTvBazsI=; b=l+WBSTkSeK5+H8WXnvAqeQhEcostncohV/lw1vq26YnbjlOmEy5vsnSpBNdQ2bt6Um SatPFLVPLsvVBgmWYQAXJeMYGWxCNOTFW+20ugeoTg1EH82xbPpf6oFgb2gsiQF9URWP s4tLckmEu00MCyOO6CKi8gfbZV96JbQnQ5jd85IQ2fuoDafru8BpyoLMPQhiMjgyKHVO +jnkunDjlbSLJjIOdUzrKzFo77efoWrM5PZ2Xj2JpyDGSEHUVguo4CJN3DiqAPTP3oV0 lCpVOoaBLh/NVjvkAvV0z6YCtirOS4OWUvM70OIUEiJ8x237TkRr2q9HiFoNVqvzsjag YfEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x1QWBWesceyiv3X85OwiXQwsGvAqndMrEL4xTvBazsI=; b=YOGEYy9MSghxkHu2CeB/w3iQs2vuKVPRpzSDTmPoOUJVOH8Bh9MMzKePuMNVP/bkBY W9Vgj4YXiT0FwFTPI2QBR2lywhTIMfqf+wjBZt4iqoX+iQcUf8RRFP7nOSq8BNcJ1xdH tqMJvk8c2vzR7CmqKZFl8EsmzaAyQ4EFDxONwmPcX0+9SKgInN5UijEaOdfc05Hu7QXI fuM/RpgJDpA/SihckTsgy32U3IfCqq21f5voyO21CKpwwXWXeD1HkEww4KHsdMlFH1Tf tGOgsDfYziqkeohy0Hz/KCWXpzkIUB46ps5uZn0Kq9MpkXG2RaaQ09W0Y2m+YJTK/jIx Xlag== X-Gm-Message-State: APjAAAXpIsmlGqZFPpFYcYzhhCIS3eiKpkNIJYvrVlbDNZ+uWvpK7M7Z 0vvmEimw4ZhrK5+ZIWOV+Io0FL1B8ZY= X-Google-Smtp-Source: APXvYqzn+aDSvEfRgeVyCTq22qL1j2PROinFfYNhxHVBEsx+a6isKbbKlV+ismrtQ8ZHuIE0wRLvyw== X-Received: by 2002:a17:902:d918:: with SMTP id c24mr12165617plz.167.1579715766297; Wed, 22 Jan 2020 09:56:06 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a6sm44610667pgg.25.2020.01.22.09.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2020 09:56:05 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ajit.khaparde@broadcom.com, stable@dpdk.org Date: Wed, 22 Jan 2020 09:55:13 -0800 Message-Id: <20200122175514.26213-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200122175514.26213-1-stephen@networkplumber.org> References: <20200122175514.26213-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/2] net/bnxt: do not print error if stats queried before start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When using pktgen lots of unnecessary errors are printed because pktgen queries statistics before device is started. Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type") Cc: ajit.khaparde@broadcom.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_stats.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 20a16a629fb5..65f90e0d8588 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -390,10 +390,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, return rc; memset(bnxt_stats, 0, sizeof(*bnxt_stats)); - if (!(bp->flags & BNXT_FLAG_INIT_DONE)) { - PMD_DRV_LOG(ERR, "Device Initialization not complete!\n"); + if (!(bp->flags & BNXT_FLAG_INIT_DONE)) return -EIO; - } num_q_stats = RTE_MIN(bp->rx_cp_nr_rings, (unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS); From patchwork Wed Jan 22 17:55:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 65056 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 801F6A0532; Wed, 22 Jan 2020 18:56:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FAC1374E; Wed, 22 Jan 2020 18:56:12 +0100 (CET) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id DDDE42BF9 for ; Wed, 22 Jan 2020 18:56:08 +0100 (CET) Received: by mail-pj1-f66.google.com with SMTP id n59so244737pjb.1 for ; Wed, 22 Jan 2020 09:56:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8J/zyeD2Gq4btQllAgF8zGudWOl3g1e8AEVWXT3ytBk=; b=pkALrZ/NawbCd4tvcS6z4G97neDt+O2J3sr3iwtcIoV/0golqRi9hbL0cyunTBet2S 8W2KzrYm/i1fSIDhic3hJh8okGHhDzCR365Mca4KfGvbFw/0zxARWHQ6pGy50Xozfo0X qSMHdeJ6kp9EvA1f9KPM9rkPs95PXRtxkjGaPg7touomwYCXzEyGL+xFRBs1WNA8PZc0 7ffQK/XXXoa+9GvR134N9Ch85RIqI8wwsZ16uyqBb1YSz9egm/X8ACQSiaaqDHdNqMCS FcK4fDkZdTXoXmrwsbQC6+cN1Bx82d/htVM2ONXCmL4VVYaOE7iVXbR5OjS3UMopW3tA eqhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8J/zyeD2Gq4btQllAgF8zGudWOl3g1e8AEVWXT3ytBk=; b=jgql5okJqs8YnlZymo0DwrKfmT4jLygWwosVltKZhXdvZQSen2BIciz5A4GPllzZQh AWp8wFrqeNeATxJZvp7yS/Cf6Fh9ssvF0pqmUj9S/qQ+pxLtcUDXLFULYnwNBbuesOyg P6vsERVaK/GKNhlY1wa/Zc2GU8cljVz0IZCXASU1Ue3LgZtuVH33tFlnOSSnh5zO5hyS hQG7dS5SJjC3Ue6ny2ghKYG++suIfS/nuWiTl0L7eN3qTPIEVwZkQIvk5yiXTygo0O5W NXXD2xgh7dfXYyzOIac9qkZrtS7d4Itkqt8a2t3jAWIHNiPCegygX1S5ruWIQS6RTRvg e7Yw== X-Gm-Message-State: APjAAAUWvsbk6ekvsTIX5+Ix/4zZxbG2BRE+jCBEeEDzeCBNGk8s4Snq 5VN5E2p7WaIXLECWyIv5V7Y4xKg+AWI= X-Google-Smtp-Source: APXvYqw0hmJmrmO9B183bErRF4GlxicRYTRRoFVhhB7xRpwMLJogDh6xvgY9X4nFYHLZdQCX9v1GBw== X-Received: by 2002:a17:902:8c91:: with SMTP id t17mr11108169plo.98.1579715767686; Wed, 22 Jan 2020 09:56:07 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a6sm44610667pgg.25.2020.01.22.09.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2020 09:56:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ajit.khaparde@broadcom.com, stable@dpdk.org Date: Wed, 22 Jan 2020 09:55:14 -0800 Message-Id: <20200122175514.26213-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200122175514.26213-1-stephen@networkplumber.org> References: <20200122175514.26213-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/2] net/bnxt: remove unnecessary memset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_ethdev layer already zeros statistics before calling the device. Fixes: 57d5e5bc86e4 ("net/bnxt: add statistics") Cc: ajit.khaparde@broadcom.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_stats.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 65f90e0d8588..32f112b5ba35 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -389,7 +389,6 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, if (rc) return rc; - memset(bnxt_stats, 0, sizeof(*bnxt_stats)); if (!(bp->flags & BNXT_FLAG_INIT_DONE)) return -EIO;