From patchwork Sun Jul 29 10:43:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 43443 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16DA4374E; Sun, 29 Jul 2018 12:43:38 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 4D2F3343C for ; Sun, 29 Jul 2018 12:43:36 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from shahafs@mellanox.com) with ESMTPS (AES256-SHA encrypted); 29 Jul 2018 13:46:53 +0300 Received: from unicorn01.mtl.labs.mlnx. (unicorn01.mtl.labs.mlnx [10.7.12.62]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w6TAhYsS028857; Sun, 29 Jul 2018 13:43:34 +0300 From: Shahaf Shuler To: yskoh@mellanox.com Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com Date: Sun, 29 Jul 2018 13:43:32 +0300 Message-Id: <20180729104332.154177-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow count action for shared counters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" According to commit fb8fd96d4251 ("ethdev: add shared counter to flow API") the counter id should be taken into account only when the shared flag is set. Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action") Cc: nelio.laranjeiro@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index b94c442ec4..adda4df656 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -490,7 +490,7 @@ mlx5_flow_counter_new(struct rte_eth_dev *dev, uint32_t shared, uint32_t id) struct mlx5_flow_counter *cnt; LIST_FOREACH(cnt, &priv->flow_counters, next) { - if (cnt->shared != shared) + if (!cnt->shared || cnt->shared != shared) continue; if (cnt->id != id) continue;