From patchwork Fri Dec 6 23:52:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 63615 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9CA6A04F3; Sat, 7 Dec 2019 00:53:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D46AF4CA6; Sat, 7 Dec 2019 00:53:02 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 9399323D for ; Sat, 7 Dec 2019 00:52:59 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id c13so2747596pls.0 for ; Fri, 06 Dec 2019 15:52:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i9Hfw4bhMflHum47rvsMqncRCB2OdHgz8zreG2wIUFQ=; b=zVWdPGuYrA31sLtVDELHAJknB3Ao6v6IJFT5oBfSFyHxIPWgvRpjK4f3ArZBD6IMVd EeVgILkzkt8LRfFGVajT86ZUEeyp5UWBe6lAY1uUIiyTD2Nm4HDODXwN8l6L1NNwczZQ JA4r8ybJejuSQiREVDtkaI5Pem7B7yjnNnnZsMqeFsSk0xSgAw4W4AoZOZFIU2wwddzW ea0bY1AxpU8LweHqNbHYX1uXAAc55qhGCPwtNsUBjWYeC9VOKtWnynrXG1eqylR7eJIf 6o8JtB5Hsa2K+jbhPLmoOKGyC8TM0qfmS9c+NBJ08KBz6jCIZCa7hVSiCCjr1fwBaj8W aZuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i9Hfw4bhMflHum47rvsMqncRCB2OdHgz8zreG2wIUFQ=; b=RSYnVUB7CO2HaL3OO69NuQf//Fw+iF4omdwi0J+7/V0Ft16b4pz8xWawMjvptKpbuj 5QvpHBvRscMiYrZLW8AEDl5epuimV+URCy+/cjQ9ZPM+B65PzYhjaUDhWDOpoxySGqIR A0KK/MVWURLO3UKhplb+kSe1iVsEZ1tOeVSBr73MRYhVRTRDPVsrxoBUV5blotmB8kpW OeTj5twJ3E7ZHRUaLvNvSOWdnlWa+pElJzuDyFm3mRzzrK6QOQmuQSKt06q1Qvv5im1V 1CNgs73AkrWNzMjMyB2R0qxEe7Wg+cKcGR1lOARWuGHy2bYNrOyL9gNf6903tROPGyPl J/Rg== X-Gm-Message-State: APjAAAVIAQyEDrBsUlQyon+wohYB0+5LJ66381UWHBBDYqQCNaB9Li1J R0tKKqP3t8yHy0X5IoOYg/e+mR6NkOf/QQ== X-Google-Smtp-Source: APXvYqxKIpZP2C+BRkgNXoU7fNirDXIYL8AHhU/fw7YZ8az1OyniReJghINkb/jkNc/ZLvlTFJ07vQ== X-Received: by 2002:a17:90a:2808:: with SMTP id e8mr18550279pjd.63.1575676378329; Fri, 06 Dec 2019 15:52:58 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k4sm17055855pfa.25.2019.12.06.15.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 15:52:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , pbhagavatula@marvell.com, stable@dpdk.org Date: Fri, 6 Dec 2019 15:52:47 -0800 Message-Id: <20191206235248.24970-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191206235248.24970-1-stephen@networkplumber.org> References: <20191125171300.3284-1-stephen@networkplumber.org> <20191206235248.24970-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/2] net/netvsc: fix RSS offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD with testpmd. The netvsc driver fails during configure step: Configuring Port 1 (socket 0) hn_dev_configure(): unsupported RX offload: 0x80000 Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Cc: pbhagavatula@marvell.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 164e9ad174a7..5ef7a452cc69 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -42,7 +42,8 @@ DEV_TX_OFFLOAD_VLAN_INSERT) #define HN_RX_OFFLOAD_CAPS (DEV_RX_OFFLOAD_CHECKSUM | \ - DEV_RX_OFFLOAD_VLAN_STRIP) + DEV_RX_OFFLOAD_VLAN_STRIP | \ + DEV_RX_OFFLOAD_RSS_HASH) int hn_logtype_init; int hn_logtype_driver; From patchwork Fri Dec 6 23:52:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 63616 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DEE0A04F3; Sat, 7 Dec 2019 00:53:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B45EF1B9B7; Sat, 7 Dec 2019 00:53:05 +0100 (CET) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id 0EB452BE9 for ; Sat, 7 Dec 2019 00:53:01 +0100 (CET) Received: by mail-pj1-f68.google.com with SMTP id r11so3391622pjp.12 for ; Fri, 06 Dec 2019 15:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AuEC2fRC4naJkN9eBNl2eRrz4CKSxbFEQOUkYqoMu+M=; b=WgSdfHN4qmqFt5x/+o7BXD/svqEnj3ueKNeViDpVFNoaxoKlD0hMvgZH4w/2OdHWAu fG6mtbMT5275GGxz61XELmm1zeB55ocOVZ+UIxDFdP6rtwSffyItA5GqiJ6jyHaSnJ4L JeeE/LmBny7/67cQ107tqwVU3mSjwey5p0nUw2imHBSfduypjEpMFPIScgTgCPMJ0Uri LNdmCNVKblwWFsX6wdMfjWyV+5kgpX4B58DLQpY0nr8xpqH+uIeeRGq0iUfoI8ce2Nbe yYPDc2bGZZCcT8csvm8cTi5Y4XS3HNdqljR1wOZfQgP0HLU2BLa0clon6COoMTqEKmao 7GsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AuEC2fRC4naJkN9eBNl2eRrz4CKSxbFEQOUkYqoMu+M=; b=EtHWZPXJ+odmbuO9d9f63yd/YRX0nJ/vxjrvY4xHMkfETfH326VvdviuXW7kV/LhlB MuMIMpyzXwJhV1fCETP6NA55DfCrUtBU5BoUNgcAjUUz1lKLeGx20VHwlKGd0wjvbGGA NVPv7EKygDSF4UEvhWmEYU78vHxeGALjO2p0SCl20uxDZi8rRqFWpPaRG8IJMxa/uxfz wQIb5t8oNf63/SfqW3AnDk+d96/pOtKNxwkHs99y3hrnuEo5yP+pYgeY77zM1hdkoSwR U5rQIpzcPhHzOIcGK+ATTOLHnAKqh2YapzM/lXOCBGHKiVLuIZZ6+B9S5QoGxWBmd3k3 mR/Q== X-Gm-Message-State: APjAAAV/AgTEV3w1MtogXCaHz8aqiCttNrkq+YuYtwNcCxcK+w82nhRM JJnDpEs2Zl9QypQ1zYORs2T2LfQjMAfu9A== X-Google-Smtp-Source: APXvYqzfbvZy+WVARWh9AXlKOw0W+NzxEKA4PgNZ3Dqk+s21VwRjhALVoIzm6d5tZnBqhts4r3edLg== X-Received: by 2002:a17:902:bb8c:: with SMTP id m12mr17719179pls.320.1575676379789; Fri, 06 Dec 2019 15:52:59 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k4sm17055855pfa.25.2019.12.06.15.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 15:52:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Abhishek Marathe , Dexuan Cui Date: Fri, 6 Dec 2019 15:52:48 -0800 Message-Id: <20191206235248.24970-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191206235248.24970-1-stephen@networkplumber.org> References: <20191125171300.3284-1-stephen@networkplumber.org> <20191206235248.24970-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In order to change RSS parameters, the host requires that RSS is disable first. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Cc: stable@dpdk.org Tested-by: Abhishek Marathe Signed-off-by: Dexuan Cui Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 5ef7a452cc69..159116f7f691 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev, hv->rss_ind[i] = reta_conf[idx].reta[shift]; } + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); + if (err) { + PMD_DRV_LOG(NOTICE, + "rss disable failed"); + return err; + } + err = hn_rndis_conf_rss(hv, 0); if (err) { PMD_DRV_LOG(NOTICE, @@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev) return err; } + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); + if (err) { + PMD_DRV_LOG(NOTICE, + "rss disable failed"); + return err; + } + err = hn_rndis_conf_rss(hv, 0); if (err) { PMD_DRV_LOG(NOTICE,