From patchwork Fri Nov 22 06:45:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AMARANATH SOMALAPURAM X-Patchwork-Id: 63219 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68374A04C1; Fri, 22 Nov 2019 07:48:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BAD82C28; Fri, 22 Nov 2019 07:48:45 +0100 (CET) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-eopbgr740079.outbound.protection.outlook.com [40.107.74.79]) by dpdk.org (Postfix) with ESMTP id 631292BF9; Fri, 22 Nov 2019 07:48:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eru6Mu301E0uk09Ikd94N+8nTTGJ9Qun/ukXFivovA9GYtBDTtD9DSVhCocsJjHuh6lEJSaMyamjCy9KswA2bLJc6cQ6XfIVPopj63tcpxRKL1D3UlkEn0KQXHpdsHD4knjMZpqyxV6T2Y01UG68t6j27rrRPIcS8H0hIv4Wt/Anzw7Be+G8IFQxjppmewpjGHL44JpLNK4tvvazRCdOohAPW/gBQdwU0NBlBbbGbUhJO0amC3AK1tO5nehrOrtiz40ixmheE68E8jYPG8u48G8dSlbW4P4yL6d0OPqFs391EzLSNSERRtRfQ7075k2zKtpre8POe3UpGbZblK3T0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21RvIMv38wWagomaWCb6syynajVhHkSl6RgGTlZ75U0=; b=NC+qabQei01t7Qo5tWSFEh+sTQRKFOafSSNBxHFu2rBM6Du24NQKRziM2n4S30vNdix3cgTu4fDXI5Fb5W2b6MMApZBM3Tx2vgtf8QLY3mxYGjUEU+ILNhO3G/v/EDOPo0FUaxM898hUKFfKFqYmZNN8ysdiGpQdBJs7DTFfedItnB+/2kkJwKqmcqfLcTo4vBBKHXW10c8c/R2v5SV/7Yk7YYsOD8sF3p4sLhGSsYYdt19mnFJK7pOBp6e+u4eqOHbFGr/AqLBNHiZKLx0bLNClN992JwDeZBs7s+4bWcNr12/IAIz2PsszL2HKclKQtjzilMJLlU0HaOZIHTwqmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21RvIMv38wWagomaWCb6syynajVhHkSl6RgGTlZ75U0=; b=xnjBJ+Kfu4I+zESOmKZ7giJQ6FelxkHq4Wd4FNLOr2Lfp18DndaAZGyQt2Z4rzqZGMOgCqeJOyxXiH9LcF1wikBvvIWT147aA7I2cG9Yva884lZ0nbNTlJ7JFjyl8ksG5r/6mBkNg+ScSqIiGm7iWPSjjqU0iDtcgzucG3Gr7us= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Amaranath.Somalapuram@amd.com; Received: from DM5PR1201MB2474.namprd12.prod.outlook.com (10.172.87.136) by DM5PR1201MB0171.namprd12.prod.outlook.com (10.174.107.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Fri, 22 Nov 2019 06:48:40 +0000 Received: from DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d]) by DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d%9]) with mapi id 15.20.2451.031; Fri, 22 Nov 2019 06:48:40 +0000 From: asomalap@amd.com To: dev@dpdk.org Cc: stable@dpdk.org Date: Fri, 22 Nov 2019 12:15:45 +0530 Message-Id: <20191122064545.94058-1-asomalap@amd.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: MAXPR01CA0100.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::18) To DM5PR1201MB2474.namprd12.prod.outlook.com (2603:10b6:3:e3::8) MIME-Version: 1.0 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.157.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b31c7835-ce5e-4af3-4239-08d76f18020c X-MS-TrafficTypeDiagnostic: DM5PR1201MB0171: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-Forefront-PRVS: 02296943FF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(189003)(199004)(7736002)(1076003)(66066001)(48376002)(50466002)(186003)(2351001)(2906002)(450100002)(99286004)(66946007)(6436002)(81156014)(66476007)(66556008)(3846002)(36756003)(5660300002)(6116002)(4326008)(316002)(8936002)(2616005)(8676002)(6486002)(6916009)(52116002)(2361001)(26005)(16586007)(6506007)(386003)(51416003)(9686003)(14444005)(81166006)(47776003)(14454004)(478600001)(6512007)(50226002)(25786009)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1201MB0171; H:DM5PR1201MB2474.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S830gQauc1U2ES+xvwViaLPHJZ9ysst5PTZRKHmff6XZ4NesnpHIfDY8TgkwAC7s1p1XjPzrOC7y3nNZlJlstDaa+3hz+nO7EtxmHxVTC+AT8DEEgT6GF37dw+5GIaFl+6yFouutBq5y6jempDSJNFY64v2/kG+nev/NpkQBx6e26pzDwj00Z/VMolZuWq8dluLwKHPq6NLrlCNqWpvChbYDg+kAV2BCdo+xNF1XF1g+Xr9HIFfY/1D//Go6Ie5+dFYtru3AwgMpHoUjDaJ90J/uSQFjDlyw8jiE5ZlY7OoCyD3BHEmlsavfhhOk4inF8Mg19jaAHa7PEYI6CLEm/qNDzaWrWOrGA/92oRKuPtG958b22sld1CVEWkJCSsdZk+U5SxzxiQzlZgaq4Ku1PWV6w4Xv2KAnpaaRI+o0OKZHCtEGOkf5vTEJk8guOYII X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b31c7835-ce5e-4af3-4239-08d76f18020c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2019 06:48:40.5678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +qJJ5EiMwjkTVK7yGnQqUzoL+d53700DqhNF4QOexG03UrT/wuE3I0u6yNVgwDeYLynMAumcAvVC/lkJudtjQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0171 Subject: [dpdk-dev] [PATCH v2 1/5] doc: fix app usage in CCP guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Amaranath Somalapuram Updateing the CCP doc, fixing description of some parameter. Changing AES_CBC to aes-cbc, SHA1_HMAC to sha1-hmac Fixes: 4433ced9aa ("doc: add AMD CCP guide") Cc: stable@dpdk.org Signed-off-by: Amaranath Somalapuram --- doc/guides/cryptodevs/ccp.rst | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/doc/guides/cryptodevs/ccp.rst b/doc/guides/cryptodevs/ccp.rst index 034d20367..a43fe92de 100644 --- a/doc/guides/cryptodevs/ccp.rst +++ b/doc/guides/cryptodevs/ccp.rst @@ -109,14 +109,14 @@ To validate ccp pmd, l2fwd-crypto example can be used with following command: .. code-block:: console - sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev "crypto_ccp" -- -p 0x1 - --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo AES_CBC - --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f - --iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff - --auth_op GENERATE --auth_algo SHA1_HMAC - --auth_key 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 - :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 - :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 + sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev "crypto_ccp" -- -p 0x1 + --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo aes-cbc + --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f + --cipher_iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff + --auth_op GENERATE --auth_algo sha1-hmac + --auth_key 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 The CCP PMD also supports computing authentication over CPU with cipher offloaded to CCP. To enable this feature, pass an additional argument as ccp_auth_opt=1 to --vdev parameters as @@ -124,14 +124,14 @@ following: .. code-block:: console - sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev "crypto_ccp,ccp_auth_opt=1" -- -p 0x1 - --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo AES_CBC - --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f - --iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff - --auth_op GENERATE --auth_algo SHA1_HMAC - --auth_key 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 - :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 - :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 + sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev "crypto_ccp,ccp_auth_opt=1" -- -p 0x1 + --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo aes-cbc + --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f + --cipher_iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff + --auth_op GENERATE --auth_algo sha1-hmac + --auth_key 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 Limitations ----------- From patchwork Fri Nov 22 06:46:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AMARANATH SOMALAPURAM X-Patchwork-Id: 63220 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83D17A04C1; Fri, 22 Nov 2019 07:49:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FB952C2B; Fri, 22 Nov 2019 07:49:15 +0100 (CET) Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730089.outbound.protection.outlook.com [40.107.73.89]) by dpdk.org (Postfix) with ESMTP id 6EC292BF9; Fri, 22 Nov 2019 07:49:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZPVklw1OwNUWHnHNYeybPQo83jts1XFBiIA+ZgEdXW0Mqdelv49qWpjPI4SWCCUDxvJ6LxGj4HByGYPug5xes+OM8ho8MSDKnO9nUT8J/QE2FebDK0Vz+0QldYZFf4J/voJ3HPvcbvkwYFn2x9e3y6/8F7dk4ZSqv2TA17t4e7eruE4VsJ4fIgZkk9tmVwclT8f2yvHZtt5Vq7sKatXMPxA8GPWnrdbHPwKVT99dXcep7YMt4iR8XKq1vsd/TDnnO+kJr0tgF0XdvIR7CNlvUrUH58pFBpEM3jnB7kfHmcRxe7bTebxq46tUlHSl/TRjfkwb5FHLCAOV7df3Cs0bSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zftQ8HGLP3MDbP0UVrBj3qGKlCMEIrk+/Ht8F24cCKE=; b=c6TI5hihDh6LpIJnrvbLR/eescJTpIZp+i8SrRGzZcVVpV2DI+YL3/b4pi4rRi/hHj/OyPQ15T+JBxnn+24ECeQuw0d9kPZLUm3uLUFSsxE7CHQqfGs4yyKYaQ4k6QCKRsOMB9V3OM5N8RdAOVy8Lr0mJPRbC0qV3hCUUpJtB/3+oMOSbuJpaAOQMQ6Zbwbg/ZevtVx9VhZYxrQUUXcfXpsqVouE90Py/DpfHrm6fbWd6AwN2A+Kc4RYXpU0HB0jg3BAj0wg/jad13/34DL13IvuNr8ryEkL/uIAd5jCBNavVXzlb7IYJjJK85HHRtYbErpJNHgmhBviae2SPMafBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zftQ8HGLP3MDbP0UVrBj3qGKlCMEIrk+/Ht8F24cCKE=; b=U6x+2V5BsKxGGjMUXw0DVK81LinNaCm9MlqGvjsm2VE1ETTe1YfCRsOGsS8aYBP58HEIN6/Uuofu+s0Zx9kRwSJx0wQWnhsxV5O4ad6+PDm6IQdXMf/hoHwVrcT+7eZTOyvqJxvKHFCTL/E1/I1Tsen3Q6Cd9UCJ1sj+dcNRvo4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Amaranath.Somalapuram@amd.com; Received: from DM5PR1201MB2474.namprd12.prod.outlook.com (10.172.87.136) by DM5PR1201MB2473.namprd12.prod.outlook.com (10.172.87.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Fri, 22 Nov 2019 06:49:13 +0000 Received: from DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d]) by DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d%9]) with mapi id 15.20.2451.031; Fri, 22 Nov 2019 06:49:13 +0000 From: asomalap@amd.com To: dev@dpdk.org Cc: stable@dpdk.org Date: Fri, 22 Nov 2019 12:16:15 +0530 Message-Id: <20191122064615.94115-1-asomalap@amd.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: MAXPR0101CA0054.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::16) To DM5PR1201MB2474.namprd12.prod.outlook.com (2603:10b6:3:e3::8) MIME-Version: 1.0 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.157.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 599acc6a-7983-4bc2-b74a-08d76f181564 X-MS-TrafficTypeDiagnostic: DM5PR1201MB2473: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:989; X-Forefront-PRVS: 02296943FF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(199004)(189003)(16586007)(316002)(305945005)(81156014)(99286004)(8676002)(7736002)(2361001)(2351001)(2906002)(2616005)(6512007)(3846002)(4326008)(81166006)(450100002)(9686003)(36756003)(6436002)(66066001)(478600001)(47776003)(6116002)(48376002)(6916009)(66476007)(66946007)(186003)(50466002)(66556008)(6506007)(386003)(51416003)(52116002)(1076003)(14454004)(6486002)(5660300002)(4744005)(8936002)(50226002)(25786009)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1201MB2473; H:DM5PR1201MB2474.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v+orjRWNYvuoo4+dlP7Km2f51rR1hRQO/OdB5QL5f0RP5hK0sRbjdKl76ql1S4M8Vw07V7FXKnRMKRSLjR27ECB3QfK3Q4t4We3WHSx/x9THPJsgCdJ4oGmTlre+oKo4Fx5W3r90Q+wcXdXa0rATDNNz9yZxlc6O69NuxTbTBbU0cDHREaX+3UHrDIYlkuCDyYmvMsYPCpWCXhjczzNQm1PYdKevurGUP0wWXEg5VJw/JCsmV1NVnP7WARMDuPEacbK4Vy/j1wBCrczvXoyoi2qkviwMjHQzcJ7+aDbL8r0M2hh1WXHffzif+X+sTfbNvFZiizIMRnXUPp2ZkDfn57PO0Z6QdGzXptJBTOImffcc1fUmzCpOFUVifDKu7J7Js/uQ6ORBUADtEmqSUNF834M5wM70Ip4sTl53sI2e4TAkZSQsXzCtC+WHyskPGKen X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 599acc6a-7983-4bc2-b74a-08d76f181564 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2019 06:49:12.9772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k87Rdml3Ga2sCDzDZ3AINLTtCXgtEt0gv46FzlPJ6bCKUx48SIgLWnuvGPMXjZ0t8nnMBtIvF1zL/q/U0cSPzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2473 Subject: [dpdk-dev] [PATCH v2 2/5] crypto/ccp: fix update max qp and burst size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Amaranath Somalapuram CCP driver crash when running l2fwd issue happen when changing MAX_PKT_BURST 32 to 256 increacing the CCP qp to 8 and CCP_MAX_BURST to 256 Fixes: ef4b04f87f ("crypto/ccp: support device init") Cc: stable@dpdk.org Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp_pmd_private.h b/drivers/crypto/ccp/ccp_pmd_private.h index 7f2979e89..781050c31 100644 --- a/drivers/crypto/ccp/ccp_pmd_private.h +++ b/drivers/crypto/ccp/ccp_pmd_private.h @@ -31,9 +31,9 @@ #endif /**< Maximum queue pairs supported by CCP PMD */ -#define CCP_PMD_MAX_QUEUE_PAIRS 1 +#define CCP_PMD_MAX_QUEUE_PAIRS 8 #define CCP_NB_MAX_DESCRIPTORS 1024 -#define CCP_MAX_BURST 64 +#define CCP_MAX_BURST 256 #include "ccp_dev.h" From patchwork Fri Nov 22 06:46:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AMARANATH SOMALAPURAM X-Patchwork-Id: 63221 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95C63A04C1; Fri, 22 Nov 2019 07:49:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65B4F2C28; Fri, 22 Nov 2019 07:49:46 +0100 (CET) Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730049.outbound.protection.outlook.com [40.107.73.49]) by dpdk.org (Postfix) with ESMTP id F31312BF9; Fri, 22 Nov 2019 07:49:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rm0ZgnfazFO8qRjZGowpvgIlLYa6POEwB+ui+NLA+EOGznwynoGqCxTL0GZ05vgd1xeEbRsVn3OpovuEoCnP5I05TmY/4lHbpHfH/e+uSSG2VybmqfuCNWP5d22AaOkdsfJ6MOsyBFL56HexVGXStu8JrIWfVYZOmGfq/aR9mHBfSvthoeNUjsgChdoxqGNUuGTG0CXd11CSNTJHdqCjS6IXtvq+nZLJ+y7J5fFILaifmycEOGcPfWWxCzsFDhaRCKv4IRlOPlTjP10tK/ucgTLB4uAqjoyrJ1EtH/pg6oTRHtxbeLLB1MsfKnBGoLRCWrfp9WgO0/6pq4Zx32bN5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o0VqOqHHjNelXvQvgV0WOtwXy/0SFjeSnYIzKoAITQY=; b=O6MlxhS2I9Re4PRmkJ5VE91Xj1xIeNOWXSV5CaWWSKC+D4OxvIVAOWAor4v+k4vNvWj465He2KlLY1GjKYE0axtbHqab5ghijJhdvnnDK5+KOwLNK3rXljFXdV+lj14sEeEE/cpVWHzPCs+seGhbw5ktV9TGBEpaPi1zpUVmog3XuknxfE69s1WNotv7AGc4Dw4tp9jpC/wGDhRxLBO0YCzQpzVW/wUY6IHt6W/i8PGWX3RJjODngOXXOvKa5BlSmMnCmjvW9RgndFVIuDZC4H+KvEsTqK/WK71xGexhz2XWyE9otGQkz1XRSI/PD0Fr5E8JgqcpWFan0xL8/2N6wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o0VqOqHHjNelXvQvgV0WOtwXy/0SFjeSnYIzKoAITQY=; b=CfhoaRorWqSke2jayRC/7ZAUERFGtJZP4egI+Cu3Nc0DbLf1jMhaBjLZm3OtglQHC0OpdU/Q6/ZPsQSD3cWvbgmi7ST1XQZ0MZqUjjvcq6SlGFhHuAkBwwzuT7bG81/gNONw0qfGKoGgX+mJUV76wVqkBwKfBv2O9Yr49Txgaws= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Amaranath.Somalapuram@amd.com; Received: from DM5PR1201MB2474.namprd12.prod.outlook.com (10.172.87.136) by DM5PR1201MB2473.namprd12.prod.outlook.com (10.172.87.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Fri, 22 Nov 2019 06:49:44 +0000 Received: from DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d]) by DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d%9]) with mapi id 15.20.2451.031; Fri, 22 Nov 2019 06:49:43 +0000 From: asomalap@amd.com To: dev@dpdk.org Cc: stable@dpdk.org Date: Fri, 22 Nov 2019 12:16:47 +0530 Message-Id: <20191122064647.94171-1-asomalap@amd.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: MAXPR0101CA0062.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::24) To DM5PR1201MB2474.namprd12.prod.outlook.com (2603:10b6:3:e3::8) MIME-Version: 1.0 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.157.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d6043bbc-e848-4edf-2cca-08d76f1827d7 X-MS-TrafficTypeDiagnostic: DM5PR1201MB2473: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:421; X-Forefront-PRVS: 02296943FF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(199004)(189003)(16586007)(316002)(305945005)(81156014)(99286004)(8676002)(7736002)(2361001)(2351001)(2906002)(2616005)(6512007)(3846002)(4326008)(81166006)(450100002)(9686003)(36756003)(6436002)(66066001)(478600001)(47776003)(6116002)(14444005)(48376002)(6916009)(66476007)(66946007)(186003)(50466002)(66556008)(6506007)(386003)(51416003)(52116002)(1076003)(14454004)(6486002)(5660300002)(4744005)(8936002)(50226002)(25786009)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1201MB2473; H:DM5PR1201MB2474.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ORkKALbzWLG5aXIKWEiHA6klCAQ9H1xBHVTL/bBfmsCYRVHnTeEXCG4mGxlPPHNwtMlK3ow7nkMT5rfeZaqpNChIIfW1K/PQX+I374PF09gUsGR+fl2ZhZjHtuBVs9Mc+GO/tjovq1gT3AmKreA3s/Jeup15vJAFN/C0L+Exj9V5DWw/ZjbVzpu1VNby4qhGWxmMV3g8FgrCm/fonlh13/d0BXTu92/DADYWXv4jgO1vAHaoVc90juI9M5MCXxv2jd8gOt5dGy8cE4jpIqH8QiaqvFk5qwsIBbpA5ifTI4ylM4yDaGtSZPrh7VxucPHHDcu1ByWk6cS5Bj9lexfnWEJtKwG71uoA39bjnPQDq3Y17JMqXcUs1W+6ccCrMUXTFKG3+X1qbVVOIRk/RzJicI+1BXYpO/HsWS0QfidPIkqt0xu79gUOuj05Hkk/AMif X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6043bbc-e848-4edf-2cca-08d76f1827d7 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2019 06:49:43.9133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: znuW4QD6puI1YpRLyyrf+eoGH9ROBUIyesBzuS4nQE4Q0CcBJkgo3PNDOMOOVxjr9+xdkYIqCsyMiveKiisutA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2473 Subject: [dpdk-dev] [PATCH v2 3/5] crypto/ccp: fix CCP CPU authentication crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Amaranath Somalapuram when ccp_auth_opt=1 is set and if authentication error occurred ccp driver crash. The enqueue referance count nb_ops miss match with dequeue nb_ops on authentication error Fixes: e0d88a394e ("crypto/ccp: support run-time CPU based auth") Cc: stable@dpdk.org Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644 --- a/drivers/crypto/ccp/ccp_crypto.c +++ b/drivers/crypto/ccp/ccp_crypto.c @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, session, auth_ctx); if (op[i]->status != RTE_CRYPTO_OP_STATUS_SUCCESS) - continue; + CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED"); } else result = ccp_crypto_auth(op[i], cmd_q, b_info); From patchwork Fri Nov 22 06:47:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AMARANATH SOMALAPURAM X-Patchwork-Id: 63222 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A1AEA04C1; Fri, 22 Nov 2019 07:50:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59D272C2B; Fri, 22 Nov 2019 07:50:16 +0100 (CET) Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730048.outbound.protection.outlook.com [40.107.73.48]) by dpdk.org (Postfix) with ESMTP id B17EC2BF9; Fri, 22 Nov 2019 07:50:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enBK7k0LVhYwXzsj5S9EXZ4nhO89ZPYKJ/Jf87IPTd+CLaZ3KnFgNXKt2v7a0vKSy7AhRdndHzCQcwM5VzZKmWuBeC4PDj7kyqVTW2BMPmPPEprO7wk5KU3W9C0KvLIh4B+eIlxaApFw15m6dm2bFIuzwVcbz03iW0o76fMPJkx1xaiqaENCyGtxZGgzZxhRA3OYuMk5Ml9iMiektawXf7ayyevMXM1NdPNzJUKEp1irzcsS16ZboPfWwgW03e1TeJmSHosHH0+CycLUn0AejMZ8xlmwtJgs33gTLhxbiIIkad8A/4filBPneFd1luDw0Oe2GA899ehaJ7y7RPrX/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfEprZooloyjA6GRqGOKdne8aYscgsQ3XUOqiXg0sgw=; b=Lcmnwb8zkWGzWEHYFQ9UH7hs3qmcy0UstOdS7W6GKEpjz7vSf1mOvkWcHh75WzxqKuz9pFvoEwVyPZJtPfqYJtFcqEdr+cRVanackhgDNDO1Mhu4iTRCRiXUgv/oE9fg6rikBki3bfv4WGja2Lkkit3Gx1MuS1O8loyDrH3+D1nDDJiaD8RaK0DmBDuu+YaJSFVy5/gx/khqMDBbHYKuE5/Kwv88vpsUt/kHZlolGH7psP9dVlmLLj5G6Ys0FjP5t279jVvfj3pPPlG6wj5KOlXMNlO21wkqHmbJw1LDjG5XEmqOqY340FTYS8LdETGOL5kLpwK3bL8gqsZsK6/l1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfEprZooloyjA6GRqGOKdne8aYscgsQ3XUOqiXg0sgw=; b=hS5L6+lIJJ3krxPUpDEZmMp5TdytG345MgNoR5hIZ39eQ2VjbQDNlQ9caMx6IABJ1XQ4HK1cZZ/guyh6RBlxM/Lb0Uxi3/velb4jLl9hSPa4zRU7K3SdX20DaJJiSt/dK1XFkAfUW5klZMgiIO2kZKffHpoWUROsxaPd7FjoOGA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Amaranath.Somalapuram@amd.com; Received: from DM5PR1201MB2474.namprd12.prod.outlook.com (10.172.87.136) by DM5PR1201MB2473.namprd12.prod.outlook.com (10.172.87.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Fri, 22 Nov 2019 06:50:13 +0000 Received: from DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d]) by DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d%9]) with mapi id 15.20.2451.031; Fri, 22 Nov 2019 06:50:13 +0000 From: asomalap@amd.com To: dev@dpdk.org Cc: stable@dpdk.org Date: Fri, 22 Nov 2019 12:17:17 +0530 Message-Id: <20191122064717.94223-1-asomalap@amd.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: MAXPR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::30) To DM5PR1201MB2474.namprd12.prod.outlook.com (2603:10b6:3:e3::8) MIME-Version: 1.0 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.157.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5ba81450-a263-46c4-a4ed-08d76f183997 X-MS-TrafficTypeDiagnostic: DM5PR1201MB2473: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-Forefront-PRVS: 02296943FF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(199004)(189003)(16586007)(316002)(305945005)(81156014)(99286004)(8676002)(7736002)(2361001)(2351001)(2906002)(2616005)(6512007)(3846002)(4326008)(81166006)(450100002)(9686003)(36756003)(6436002)(66066001)(478600001)(47776003)(6116002)(48376002)(6916009)(66476007)(66946007)(186003)(50466002)(66556008)(6506007)(386003)(51416003)(52116002)(1076003)(14454004)(6486002)(5660300002)(8936002)(50226002)(25786009)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1201MB2473; H:DM5PR1201MB2474.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PcbRAgVDALHjMDwjiYTUO8rBgMmHBffzcNKtdWd/wG/a2rNV+QoSJnvk2egx945uKvwNDzEim561O7QNhashJCfxw1uRchCMfr1jy1yYcQHnrokqcbsmtjWPjerG36fzI+DzQqx7MoA/05cmZ2gzD2hprkicLfplN4tyzNd3dCTwqdhZbf8d9grmNBEY7mtcaM/W/PBrGQ7jWAwhcKgJqMZEZjzM4r3YmQvHSzl3iEEGncRj8Eqhxbl1YZTumXyc1S6H3Vb/4o1cTFBvPby5jXE5uxY5n4H3edybh7M4Ujb3chgoQesQm6HIzxoZew+bJu8o0MKrQxqrEMILYyn8y+utceDHKaZs3tU6YIkkhmEpxDs4yxBkduMVmS7+ELyBdY5mWj87MQlpforxgQGQGhBQj3TCTRliySwZ80NrD0jo1YBNJ4CQ/eopIbgJ5XA/ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ba81450-a263-46c4-a4ed-08d76f183997 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2019 06:50:13.4441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mmSqtl6OW5mmiz5GS0funfPXHnrSqKMd2ayAHpy1KJ4hktHqBd25n3HFG/6RkK3svoZJEV+01Znmd+Ja9H31eQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2473 Subject: [dpdk-dev] [PATCH v2 4/5] crypto/ccp: fix support scheduling CCP's on burst X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Amaranath Somalapuram CCP driver was scheduling only one CCP in a single burst(enqueue). Effective throughput was limited to 1 CCP performance. Scheduling multiple ccp within one burst will increase the ccp performance. this changes will divide the enqueue packets equally among the multiple CCP Fixes: e0d88a394e ("crypto/ccp: support run-time CPU based auth") Cc: stable@dpdk.org Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_crypto.c | 22 +++++++---- drivers/crypto/ccp/ccp_crypto.h | 7 +++- drivers/crypto/ccp/ccp_dev.h | 2 +- drivers/crypto/ccp/ccp_pmd_private.h | 2 + drivers/crypto/ccp/rte_ccp_pmd.c | 57 +++++++++++++++++++--------- 5 files changed, 63 insertions(+), 27 deletions(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 1837c8543..4256734d1 100644 --- a/drivers/crypto/ccp/ccp_crypto.c +++ b/drivers/crypto/ccp/ccp_crypto.c @@ -2680,7 +2680,9 @@ process_ops_to_enqueue(struct ccp_qp *qp, struct rte_crypto_op **op, struct ccp_queue *cmd_q, uint16_t nb_ops, - int slots_req) + uint16_t total_nb_ops, + int slots_req, + uint16_t b_idx) { int i, result = 0; struct ccp_batch_info *b_info; @@ -2701,6 +2703,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, /* populate batch info necessary for dequeue */ b_info->op_idx = 0; + b_info->b_idx = 0; b_info->lsb_buf_idx = 0; b_info->desccnt = 0; b_info->cmd_q = cmd_q; @@ -2710,7 +2713,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, b_info->head_offset = (uint32_t)(cmd_q->qbase_phys_addr + cmd_q->qidx * Q_DESC_SIZE); - for (i = 0; i < nb_ops; i++) { + for (i = b_idx; i < (nb_ops+b_idx); i++) { session = (struct ccp_session *)get_sym_session_private_data( op[i]->sym->session, ccp_cryptodev_driver_id); @@ -2762,6 +2765,8 @@ process_ops_to_enqueue(struct ccp_qp *qp, } b_info->opcnt = i; + b_info->b_idx = b_idx; + b_info->total_nb_ops = total_nb_ops; b_info->tail_offset = (uint32_t)(cmd_q->qbase_phys_addr + cmd_q->qidx * Q_DESC_SIZE); @@ -2776,7 +2781,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, rte_ring_enqueue(qp->processed_pkts, (void *)b_info); EVP_MD_CTX_destroy(auth_ctx); - return i; + return i-b_idx; } static inline void ccp_auth_dq_prepare(struct rte_crypto_op *op) @@ -2861,8 +2866,8 @@ ccp_prepare_ops(struct ccp_qp *qp, } min_ops = RTE_MIN(nb_ops, b_info->opcnt); - for (i = 0; i < min_ops; i++) { - op_d[i] = b_info->op[b_info->op_idx++]; + for (i = b_info->b_idx; i < min_ops; i++) { + op_d[i] = b_info->op[b_info->b_idx + b_info->op_idx++]; session = (struct ccp_session *)get_sym_session_private_data( op_d[i]->sym->session, ccp_cryptodev_driver_id); @@ -2903,7 +2908,8 @@ ccp_prepare_ops(struct ccp_qp *qp, int process_ops_to_dequeue(struct ccp_qp *qp, struct rte_crypto_op **op, - uint16_t nb_ops) + uint16_t nb_ops, + uint16_t *total_nb_ops) { struct ccp_batch_info *b_info; uint32_t cur_head_offset; @@ -2918,6 +2924,7 @@ process_ops_to_dequeue(struct ccp_qp *qp, if (b_info->auth_ctr == b_info->opcnt) goto success; + *total_nb_ops = b_info->total_nb_ops; cur_head_offset = CCP_READ_REG(b_info->cmd_q->reg_base, CMD_Q_HEAD_LO_BASE); @@ -2927,7 +2934,7 @@ process_ops_to_dequeue(struct ccp_qp *qp, qp->b_info = b_info; return 0; } - } else { + } else if (b_info->tail_offset != b_info->head_offset) { if ((cur_head_offset >= b_info->head_offset) || (cur_head_offset < b_info->tail_offset)) { qp->b_info = b_info; @@ -2937,6 +2944,7 @@ process_ops_to_dequeue(struct ccp_qp *qp, success: + *total_nb_ops = b_info->total_nb_ops; nb_ops = ccp_prepare_ops(qp, op, b_info, nb_ops); rte_atomic64_add(&b_info->cmd_q->free_slots, b_info->desccnt); b_info->desccnt = 0; diff --git a/drivers/crypto/ccp/ccp_crypto.h b/drivers/crypto/ccp/ccp_crypto.h index 882b398ac..8e6d03efc 100644 --- a/drivers/crypto/ccp/ccp_crypto.h +++ b/drivers/crypto/ccp/ccp_crypto.h @@ -353,7 +353,9 @@ int process_ops_to_enqueue(struct ccp_qp *qp, struct rte_crypto_op **op, struct ccp_queue *cmd_q, uint16_t nb_ops, - int slots_req); + uint16_t total_nb_ops, + int slots_req, + uint16_t b_idx); /** * process crypto ops to be dequeued @@ -365,7 +367,8 @@ int process_ops_to_enqueue(struct ccp_qp *qp, */ int process_ops_to_dequeue(struct ccp_qp *qp, struct rte_crypto_op **op, - uint16_t nb_ops); + uint16_t nb_ops, + uint16_t *total_nb_ops); /** diff --git a/drivers/crypto/ccp/ccp_dev.h b/drivers/crypto/ccp/ccp_dev.h index de3e4bcc6..f4ad9eafd 100644 --- a/drivers/crypto/ccp/ccp_dev.h +++ b/drivers/crypto/ccp/ccp_dev.h @@ -59,7 +59,7 @@ #define CMD_Q_RUN 0x1 #define CMD_Q_SIZE 0x1F #define CMD_Q_SHIFT 3 -#define COMMANDS_PER_QUEUE 2048 +#define COMMANDS_PER_QUEUE 8192 #define QUEUE_SIZE_VAL ((ffs(COMMANDS_PER_QUEUE) - 2) & \ CMD_Q_SIZE) diff --git a/drivers/crypto/ccp/ccp_pmd_private.h b/drivers/crypto/ccp/ccp_pmd_private.h index 781050c31..1c4118ee3 100644 --- a/drivers/crypto/ccp/ccp_pmd_private.h +++ b/drivers/crypto/ccp/ccp_pmd_private.h @@ -50,8 +50,10 @@ struct ccp_batch_info { struct rte_crypto_op *op[CCP_MAX_BURST]; /**< optable populated at enque time from app*/ int op_idx; + uint16_t b_idx; struct ccp_queue *cmd_q; uint16_t opcnt; + uint16_t total_nb_ops; /**< no. of crypto ops in batch*/ int desccnt; /**< no. of ccp queue descriptors*/ diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c index 4810d799c..38cb1fe3d 100644 --- a/drivers/crypto/ccp/rte_ccp_pmd.c +++ b/drivers/crypto/ccp/rte_ccp_pmd.c @@ -22,6 +22,7 @@ */ static unsigned int ccp_pmd_init_done; uint8_t ccp_cryptodev_driver_id; +uint8_t cryptodev_cnt; struct ccp_pmd_init_params { struct rte_cryptodev_pmd_init_params def_p; @@ -201,30 +202,46 @@ ccp_pmd_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops, struct ccp_queue *cmd_q; struct rte_cryptodev *dev = qp->dev; uint16_t i, enq_cnt = 0, slots_req = 0; + uint16_t tmp_ops = nb_ops, b_idx, cur_ops = 0; if (nb_ops == 0) return 0; if (unlikely(rte_ring_full(qp->processed_pkts) != 0)) return 0; + if (tmp_ops >= cryptodev_cnt) + cur_ops = nb_ops / cryptodev_cnt + (nb_ops)%cryptodev_cnt; + else + cur_ops = tmp_ops; + while (tmp_ops) { + b_idx = nb_ops - tmp_ops; + slots_req = 0; + if (cur_ops <= tmp_ops) { + tmp_ops -= cur_ops; + } else { + cur_ops = tmp_ops; + tmp_ops = 0; + } + for (i = 0; i < cur_ops; i++) { + sess = get_ccp_session(qp, ops[i + b_idx]); + if (unlikely(sess == NULL) && (i == 0)) { + qp->qp_stats.enqueue_err_count++; + return 0; + } else if (sess == NULL) { + cur_ops = i; + break; + } + slots_req += ccp_compute_slot_count(sess); + } - for (i = 0; i < nb_ops; i++) { - sess = get_ccp_session(qp, ops[i]); - if (unlikely(sess == NULL) && (i == 0)) { - qp->qp_stats.enqueue_err_count++; + cmd_q = ccp_allot_queue(dev, slots_req); + if (unlikely(cmd_q == NULL)) return 0; - } else if (sess == NULL) { - nb_ops = i; - break; - } - slots_req += ccp_compute_slot_count(sess); + enq_cnt += process_ops_to_enqueue(qp, ops, cmd_q, cur_ops, + nb_ops, slots_req, b_idx); + i++; } - cmd_q = ccp_allot_queue(dev, slots_req); - if (unlikely(cmd_q == NULL)) - return 0; - - enq_cnt = process_ops_to_enqueue(qp, ops, cmd_q, nb_ops, slots_req); qp->qp_stats.enqueued_count += enq_cnt; return enq_cnt; } @@ -234,9 +251,16 @@ ccp_pmd_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops, uint16_t nb_ops) { struct ccp_qp *qp = queue_pair; - uint16_t nb_dequeued = 0, i; + uint16_t nb_dequeued = 0, i, total_nb_ops; + + nb_dequeued = process_ops_to_dequeue(qp, ops, nb_ops, &total_nb_ops); - nb_dequeued = process_ops_to_dequeue(qp, ops, nb_ops); + if (total_nb_ops) { + while (nb_dequeued != total_nb_ops) { + nb_dequeued = process_ops_to_dequeue(qp, + ops, nb_ops, &total_nb_ops); + } + } /* Free session if a session-less crypto op */ for (i = 0; i < nb_dequeued; i++) @@ -296,7 +320,6 @@ cryptodev_ccp_create(const char *name, { struct rte_cryptodev *dev; struct ccp_private *internals; - uint8_t cryptodev_cnt = 0; if (init_params->def_p.name[0] == '\0') strlcpy(init_params->def_p.name, name, From patchwork Fri Nov 22 06:47:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AMARANATH SOMALAPURAM X-Patchwork-Id: 63223 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9616A04C1; Fri, 22 Nov 2019 07:50:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC4D258C3; Fri, 22 Nov 2019 07:50:46 +0100 (CET) Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-eopbgr720089.outbound.protection.outlook.com [40.107.72.89]) by dpdk.org (Postfix) with ESMTP id 2E3692BF9; Fri, 22 Nov 2019 07:50:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nel2EvOdntpnmBGQAR2542YGyWsl54nlLebcZiMUTZ0HKt2G0UK651S0qIdqnzAXQtr3NPewr5zGHSMeZeoG0G6iCJeE3+2T3Wte0iwcCurW3SrtVFRHMTGatOuxHXTOvLHhjgndhcFDGLc/fW71y+iGKG0e0UzTcJtHK3eeaedxzAE4fIDm+mABHJ5TadvB47WiCavWRZeqQegcISzlt9bAmwDTo23Q3DGP4QAH247LE6MZHYwqxT5jENXP2G7Mmv2RzpvH+BRIU76gmQcmQdvcJ+LtR63KgS5X3Wn1wWkRajJMVW0gL0zUheGgLFQzKFDOPnQEut/mag3Rc4ZYGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SkJU3q2MV9ADc7zl37YRXOXikUQR9QHayEKF4/lB1qQ=; b=L9YywzeXg2h/AkH1/q/toz3AqQ7YxdY70xD9qTK6dqTRD5pDjGUsQ7B6d/6+g8htRmXVzbN3g04Zea3QHXHDeZI7dv0TdmTT6zuUfgcLwHS2EhehHJmsctvdGgT2Pqr5+clUzz5u/ccfPpHJpgkQ7yl66ik3mmhKVK2Y6etrMthu6AIybLT5wXCYK9yPkH29Sq9TZmgBAdcgIoJ5eFe85sk7p8cJPiZJnUArB3es5IvktqY+2zhSH2bcxZUCERzxy58odS/IhDbUVwgRHLSaXE76yAxd68PUdNx2bFokl+zkGG/IR5fVYn5I7BOZ8LKz1K7PWtB6bglrqinnBrtFfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SkJU3q2MV9ADc7zl37YRXOXikUQR9QHayEKF4/lB1qQ=; b=BsQK3ZYsIOjnvfXiAzNWYB5DqA2HgYq6fmB0T6/vgkXXXL3NgbmxtjLGvT7esxIVQU+My4jaH0Rtp5LJX9TRIJfeLKXNtZESjyXSU9t76bvexEaxys6LyiLQ/WGMhuFME1zkRAnVEHz9QNVAjixt8ZzR6LTsgzXfpzgw+NyDFa0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Amaranath.Somalapuram@amd.com; Received: from DM5PR1201MB2474.namprd12.prod.outlook.com (10.172.87.136) by DM5PR1201MB2473.namprd12.prod.outlook.com (10.172.87.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Fri, 22 Nov 2019 06:50:43 +0000 Received: from DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d]) by DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::3da8:4a0d:72f9:d41d%9]) with mapi id 15.20.2451.031; Fri, 22 Nov 2019 06:50:43 +0000 From: asomalap@amd.com To: dev@dpdk.org Cc: stable@dpdk.org Date: Fri, 22 Nov 2019 12:17:47 +0530 Message-Id: <20191122064747.94276-1-asomalap@amd.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: MAXPR01CA0096.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::14) To DM5PR1201MB2474.namprd12.prod.outlook.com (2603:10b6:3:e3::8) MIME-Version: 1.0 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.157.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a7d6c66c-baf9-4f24-4e59-08d76f184ba3 X-MS-TrafficTypeDiagnostic: DM5PR1201MB2473: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-Forefront-PRVS: 02296943FF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(18543002)(199004)(189003)(16586007)(316002)(305945005)(81156014)(99286004)(8676002)(7736002)(2361001)(2351001)(2906002)(2616005)(6512007)(3846002)(4326008)(81166006)(450100002)(9686003)(36756003)(6436002)(66066001)(478600001)(47776003)(6116002)(48376002)(6916009)(66476007)(66946007)(186003)(50466002)(66556008)(6506007)(386003)(51416003)(52116002)(1076003)(14454004)(6486002)(5660300002)(8936002)(50226002)(25786009)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1201MB2473; H:DM5PR1201MB2474.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q+UrPztKVmZ5QBZClR5Wz/5O9bDAoOZdhY/9B5CUKCScpxxMqyAR3gua0lSWSY+ArtuCRwlzPTgTlntK0BZ686RTKTXgTBszegU5PFwaHeu/Gipec23rfdNV8UUAAFlNMuoInJHmkY53Y7ouRLIsEu33NX4GWxdCsv+1h4YvvolPSIe8IXyayt6l48KCsk6UrMRjgFK37zEnkOJrubTPh0x80PxdoTIAXmWCYOVVbOlIHzblmXSNeg/4hGfDuSujQ80L9tb2I+a8dYB7y+TfxW2Az2kYHEhAlQ/XuwNPq3sIziVgbslTqHrMpUXwGbEO2TV/KHq7zxEBUpSg2V1zCE5ctLAIGoZf5mKDSl+P8dm0aAVCdyGiQf+lm4vCTyrqqiI9eOT/vxDJewONQbHXhJei+wAEteYTpRet3B/GfpPGSQ/WHERDd40nkiU30tmp X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7d6c66c-baf9-4f24-4e59-08d76f184ba3 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2019 06:50:43.7055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 00glsM/rkrp49KSK5U+K4O0fmBq48GZD3StJOlacS/B6zfavRLJ4QbUdc3iQa177vITJt1k1Fa0ahB4NunbKHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2473 Subject: [dpdk-dev] [PATCH v2 5/5] crypto/ccp: fix capabilities for digest size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Amaranath Somalapuram CCP can support varied digest sizes ranging from 1 to some max value But the current code support only fixed max values. This patch updates the minimum digest sizes to 1 Fixes: e0d88a394e ("crypto/ccp: support run-time CPU based auth") Cc: stable@dpdk.org Signed-off-by: Amaranath Somalapuram --- drivers/crypto/ccp/ccp_pmd_ops.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c index d5041f0ec..a19e85ecb 100644 --- a/drivers/crypto/ccp/ccp_pmd_ops.c +++ b/drivers/crypto/ccp/ccp_pmd_ops.c @@ -47,9 +47,9 @@ .increment = 1 \ }, \ .digest_size = { \ - .min = 20, \ + .min = 1, \ .max = 20, \ - .increment = 0 \ + .increment = 1 \ }, \ .aad_size = { 0 } \ }, } \ @@ -89,9 +89,9 @@ .increment = 1 \ }, \ .digest_size = { \ - .min = 28, \ + .min = 1, \ .max = 28, \ - .increment = 0 \ + .increment = 1 \ }, \ .aad_size = { 0 } \ }, } \ @@ -173,9 +173,9 @@ .increment = 1 \ }, \ .digest_size = { \ - .min = 32, \ + .min = 1, \ .max = 32, \ - .increment = 0 \ + .increment = 1 \ }, \ .aad_size = { 0 } \ }, } \ @@ -257,9 +257,9 @@ .increment = 1 \ }, \ .digest_size = { \ - .min = 48, \ + .min = 1, \ .max = 48, \ - .increment = 0 \ + .increment = 1 \ }, \ .aad_size = { 0 } \ }, } \ @@ -341,9 +341,9 @@ .increment = 1 \ }, \ .digest_size = { \ - .min = 64, \ + .min = 1, \ .max = 64, \ - .increment = 0 \ + .increment = 1 \ }, \ .aad_size = { 0 } \ }, } \ @@ -383,9 +383,9 @@ .increment = 1 \ }, \ .digest_size = { \ - .min = 64, \ + .min = 1, \ .max = 64, \ - .increment = 0 \ + .increment = 1 \ }, \ .aad_size = { 0 } \ }, } \ @@ -536,9 +536,9 @@ .increment = 1 \ }, \ .digest_size = { \ - .min = 16, \ + .min = 1, \ .max = 16, \ - .increment = 0 \ + .increment = 1 \ }, \ .aad_size = { 0 } \ }, } \