From patchwork Thu Oct 17 11:51:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Flavia Musatescu X-Patchwork-Id: 61368 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A02A1E975; Thu, 17 Oct 2019 13:51:55 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 347821E969; Thu, 17 Oct 2019 13:51:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2019 04:51:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,307,1566889200"; d="scan'208";a="279855051" Received: from silpixa00389033.ir.intel.com ([10.237.222.179]) by orsmga001.jf.intel.com with ESMTP; 17 Oct 2019 04:51:50 -0700 From: Flavia Musatescu To: dev@dpdk.org, "John W. Linville" Cc: stable@dpdk.org, Flavia Musatescu , ciwillia@brocade.com Date: Thu, 17 Oct 2019 12:51:47 +0100 Message-Id: <1571313107-31794-1-git-send-email-flavia.musatescu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1570728870-26668-1-git-send-email-flavia.musatescu@intel.com> References: <1570728870-26668-1-git-send-email-flavia.musatescu@intel.com> Subject: [dpdk-dev] [PATCH v3] net/af_packet: improve Tx statistics accuracy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When sendto call fails and ENOBUFS/EAGAIN error is being set some of the packets are actually successfully transmitted. There is no available count of those packets, so in order to make the statistics more accurate, all the previously enqueued packets will be considered successful, even though this is not entirely correct. Before: testpmd Tx statistics: TX-packets: 7529062 TX-errors: 3702150 TX-bytes: 451743720 pktgen Rx statistics: Total Rx Pkts: 10700700 After: testpmd TX statistics: TX-packets: 11510625 TX-errors: 0 TX-bytes: 690637500 pktgen Rx statistics: Total Rx Pkts: 10974307 Fixes: 74b7fc0a0ff1 ("net/af_packet: fix packet bytes counting") Cc: ciwillia@brocade.com Cc: stable@dpdk.org Signed-off-by: Flavia Musatescu --- v2: * Changed the comment. v3: * Same applied for EAGAIN error. --- drivers/net/af_packet/rte_eth_af_packet.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 6df09f2..5592626 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -244,8 +244,14 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) } /* kick-off transmits */ - if (sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0) == -1) { - /* error sending -- no packets transmitted */ + if (sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0) == -1 && + errno != ENOBUFS && errno != EAGAIN) { + /* + * In case of a ENOBUFS/EAGAIN error all of the enqueued + * packets will be considered successful even though only some + * are sent. + */ + num_tx = 0; num_tx_bytes = 0; }