From patchwork Tue Aug 13 13:29:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Leroy X-Patchwork-Id: 57662 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D79051BE84; Tue, 13 Aug 2019 15:29:59 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id CCDB01BDAC for ; Tue, 13 Aug 2019 15:29:58 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id p17so107748581wrf.11 for ; Tue, 13 Aug 2019 06:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=from:to:cc:subject:date:message-id; bh=8/AZxTQ8YiGd7zcSV2zLFYZBMjZ/S9tg8QtMn8+RHb8=; b=IKVjcSIUIlwEn7Zy9m433LvtOrdMa4IS/+gBxMGEHcG0mx2kXHjdSLx4OdA61LjPKL CtoXoHD4+yySYae0wBSnbRhCkhl+9xPOxuI6FdCWs/zCYQrWCtbVxtansK/Ioc/1VFmN TR4fCxU0HfBRUthBVlqSpLbjszNtYAHVOeja8jDJ63Ro/W6+xj/odADt4k8vB93GtdGE SYEzjuQyhySpZvj0mBVvpvP3V9f1nFgVzfyNuyK7NmeCqNu4GJ6UgVeH/8LzE1eO/JnQ 2CPsggvi2OCniFuCes62EZ9Kazr1yTr1ZW68JhGuWYL8fd2vsJj4md5XIfL1OvDlybdX r6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8/AZxTQ8YiGd7zcSV2zLFYZBMjZ/S9tg8QtMn8+RHb8=; b=V6CtaGEVbfRS8a+ljiKfSerBvYk7QpFkvODM+zMwr9BrTvl5wUDc/JtDuNF8a8DrVf +BPrR2sYTTynGEX3sSqKvWuvaIopcgQSG5baxkNGXyUciOq82RJwYArlQQZNP0Cf8rWg EJsZiBtrOJafgpPCTo2tMrbnw6AP2akmMzcsj1Ns6VRtmjpjdnDKVXXtuOtKn2TtrFsQ gpPyOB+uBmGL3yBXhI7JvXuDLnac87gJjK4427Me5uSYcFnwMt1Ph8aUl8QUv2S1dKGr nC8HcT/qZJcMA2TF/FTRIT8WLXeGodK1N7H1rFKAxIZ2hgwV87w3Y5qv3y/za8ffe2i2 VsVA== X-Gm-Message-State: APjAAAXgD/eI94i+cpBhXYBbZa096qOF1O2ooPMmX0WAFDAZw2wpQnlu oAl+qoA6vGu2hFffemvGHZGT46lrvns= X-Google-Smtp-Source: APXvYqxWWl9ODeVaZwVsSO3ijEPE4isH3+SYGHpiaURZlIAa9JlXJb4EHqzGxAXNOqAjJryWgheXRg== X-Received: by 2002:adf:a348:: with SMTP id d8mr35529625wrb.235.1565702998332; Tue, 13 Aug 2019 06:29:58 -0700 (PDT) Received: from bolet.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i66sm2429002wmi.11.2019.08.13.06.29.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 06:29:57 -0700 (PDT) From: Maxime Leroy To: dev@dpdk.org Cc: llouis@vmware.com, stable@dpdk.org Date: Tue, 13 Aug 2019 15:29:47 +0200 Message-Id: <20190813132947.13047-1-maxime.leroy@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa. This issue has been introduced with the new Rx offload API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support it. To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from tx/rx offload capa. Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API") Cc: llouis@vmware.com Cc: stable@dpdk.org Signed-off-by: Maxime Leroy Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 57feb377..9cd5eb65 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -44,7 +44,6 @@ #define VMXNET3_TX_OFFLOAD_CAP \ (DEV_TX_OFFLOAD_VLAN_INSERT | \ - DEV_TX_OFFLOAD_IPV4_CKSUM | \ DEV_TX_OFFLOAD_TCP_CKSUM | \ DEV_TX_OFFLOAD_UDP_CKSUM | \ DEV_TX_OFFLOAD_TCP_TSO | \ @@ -54,7 +53,6 @@ (DEV_RX_OFFLOAD_VLAN_STRIP | \ DEV_RX_OFFLOAD_VLAN_FILTER | \ DEV_RX_OFFLOAD_SCATTER | \ - DEV_RX_OFFLOAD_IPV4_CKSUM | \ DEV_RX_OFFLOAD_UDP_CKSUM | \ DEV_RX_OFFLOAD_TCP_CKSUM | \ DEV_RX_OFFLOAD_TCP_LRO | \