From patchwork Wed Jul 31 22:41:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Christensen X-Patchwork-Id: 57339 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 722151BF57; Thu, 1 Aug 2019 00:41:28 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 8D9351BF0A for ; Thu, 1 Aug 2019 00:41:26 +0200 (CEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6VMWorC034868 for ; Wed, 31 Jul 2019 18:41:25 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0a-001b2d01.pphosted.com with ESMTP id 2u3hqan75m-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 31 Jul 2019 18:41:25 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 31 Jul 2019 23:41:23 +0100 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 31 Jul 2019 23:41:22 +0100 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6VMfLns40763834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jul 2019 22:41:21 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 27DA7AE060; Wed, 31 Jul 2019 22:41:21 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D1CC7AE05C; Wed, 31 Jul 2019 22:41:20 +0000 (GMT) Received: from oprom9.localdomain (unknown [9.40.204.34]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 31 Jul 2019 22:41:20 +0000 (GMT) From: David Christensen To: viacheslavo@mellanox.com Cc: dev@dpdk.org, David Christensen Date: Wed, 31 Jul 2019 17:41:11 -0500 X-Mailer: git-send-email 1.8.3.1 X-TM-AS-GCONF: 00 x-cbid: 19073122-0052-0000-0000-000003E713B8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011531; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000287; SDB=6.01240262; UDB=6.00654007; IPR=6.01021682; MB=3.00027986; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-31 22:41:23 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19073122-0053-0000-0000-000061EB002E Message-Id: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-31_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=773 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907310225 Subject: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function mlx5_set_min_inline() includes a switch() that checks various PCI device IDs in order to set the txq_inline_min value. No value is set when the PCI device ID matches the ConnectX-5 adapters, resulting in an assert() failure later in the function mlx5_set_txlimit_params(). This error was encountered on an IBM Power 9 system running RHEL 7.6 w/o Mellanox OFED installed. Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup") Cc: viacheslavo@mellanox.com Signed-off-by: David Christensen Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 3a345c7..0f61dd5 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1341,6 +1341,7 @@ struct mlx5_dev_spawn_data { * and PFC control may be broken, so disable feature. */ config->hw_vlan_insert = 0; + config->txq_inline_min = MLX5_INLINE_HSIZE_NONE; break; default: config->txq_inline_min = MLX5_INLINE_HSIZE_NONE;