From patchwork Tue Jul 16 21:34:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ed Czeck X-Patchwork-Id: 56554 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C013B3798; Tue, 16 Jul 2019 23:34:27 +0200 (CEST) Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by dpdk.org (Postfix) with ESMTP id 6C18F2C18 for ; Tue, 16 Jul 2019 23:34:26 +0200 (CEST) Received: by mail-qt1-f196.google.com with SMTP id l9so21193436qtu.6 for ; Tue, 16 Jul 2019 14:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=GuIewqPX/KmWBP3KmUHoe61qwF4ajgrNmd5hFMRa9Ck=; b=pRJxp2y9kFE3tw0AAjue5fre/ycA+M2hBXOZlt/2M2AJsosQsAH1SvPMNTuHEZ7+zw oSsZ8qdVRIDrBAMinTeIT4PvZx/zZfH8i6XKIUoyV1g4HdWDXybo0VqIs5jNumPzaVIj dHVv+aTaVYM5Gyb7RJZLMQ+FATnXkB+PU6x4i7hwnvKr2EHm2kLltDXOaThQWgLpUbSw otaTi6Rl0aYjnyqeZO8cQtH7cYLnINtv2VNwainfRB5HBHzpCuKJY5azp7B20BoEF/s+ Coldbsh3eb++lCYV0dfWn6mU3kVVTzkHoG1xWQVTLhi8Fvwv9NaFkdcM13KFOslZ27qQ g4/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GuIewqPX/KmWBP3KmUHoe61qwF4ajgrNmd5hFMRa9Ck=; b=npP+k1XkD2EFBiqBUpsw9Tnn36T4aHzoekVMJcaUQ9Uy2YAM+UbS+sf+0lLmI+q5og s1ab3TkEcDmVWY4J4rUzaxUdL0Nw7iYqfRoNqv01wJOXyPT/CmOjxFzRditLeqY/rIgZ OIK7MB3g2jyq/mDCyCmpdUiVweCU5/mQhFEA2jxus4iP6JeB19V0zAN95oQSVhXyTiwk JccsHWGI478AfIdJ1NYZhUu+rpyeKi18SAG/u4VXveEMkcvAw2UpAQiY5XdpT8jAo9Id Fl8w3SyAnpbOozdVhIPfWlrwUa+D1mRvj4KixWgTqmxEcnyCyf5wqFh/qmkMfUTVd/Ha iDlA== X-Gm-Message-State: APjAAAXGYWv2kjenXE4ueC/Jt72L4HiAllFs5vIcKleSWbf+P/Qyqpl5 ab5ZuXlMpm9GjriigIxznvbsiNv3Zmc= X-Google-Smtp-Source: APXvYqybujEWXLxLDTu9wm9MMvxtePterNBLX5itvRYjXQp9+vB6GDwv90EdDytLmRpw6G3Z2/cBSA== X-Received: by 2002:aed:3944:: with SMTP id l62mr25005590qte.34.1563312865598; Tue, 16 Jul 2019 14:34:25 -0700 (PDT) Received: from localhost.localdomain (pool-173-48-129-93.bstnma.fios.verizon.net. [173.48.129.93]) by smtp.gmail.com with ESMTPSA id g10sm9078132qki.37.2019.07.16.14.34.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Jul 2019 14:34:25 -0700 (PDT) From: Ed Czeck To: dev@dpdk.org, ferruh.yigit@intel.com Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com, Ed Czeck , stable@dpdk.org Date: Tue, 16 Jul 2019 17:34:20 -0400 Message-Id: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: c33d45af3633 ("net/ark: add Tx initial version") Cc: stable@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev_rx.c | 4 +--- drivers/net/ark/ark_ethdev_tx.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c index 7de1a98..6156730 100644 --- a/drivers/net/ark/ark_ethdev_rx.c +++ b/drivers/net/ark/ark_ethdev_rx.c @@ -127,9 +127,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, uint32_t i; int status; - /* Future works: divide the Q's evenly with multi-ports */ - int port = dev->data->port_id; - int qidx = port + queue_idx; + int qidx = queue_idx; /* We may already be setup, free memory prior to re-allocation */ if (dev->data->rx_queues[queue_idx] != NULL) { diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c index 1967655..08bcf43 100644 --- a/drivers/net/ark/ark_ethdev_tx.c +++ b/drivers/net/ark/ark_ethdev_tx.c @@ -211,9 +211,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev, struct ark_tx_queue *queue; int status; - /* Future: divide the Q's evenly with multi-ports */ - int port = dev->data->port_id; - int qidx = port + queue_idx; + int qidx = queue_idx; if (!rte_is_power_of_2(nb_desc)) { PMD_DRV_LOG(ERR, From patchwork Tue Jul 16 21:34:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ed Czeck X-Patchwork-Id: 56555 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 479221B953; Tue, 16 Jul 2019 23:34:30 +0200 (CEST) Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by dpdk.org (Postfix) with ESMTP id 83FDB493D for ; Tue, 16 Jul 2019 23:34:28 +0200 (CEST) Received: by mail-qt1-f195.google.com with SMTP id w17so21181890qto.10 for ; Tue, 16 Jul 2019 14:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2tXhOK9qeKfxThegcspNANFYKIVC5SCRHvMbFiPigS8=; b=rSOtctaCBaA82vzudIZqXo8axy8OC0TZUfMpQoRwwaEC66RM8Q+0WgOcpMIiel7i8Z F29mcFMl05IArC5ZOj3Y/JwHymGcaiBFsccoqjsMptnKiydAwdVtzsIAKblJfg2Z+Q8F Du/Y+8kS8ZkDvDgqGOh1whHBz/oPVPDzT/auJtfppHpk/put49m+dKStX/i/szH6//ed jEB9xWXMfD94BmIKJZr5o0WUiIbo2q9Nu3D/4JwEIP6CL9QfDAV0xTzxTTZqIrOZmGrZ O+FzG6TPO8yC3AipwmxFNtbVRqiNnoyE99S92W4D5r7y1Wg1xDdaZVxGVyty2jtdhX1v r2JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2tXhOK9qeKfxThegcspNANFYKIVC5SCRHvMbFiPigS8=; b=E3ITW1GOdDGCvUr1TbXkJlSxA1vU97W8t/XRk+QohsoPjtC8Jev/Dwv2bazsMm7djE s+5eEv4LrLXSg3YwDEh4w9Tw0FW8mkjO1gZBmJjaJU42Mvzb6mM8P7f8dYxFQ263M5/P oNc2uJM1ZwTUcwUcfgl/hXqb+A0G9ezQ9N9G5NsZ+8Ef3bSiAbnPSCf4FXo1IFVr/QBG BRNhNrjaSFD7JKa+6DvOziHXbdcSsy8aDSpf7FdBEQKTbFo39RkRIgaURMSURJykCand /En5ZVANSHdl0jMhrw9/oKABxOiU6XSbenwcBfkuFtkC01q5zc6zXtALocY4Sp0GnHn2 k0NQ== X-Gm-Message-State: APjAAAXq/xEKJapREorjyf7mnlo2U9bYlw1KC+W5nbyLBoPK/zJpZqno wXo24+CklF5pNNq0gBkxcMhxKYKEFBE= X-Google-Smtp-Source: APXvYqzBbR1E+pFdxLQ6ElNXoUzRhEIRpLlETBV6nehtT6vBH6ivqMGT0qeHTvNgAGC21UOfq1+kmQ== X-Received: by 2002:ac8:1b04:: with SMTP id y4mr23929439qtj.389.1563312867544; Tue, 16 Jul 2019 14:34:27 -0700 (PDT) Received: from localhost.localdomain (pool-173-48-129-93.bstnma.fios.verizon.net. [173.48.129.93]) by smtp.gmail.com with ESMTPSA id g10sm9078132qki.37.2019.07.16.14.34.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Jul 2019 14:34:26 -0700 (PDT) From: Ed Czeck To: dev@dpdk.org, ferruh.yigit@intel.com Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com, Ed Czeck Date: Tue, 16 Jul 2019 17:34:21 -0400 Message-Id: <1563312861-26219-2-git-send-email-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com> References: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com> Subject: [dpdk-dev] [PATCH 2/2] net/ark: remove resources when port is close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the resources for the port can be freed by rte_eth_dev_close() Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index 86e500e..3435728 100644 --- a/drivers/net/ark/ark_ethdev.c +++ b/drivers/net/ark/ark_ethdev.c @@ -261,6 +261,8 @@ eth_ark_dev_init(struct rte_eth_dev *dev) /* Use dummy function until setup */ dev->rx_pkt_burst = ð_ark_recv_pkts_noop; dev->tx_pkt_burst = ð_ark_xmit_pkts_noop; + /* Let rte_eth_dev_close() release the port resources */ + dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE; ark->bar0 = (uint8_t *)pci_dev->mem_resource[0].addr; ark->a_bar = (uint8_t *)pci_dev->mem_resource[2].addr; @@ -706,6 +708,9 @@ eth_ark_dev_close(struct rte_eth_dev *dev) eth_ark_dev_rx_queue_release(dev->data->rx_queues[i]); dev->data->rx_queues[i] = 0; } + + rte_free(dev->data->mac_addrs); + dev->data->mac_addrs = 0; } static void