From patchwork Fri Jun 28 13:29:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Iremonger, Bernard" X-Patchwork-Id: 55597 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CE48559A; Fri, 28 Jun 2019 15:29:34 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6E6EB4CA6; Fri, 28 Jun 2019 15:29:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 06:29:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,427,1557212400"; d="scan'208";a="153371711" Received: from sivswdev08.ir.intel.com (HELO localhost.localdomain) ([10.237.217.47]) by orsmga007.jf.intel.com with ESMTP; 28 Jun 2019 06:29:30 -0700 From: Bernard Iremonger To: dev@dpdk.org, konstantin.ananyev@intel.com, akhil.goyal@nxp.com Cc: Bernard Iremonger , stable@dpdk.org Date: Fri, 28 Jun 2019 14:29:21 +0100 Message-Id: <1561728562-11213-2-git-send-email-bernard.iremonger@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1561728562-11213-1-git-send-email-bernard.iremonger@intel.com> References: <1561728562-11213-1-git-send-email-bernard.iremonger@intel.com> Subject: [dpdk-dev] [PATCH 1/2] test/ipsec: fix teardown function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Set freed cop pointers to NULL Set other freed pointers to NULL instead of 0 Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Cc: stable@dpdk.org Signed-off-by: Bernard Iremonger --- app/test/test_ipsec.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index 5389a59..2328342 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test_ipsec.c @@ -451,8 +451,10 @@ ut_teardown(void) for (i = 0; i < BURST_SIZE; i++) { /* free crypto operation structure */ - if (ut_params->cop[i]) + if (ut_params->cop[i]) { rte_crypto_op_free(ut_params->cop[i]); + ut_params->cop[i] = NULL; + } /* * free mbuf - both obuf and ibuf are usually the same, @@ -462,17 +464,17 @@ ut_teardown(void) if (ut_params->obuf[i]) { rte_pktmbuf_free(ut_params->obuf[i]); if (ut_params->ibuf[i] == ut_params->obuf[i]) - ut_params->ibuf[i] = 0; - ut_params->obuf[i] = 0; + ut_params->ibuf[i] = NULL; + ut_params->obuf[i] = NULL; } if (ut_params->ibuf[i]) { rte_pktmbuf_free(ut_params->ibuf[i]); - ut_params->ibuf[i] = 0; + ut_params->ibuf[i] = NULL; } if (ut_params->testbuf[i]) { rte_pktmbuf_free(ut_params->testbuf[i]); - ut_params->testbuf[i] = 0; + ut_params->testbuf[i] = NULL; } } From patchwork Fri Jun 28 13:29:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Iremonger, Bernard" X-Patchwork-Id: 55598 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 804855398; Fri, 28 Jun 2019 15:29:37 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5E36D378E; Fri, 28 Jun 2019 15:29:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 06:29:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,427,1557212400"; d="scan'208";a="153371726" Received: from sivswdev08.ir.intel.com (HELO localhost.localdomain) ([10.237.217.47]) by orsmga007.jf.intel.com with ESMTP; 28 Jun 2019 06:29:34 -0700 From: Bernard Iremonger To: dev@dpdk.org, konstantin.ananyev@intel.com, akhil.goyal@nxp.com Cc: Bernard Iremonger , stable@dpdk.org Date: Fri, 28 Jun 2019 14:29:22 +0100 Message-Id: <1561728562-11213-3-git-send-email-bernard.iremonger@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1561728562-11213-1-git-send-email-bernard.iremonger@intel.com> References: <1561728562-11213-1-git-send-email-bernard.iremonger@intel.com> Subject: [dpdk-dev] [PATCH 2/2] test/ipsec: fix destroy sa function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Call rte_cryptodev_sym_session_clear() function. Cc: stable@dpdk.org Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Signed-off-by: Bernard Iremonger --- app/test/test_ipsec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index 2328342..ea558fd 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test_ipsec.c @@ -1170,9 +1170,11 @@ static void destroy_sa(uint32_t j) { struct ipsec_unitest_params *ut = &unittest_params; + struct ipsec_testsuite_params *ts = &testsuite_params; rte_ipsec_sa_fini(ut->ss[j].sa); rte_free(ut->ss[j].sa); + rte_cryptodev_sym_session_clear(ts->valid_dev, ut->ss[j].crypto.ses); rte_cryptodev_sym_session_free(ut->ss[j].crypto.ses); memset(&ut->ss[j], 0, sizeof(ut->ss[j])); }