From patchwork Mon Jun 3 10:06:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: longtb5@viettel.com.vn X-Patchwork-Id: 54151 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AEAA4D27; Mon, 3 Jun 2019 12:06:24 +0200 (CEST) Received: from mailfilter03.viettel.com.vn (mailfilter03.viettel.com.vn [125.235.240.55]) by dpdk.org (Postfix) with ESMTP id 47FB528F3; Mon, 3 Jun 2019 12:06:20 +0200 (CEST) DomainKey-Signature: s=dmsig1; d=viettel.com.vn; c=simple; q=dns; h=Authentication-Results:X-IronPort-AV:Received:Received: Received:Received:X-Virus-Scanned:Received:Received:To:Cc: Subject:Message-Id:X-Mailer:In-Reply-To:References: MilterAction:Date:From; b=ggzCE+Cclz1RTIvRSvk16Yo5DJqUjP4AYQ4HQ7MtexZGxxTfh+ynRsxg iuhu6U2tXNzOJwAG0+vI2o+1SsqZd4yM60rQFRe1EHEzjDhDxfLhIhJbg k4lZCqVANFQFztqdlGSLAiimsuESv+J8yN1m05lm4F4HRvPG4Q43sPz87 Y5Qw68IpqOb4Pf8DLblK8gR93kWErSozGemX64b/uH27YmESgrD6qvA6q vvyB6p7tJiMIvWLkXoFn1UznnqQDBbAwDMKjUnBTS86jPcuXdLt6cu+MA H0aRt1GMmx1ti1OORspIQTVL38lVV4opb/3d0utWBqC+JaHIK4kzAe2pg w==; DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=viettel.com.vn; s=dkim1; t=1559556382; h=to:cc:subject:message-id:in-reply-to:references:date: from; bh=bY77v1dMnWk5pklqP7FIOcSDY3BpuiJ7o+JUZSeLJNA=; b=o3lbvvCNZ/9QcS6jK1cOBM909iubU5rOAwLZQPZAeHB463fnKrb9sLjS /pzKDRWSChx7sVRWuJt7SErBfro8EwIFOqnuLUpRGgyCbXvyGYTHNR6uN y7q6eOMX2bxjvfsnLjF9Z5irSWrMOKiTYImt52LJBquf0vUQ54xA3eptQ mrfyx1u2Q6xDOEsc9PxHEGwSVOEMp3KHQt9rELerNul8oftgIiy6gta1i nmfb+kkaiJwSwkcnoEX9IcN2vD0e82HnMHY14i5IwU5nouKxz93AIBv92 YLAD7i31LUcD780fSwyMlqhLmYuzfUfMCQBpI9WeC7d6TuYiNgmN6vmo9 A==; Authentication-Results: mailfilter03.viettel.com.vn; spf=Pass smtp.mailfrom=longtb5@viettel.com.vn; dmarc=pass (p=none dis=none) d=viettel.com.vn X-IronPort-AV: E=Sophos;i="5.56,253,1539622800"; d="scan'208";a="143890234" Received: from 125.235.240.44.adsl.viettel.vn (HELO mta1.viettel.com.vn) ([125.235.240.44]) by mailfilter03.viettel.com.vn with ESMTP; 03 Jun 2019 17:06:18 +0700 Received: from localhost (localhost [127.0.0.1]) by mta1.viettel.com.vn (Postfix) with ESMTP id 7A71660CA49; Mon, 3 Jun 2019 17:06:18 +0700 (ICT) Received: from mta1.viettel.com.vn ([127.0.0.1]) by localhost (mta1.viettel.com.vn [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id BP6T4WErZWIL; Mon, 3 Jun 2019 17:06:18 +0700 (ICT) Received: from localhost (localhost [127.0.0.1]) by mta1.viettel.com.vn (Postfix) with ESMTP id 59CF260CA4C; Mon, 3 Jun 2019 17:06:18 +0700 (ICT) X-Virus-Scanned: amavisd-new at Received: from mta1.viettel.com.vn ([127.0.0.1]) by localhost (mta1.viettel.com.vn [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2TfyVgu1MORd; Mon, 3 Jun 2019 17:06:18 +0700 (ICT) Received: from localhost.localdomain (unknown [27.68.241.28]) by mta1.viettel.com.vn (Postfix) with ESMTPSA id 19BED60C9B1; Mon, 3 Jun 2019 17:06:17 +0700 (ICT) To: bruce.richardson@intel.com Cc: dev@dpdk.org, Bao-Long Tran , stable@dpdk.org Message-Id: <1559557107-115815-2-git-send-email-longtb5@viettel.com.vn> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn> References: <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn> MilterAction: FORWARD Date: Mon, 3 Jun 2019 17:06:18 +0700 (ICT) From: longtb5@viettel.com.vn Subject: [dpdk-dev] [PATCH 1/2] examples/l3fwd-vf: remove old Rx/Tx configuration defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The RX and TX Prefetch, Host, and Write-back threshold values are defined but not used anywhere. They are leftovers from a previous patch. Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration") Cc: stable@dpdk.org Signed-off-by: Bao-Long Tran --- examples/l3fwd-vf/main.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c index 0ef469c..5533031 100644 --- a/examples/l3fwd-vf/main.c +++ b/examples/l3fwd-vf/main.c @@ -74,25 +74,6 @@ nb_lcores*MEMPOOL_CACHE_SIZE), \ (unsigned)8192) -/* - * RX and TX Prefetch, Host, and Write-back threshold values should be - * carefully set for optimal performance. Consult the network - * controller's datasheet and supporting DPDK documentation for guidance - * on how these parameters should be set. - */ -#define RX_PTHRESH 8 /**< Default values of RX prefetch threshold reg. */ -#define RX_HTHRESH 8 /**< Default values of RX host threshold reg. */ -#define RX_WTHRESH 4 /**< Default values of RX write-back threshold reg. */ - -/* - * These default values are optimized for use with the Intel(R) 82599 10 GbE - * Controller and the DPDK ixgbe PMD. Consider using other values for other - * network controllers and/or network drivers. - */ -#define TX_PTHRESH 36 /**< Default values of TX prefetch threshold reg. */ -#define TX_HTHRESH 0 /**< Default values of TX host threshold reg. */ -#define TX_WTHRESH 0 /**< Default values of TX write-back threshold reg. */ - #define MAX_PKT_BURST 32 #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ From patchwork Mon Jun 3 10:06:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: longtb5@viettel.com.vn X-Patchwork-Id: 54152 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 735941B952; Mon, 3 Jun 2019 12:06:28 +0200 (CEST) Received: from mailfilter01.viettel.com.vn (mailfilter01.viettel.com.vn [125.235.240.53]) by dpdk.org (Postfix) with ESMTP id 67D551B950; Mon, 3 Jun 2019 12:06:26 +0200 (CEST) DomainKey-Signature: s=dmsig1; d=viettel.com.vn; c=simple; q=dns; h=Authentication-Results:X-IronPort-AV:Received:Received: Received:Received:X-Virus-Scanned:Received:Received:To:Cc: Subject:Message-Id:X-Mailer:In-Reply-To:References: MilterAction:Date:From; b=HcrHHhpAWAS9mpUBx5gaNynHvjrzzqgEQDg5Wn5rCv+R3+jpSzU5v/gm NLkltd7U+18/T/SZrGyNZ4v+5InWmaEM3JiDVfgq1HPI/WHgApUl7lS3u DB5fJ2KHlGfFDqyYmkXLmGhzbVzG7Kl5KmoRIdr2Ga+0t+0zjiF5GZfzd aE8DzInax92lHTl6efLNCpSvqGdoZgIhMh4v95Hx2HZtHiu16Pufzld+P fm2c9cNEy0r+xnZ46kMIPSiXNQfJ7VxM3jqTjiMP11RzkooEVYi5PU8xA bNDg3JeNngUKsHLnZHKV7URxejXaHPFG0Hm5fXBLPotxp3ELaP7sEHlmt Q==; DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=viettel.com.vn; s=dkim1; t=1559556387; h=to:cc:subject:message-id:in-reply-to:references:date: from; bh=n517cYJAGr2dJvQZktLr3xRLySa8LgVEN0osCLQ6h/k=; b=WZGszCtgbdskL28wXc3BbV++uVE5UGMeivIO7QBMMqh3t4CYkSCTu2cd 4+v4I78TfP3UyUGgaz43fV10YVtnh4xr/Qxds2GtK/6G1Oz3LFHN5LEzN 2lHCPYhhkBJZcrzsa9sV3dBDOWS7Tqi8i7DlOPmGhC7upHzllyzBsVZXK GbNmgB4ta1R2ZW+qYWkJXlyNtCXjRcRvarAFPnj8rls+ZRpuaucrPWEYx Fqx3GENDCXDbAu1E8pHryOveJWoPBTBWBk5KRCTPPxsW+36Ri5oh1XwHK /hfE6YLvZMmv7TCmgKTHNUgWrARF2UkH3/kFh+TW188F9KX6tJdhxaRo1 Q==; Authentication-Results: mailfilter01.viettel.com.vn; spf=Pass smtp.mailfrom=longtb5@viettel.com.vn; dmarc=pass (p=none dis=none) d=viettel.com.vn X-IronPort-AV: E=Sophos;i="5.56,253,1539622800"; d="scan'208";a="143348963" Received: from 125.235.240.44.adsl.viettel.vn (HELO mta1.viettel.com.vn) ([125.235.240.44]) by mailfilter01.viettel.com.vn with ESMTP; 03 Jun 2019 17:06:24 +0700 Received: from localhost (localhost [127.0.0.1]) by mta1.viettel.com.vn (Postfix) with ESMTP id 3E69460C9B1; Mon, 3 Jun 2019 17:06:23 +0700 (ICT) Received: from mta1.viettel.com.vn ([127.0.0.1]) by localhost (mta1.viettel.com.vn [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Xcs8LVLtZZII; Mon, 3 Jun 2019 17:06:23 +0700 (ICT) Received: from localhost (localhost [127.0.0.1]) by mta1.viettel.com.vn (Postfix) with ESMTP id 1C48160CA3A; Mon, 3 Jun 2019 17:06:23 +0700 (ICT) X-Virus-Scanned: amavisd-new at Received: from mta1.viettel.com.vn ([127.0.0.1]) by localhost (mta1.viettel.com.vn [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gDpFvb4CGf4p; Mon, 3 Jun 2019 17:06:23 +0700 (ICT) Received: from localhost.localdomain (unknown [27.68.241.28]) by mta1.viettel.com.vn (Postfix) with ESMTPSA id BEAC460C9B1; Mon, 3 Jun 2019 17:06:22 +0700 (ICT) To: bruce.richardson@intel.com Cc: dev@dpdk.org, Bao-Long Tran , stable@dpdk.org Message-Id: <1559557107-115815-3-git-send-email-longtb5@viettel.com.vn> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn> References: <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn> MilterAction: FORWARD Date: Mon, 3 Jun 2019 17:06:23 +0700 (ICT) From: longtb5@viettel.com.vn Subject: [dpdk-dev] [PATCH 2/2] doc: remove old Rx/Tx configuration info in l2fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Update doc the match with code. Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration") Cc: stable@dpdk.org Signed-off-by: Bao-Long Tran --- doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst index bede06e..39d6b00 100644 --- a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst +++ b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst @@ -281,18 +281,6 @@ The list of queues that must be polled for a given lcore is stored in a private The values n_rx_port and rx_port_list[] are used in the main packet processing loop (see :ref:`l2_fwd_app_rx_tx_packets`). -The global configuration for the RX queues is stored in a static structure: - -.. code-block:: c - - static const struct rte_eth_rxconf rx_conf = { - .rx_thresh = { - .pthresh = RX_PTHRESH, - .hthresh = RX_HTHRESH, - .wthresh = RX_WTHRESH, - }, - }; - .. _l2_fwd_app_tx_init: TX Queue Initialization