From patchwork Tue May 28 08:28:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 53722 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C9D7F72; Tue, 28 May 2019 10:28:53 +0200 (CEST) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id C033FA49 for ; Tue, 28 May 2019 10:28:51 +0200 (CEST) Received: by mail-lj1-f195.google.com with SMTP id 14so16847189ljj.5 for ; Tue, 28 May 2019 01:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=I1OEqH87Nx7s9PioH/qAfs3XTfHqzfGt/gb/LbH/NqQ=; b=Xg1sKNVg3GCfXkUJy1IW5kfgGgpKTIzUgONJx1ZNMaisNL3IxjMbqwYwH+d6a1fJHO CZLIG10VdF+QeImiPKB4s7JKYjFHAd5UJSWBb4SWQjp/H82na1S/L9PK1dUi8COz1hfC +f8Uhoi26qhyzJ2+dixcDDVNhnkIbS5xS352fb31nJjBkkx3hD6ZnzpPfNoDFoNGV8Jc zeFp36++Otaj1M+eSyNTe09aoOBISSo/fwku2/4OPfFPSDkjGdaF9WeAKf84nApZTABQ gjoOYyxya7cSjy29igl9FB6P+ltR8wi1PC5J0TQ6cgRbzWo2I4Es6dekntCWU7umv4sG gWEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=I1OEqH87Nx7s9PioH/qAfs3XTfHqzfGt/gb/LbH/NqQ=; b=ZIJ0VYSzmH/OKvZ6i/cJm83UzWdxwGOLuWZM7meJMKEyjre+Hy2uAa9hJlSYqUrX0G 1Wj09bcr5EX1PyPs+MJIepOuds60GxUnIyOZUO5nVnGfHQMzu45aLuzJrOOw6u44rf+G PyC38ZpdXQXFrmI4KywsZbHn4II3m5vVMaltSORzXEbzDdwATmGqvBAdnikEzs50+W9/ 24guoq4pP1U4gnY/Redg69YNkHL7FjrIe6tvrmRWnHyGf5UoMbxcNdVDY6vYHXzajuFF cp1kFIjkavTpAgZZ12PqX2MxLmoQV9mhM1srAJCHi8u7L94uN7TdE9j8AHZI2TvhoaV2 CpTw== X-Gm-Message-State: APjAAAX/I/Hg1M52+6LS4aJL/KBusSoqT6EhkY9FntQL9JX2vBPnW/+e JP52atfxWapjNXdaCStVqDGVILsBApg= X-Google-Smtp-Source: APXvYqyfk/veYaehaWQNU9FJyoOuvpuMeosE871cU4b2UtN1/yfButBrwSbHCdX5Aa0tMDXxpCKJpA== X-Received: by 2002:a2e:5d08:: with SMTP id r8mr8939722ljb.202.1559032131026; Tue, 28 May 2019 01:28:51 -0700 (PDT) Received: from localhost.localdomain (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id r26sm2737260lfa.62.2019.05.28.01.28.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 01:28:49 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: mw@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, Michal Krawczyk Date: Tue, 28 May 2019 10:28:34 +0200 Message-Id: <20190528082834.28697-1-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 Subject: [dpdk-dev] [PATCH] net/ena: update Rx checksum errors on Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rx checksum flags and input errors shouldn't be updated on Tx, as it would work only for packets forwarding. The ierrors statistic should be updated on Rx, right after checking Rx checksum flags if the Rx checksum offload is enabled. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index b6651fc0f..2cc4a169f 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2105,8 +2105,10 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, ena_rx_mbuf_prepare(mbuf_head, &ena_rx_ctx); if (unlikely(mbuf_head->ol_flags & - (PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD))) + (PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD))) { + rte_atomic64_inc(&rx_ring->adapter->drv_stats->ierrors); ++rx_ring->rx_stats.bad_csum; + } mbuf_head->hash.rss = ena_rx_ctx.hash; @@ -2334,10 +2336,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, /* Set TX offloads flags, if applicable */ ena_tx_mbuf_prepare(mbuf, &ena_tx_ctx, tx_ring->offloads); - if (unlikely(mbuf->ol_flags & - (PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD))) - rte_atomic64_inc(&tx_ring->adapter->drv_stats->ierrors); - rte_prefetch0(tx_pkts[(sent_idx + 4) & ring_mask]); /* Process first segment taking into