From patchwork Wed Apr 17 10:09:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akhil Goyal X-Patchwork-Id: 52858 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 782DB1B5EA; Wed, 17 Apr 2019 12:09:29 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80047.outbound.protection.outlook.com [40.107.8.47]) by dpdk.org (Postfix) with ESMTP id C007A1B5D7; Wed, 17 Apr 2019 12:09:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Byf4iucpiyswdpUzioPzYc8XBtQYicixTnWN7pxPB9w=; b=gDeS+SWWoJNTM4/Re54MSbisi54XXYustVeG7dMnt4M2kph2gawsYgdTv1MMtHzQ+G8g5n2j7n7Ot28PpWYhpKi0eGkh86cBoCKPhKwuFX//uI9CSsYmcaZuu3Jt0jxHCHnaVhS796SBx069PoFYK3GyhsNLRhbbaZcfirKGJhE= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB4222.eurprd04.prod.outlook.com (52.134.31.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Wed, 17 Apr 2019 10:09:26 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.021; Wed, 17 Apr 2019 10:09:26 +0000 From: Akhil Goyal To: "dev@dpdk.org" CC: Hemant Agrawal , Akhil Goyal , "stable@dpdk.org" Thread-Topic: [PATCH] drivers/crypto: fix session destroy for dpaa and dpaa2 Thread-Index: AQHU9QWjC8OoNGzgikGiwF1AX4l6LA== Date: Wed, 17 Apr 2019 10:09:26 +0000 Message-ID: <20190417095922.5394-1-akhil.goyal@nxp.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR0101CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::13) To VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:56::26) x-mailer: git-send-email 2.17.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.1.68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6eb3da78-ff0a-4918-b00d-08d6c31cc5bd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB4222; x-ms-traffictypediagnostic: VI1PR04MB4222: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(376002)(346002)(39860400002)(189003)(199004)(6436002)(2501003)(53936002)(54906003)(71190400001)(71200400001)(316002)(386003)(6506007)(4326008)(14454004)(36756003)(186003)(1076003)(8676002)(86362001)(14444005)(25786009)(50226002)(1730700003)(450100002)(8936002)(256004)(305945005)(6486002)(81156014)(81166006)(478600001)(7736002)(68736007)(6116002)(3846002)(5660300002)(5640700003)(476003)(2616005)(44832011)(102836004)(6916009)(66066001)(2906002)(6512007)(486006)(99286004)(106356001)(52116002)(105586002)(2351001)(97736004)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4222; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5y4qltSeWyBY8BeQMj//hEm/LGvUsLRATWN+aR4D2HjERyx8Qyt6rYCGnJaws9vqsz2/OnRgIP+En/SK3cFm0Eh1yc/jwy/IfMMKXn728VQTJlqxtLSdZv/R6sg6yAonTCpZCzPsruyhG1syWQw8kRpdqhufL7b2jKhbaH+KCF7hiyvGD/aEJ1isolHvzblFPMKAE1XeKXJa9WerQsM/+M2QUMYMhfcgdpMPfkW8oCxN9Jit/e1JAOfe1o90M1siTNCulCubyvDG5Wvz3W0se6tMWgV4JeieRPQQX/vbEJexQWCPBX9SwT6gE3dbT88cqFa84ojs3IkZF5ZW6LgXrbg3rAlOSfRiENsEp7v5u1YHJy1Q/JFAG0nNPaOEl/iT7GagLfnf/aZnEy7zkx9wwOIGKkp/EC/voQ2gSeVos3g= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6eb3da78-ff0a-4918-b00d-08d6c31cc5bd X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 10:09:26.6079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4222 Subject: [dpdk-dev] [PATCH] drivers/crypto: fix session destroy for dpaa and dpaa2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 1f14d500bce1 ("crypto/dpaa_sec: support IPsec protocol offload") Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec") Coverity issue: 336798 Cc: stable@dpdk.org Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 5b72b9ee4..0d273bb62 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -2836,7 +2836,7 @@ dpaa2_sec_security_session_destroy(void *dev __rte_unused, rte_free(s->ctxt); rte_free(s->cipher_key.data); rte_free(s->auth_key.data); - memset(sess, 0, sizeof(dpaa2_sec_session)); + memset(s, 0, sizeof(dpaa2_sec_session)); set_sec_session_private_data(sess, NULL); rte_mempool_put(sess_mp, sess_priv); } diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 8305f19a3..d9a7cd8a4 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -2453,7 +2453,7 @@ dpaa_sec_security_session_destroy(void *dev __rte_unused, rte_free(s->cipher_key.data); rte_free(s->auth_key.data); - memset(sess, 0, sizeof(dpaa_sec_session)); + memset(s, 0, sizeof(dpaa_sec_session)); set_sec_session_private_data(sess, NULL); rte_mempool_put(sess_mp, sess_priv); }