From patchwork Thu Mar 7 13:59:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Krakowiak X-Patchwork-Id: 50967 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 200F01B13F; Thu, 7 Mar 2019 15:04:19 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 102B04F94 for ; Thu, 7 Mar 2019 15:04:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 06:04:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="149487365" Received: from lkrakowx-mobl.ger.corp.intel.com (HELO lukas.isw.intel.com) ([10.103.104.102]) by fmsmga002.fm.intel.com with ESMTP; 07 Mar 2019 06:04:14 -0800 From: Lukasz Krakowiak To: david.hunt@intel.com Cc: dev@dpdk.org, Lukasz Krakowiak Date: Thu, 7 Mar 2019 07:59:48 -0600 Message-Id: <20190307135950.30738-2-lukaszx.krakowiak@intel.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190307135950.30738-1-lukaszx.krakowiak@intel.com> References: <20190307135950.30738-1-lukaszx.krakowiak@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/3] test: rename test_power_acpi_cpufreq.c -> app/test/test_power_cpufreq.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch rename file test_power_acpi_cpufreq.c -> app/test/test_power_cpufreq.c. Signed-off-by: Lukasz Krakowiak Acked-by: Anatoly Burakov --- app/test/Makefile | 2 +- app/test/meson.build | 2 +- app/test/{test_power_acpi_cpufreq.c => test_power_cpufreq.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename app/test/{test_power_acpi_cpufreq.c => test_power_cpufreq.c} (100%) diff --git a/app/test/Makefile b/app/test/Makefile index 89949c2bb..d1bcfd456 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -158,7 +158,7 @@ endif SRCS-$(CONFIG_RTE_LIBRTE_METER) += test_meter.c SRCS-$(CONFIG_RTE_LIBRTE_KNI) += test_kni.c -SRCS-$(CONFIG_RTE_LIBRTE_POWER) += test_power.c test_power_acpi_cpufreq.c +SRCS-$(CONFIG_RTE_LIBRTE_POWER) += test_power.c test_power_cpufreq.c SRCS-$(CONFIG_RTE_LIBRTE_POWER) += test_power_kvm_vm.c SRCS-y += test_common.c diff --git a/app/test/meson.build b/app/test/meson.build index 05e5ddeb0..4ae3dffea 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -82,7 +82,7 @@ test_sources = files('commands.c', 'test_pmd_ring.c', 'test_pmd_ring_perf.c', 'test_power.c', - 'test_power_acpi_cpufreq.c', + 'test_power_cpufreq.c', 'test_power_kvm_vm.c', 'test_prefetch.c', 'test_reciprocal_division.c', diff --git a/app/test/test_power_acpi_cpufreq.c b/app/test/test_power_cpufreq.c similarity index 100% rename from app/test/test_power_acpi_cpufreq.c rename to app/test/test_power_cpufreq.c From patchwork Thu Mar 7 13:59:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Krakowiak X-Patchwork-Id: 50968 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C26FA1B150; Thu, 7 Mar 2019 15:04:20 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3F8A95F11 for ; Thu, 7 Mar 2019 15:04:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 06:04:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="149487374" Received: from lkrakowx-mobl.ger.corp.intel.com (HELO lukas.isw.intel.com) ([10.103.104.102]) by fmsmga002.fm.intel.com with ESMTP; 07 Mar 2019 06:04:15 -0800 From: Lukasz Krakowiak To: david.hunt@intel.com Cc: dev@dpdk.org, Lukasz Krakowiak Date: Thu, 7 Mar 2019 07:59:49 -0600 Message-Id: <20190307135950.30738-3-lukaszx.krakowiak@intel.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190307135950.30738-1-lukaszx.krakowiak@intel.com> References: <20190307135950.30738-1-lukaszx.krakowiak@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/3] test: remove prefix _acpi from UT power function/test names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch remove prefix _acpi from power UT function/test names. Signed-off-by: Lukasz Krakowiak Acked-by: Anatoly Burakov --- app/test/autotest_data.py | 4 ++-- app/test/meson.build | 2 +- app/test/test_power_cpufreq.c | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py index 5f87bb94d..c80801b20 100644 --- a/app/test/autotest_data.py +++ b/app/test/autotest_data.py @@ -622,8 +622,8 @@ "Report": None, }, { - "Name": "Power ACPI cpufreq autotest", - "Command": "power_acpi_cpufreq_autotest", + "Name": "Power cpufreq autotest", + "Command": "power_cpufreq_autotest", "Func": default_autotest, "Report": None, }, diff --git a/app/test/meson.build b/app/test/meson.build index 4ae3dffea..a389a2b10 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -205,7 +205,7 @@ fast_non_parallel_test_names = [ 'member_autotest', 'metrics_autotest', 'pdump_autotest', - 'power_acpi_cpufreq_autotest', + 'power_cpufreq_autotest', 'power_autotest', 'power_kvm_vm_autotest', 'reorder_autotest', diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c index 61b1da05a..d099f2f47 100644 --- a/app/test/test_power_cpufreq.c +++ b/app/test/test_power_cpufreq.c @@ -14,14 +14,14 @@ #ifndef RTE_LIBRTE_POWER static int -test_power_acpi_cpufreq(void) +test_power_cpufreq(void) { printf("Power management library not supported, skipping test\n"); return TEST_SKIPPED; } static int -test_power_acpi_caps(void) +test_power_caps(void) { printf("Power management library not supported, skipping test\n"); return TEST_SKIPPED; @@ -367,7 +367,7 @@ check_power_freq_min(void) } static int -test_power_acpi_cpufreq(void) +test_power_cpufreq(void) { int ret = -1; enum power_management_env env; @@ -539,7 +539,7 @@ test_power_acpi_cpufreq(void) } static int -test_power_acpi_caps(void) +test_power_caps(void) { struct rte_power_core_capabilities caps; int ret; @@ -568,5 +568,5 @@ test_power_acpi_caps(void) #endif -REGISTER_TEST_COMMAND(power_acpi_cpufreq_autotest, test_power_acpi_cpufreq); -REGISTER_TEST_COMMAND(power_acpi_caps_autotest, test_power_acpi_caps); +REGISTER_TEST_COMMAND(power_cpufreq_autotest, test_power_cpufreq); +REGISTER_TEST_COMMAND(power_caps_autotest, test_power_caps); From patchwork Thu Mar 7 13:59:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Krakowiak X-Patchwork-Id: 50969 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9E461B19A; Thu, 7 Mar 2019 15:04:21 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7DEEA1B12B for ; Thu, 7 Mar 2019 15:04:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 06:04:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="149487380" Received: from lkrakowx-mobl.ger.corp.intel.com (HELO lukas.isw.intel.com) ([10.103.104.102]) by fmsmga002.fm.intel.com with ESMTP; 07 Mar 2019 06:04:17 -0800 From: Lukasz Krakowiak To: david.hunt@intel.com Cc: dev@dpdk.org, Lukasz Krakowiak Date: Thu, 7 Mar 2019 07:59:50 -0600 Message-Id: <20190307135950.30738-4-lukaszx.krakowiak@intel.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190307135950.30738-1-lukaszx.krakowiak@intel.com> References: <20190307135950.30738-1-lukaszx.krakowiak@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/3] test: add UT for power turbo feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add UT check_power_turbo. Signed-off-by: Lukasz Krakowiak --- app/test/test_power_cpufreq.c | 72 +++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c index d099f2f47..c75c9bf1c 100644 --- a/app/test/test_power_cpufreq.c +++ b/app/test/test_power_cpufreq.c @@ -366,6 +366,59 @@ check_power_freq_min(void) return 0; } +/* Check rte_power_turbo() */ +static int +check_power_turbo(void) +{ + int ret; + + if (rte_power_turbo_status(TEST_POWER_LCORE_ID) == 0) { + printf("Turbo not available on lcore %u, skipping test\n", + TEST_POWER_LCORE_ID); + return 0; + } + + /* test with an invalid lcore id */ + ret = rte_power_freq_enable_turbo(TEST_POWER_LCORE_INVALID); + if (ret >= 0) { + printf("Unexpectedly enable turbo successfully " + "on lcore %u\n", TEST_POWER_LCORE_INVALID); + return -1; + } + ret = rte_power_freq_enable_turbo(TEST_POWER_LCORE_ID); + if (ret < 0) { + printf("Fail to enable turbo on lcore %u\n", + TEST_POWER_LCORE_ID); + return -1; + } + + /* Check the current frequency */ + ret = check_cur_freq(TEST_POWER_LCORE_ID, 0); + if (ret < 0) + return -1; + + /* test with an invalid lcore id */ + ret = rte_power_freq_disable_turbo(TEST_POWER_LCORE_INVALID); + if (ret >= 0) { + printf("Unexpectedly disable turbo successfully " + "on lcore %u\n", TEST_POWER_LCORE_INVALID); + return -1; + } + ret = rte_power_freq_disable_turbo(TEST_POWER_LCORE_ID); + if (ret < 0) { + printf("Fail to disable turbo on lcore %u\n", + TEST_POWER_LCORE_ID); + return -1; + } + + /* Check the current frequency */ + ret = check_cur_freq(TEST_POWER_LCORE_ID, 1); + if (ret < 0) + return -1; + + return 0; +} + static int test_power_cpufreq(void) { @@ -427,6 +480,21 @@ test_power_cpufreq(void) "been initialised\n"); goto fail_all; } + if (rte_power_turbo_status == NULL) { + printf("rte_power_turbo_status should not be NULL, environment has not " + "been initialised\n"); + goto fail_all; + } + if (rte_power_freq_enable_turbo == NULL) { + printf("rte_power_freq_enable_turbo should not be NULL, environment has not " + "been initialised\n"); + goto fail_all; + } + if (rte_power_freq_disable_turbo == NULL) { + printf("rte_power_freq_disable_turbo should not be NULL, environment has not " + "been initialised\n"); + goto fail_all; + } ret = rte_power_exit(TEST_POWER_LCORE_ID); if (ret < 0) { @@ -502,6 +570,10 @@ test_power_cpufreq(void) if (ret < 0) goto fail_all; + ret = check_power_turbo(); + if (ret < 0) + goto fail_all; + ret = rte_power_exit(TEST_POWER_LCORE_ID); if (ret < 0) { printf("Cannot exit power management for lcore %u\n",