From patchwork Sat Mar 2 12:10:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50761 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA007374E; Sat, 2 Mar 2019 13:10:46 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690089.outbound.protection.outlook.com [40.107.69.89]) by dpdk.org (Postfix) with ESMTP id 02808A51 for ; Sat, 2 Mar 2019 13:10:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQAsk+ZDAAOHdZwLJMSuU3VUx8Ns2Jm7xG0pTmL21hM=; b=uzZ53mNN10n8OOQmKwz+dqaYAn4hY8+SZ+tpApJA7yw/m4JWg6ThSiWIwegSKyVxGUbRoEhuaVfAGO8eQaTPe8N+BMPBWGXiz9KyCzN+q/XWxCF5K7aXo7lkEv4LG93k7UGZvuWQBVgpG6+NCEbceZUoFN2d0WkgzP0qV7P7b8U= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:43 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:43 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 01/10] net/atlantic: Fix negative error codes Thread-Index: AQHU0PD1JysLpncqHkmTzbOtSZBhrg== Date: Sat, 2 Mar 2019 12:10:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9408884-da87-4aec-6c31-08d69f0817ed x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:xX1TCgAhjRifdu9TZOYUa9G1vWGKXc3iFhai7i4?= =?iso-8859-1?q?8T5sSDL5udwETjDrr7hprZjXq?= =?iso-8859-1?q?AkjRVI4z90XIeF7/LvOJumdMWsZ4dJ2Ly1AQgwibbw/tiwmHwE+?= =?iso-8859-1?q?iYC2/IQh0QhG8dEPbM9/5Vfa+O19gfOxTv4xYtsCGhZM+X/bxC4?= =?iso-8859-1?q?OclUe4VJChkdxUvLqHqfVtcq0s61uiZCZaroBnisEWRKSrWg/1M?= =?iso-8859-1?q?I6eYelPytU9XuityO/KC57tCwnxb72Hx0QlFKpZOSg0pHZ4iNy3?= =?iso-8859-1?q?Jx8QA1mMqkIB7jFqwtBGGnfeC5t0MzTVmVlWbTf6WBwVIlqT85I?= =?iso-8859-1?q?rRyUksfTjf7jNBsZbGQjMBndSDsPejwdLoxo6JXXGm6q8oL4xX9?= =?iso-8859-1?q?NcT4Cd60zG41sZ9QEDJSMTxGw4y8vHZnUaHmC03hPYVSY2T5uMk?= =?iso-8859-1?q?nvjtxsyhLBxYsmJvY3UJHOSxjvbYEO/c21eSDp1A75hHW8B6bkQ?= =?iso-8859-1?q?EI2T0KrKjY7PSJagESARbicERuoVDtFocvtDhWVTMFVyucwr45f?= =?iso-8859-1?q?VmbRoNWCLNxNDfLnGyBom//UUU2VLJh38DTEBdI24pGkISolMKN?= =?iso-8859-1?q?qt/16cpCj37N0g3ZZp9E3Kqh2RYQkGW15idag3n0SfQR7ehRVNh?= =?iso-8859-1?q?qfDNxANX7arTh6MDE7SCKOES+JzGlRHyPq/aQr2BtA94118Et4H?= =?iso-8859-1?q?1OxsJ+DAfEtuhkW7GnNfSQWqHjThOrZ2sKyLHZhjWUDbkLZ+ae9?= =?iso-8859-1?q?OHWnAXuX32zvdUHduuRdjadDdh+WpNumaj/Y8NmjO0sLlM0EhH5?= =?iso-8859-1?q?PGq/GbgFl0JmXh8oWaThRd81Y/1geKbYR+IAdeHLtaHGE3yFmNI?= =?iso-8859-1?q?HQR+hLDft9h3O0CzLPJvWNjIidgUpqXUDw1fnI/pV4LbJ7GymSB?= =?iso-8859-1?q?AFRaiLw+4TUKw8Tre6cBDAh7Rs9f23NwTBxszku5wOVKk0kf/Mm?= =?iso-8859-1?q?zjoxpPkmNPhqhbEBt4YfBddL0Noqt5EkUjyNP5KJb6Co2hRbtaA?= =?iso-8859-1?q?igpP63gh9BCF76llmn6N0Foc56LL662k1oijTIeRlMTCEkBrSKo?= =?iso-8859-1?q?gibSdmXH3Fi/c7A1pi/3bmxORxH2K5nBfyefFnk6cqrvpm7mL1U?= =?iso-8859-1?q?TKqOYM/bZg6dzj5DudTFqmpz+BvbJAhd+34ykRkxCrsq7/btdd+?= =?iso-8859-1?q?DGFECu0ilIz+AZf6ijmTiPkvwytcN3O7u5k236lyj+tIyTNZFRD?= =?iso-8859-1?q?eYmdroEnujct4a9t/bzQT4AI0yZf5H5cUZwXy2gn1Z8Ohfuw3Lg?= =?iso-8859-1?q?0It8EO7bjVl02Los/Vp15exBKhnThgcupc104Jcqw0z8muwNuek?= =?iso-8859-1?q?Us8PPmc6hHY4EtIeM2EenNMu7676W9XHcXRgLUNPuDSrLZP0U6F?= =?iso-8859-1?q?6yXidDxyjOFwCkHPVRTG/LKLue2RdjN6Tz/slUYxQS5o5gb4=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(4744005)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZiO+sY97tCs1DNZT6Xbd3rC+x27MSCOKSSuGAnVolj3r18wrD/XyU5P7ny6iIganiOGAvV/26o24FaTyy/zVHhnuNoiZcQfhCbLUnEzGopF0dRXLHYR4pV4sOXZgPVhECiW2JqqXY24chTTyl6A+dV20Xj5nxzqQ3r6pyw3btKZJu0SaJVF/59TLtWQswQI8xi4t2E6YNMH5rlviKONqDpGep0zG0IMGLobf0Yc0buFSu3s9EWL7AAv3NGuWMP1cllj6T4kc5XVayQUSjJsvTyz3aavCeYMsoNgKTuBIqpciT5YyxBYD9+J1j1s3CNLNLzMWvJbnorNXHemvN/wTWZ/EyZpf7twSEMKIV5MCFfNHrF65a0/Wd3X45HN1CmpGp8MZAga0WdpqgfkpaOWGrEhJYoa/IBPoCabODcQC2/8= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9408884-da87-4aec-6c31-08d69f0817ed X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:41.8226 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 01/10] net/atlantic: Fix negative error codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index 40c913795..aea58c0d5 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -812,12 +812,12 @@ atl_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, ol_flags = m->ol_flags; if (m->nb_segs > AQ_HW_MAX_SEGS_SIZE) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return i; } if (ol_flags & ATL_TX_OFFLOAD_NOTSUP_MASK) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; } From patchwork Sat Mar 2 12:10:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50762 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 223A337A2; Sat, 2 Mar 2019 13:10:48 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690068.outbound.protection.outlook.com [40.107.69.68]) by dpdk.org (Postfix) with ESMTP id EA5C2378E for ; Sat, 2 Mar 2019 13:10:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=govM9JKoQQ0GwxECuZzjG61uD/7SmfE1UUkoS282cYc=; b=OGWFhf7GT9O7pCh3hQkM4yDdoxYMC2WgGVgfy/XEgWHmtkNJMHaYmo98frXATxc0F0zbfzzYeeogese590c0D3Y4+XOBBpvOadxcni4eww7rzH2kugTmHvUvYqK+vAh3tV0kX4QIgWRinAH0sqqgjeqBEGS+Gf8fuEZjmpPYX6I= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:45 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:45 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 02/10] net/atlantic: remove unused variable Thread-Index: AQHU0PD3YZsNFa5y7EmmN1Nk8NnsXQ== Date: Sat, 2 Mar 2019 12:10:45 +0000 Message-ID: <4a66f0567202115c93ad9fc05755339b756e86dc.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a2f3895-5a1c-4596-6d24-08d69f081933 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:4eF6BlwWdIhvOdbqPDhNYXFy5rnL5HHyNGWIUvC?= =?iso-8859-1?q?Dq+cuamToFMeIGnr7xaMMxjwv?= =?iso-8859-1?q?CjnQ6+wq4yVgOinl6f2AwzvaeA4+iNUc1THoF77kaVIamt2j6if?= =?iso-8859-1?q?zriMizYBGj5aZB6SS7u6ytvHAKYzNngn2qRAaO3P+xMBx7WqwhM?= =?iso-8859-1?q?+rb0Vu8GsOffWP8gyu6rAdjlpzJqVOYIHqFXP82hFfVq3BuQj0e?= =?iso-8859-1?q?Ki/VqshOoYovU0Uar4R9+GbJRQSoFosf0dArLHOD+JU6erLQ0m8?= =?iso-8859-1?q?tTcP5Ld0lYtkiXNSlc/CBS+Cbe0azda+XbyFcYx5KC207loz9qY?= =?iso-8859-1?q?5TIFyAEJB5SHn3elzYX2NdnCSoI+mRCHphNferCKmLdj0510nax?= =?iso-8859-1?q?HyrSXW7jlMmd/xlvfsNgLZHVA/M/5B51xeONAc1FsGHsnoklYUk?= =?iso-8859-1?q?PTB8UDFQTpaMhY/VNaZMHUMU54kH5uoTjLrcjWE24ByBYFVFrIa?= =?iso-8859-1?q?CCWiOfAAgOpTRbOdvCcosCHegEx1gOK9zjOmEHagBCtPBZeQxsb?= =?iso-8859-1?q?cp8nwUPHm2BrVcJusWPtzszbYL7+VqoDBH9c4iHHCJVJrcMh2iD?= =?iso-8859-1?q?iez2xJtCM1emg9XUvbqEBVSCMa1r3LYPByCaSKue0JuWfEDbRTY?= =?iso-8859-1?q?5peealfhUj6EDsaw+RIGRaHqQaXdjaZd1zSKcGYeWRon659P/oY?= =?iso-8859-1?q?rKb9/ab4eGRXfi5dpWVWzLVoQ3mOd84yDpc621i9LPDJ5t9TiYt?= =?iso-8859-1?q?xDypEPTTN43RYggxkngO/crchQlFXnhfk+q/IxJxRycLEZRMbQM?= =?iso-8859-1?q?36Dd0/V0joryhOBIZbYyelPKbhcT0v9zN7/GUlHSEMXKOupA5nQ?= =?iso-8859-1?q?/ke17HF4BHgztKaD2dennd2GVfR/dl46FdRFz8HQtGrynZTyTQf?= =?iso-8859-1?q?RXHQl8L5bMhjzZoABwGirZBDs3932QXUlxlXAZHXWQLvbSYTvAT?= =?iso-8859-1?q?qlMbv1KPs7AgsGeasbNKH4SchmwxwZlwty0231IQVXXpKVEW9iQ?= =?iso-8859-1?q?6y2rmAjlIXth2MsWDdjb9SY4jjtg7eNLS9N8oy3YsRIRTGf7eWq?= =?iso-8859-1?q?aaz9xoeLSlfDiKCKl9XETj06yIcIvrsqNXDEbeScOKZRVOBFE07?= =?iso-8859-1?q?fIDqwpBIknKarwtizBHZ9piMX1wnpEZL3dXZUYP62iBfLXCOJZj?= =?iso-8859-1?q?zNchkrNHJD8AuM8Tw/VDUpFlRB5bFD/f1ca/NCa3O8cQyNqB7rw?= =?iso-8859-1?q?7yTMP64c3X4xm1xze1D27MQftMwJOJhLFWA96x9dQ41gHCAcDQf?= =?iso-8859-1?q?/b8UrqDLus4sEZT8RxE41ezByZ84cFzBFQ92QhmLgibK6XLHqxQ?= =?iso-8859-1?q?csdIeer3I1nAVL66wjM+YR7XBhvmJzSrYNcVzAmBKJemnA62Rb9?= =?iso-8859-1?q?VHQafX/70cNrPDVQjR/ngX/22vA=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: CwXLFHB4Rts4DK3qLUFvGUjanuQTWzJYVGwalhR+CMjh9PaZG2elKMXb2q61YsQ501nE0cCMD4qzCIbKUwdnt0XmtI5GrrNsMW4hU6iwxVOxUmom8vyfz63yame1DgPutx80XQrHILiKJt0is7R986bIsTrn4vlQ7TZTjYsvZKqEqUfh4nNofpBmk33v6uANn7N7RX4WY6yUUcHG9DRKqZ83UDHMN2LEZs0YzkHHFBIYrwlwgMsTA6ij/WKaqOsHoJREZmUHPPaSw/aOUWqmHvVL1X6kk22+OzvNdmOASKoWuOkt8XyC6E7f7SuePGA8R64n3HIC4ksRTxaWE4p8PYl5K9MrRnGajoa65OmEsmyLQtMZqXrkhGh02BQIyJHn0FrZiCg9vSjGmWRNctXBmcrr+Vfz8qfBXiwhOkh3dEo= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a2f3895-5a1c-4596-6d24-08d69f081933 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:43.9271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 02/10] net/atlantic: remove unused variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found by coverity scan Signed-off-by: Igor Russkikh Reviewed-by: Rami Rosen --- drivers/net/atlantic/hw_atl/hw_atl_b0.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/atlantic/hw_atl/hw_atl_b0.c index 9400e0edb..53fd8e9f0 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_b0.c @@ -31,7 +31,6 @@ static int hw_atl_b0_hw_qos_set(struct aq_hw_s *self) u32 tc = 0U; u32 buff_size = 0U; unsigned int i_priority = 0U; - bool is_rx_flow_control = false; /* TPS Descriptor rate init */ hw_atl_tps_tx_pkt_shed_desc_rate_curr_time_res_set(self, 0x0U); @@ -64,7 +63,6 @@ static int hw_atl_b0_hw_qos_set(struct aq_hw_s *self) /* QoS Rx buf size per TC */ tc = 0; - is_rx_flow_control = 0; buff_size = HW_ATL_B0_RXBUF_MAX; hw_atl_rpb_rx_pkt_buff_size_per_tc_set(self, buff_size, tc); @@ -76,9 +74,7 @@ static int hw_atl_b0_hw_qos_set(struct aq_hw_s *self) (buff_size * (1024U / 32U) * 50U) / 100U, tc); - hw_atl_rpb_rx_xoff_en_per_tc_set(self, - is_rx_flow_control ? 1U : 0U, - tc); + hw_atl_rpb_rx_xoff_en_per_tc_set(self, 0U, tc); /* QoS 802.1p priority -> TC mapping */ for (i_priority = 8U; i_priority--;) From patchwork Sat Mar 2 12:10:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50763 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F24644BE; Sat, 2 Mar 2019 13:10:50 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690081.outbound.protection.outlook.com [40.107.69.81]) by dpdk.org (Postfix) with ESMTP id DD93E44BE for ; Sat, 2 Mar 2019 13:10:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7KPM4IQ2UuAZe5+7IiT/w275YDyDn+HzWcvY1nxfA20=; b=bBywtNUCvxVzAdefYkGDdLSDSnRwHNfOmMKmkz32CA5Amjgp5jpQZ1WymJPHNCYvrS6ja5T6Iyf0q6EjeIXQq9xmYb7N8JQ7jMHwJ8C0HNA2PiiRi1p/0Sicyy7jb3XTzGKNDI6iBo3w3uL4CXFhNvpnMJbfFkKwSziwj07CFg8= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:47 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:47 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 03/10] net/atlantic: check for error codes Thread-Index: AQHU0PD4nhZGjUb150eVQOLB8UPEuQ== Date: Sat, 2 Mar 2019 12:10:47 +0000 Message-ID: <7e077beff7792d403135f93a9e68c6308aa7e4a8.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28ac51b5-395e-46fe-1d0d-08d69f081a5c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:hZwfA3rke2Js0Y9ppGPUm8X2O83Xo6qs8pSobkn?= =?iso-8859-1?q?ko2y7t9yAE5wOZ5Ozv4iX5q29?= =?iso-8859-1?q?jDXDbPaRMK7onYbYzTKLTUL+r0OsOYHnZfW6e/wF+1JRlrl7Tbc?= =?iso-8859-1?q?uihUDQqFbKmByMukatdtXIboQ1ixZoXcZPH+BfMYELttXXYQp+g?= =?iso-8859-1?q?1MncSwUDdgt/hMRz4ziOD8C2p14EI145QVbseTYEjgg0Xqcv1Y/?= =?iso-8859-1?q?pld1ZvfSUdbMef4odnLeTT270tvptZl1auKSF6tIz89Vw9jJDgA?= =?iso-8859-1?q?NQ3ZpSHjcRshaOG5RgX7927U6yikt27bhil8qnQqiUATk+4c19s?= =?iso-8859-1?q?1Rlnb2rPKkp5BZf5QP6lOIUcx2YlO+xxU9FPvt+FOBrSzKGhLfZ?= =?iso-8859-1?q?LhfB/M6qHmIo2m8V1Sp9SP0qyPSDU/j0gO1trG4KQuV1ZygFYAE?= =?iso-8859-1?q?fiwB1pPQcBTE7ts6qCn5wbbrQRCn6vzMTy7+ft3266JIBOfaCLa?= =?iso-8859-1?q?ZJRWMPmh0zK20FhFa7LPiAz7EiOfLLqLi0p1kNaEZwwxvS3wsUg?= =?iso-8859-1?q?019vCtQ5Gj8nxmnYnilHe9iJHJ4Y4S0ak52gH8xc4gvWji4RLo3?= =?iso-8859-1?q?5g6F/CJ6jF2+qd/aD5ciK6mHSyriHCyAG3vaYodUpRSTJGqd5hU?= =?iso-8859-1?q?lGgamBwmax7oxD6vMXCunDNwK1RiBj4ZsDfIe0p1TosjvVLv2Cr?= =?iso-8859-1?q?PVBHKxs4lEDhUaFYjZXwVGne3aQPC5LgNkxvlb8dzVD8+Q1pgLR?= =?iso-8859-1?q?42CivU2Q1pK8tMDsXykPR4AlVNOi1IhqrO4BRukVEm0QUFQOTgV?= =?iso-8859-1?q?+7WAbR7oODqva43WkiXxrqpfCZxxMhNava+cU9Yvo0gL5QwFUhx?= =?iso-8859-1?q?xEgfzDHEgLWhEKrExmAX2wubsDe/E+BPYcP30rILAkf6xkFQ9Ly?= =?iso-8859-1?q?6YkahoM/pYXMgpv+O7ZAzKIYwFrtNdNDde9u8uJkRRU2i0WJAJY?= =?iso-8859-1?q?mj+q8uDzIcvoq10zODaDNoBqFAAEmdzHRRB9oymIYwCQ95sz/i9?= =?iso-8859-1?q?Jsdw5CE5PjH65tOjG8NLhybNT0hYv/c0VoickuBFnfYKvqCOThD?= =?iso-8859-1?q?I8yfVans7qC/8QGChrrWsbZLCicUF2KBivfgjO8GAqfyh0ZO/j8?= =?iso-8859-1?q?M5RB4MNmIuT2JWt9DBAUnejb2MXDpDf8RxSQ3sZLkWz0TTGILT5?= =?iso-8859-1?q?QMPDPlCvWUttwb4hiMqS58lr22TQ/6N4HGUbibviOMFI019Sgzy?= =?iso-8859-1?q?zYzWcWoIL1qjeTwuBHYcLYAg2kinF3W5PgAVh0nlkOs45p9s6Kf?= =?iso-8859-1?q?4rKhG11wMFIbPsrXM8EL9N86pl5x33ieAdyUalKK2aY+X0g8V8Z?= =?iso-8859-1?q?75N9NPkvdST0OKkNm6Y79TU7S/cyGkzv9gyHcV2oaFfasDQOBVE?= =?iso-8859-1?q?kxIQgZ+qSZJ7YqjCBlARi4HBcad3shpuCpbA2vET86ciIOfc=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(4744005)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: V7XQpLpHX0or2IXKDo32jO7VZjYVZip4u+XWlsGX1LjKM+DDlYdxEV66Rfsy0sM5WIW4dYmmyV984sMobqHZbKjdqZTr6jYv++HqAK/2BBTYwIv0fUz9BM14Ce5z2Q9tGjyn/5CeQr8qjvqOdiesgvqycMZDboT2ECcGaZD8uJ3T0lRJ4AZjzJWAENxoCfOwaXVsppYK7ZfhW6oAwONBi0Y4EIqM0Dg5/UUqDfiLCiMU4xJEUkPOcpC6eHJRvdHhC4lklCodaxGlwphV/GC4+0R07xE2Tga3YYAmMF6VCSuhP+6gY/fS+0TkeeSXpx6TOuX6qRphywwr8W3jVY1K/JaCtW36sgRyIFz7+kotTN/QdZ6ckXzmtizwCiZUwlQuMatDY3sjn9gvEP+DTsWHpIAa0lHQV+oe+WKbLx+oKcA= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28ac51b5-395e-46fe-1d0d-08d69f081a5c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:45.8985 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 03/10] net/atlantic: check for error codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found by Coverity Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c index f11093a50..13f02b9f9 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c @@ -462,8 +462,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self, goto err_exit; } } while (sw.tid != fw.tid || 0xFFFFU == fw.len); - if (err < 0) - goto err_exit; if (rpc) { if (fw.len) { @@ -875,8 +873,7 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac) } err = hw_atl_utils_fw_rpc_call(self, rpc_size); - if (err < 0) - goto err_exit; + err_exit: return err; } From patchwork Sat Mar 2 12:10:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50764 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFF864C9C; Sat, 2 Mar 2019 13:10:52 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690066.outbound.protection.outlook.com [40.107.69.66]) by dpdk.org (Postfix) with ESMTP id C687F4C77 for ; Sat, 2 Mar 2019 13:10:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SvPEK4Eb4qMDLYM48W+EsAFuwd3aJ/PppFcjoX9tqTo=; b=O/3otVvuFCVXkywFaWPP9w0AYwuuMqSCBUmMJhF5nR6pfFKl63z4PhzyOzvQtBPizsNccuz9MOvXBerj0jYS1Y3E+w0tZP3KL77VTZlCDmt3m0OmTkuVOgB40Lefuv9lUWdM0xUYT+UtVm6yS0tQzod2qDwknW4m8Nvj2Aq01LY= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:49 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:49 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 04/10] net/atlantic: fix buffer overflow Thread-Index: AQHU0PD5MQDVHQCc1kussJ9nhQqUJg== Date: Sat, 2 Mar 2019 12:10:49 +0000 Message-ID: <98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd96e484-8d5c-4982-4d7d-08d69f081b7f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:Dc4fJBuQ7nX9V77jeb+V7+KL0vXakZbvCF+qtv3?= =?iso-8859-1?q?Bs58U1HyrIEOSLqXvFveEjmGE?= =?iso-8859-1?q?WttJc/ewYozwF09Di2zeqKqHgNMgh0ECzWg0rexwHX7ejS2L8A9?= =?iso-8859-1?q?xeBajRbRyBtvoVp8DwYClV7LsjexbR4Y76yhlCse3cTexaxtZ2+?= =?iso-8859-1?q?ayCfis+2Mkq1bucV0eZJyWPaW/hnOOxiErUzAJ43r0sqVheOESf?= =?iso-8859-1?q?m98vwggOLT2Usw2OmmBTw7gg+dVRVFvoDjS+bZnTnoCFaZoUWUa?= =?iso-8859-1?q?nRyWBxT/alr2imyOxtIJSvMtd32z528guPOn8RPon765Tbz2GHJ?= =?iso-8859-1?q?bhhsW1V+oqmpMSUW/zn6JQwD5NUN+Evs6qUwJyy5qdlNkq/+x4R?= =?iso-8859-1?q?DlPdsSx+EjUksXIZzhGlibYM5ZN8dt0st0viBSMrsHkl6l7qqmC?= =?iso-8859-1?q?y6+5IyR/c88oP2AF+V0OAlpa849727VJwLMBdaZpxnAPdY7cFvd?= =?iso-8859-1?q?Lcm+y9sOY7k16YuNIM6OWP22wBdcilla/Ah2/yTPb+Q9+E2Pf1P?= =?iso-8859-1?q?T65mg7AeE9/dLu0Qqx21VzACbZPrcmXcXKGl54gBU6ZWzDJunUE?= =?iso-8859-1?q?ENnDvuRY+NNnpsJJFJoQRHbQD1fZ428+hIuNVka4kiZVHacj2n6?= =?iso-8859-1?q?DpTaMsajRmktsd5P2zDGKHH4rc8D/T8CjMEY2/UUPk4UgPHLx5F?= =?iso-8859-1?q?VzrOR/HV0/pKiSBkM3gwWE2RtwqVmWpjwIdelyJUqS8iqAQLdHo?= =?iso-8859-1?q?RqIg3S/EeL7kB4tjqutYyaeRIPHdPH5X6mMVJTi2FHzx0VGRvwW?= =?iso-8859-1?q?Q3ebpeRB211wydz4ziG4KYi13j/I+lrsOOlMB1+Q0KUhpqX+Vbf?= =?iso-8859-1?q?N4skuCnq9q/8M2oR2VMsusD2KctCiM5EC4CI7oIO7dM+hBBxuK9?= =?iso-8859-1?q?61SSQodTo37JXkuqzz1HYC3EqZTEIj0u+8y6G2QyRSwFMgCiGEt?= =?iso-8859-1?q?g/WYxkmxgtzAzf/KN29K5hhhTJfTWq+JR/O4u2C77x3SfsaE5Dx?= =?iso-8859-1?q?oJmia2lIO/vV67OfDK1KQR88VB9Z2lqhF6dWXNr6qmEzHQBbls8?= =?iso-8859-1?q?uuvjGkM6ASdTsmVsSl64ODKd98TqFTmV3dNNNiOlF3bqxMUshNe?= =?iso-8859-1?q?sS/lzBxI4x7BeSmlDZng5cjlZyxx0vB4JPWoC7dnfPPb057u2yt?= =?iso-8859-1?q?40GpiC6jn/oJAhPUQe6iMsc8UsgPDbCi9BkX1/RhvnpJx/hPk9R?= =?iso-8859-1?q?2GqeL0CqydPcxsYiQFsdXsrg/qGtSOXqaP84h0LIBJyJ1zc8gfw?= =?iso-8859-1?q?NQr4GEuO4qDl+EmO+d+psUdLYsFpEJDJmpWlnNXlxVbtooZarKP?= =?iso-8859-1?q?5ZDWbb1ks0yPwY797ytVYZHx294zjCado2BdYEmGx8nPISmlxie?= =?iso-8859-1?q?s9j931iV1eRy7aZ6Z5tBr37D8gPQfieRFNopX2rqd/3coQc4=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(14444005)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: X8pHNmX+KceIhC6gT9LPDDoSSHvTIMMwDFfqSjaBwHWg986KsLzFxr1zgPX0BY2lBqZmMd4LDvNcRQXLazJ5mAtb9vXFSTtmxCteoDcGZRJxyCem0DRpegB6D43ICDE1YLE7ODhx8UY9BCuxsNXhHYOHea4Cwl2V+P57s1ccJxpXaJ3WKfCIQtepuVpTCk3gFP8Zdu6WjkdyGcuz1nL7zSLkwMpMFumxO60AHAPr7B7Aw0VGO2N+h/HgVJdX/NrUGaVdZM9cypmPdPSxxRRDIbVuaaLlxdxgMMhRtigpLZ5LWLnwC1vJ8H/l8HDwmYgyXFTNgiZ60R4cOHrZ85c7Q2RJvRRb8PF5mTTKobMQ4Bz+Z6/zRqVO7aTjpDsF6QgP/IBqnRGN0lJd5Kh5yiyOT8KuD8OCvNIqERScjRJx+fo= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd96e484-8d5c-4982-4d7d-08d69f081b7f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:47.8118 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 04/10] net/atlantic: fix buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavel Belous Found by Coverity Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c index 6841d9bce..a155d4aab 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c @@ -501,7 +501,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len) /* Write SMBUS request to cfg memory */ err = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr, (u32 *)(void *)&request, - RTE_ALIGN(sizeof(request), sizeof(u32))); + RTE_ALIGN(sizeof(request) / sizeof(u32), sizeof(u32))); if (err < 0) return err; @@ -523,7 +523,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len) err = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32), &result, - RTE_ALIGN(sizeof(result), sizeof(u32))); + RTE_ALIGN(sizeof(result) / sizeof(u32), sizeof(u32))); if (err < 0) return err; @@ -558,7 +558,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len) /* Write SMBUS request to cfg memory */ err = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr, (u32 *)(void *)&request, - RTE_ALIGN(sizeof(request), sizeof(u32))); + RTE_ALIGN(sizeof(request) / sizeof(u32), sizeof(u32))); if (err < 0) return err; @@ -589,7 +589,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len) /* Read status of write operation */ err = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32), &result, - RTE_ALIGN(sizeof(result), sizeof(u32))); + RTE_ALIGN(sizeof(result) / sizeof(u32), sizeof(u32))); if (err < 0) return err; From patchwork Sat Mar 2 12:10:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50765 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 229084C9F; Sat, 2 Mar 2019 13:10:55 +0100 (CET) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-eopbgr820049.outbound.protection.outlook.com [40.107.82.49]) by dpdk.org (Postfix) with ESMTP id 865F34C94 for ; Sat, 2 Mar 2019 13:10:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ignEHWoxguKlCQV+/L+FFHv5+ZfaQmlaunF92gwBXaI=; b=c/8uHMqCpR2t9NRhVo4LysALmu2lhY8ANg8Z5JnVOzOR5U/UVekhZSDw5Ax+wlaQP97XzZjMffnL745OZ+JPgi3jBjxNfQpdiYfPAhw4bBt4+bMC7QqweSmDnOj0OM6+7OF06gkpASkpHnSMarXMpiX0g2sJhOxuVuGvIY1y+1Q= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:51 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:51 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 05/10] net/atlantic: use eeprom magic as a device address Thread-Index: AQHU0PD6P5RGQLcsvEqHcpgj+4yNjQ== Date: Sat, 2 Mar 2019 12:10:51 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41e640dd-823a-43fd-d7d6-08d69f081c9c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:jbtkiglSkTVAq/oWe18oV/Jm0B7blVB4uPap5kI?= =?iso-8859-1?q?mYNS7i6XJAsmC7erhdBZvPkcF?= =?iso-8859-1?q?bFjWgCmTaGIeqNnMXJHIKcQjrOMQaAC+J1oFjpSLakCWNK0Q4Nl?= =?iso-8859-1?q?aFW2wXW3czBrZ/0t91k09FbkY0eyy4usUt/0YBt+QBqGPv0tLvt?= =?iso-8859-1?q?mdALjCiOdLujx76de8Y9+ujTmnBqV2StCGhwU1xnAJVeQ6LQ7wb?= =?iso-8859-1?q?ZRzKT//orQ4V2SbA9u16rADbFcEYqDlO/qje4siATAXlIRSr9n4?= =?iso-8859-1?q?XkmUfaJobdprnJBtOf2Zo8dQYSI2OJNxBqZVwY05fiwTz3PCLj2?= =?iso-8859-1?q?xHV7DrI6Sk38zclOS2FAtsyKa+DQAly1RHqRXSRE3I8IqBKCpIF?= =?iso-8859-1?q?YslHtiqZPGsfCtLBLqmXmqZWmvdAI93y/pZw63rVt60yb/6kkkw?= =?iso-8859-1?q?E4WolhNbIBBDhsKj3mjs3h9DWKU3/d4Bgs3X7S1JznthGzx/aTW?= =?iso-8859-1?q?SPwthKW0WyetFjCw8AAWXKWw36lgzS+b7wOTfTWGXZ8Tcz4gjvY?= =?iso-8859-1?q?lqDhhOGD2YROSpJFoD05vow5j0CikbXj+cwGUls55QUO2E2EMj4?= =?iso-8859-1?q?cX0GLPndxUHT0ttOnO3GmgwkiYxJw7deUADsQKTaCTNtS05MK+G?= =?iso-8859-1?q?nNcTKgrXCjh379l5d4bLhy9eATWMEws9jf/lIMJKbih4RoGpFDF?= =?iso-8859-1?q?jObiDIKPu6QdfCeNH8xYdcp20hOBaOZH9eaL6MMvsZpddCXZa7W?= =?iso-8859-1?q?YDaGyeyHy86+HNb1yeGH9xZf95eg/hOFSeDejqiYQLZQj/vJZoA?= =?iso-8859-1?q?jZLIEzdU4E/KXpYv6Qd6hg1Ouo9DU9Xgb89g2uuqT3M1pDPp4Pn?= =?iso-8859-1?q?uKjdufV8qaCi2rfPufy+wxeKy40z691+SRiX44Agdj2itSK2ugQ?= =?iso-8859-1?q?XNYCrTIapJD7KI/ir4/Ogk/kLS6rvRhtZoMLYVNgc4EJL1Xnux3?= =?iso-8859-1?q?nHHnIbUmZjNLLA74TgzEK67pOBxQPrK8xxm5qAehNmyg9i+ySOM?= =?iso-8859-1?q?H/UGs6r9rgyOFlol/Z2R/XIURgwRIxBitfwvSLFDO/6XfrMk7Qd?= =?iso-8859-1?q?dmGE+oQ3Y8hHICpOXOy9RlxS7Qa8/0FVoaD8+1es5lQ34FMKg8T?= =?iso-8859-1?q?ZaeAfaBJILArPO3pw5kugCynIJQHx3kkKyj55SvpMSrVzByckNN?= =?iso-8859-1?q?d5PIdXl938mzHRJaDzkZzMPGubOY0oQumfgdxolb6yCIDN5yQ/a?= =?iso-8859-1?q?FqTsypv+c/d08+X26JGxbV9MSgqYsYWfSdr7xaM+15My69q/QCb?= =?iso-8859-1?q?K56B6z5zkCvjU4IcuOGzOEb8gfEl74p35Fq4AmCBT4u5kIdIS8q?= =?iso-8859-1?q?ZCOfdnsmPJ8pfcnVXwbjiNr/GrLtwndpp2M31txqLakvynZc+qa?= =?iso-8859-1?q?bsEyw1bJ52TJTcmHvMI0ItnL8ZPbNl8/2oiN1McNmdN1GfTo=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(14444005)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: EjLpfFKP6DRpDncTeDcGa5QTeTy1WDyb+XcwlvzxQVkzqm5M1H+jQB965XQP6+6wS6Yq7Zca4Nxkn6huDtlzSPva+4xkoZCX5p66K7LpmOiNByrZx7n0jCia0iSefLogXrbmewnQqz8DuanHFfKBTZureH3cWN2upPgN19eOrW7SB9mb978fzXKsE/TVF99iwhwYYqrYGWuLwOquDPUxJmvKlu4jejIScK2fWqifaVGfFBcVfdul+S5i3VEkSmlJ/fTLxttdwvoQHDwZ662ufMB7hhDyTv9b1BcXtQRtlWgYR0l6RHHawbD9FlgyrZ69ydTiS0n8LXChFboVhwVnVvchK6gG+uWQqQcbh4B6jnAwDg+qDlU4ekw/D7biWq9JfjDRd1SIhH8btUlFKEmc6Aep/mKCF5PIkVdcIkkRF/w= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41e640dd-823a-43fd-d7d6-08d69f081c9c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:49.6851 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 05/10] net/atlantic: use eeprom magic as a device address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavel Belous Default dev addr is replaced with magic field from the request. Length is allowed to be less than maximum. SMBUS access bit definitions also better organised now. Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- drivers/net/atlantic/atl_ethdev.c | 20 ++++++++++------ drivers/net/atlantic/atl_types.h | 5 ++-- drivers/net/atlantic/hw_atl/hw_atl_utils.c | 4 ++++ drivers/net/atlantic/hw_atl/hw_atl_utils.h | 23 ++++++++++-------- .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 24 ++++++++++--------- 5 files changed, 46 insertions(+), 30 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 5bc04f55c..ae1babacf 100644 --- a/drivers/net/atlantic/atl_ethdev.c +++ b/drivers/net/atlantic/atl_ethdev.c @@ -1102,24 +1102,27 @@ atl_dev_get_eeprom_length(struct rte_eth_dev *dev __rte_unused) return SFP_EEPROM_SIZE; } -static int -atl_dev_get_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom) +int atl_dev_get_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom) { struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private); + uint32_t dev_addr = SMBUS_DEVICE_ID; if (hw->aq_fw_ops->get_eeprom == NULL) return -ENOTSUP; - if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL) + if (eeprom->length > SFP_EEPROM_SIZE || eeprom->data == NULL) return -EINVAL; - return hw->aq_fw_ops->get_eeprom(hw, eeprom->data, eeprom->length); + if (eeprom->magic) + dev_addr = eeprom->magic; + + return hw->aq_fw_ops->get_eeprom(hw, dev_addr, eeprom->data, eeprom->length); } -static int -atl_dev_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom) +int atl_dev_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom) { struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private); + uint32_t dev_addr = SMBUS_DEVICE_ID; if (hw->aq_fw_ops->set_eeprom == NULL) return -ENOTSUP; @@ -1127,7 +1130,10 @@ atl_dev_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom) if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL) return -EINVAL; - return hw->aq_fw_ops->set_eeprom(hw, eeprom->data, eeprom->length); + if (eeprom->magic) + dev_addr = eeprom->magic; + + return hw->aq_fw_ops->set_eeprom(hw, dev_addr, eeprom->data, eeprom->length); } static int diff --git a/drivers/net/atlantic/atl_types.h b/drivers/net/atlantic/atl_types.h index 3d90f6cae..ecc515e43 100644 --- a/drivers/net/atlantic/atl_types.h +++ b/drivers/net/atlantic/atl_types.h @@ -137,9 +137,10 @@ struct aq_fw_ops { int (*led_control)(struct aq_hw_s *self, u32 mode); - int (*get_eeprom)(struct aq_hw_s *self, u32 *data, u32 len); + int (*get_eeprom)(struct aq_hw_s *self, int dev_addr, u32 *data, u32 len); + + int (*set_eeprom)(struct aq_hw_s *self, int dev_addr, u32 *data, u32 len); - int (*set_eeprom)(struct aq_hw_s *self, u32 *data, u32 len); }; struct atl_sw_stats { diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c index 13f02b9f9..4299b7016 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c @@ -305,6 +305,10 @@ int hw_atl_utils_fw_downld_dwords(struct aq_hw_s *self, u32 a, AQ_HW_WAIT_FOR(!(0x100 & aq_hw_read_reg(self, HW_ATL_MIF_CMD)), 1, 1000U); + if (err) { + err = -ETIMEDOUT; + goto err_exit; + } *(p++) = aq_hw_read_reg(self, HW_ATL_MIF_VAL); a += 4; diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.h b/drivers/net/atlantic/hw_atl/hw_atl_utils.h index 5f3f70847..f2a87826c 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils.h +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.h @@ -8,6 +8,7 @@ #ifndef HW_ATL_UTILS_H #define HW_ATL_UTILS_H +#define BIT(x) (1UL << (x)) #define HW_ATL_FLUSH() { (void)aq_hw_read_reg(self, 0x10); } /* Hardware tx descriptor */ @@ -389,18 +390,8 @@ enum hal_atl_utils_fw_state_e { #define HAL_ATLANTIC_UTILS_FW_MSG_OFFLOAD_DEL 10U #define HAL_ATLANTIC_UTILS_FW_MSG_CABLE_DIAG 13U // 0xd -#define SMBUS_READ_REQUEST BIT(13) -#define SMBUS_WRITE_REQUEST BIT(14) #define SMBUS_DEVICE_ID 0x50 -enum hw_atl_fw2x_rate { - FW2X_RATE_100M = 0x20, - FW2X_RATE_1G = 0x100, - FW2X_RATE_2G5 = 0x200, - FW2X_RATE_5G = 0x400, - FW2X_RATE_10G = 0x800, -}; - enum hw_atl_fw2x_caps_lo { CAPS_LO_10BASET_HD = 0x00, CAPS_LO_10BASET_FD, @@ -414,6 +405,10 @@ enum hw_atl_fw2x_caps_lo { CAPS_LO_2P5GBASET_FD, CAPS_LO_5GBASET_FD, CAPS_LO_10GBASET_FD, + CAPS_LO_AUTONEG, + CAPS_LO_SMBUS_READ, + CAPS_LO_SMBUS_WRITE, + CAPS_LO_MACSEC }; enum hw_atl_fw2x_caps_hi { @@ -451,6 +446,14 @@ enum hw_atl_fw2x_caps_hi { CAPS_HI_TRANSACTION_ID, }; +enum hw_atl_fw2x_rate { + FW2X_RATE_100M = BIT(CAPS_LO_100BASETX_FD), + FW2X_RATE_1G = BIT(CAPS_LO_1000BASET_FD), + FW2X_RATE_2G5 = BIT(CAPS_LO_2P5GBASET_FD), + FW2X_RATE_5G = BIT(CAPS_LO_5GBASET_FD), + FW2X_RATE_10G = BIT(CAPS_LO_10GBASET_FD), +}; + struct aq_hw_s; struct aq_fw_ops; struct aq_hw_link_status_s; diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c index a155d4aab..d0eb9f5e9 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c @@ -129,7 +129,9 @@ static u32 fw2x_to_eee_mask(u32 speed) static int aq_fw2x_set_link_speed(struct aq_hw_s *self, u32 speed) { - u32 val = link_speed_mask_2fw2x_ratemask(speed); + u32 rate_mask = link_speed_mask_2fw2x_ratemask(speed); + u32 reg_val = aq_hw_read_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR); + u32 val = rate_mask | ((BIT(CAPS_LO_SMBUS_READ) | BIT(CAPS_LO_SMBUS_WRITE) | BIT(CAPS_LO_MACSEC)) & reg_val); aq_hw_write_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR, val); @@ -484,7 +486,7 @@ static int aq_fw2x_led_control(struct aq_hw_s *self, u32 mode) return 0; } -static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len) +static int aq_fw2x_get_eeprom(struct aq_hw_s *self, int dev_addr, u32 *data, u32 len) { int err = 0; struct smbus_read_request request; @@ -494,7 +496,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len) if (self->fw_ver_actual < HW_ATL_FW_FEATURE_EEPROM) return -EOPNOTSUPP; - request.device_id = SMBUS_DEVICE_ID; + request.device_id = dev_addr; request.address = 0; request.length = len; @@ -506,16 +508,16 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len) if (err < 0) return err; - /* Toggle 0x368.SMBUS_READ_REQUEST bit */ + /* Toggle 0x368.CAPS_LO_SMBUS_READ bit */ mpi_opts = aq_hw_read_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR); - mpi_opts ^= SMBUS_READ_REQUEST; + mpi_opts ^= BIT(CAPS_LO_SMBUS_READ); aq_hw_write_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR, mpi_opts); /* Wait until REQUEST_BIT matched in 0x370 */ AQ_HW_WAIT_FOR((aq_hw_read_reg(self, HW_ATL_FW2X_MPI_STATE_ADDR) & - SMBUS_READ_REQUEST) == (mpi_opts & SMBUS_READ_REQUEST), + BIT(CAPS_LO_SMBUS_READ)) == (mpi_opts & BIT(CAPS_LO_SMBUS_READ)), 10U, 10000U); if (err < 0) @@ -542,7 +544,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len) } -static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len) +static int aq_fw2x_set_eeprom(struct aq_hw_s *self, int dev_addr, u32 *data, u32 len) { struct smbus_write_request request; u32 mpi_opts, result = 0; @@ -551,7 +553,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len) if (self->fw_ver_actual < HW_ATL_FW_FEATURE_EEPROM) return -EOPNOTSUPP; - request.device_id = SMBUS_DEVICE_ID; + request.device_id = dev_addr; request.address = 0; request.length = len; @@ -572,15 +574,15 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len) if (err < 0) return err; - /* Toggle 0x368.SMBUS_WRITE_REQUEST bit */ + /* Toggle 0x368.CAPS_LO_SMBUS_WRITE bit */ mpi_opts = aq_hw_read_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR); - mpi_opts ^= SMBUS_WRITE_REQUEST; + mpi_opts ^= BIT(CAPS_LO_SMBUS_WRITE); aq_hw_write_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR, mpi_opts); /* Wait until REQUEST_BIT matched in 0x370 */ AQ_HW_WAIT_FOR((aq_hw_read_reg(self, HW_ATL_FW2X_MPI_STATE_ADDR) & - SMBUS_WRITE_REQUEST) == (mpi_opts & SMBUS_WRITE_REQUEST), + BIT(CAPS_LO_SMBUS_WRITE)) == (mpi_opts & (BIT(CAPS_LO_SMBUS_WRITE))), 10U, 10000U); if (err < 0) From patchwork Sat Mar 2 12:10:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50766 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6537E4CAF; Sat, 2 Mar 2019 13:10:56 +0100 (CET) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-eopbgr820082.outbound.protection.outlook.com [40.107.82.82]) by dpdk.org (Postfix) with ESMTP id 2D2C24C9F for ; Sat, 2 Mar 2019 13:10:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2LF57tJrCoG3qbrycTKIHk1LKUd+AZaFjBubR9Rezg=; b=IAAhXzth+VzmHXwqE01uQUCRpmgkyNiLgWoAuS/uSigLSngR7K+2tMSaA45S7Ewttkl6eK/Kgx7/Nz6VbHkOpHdGN1TBmskuj5CXAesEtGbcxBMtqx3sNM6Y/5vcy4jCLOticHDxeeDpiNjO3zk+UKKjzK6y1DQVlndjTJWzd8U= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:53 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:53 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 06/10] net/atlantic: fix eeprom fetching for small and uneven lengths Thread-Index: AQHU0PD7v1eTU9dim0mbYrhFEWsFGQ== Date: Sat, 2 Mar 2019 12:10:52 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 195eb1ad-fbdc-4902-3889-08d69f081db1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:aNGoJnM4RUQw3y6Jx5j953NO6i1R9VVMaUmrNf8?= =?iso-8859-1?q?t8XslMAu985TJ/LdkjLQNgTqK?= =?iso-8859-1?q?Mpz16BYiZyhwInWVkgWMKdyM/BOj80Rs+skKXd/J2Tj8TaHzuv3?= =?iso-8859-1?q?BApUpFVkz3PSQZdheVUJYMgyE/Qx40XMJjsxJkrnbC9bmk6daSP?= =?iso-8859-1?q?Wl0oiBbKPajHFHQ12GU4RYmkAfDY2yF2ChMQ3ntIvp957GkoZKA?= =?iso-8859-1?q?rsFDt93VtPMhZ/Ag3DUhRNonklFITn4y/qHIDjlC4PVahTUhjVR?= =?iso-8859-1?q?9ZVzfIvwoKauyz+ymAcciTuFL9Yl7jo8W69CYdpmrKziP+zjlLa?= =?iso-8859-1?q?ryqzA2I5RhPkJeZgxGF+irQHeisC3jSZ6ZJ2dxSqREE1kLCiADE?= =?iso-8859-1?q?n0f/Y9GpeVF6T/zdsOZfp37Bl0Alk/RKzvvh+HjaDegXRXPE7if?= =?iso-8859-1?q?8/7RMn24xE1iGdKIR3rUVtejo42GG5Jo2JMDgwvN4OaKH9O4xQ6?= =?iso-8859-1?q?oZpcEoRXCI9vAdYQd9og0L9J8WLs+SZwY8NQ+9YJRz2Vz0FvfKo?= =?iso-8859-1?q?hxXO490c3uTC7v/65pFkxYrFqBLM0dGEzOrMqeWFMf9h5GHcNS4?= =?iso-8859-1?q?LK3ONqINzD+tkJngjb484/QK21geLm+8pN7+BYigJPGRnEUa2bS?= =?iso-8859-1?q?5Wu8aMyP9rVV+BeiwBOBap4eirofjkSs28gLQVqrkOW9VYWC8SI?= =?iso-8859-1?q?eTFVNSd23q1VDwSsApdqlmkgS6Cd22sCq4mtzY0GTsLiIxnEDqg?= =?iso-8859-1?q?rK9WLZ1mWhUcSJ7XI2d4wZ1O0qc2v+rzdobYml7SC3U2IPXHmGQ?= =?iso-8859-1?q?WGI6I3y+aXlC9rA/AQ/pXBN2I6gJZ9rnp3LhG3YChKp/aC1GL5T?= =?iso-8859-1?q?G53gXGlUFtZm0/HtLrG5rV69ydOL3UmpC0BgrzmwD/oWnjFwExJ?= =?iso-8859-1?q?0lyxLwp9nb8VsN59eB6r94zImDy5xLiZZ03edIfz2kBmtGRA++G?= =?iso-8859-1?q?7hLojAISFvrkCg6rksKvJFQihSdubmghO+pteik/ajO7CeN2xWG?= =?iso-8859-1?q?5IximIJ9eE0QTwbAfc+ChhcrQUX/XOc8mi4f6DM01KkPTxGSUVN?= =?iso-8859-1?q?1g9sXdf9ofi0CV7IKUCAP9HAipC1mSn7F9BmjqrkVuTcq3IYsM8?= =?iso-8859-1?q?bxI+zNIjPdlnpN7rVQ7g4lCrl1Ky24fo5Je7saVWHjvEdLuqpiS?= =?iso-8859-1?q?yTm0FCnG1bI9DC/GAhujwd8VE7oGlUCdBnsLkrCRtHuH2vC6ZLw?= =?iso-8859-1?q?oMuebpto8dnDU84DifmYbl5OMefL+2Z/XF0P+43lBjcwRGZqPky?= =?iso-8859-1?q?0Y+4Xe/vN6+9Qd0vAE7SFbvYwEz7yO1+7b9hDS5N3bkwdfoIYxT?= =?iso-8859-1?q?Z5VArYCZDmXIFexXQjMMMSRYbb2EznRE1uZk4P+fBmR7KRGpQV9?= =?iso-8859-1?q?TzWSIPeDpXd88KisOC3Q1MWXWew=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yDKvp1E878nj5+iAjgWruUNLzXmsPui8gm1OQutuJM8WRqNR6NPT8S63HmSdFaTuhkOB0cIMSE/diggmFPSm9D7d0HkErRmeg8M2DLSEZdCmPniO/nEFLNJO9J2+FrDZziuKVgd0GxYdFGcqUXy2z2oOTFlKzJhON/7A0mHfefygU/S8CuAq+SLxZwfX8cBgi1xtbw/zEAT7QHeI6a2WJhxmD0tMy+IDgx/x8ZdSi5CGt17x+r3XmpV5JVIe7Z22094jmQvn9xuYYtWUYxkfDxkeyAkwvVejy8iiHNd4yZq203gU8GtGdP7PGFCI2zeU49kPw1DfgYYchnvEuqUufMCKAFxd6DRNSXkFqoSU+q2bRYOmXVLEfJ+4y3cX1NM80+0DRurlKO2vxIa30jIX64fANiMF/VT1QTkJbwkgYHk= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 195eb1ad-fbdc-4902-3889-08d69f081db1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:51.4954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 06/10] net/atlantic: fix eeprom fetching for small and uneven lengths X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavel Belous Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 27 ++++++++++++++++--- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c index d0eb9f5e9..efa999268 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c @@ -531,13 +531,32 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, int dev_addr, u32 *data, u32 return err; if (result == 0) { - err = hw_atl_utils_fw_downld_dwords(self, + u32 num_dwords = len / sizeof(u32); + u32 bytes_remains = len % sizeof(u32); + + if (num_dwords) { + err = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32) * 2, data, - RTE_ALIGN(len, sizeof(u32))); + num_dwords); - if (err < 0) - return err; + if (err < 0) + return err; + } + + if (bytes_remains) { + u32 val = 0; + + err = hw_atl_utils_fw_downld_dwords(self, + self->rpc_addr + sizeof(u32) * 2 + num_dwords, + &val, + sizeof(u32)); + + if (err < 0) + return err; + + rte_memcpy((u8*)data + len - bytes_remains, &val, bytes_remains); + } } return 0; From patchwork Sat Mar 2 12:10:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50767 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25B044F91; Sat, 2 Mar 2019 13:10:58 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690062.outbound.protection.outlook.com [40.107.69.62]) by dpdk.org (Postfix) with ESMTP id 6C4E94CB5 for ; Sat, 2 Mar 2019 13:10:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P2qZ1NVGMAanEk30cu1WGwLlAPpWO0JKLe6msbS4d8w=; b=NbZIKQCWfhkb2X31b90jLjbZJm25jmvmiRH9clAJfDURTGzop3naewsZjKG2Xd4MweTbLQYOt6kPPx5xgHhvabGN/PdJYZfs9xFH10FKR0yraKGX9aXsBUbJkkk3Q8T33kQtu4PZvxOh2SqxsssATokHpBqn1xYeWufm46v4AwA= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:55 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:55 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 07/10] net/atlantic: fix link configuration Thread-Index: AQHU0PD8mCpcOwyNpUGx5vavH138HA== Date: Sat, 2 Mar 2019 12:10:55 +0000 Message-ID: <5a6195428c5075be9041d685e054720c328f4e54.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ec7369e7-926c-4bde-a4fa-08d69f081ebf x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:NzIPUkl0PL6U0Ht/pyuqAsbPGv/784aa4WxQTxE?= =?iso-8859-1?q?nepx16Vq56GoOBMYgU/ErCv9x?= =?iso-8859-1?q?h/tX0ti9S+IphcYxfnHYcMzc8smSb+PIKFHSgzQc2xZhg3tJ9cw?= =?iso-8859-1?q?lFvRL3lQdBc8oQl9a4xYrcz1V4o5IF+ShudSwKPKbMZitRoZ8YJ?= =?iso-8859-1?q?vyzOPw+YN6NE4oW9rZNuoHJL3r28FEsiuUsjLJTQ41pIdYjcTuz?= =?iso-8859-1?q?1Z/fYgk/SF2G2nX7DxUZnLcDV4VpywoVCvpAyPQnTV4Q5037jre?= =?iso-8859-1?q?Fb5V3d7OWBBjuRpR1zOo5Ngx5XzWPrhHq0t5y+aoRwFGzIaMGfM?= =?iso-8859-1?q?Jg5XrjJKomZVNqtq5bY9EqmqacszGg2hSkZ49oyvUZp2rGHKqLb?= =?iso-8859-1?q?fsKRRmfZh2uJQV/+jKtsNe2C3HNM8DjytTue//ntBnuUoUaOvrj?= =?iso-8859-1?q?e+xNCKvm5RsbUeAnlGvMIvuyOijGK3S9wfsZT6P/v5OGhsrsEAR?= =?iso-8859-1?q?6JFtacaL+1HkkgnEPh8bfsBi86xrxMOMaYPSFBe0YKHnE4+p0OK?= =?iso-8859-1?q?VYSb3q1ON0ZThODeFNN1b54MhL5YLr+7ZHn5wGXcJpDT5vaCe1p?= =?iso-8859-1?q?U9/uEoWNGv/R5hn/lYyChvjWwzz/9RFqv2bkGXs8Ep4m7FOApma?= =?iso-8859-1?q?nKBLYvJilHnejtJ9kVejq69GFVU8KRI+AE6fQ7gnHqzG/9rZeF7?= =?iso-8859-1?q?bJG6T5PFuw/3d5gmOfmPW+ycOQIS0ToFT4qIfDBay3yKnVMjKbx?= =?iso-8859-1?q?ml3vhgWAf9Tq5Ej0iBA5v5Jx/+UBQPigQwsnlmUQJ4aM5Z66+4E?= =?iso-8859-1?q?SopL1pFRSswHWirRP2dvSERRgJpmKNINuo611cShn4N5e5Y9Kqg?= =?iso-8859-1?q?sWW/d5ttyfLi38X563vNTlMjQpnNptvEKyIEiuYRmxBe0Ue22c1?= =?iso-8859-1?q?gqGdSBO6CJVuWH99XBrAtQI8kKyI09TwcieaB2xC8z6K/YdxU8O?= =?iso-8859-1?q?u+4qvPp1dJLpQ3T5dtn0R2O9xBatDpeeJSwPAInhwZN5k4+d29c?= =?iso-8859-1?q?AwjQk5mH9ne/7hkcUe8Ob2LIxmrykum5ma7tjz3CVZzPqwIoqs4?= =?iso-8859-1?q?PqoW9zAekU/CmAZ8zAqMzYvCX6v64JZ1GzmkqI9kog96yCh2rGB?= =?iso-8859-1?q?6QpIQc21MAdAnQK7ciYQZEn2uVWH4yFZBd2/atkupXkBKPQcc/R?= =?iso-8859-1?q?+fXA2Y9IDffZX6Bb3jodYtBy4Bjn4Y3fGcGHrC3IRM+ubw8j0wz?= =?iso-8859-1?q?eAs5nYciEECuqbfUfOdtfyLbUXllUhXS29YzFum2ern4QSLBDAC?= =?iso-8859-1?q?8gl85uUnxbPpDJreLY+XTtXOntEilk9LhziZLzXgRSxHfRBk9O/?= =?iso-8859-1?q?U3pf+sgrlMs91SfQBeokCMDVrQA/2mLP6579HCOZ9XrcToZlNqk?= =?iso-8859-1?q?MBYRQqOcr8gFV+lbnbivVPwKQqAVPK21l+uw1nL7wvrlvJYU=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(14444005)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: KbDOqY0FQLA64eKSxpIqXuKnzlGjJIuOW6yJwQamxQ38uBjJVfjH38BsfM2Sw8y99vq7TE8GwGqMtwZnE7b/5TK7jsoX3DA9kSTxDuoT7KTXLN1uKHNrK2pvHE0SbvGVHvMZbcnlfjR+0qF1TzjMGZgc4aWg8x04fyhRQ7NFDbjO9D4ZnLrfsWkjJ+/Hf9NGgCILADWM3sOUR9Hj0iD9gPgvkGkA31ctOmQzBxQ2eWXk3LXRmiM4EKAEEihZwxq4UbHllDPUNp5iJUPwBSiY4W9l2EFCxfslrIEsv2WVPXMJnK/mFQ8uxEEZBPwFqdT0DhqE8zaVHtqXyUm86Gs+n7w0ceTXtFTzX3gvIt6UM8fuYxR0+Lp5I/baaK8xv7GjbAuLpfwdYcEzW/4CFlJllZ6irzROnfhArVeDN5qexb0= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec7369e7-926c-4bde-a4fa-08d69f081ebf X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:53.2696 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 07/10] net/atlantic: fix link configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case link speed is re configured after port start, it does not takes the requested speed value, but instead just sets full autoneg mask. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 44 ++++++++++++++----------------- 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index ae1babacf..ad4e5a717 100644 --- a/drivers/net/atlantic/atl_ethdev.c +++ b/drivers/net/atlantic/atl_ethdev.c @@ -465,8 +465,6 @@ atl_dev_start(struct rte_eth_dev *dev) struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev); struct rte_intr_handle *intr_handle = &pci_dev->intr_handle; uint32_t intr_vector = 0; - uint32_t *link_speeds; - uint32_t speed = 0; int status; int err; @@ -543,6 +541,8 @@ atl_dev_start(struct rte_eth_dev *dev) goto error; } + err = atl_dev_set_link_up(dev); + err = hw->aq_fw_ops->update_link_status(hw); if (err) @@ -550,26 +550,6 @@ atl_dev_start(struct rte_eth_dev *dev) dev->data->dev_link.link_status = hw->aq_link_status.mbps != 0; - link_speeds = &dev->data->dev_conf.link_speeds; - - speed = 0x0; - - if (*link_speeds == ETH_LINK_SPEED_AUTONEG) { - speed = hw->aq_nic_cfg->link_speed_msk; - } else { - if (*link_speeds & ETH_LINK_SPEED_10G) - speed |= AQ_NIC_RATE_10G; - if (*link_speeds & ETH_LINK_SPEED_5G) - speed |= AQ_NIC_RATE_5G; - if (*link_speeds & ETH_LINK_SPEED_1G) - speed |= AQ_NIC_RATE_1G; - if (*link_speeds & ETH_LINK_SPEED_2_5G) - speed |= AQ_NIC_RATE_2G5; - if (*link_speeds & ETH_LINK_SPEED_100M) - speed |= AQ_NIC_RATE_100M; - } - - err = hw->aq_fw_ops->set_link_speed(hw, speed); if (err) goto error; @@ -657,9 +637,25 @@ static int atl_dev_set_link_up(struct rte_eth_dev *dev) { struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private); + uint32_t link_speeds = dev->data->dev_conf.link_speeds; + uint32_t speed_mask = 0; + + if (link_speeds == ETH_LINK_SPEED_AUTONEG) { + speed_mask = hw->aq_nic_cfg->link_speed_msk; + } else { + if (link_speeds & ETH_LINK_SPEED_10G) + speed_mask |= AQ_NIC_RATE_10G; + if (link_speeds & ETH_LINK_SPEED_5G) + speed_mask |= AQ_NIC_RATE_5G; + if (link_speeds & ETH_LINK_SPEED_1G) + speed_mask |= AQ_NIC_RATE_1G; + if (link_speeds & ETH_LINK_SPEED_2_5G) + speed_mask |= AQ_NIC_RATE_2G5; + if (link_speeds & ETH_LINK_SPEED_100M) + speed_mask |= AQ_NIC_RATE_100M; + } - return hw->aq_fw_ops->set_link_speed(hw, - hw->aq_nic_cfg->link_speed_msk); + return hw->aq_fw_ops->set_link_speed(hw, speed_mask); } /* From patchwork Sat Mar 2 12:10:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50768 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54CC54F9B; Sat, 2 Mar 2019 13:11:00 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690071.outbound.protection.outlook.com [40.107.69.71]) by dpdk.org (Postfix) with ESMTP id 51CA54F98 for ; Sat, 2 Mar 2019 13:10:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfG3GqGxL48e9NnuRvDdyNCEusVHw/iV4qz6kvI1OLE=; b=JcdT7h+QvKL5Ik0qMwIrVg+fowCFGgF8m3eAFMW844BBl0JhaKzdh1FDJ0fapSr6U/CUV4Sxt2WTICBjfPhVFzAXxTiqqKRBFoNEqS58O5aA/ZMNHyxuv8ipnxUMLjvjc6hhsKV1s3IYAn8QgIkD8KQlsf5tdQr/OV1nsvWkUa8= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:57 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:57 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx Thread-Index: AQHU0PD9nduY1Cz6s0aayOstP0WFAA== Date: Sat, 2 Mar 2019 12:10:56 +0000 Message-ID: <997f7e5e1eab9c5af41aa9c05140a2fd72a3b221.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5e1fe0b6-7413-44fd-2e5f-08d69f081ffc x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:h7ACrM962Ml4Q2Ld9eDgb6YN23ps/Z9wM/WatsH?= =?iso-8859-1?q?dDz4VHamzZcKcwTm7efI+PrVc?= =?iso-8859-1?q?BiPnqbUoeOO1FnhpegYlry3wyrSum6OVvjygO+Q37jW48Y92f2A?= =?iso-8859-1?q?GNLimfi6i0A71ydw8aIMVp6AkVSOzxHXnsqmaUeRn7Pbsq+XWEu?= =?iso-8859-1?q?mYLxIGRwEkkFlCOEV/9qOZ4xLv258QKUfexclv92BJhidJvpj50?= =?iso-8859-1?q?8jj3CVt9HKW1z3KRXBkqkWCXGwT9ZMOA9SrgfxDQeDaMkhtrxyo?= =?iso-8859-1?q?aNjXtjLFeoTkQlhEtiUZLqLRdJ8oMVvZE8AGemd0CyfZm1DJ7Mq?= =?iso-8859-1?q?8Xpw5aXDjzzRFNYXYa+f+x8Q1fx+2CNwHu44wLzFI87Wvac8bJ5?= =?iso-8859-1?q?vKRZWl/u4UEMRZ5SFpfhV5lWIuBIsSsBLE3eP4Y171ZKaNZQb0B?= =?iso-8859-1?q?5l036MpqbWIXHsAFVm172nP0PtWbGJuWlhncPJib7DR6K5DPUOP?= =?iso-8859-1?q?oAh+ogohCxECeKYH4yWuh4gK/Que41y7MCMGcQopK1V6w8knqiS?= =?iso-8859-1?q?e5NoqqLxvmgg9Ud7i19P+s2HGHOckKpmoHqcpF9YmvLVR4SFDq5?= =?iso-8859-1?q?f1R+NrjQkn8EtyOyeK4N1iNdIKLSGzQOTf1prSdCvu/I5NCtFzi?= =?iso-8859-1?q?LMLJLlXxOXiPPwSB3+iP0zh5BJvt0VYqiL8dD4ewM/SKUEyjBdl?= =?iso-8859-1?q?Svg6Wlb9MSxvTFsI+zXlnBbYYVsAPB04Iaoj85yARu1uY1Hy4E0?= =?iso-8859-1?q?YHT5JKvaS8Z62xbqxyNfwDjHQwkpDSu2YyEGmVSv1zgDS81C+Gy?= =?iso-8859-1?q?IA+WEVnyTDZ043z6MmnipCECZduXSe/TuAxEe3GBQ3RJiYJBG+3?= =?iso-8859-1?q?d3u82aluwB/XxMgs+sF/6CXTy6kuQG4f6XR6FIVVBfdB5TloEis?= =?iso-8859-1?q?8WRA3wmVoxGGk9ncACmE5VbjiziiCUFnMkcAR8ztM7wYYtvMsZS?= =?iso-8859-1?q?0e5uNIbsmGshmGUQ89WLIm17iCw9NjdInZ4ZYKXQaGl9OiME0vj?= =?iso-8859-1?q?4LQWOUEQD13UhuowBjAHKgcKm3LHPDX+qGq7szRMxvjRzKXr6vI?= =?iso-8859-1?q?wLKy4V4RTpbAUHma3nwjfRIe0L1sCYb1isVIZzpqaQdAh09xKSG?= =?iso-8859-1?q?wkiQ2E0YLFNxVjNbocpThS+X3EKw/y6e7t7ZPY6MnGOafPU9s32?= =?iso-8859-1?q?ok0lJ+jJ/hypLZE2wCO1T82QKo2FxVsh5K4N8Dx6YvInRKTX0aB?= =?iso-8859-1?q?JGaJEh5pBDE+OYI5KpoQuaQ94+6l6vj93FEmbmn3rgobuE29tCm?= =?iso-8859-1?q?aNQn9cn7luuT13TrmFHBepiwMz7LMZgLlSc/LMum6pZKRzND25f?= =?iso-8859-1?q?PZcWcbRENGpGZ2eQDhgyvyIXytwgSElsa+dYBvP0OtpgWf5x+fQ?= =?iso-8859-1?q?7Wd5Fk91/CenchkUyXsOi3FViLg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0Kj28n+5NmA8Xtrs9SDetNuwZ2OWaCUDDbCkw1dpCL9EBYbMLS3bg56RexamNvQYsBYlPYBJXH7cJWvttNKbi5Aq+USj2QFEwk8YjWqvjiuw8SkvMsToJcVF3OC2hDFqgBv+8JLHbO3F6uUEaMaBwUR3sAD0pU3eKCNupolztvVEYiN0WP3aqwc9fiZ0ahEZYQ+oDqVTNWWlaSGuXux8vdM0E3c8/VDOswtObPqxuim4j5a4yJJY69LHPs3MmCUgyvskjvak1BzqTWRJ+LPHbbfPTo4CKIpH2ATQmf/mLh3fb5QsxRC0Dee07I5L45IOAyEERCjMgZRLKs1DnzH3YOlmmk2hG/G5wWiKtn9oBDZyS8MMrSrmd4/f/kf6VFXyAEkOio8Wmtvg4xWS8bmtxOdtKGioTGPM++yDJB+uw08= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e1fe0b6-7413-44fd-2e5f-08d69f081ffc X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:55.3441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Default rxtx logging used ERR level, that caused logger to always trigger. That caused perf degradation even if logger was not enabled but compiled in. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_rxtx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index aea58c0d5..f1519594a 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -946,7 +946,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) break; } - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u tail=%u " "eop=0x%x pkt_len=%u hash=0x%x hash_type=0x%x", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, @@ -981,7 +981,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) while (true) { new_mbuf = rte_mbuf_raw_alloc(rxq->mb_pool); if (new_mbuf == NULL) { - PMD_RX_LOG(ERR, + PMD_RX_LOG(DEBUG, "RX mbuf alloc failed port_id=%u " "queue_id=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id); @@ -1084,7 +1084,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) adapter->sw_stats.q_ibytes[rxq->queue_id] += rx_mbuf_first->pkt_len; - PMD_RX_LOG(ERR, "add mbuf segs=%d pkt_len=%d", + PMD_RX_LOG(DEBUG, "add mbuf segs=%d pkt_len=%d", rx_mbuf_first->nb_segs, rx_mbuf_first->pkt_len); } @@ -1104,7 +1104,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) */ nb_hold = (uint16_t)(nb_hold + rxq->nb_rx_hold); if (nb_hold > rxq->rx_free_thresh) { - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u rx_tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_tail=%u " "nb_hold=%u nb_rx=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, (unsigned int)tail, (unsigned int)nb_hold, @@ -1129,8 +1129,6 @@ atl_xmit_cleanup(struct atl_tx_queue *txq) struct hw_atl_txd_s *txd; int to_clean = 0; - PMD_INIT_FUNC_TRACE(); - if (txq != NULL) { sw_ring = txq->sw_ring; int head = txq->tx_head; @@ -1181,11 +1179,7 @@ atl_tso_setup(struct rte_mbuf *tx_pkt, union hw_atl_txc_s *txc) uint32_t tx_cmd = 0; uint64_t ol_flags = tx_pkt->ol_flags; - PMD_INIT_FUNC_TRACE(); - if (ol_flags & PKT_TX_TCP_SEG) { - PMD_DRV_LOG(DEBUG, "xmit TSO pkt"); - tx_cmd |= tx_desc_cmd_lso | tx_desc_cmd_l4cs; txc->cmd = 0x4; @@ -1240,8 +1234,6 @@ atl_xmit_pkt(struct aq_hw_s *hw, struct atl_tx_queue *txq, u32 tx_cmd = 0U; int desc_count = 0; - PMD_INIT_FUNC_TRACE(); - tail = txq->tx_tail; txc = (union hw_atl_txc_s *)&txq->hw_ring[tail]; From patchwork Sat Mar 2 12:10:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50769 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A1E1532C; Sat, 2 Mar 2019 13:11:02 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690054.outbound.protection.outlook.com [40.107.69.54]) by dpdk.org (Postfix) with ESMTP id 6FBEF532C for ; Sat, 2 Mar 2019 13:11:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c/OEf9ash7PN7S+DDB7rBx96j9sPW1aBZarOHiFyVso=; b=DZLcD4Yut2Zj4N1aLZEU098jxODnMWSzP8wyZbyiLSUWogf7xEe2i8SI3EZ35R2IN3brj0UPCPTvhL3hnmB/FU07YWUxsktx1pM8gYKf5tYawW1Atifyk//qHEIbcxM09spe7npQ7wdO2N9kN/bxlw3xDFWtHaAOcemsS0ZPNiM= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:59 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:59 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 09/10] net/atlantic: fix missing vlan filter offload Thread-Index: AQHU0PD/MyZPk423OEW1odPYsW2NuA== Date: Sat, 2 Mar 2019 12:10:59 +0000 Message-ID: <0dddb77c0ff52fd62487ded9d24e63ca23dff397.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08d8aca5-839b-44e2-9951-08d69f082148 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:7fmVrMJldEM5BTDiaTimhUmWwOJhDckB067/V2h?= =?iso-8859-1?q?yQ4g4xecosXvp+qec66yPia4u?= =?iso-8859-1?q?Q30iW4wX7lhO7twIAgT6kiBeBi/Rn4ujacQY7ZD5FlRBfbeuiCK?= =?iso-8859-1?q?VYPEUzPkvynbs7MrxQi+TvvCVlh+vU59u/52HN42TWkK+GSeZtG?= =?iso-8859-1?q?Aoml87Z+Bala7MFxPtiFFZ4mF4NXTqYSqsswyGhQCWPSRboZrMq?= =?iso-8859-1?q?PE0skChCHgA3qStt2w2Pyk6re50n4C2gU8leSQvp6WQIxiPT+K/?= =?iso-8859-1?q?LqX17GyPVhY4RE++1awh1vUw1zI3ScrhwfnODIZxJxeTiarHwGq?= =?iso-8859-1?q?+tuhUR5z/8Aj9HWBhsy+IFLhYhMRRKMcj4dFW4h5lz77cS4cDmM?= =?iso-8859-1?q?1Ih90krYFEenQxTTGos8xATZyhBmI64owxAJ5oC1g+GgLQQUJIV?= =?iso-8859-1?q?2yVchgED62N0RUSVrV1eF6N2foxUP6AWXmbSbSt73+L2PBeewuD?= =?iso-8859-1?q?irQMW6v7jHvnoTOTwvr0J1SSzTpoEBdKu2pdvejTZqUkN4L3/O5?= =?iso-8859-1?q?7fOBsQMGW0tzVVbfbvR3Xs7wzIuSEuG3od/Yeqt6xy6knKjJkLB?= =?iso-8859-1?q?YsG5WvoioZApetlwS+iUdo2RLuNNBAy2VAuomBb36ckUYQTArt6?= =?iso-8859-1?q?ivMUacqqhaQ9bazbbdfJDOUAMMwSskfAVfaPPRU6L7wYo/PWZx3?= =?iso-8859-1?q?1I8cCBkA6njnlmuYucDxILFdH+2MYXGUnEZUjxi68bitmuV6gYC?= =?iso-8859-1?q?iNQg24MD4Hp64hEglQe4lQO66xq6yzIBpFdh8YjXpH4JHAb6hvK?= =?iso-8859-1?q?rMB3bMOa7rZzCBSI3vvh4+y6E6kjz8hK0rY0lV8Op2hpVYuRC2l?= =?iso-8859-1?q?7mu3oLUDKnJOqN8DG8qv9f7pbFnPtClwxvLRoyJBf93HhZaFhsF?= =?iso-8859-1?q?FjjximXwmvWyi7NKbljk3rrOLfA92Ogp4IolDEF2VOb7jDENFiB?= =?iso-8859-1?q?r6/ovCzgyjC0TvyglWE7vqtS3WKU1qS46dR5fTaAYMYGPSNLwpJ?= =?iso-8859-1?q?5IKIVP8MrNUN0T5vVUWg+X72BbXJCCmQsuas5N8cW+6Y2jySzlc?= =?iso-8859-1?q?vzrKjQkGJr2h+yPMmCXdH7xuhWPj47syxb1kypHfLXtOocm1eLt?= =?iso-8859-1?q?19tIcs0RqZxB0ULKMlisLf18jzTSeLCxAh5QIo2U5YgsCyQZNNc?= =?iso-8859-1?q?N5NLnw5YEjawZbEs9nz+Wky4oekgHR2Yp6gUL5xQOk3yk/HcdDX?= =?iso-8859-1?q?mrhzUrhihqG4zV+qVULLzGgjAsx/aV353Udb7sto+AUUWkzq1X4?= =?iso-8859-1?q?Ld/1AEEJImITBcAPtPMbKPNUpJ6OffoB7tmQcBsYyaIV1PiZjd8?= =?iso-8859-1?q?T1btdIvuVOo/D9fzPTItzq9I3RsyuMThu0NXvB/kbXv3nflszVl?= =?iso-8859-1?q?77UgWE7pPHY/vj6WDoti3vw0i5q1QAcvg4LxTbeh4fV8ftkKqyY?= =?iso-8859-1?q?evZTOm2HyyY4MemKF3?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(14444005)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(4744005)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: I8SMlAQyz65NLK48H24Gzmh0WI24ESdww6K93eBiUoI19XxL9AkslBdUePvoqw+NpisCo2oYb+xKQdpmucoZOaG96txDsRPrw+FRo8ihgQdx6ZtqUGNpsaD6nnlehhfSb4CWd4vxl2FJVY5CCpQLvMr+Ck6ytj7dIBwCMdjCShd6GDx6fpZtmPAL9g27xS7m0q5VBN5mY10gDucxhLxaMNk6wzhSrpWmP8BuCdYk9+4F+D8zHaKC9DwLFtYKXSriAbs2U+syJKocK/JyrZn47d0kZb6Ju1vIMcTeEyEp5DHc3rGzwP+bsgHcu4pJcHlNKEt1H+PHeJnc7LAmsPNWqNYdOiYGNTmq5QGgeGdvPZZSy8w75dhZdnwBfisYACV/szt/BSbV29ufsYeA9X76mFBvLlag5aUVAIqAz6nZL04= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08d8aca5-839b-44e2-9951-08d69f082148 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:57.2204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 09/10] net/atlantic: fix missing vlan filter offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index ad4e5a717..c2ba19830 100644 --- a/drivers/net/atlantic/atl_ethdev.c +++ b/drivers/net/atlantic/atl_ethdev.c @@ -165,7 +165,8 @@ static struct rte_pci_driver rte_atl_pmd = { | DEV_RX_OFFLOAD_IPV4_CKSUM \ | DEV_RX_OFFLOAD_UDP_CKSUM \ | DEV_RX_OFFLOAD_TCP_CKSUM \ - | DEV_RX_OFFLOAD_JUMBO_FRAME) + | DEV_RX_OFFLOAD_JUMBO_FRAME \ + | DEV_RX_OFFLOAD_VLAN_FILTER) #define ATL_TX_OFFLOADS (DEV_TX_OFFLOAD_VLAN_INSERT \ | DEV_TX_OFFLOAD_IPV4_CKSUM \ From patchwork Sat Mar 2 12:11:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50770 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 665A55688; Sat, 2 Mar 2019 13:11:06 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690063.outbound.protection.outlook.com [40.107.69.63]) by dpdk.org (Postfix) with ESMTP id 9FE715424 for ; Sat, 2 Mar 2019 13:11:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=agTPu0q6YqqbXYYSrrtfpYEdWJ3UVPhPoWnqkN4mMaI=; b=jyZKd6C7rkLGsqaUXVfi7xxaceVR+MRqErxZqFWXv/tqzDEYLQWxH4duGBiABcnYHb/vDMr+YIHZu40v6csaARQ5y0p3LvsIruoFQNJh7fc88clORqq1NW+0BMaPsPljpCot3YMX7hboQurFyv/IVU1Al3T/YYN17Ce1e5JClGk= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:11:01 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:11:01 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 10/10] net/atlantic: fix xstats to return correct number of requested items Thread-Index: AQHU0PEAYuotUebbR0uF5hCzzsVd8A== Date: Sat, 2 Mar 2019 12:11:01 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8fe9612d-85ea-40cd-17f0-08d69f08226c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:ZxTj4o7WX9UU+0UlhdtUNsbj25Q7G3gBsb/DcpB?= =?iso-8859-1?q?c1sVdHiVylMajMiOe/fNa3FNF?= =?iso-8859-1?q?d8WUWp5exjR9YFJQmo0krto8DbcsPpnNB3NiqjmN0d4ZQBaTlSl?= =?iso-8859-1?q?Mhukrnw6U9nitUfYIzRbPunnEKUkFMpvgHyVvIpZggv6OYINLiy?= =?iso-8859-1?q?ZdNi1Wuv2/0uDPTnnKanjPH30BPMel9i3KjhnwXt9rT4G53RUtp?= =?iso-8859-1?q?mHM7ahUtNW148R5KjIM/0vzJAv2kSFHL6WOlovnuJ03By0wZ17V?= =?iso-8859-1?q?zFg/DZTaj08ruuO+7kuu8qMIo6H8cWK3DpAgE1YaDRzoNgsCjNl?= =?iso-8859-1?q?PMb6sEbscnNMH9aSD03vnNwFNpX/0wNcVCRDaCr52nq0UhXL9j7?= =?iso-8859-1?q?MMq205LL8RSskYF3y/Cof57bJRmseOCxsQ6ryI+/8t/2e3lgNS+?= =?iso-8859-1?q?VCi8sqWERnsL03w319dBS4xAwWVDB6bHbkmWwC+fo/09hB7zBrv?= =?iso-8859-1?q?jaZjYWwxNeHntWDxXs1M1XwdgtQriwhQMeR7JOtPMlRjyQ5FLrI?= =?iso-8859-1?q?94WbNDeAnOH9KUe4SRy39QrMNZZJ4pZOmD5NdAp2AMLa8bS7DP0?= =?iso-8859-1?q?/H8/EGlzHl/kzS/zwLnI66tL8hnC6i0FtKypV1Iymz/gFaLHJOq?= =?iso-8859-1?q?nxi6jhZicCSNY+Li7btHHQ2JopIiSWp5R/StOO9S3TPAuCYircY?= =?iso-8859-1?q?yQ6QoURpDtzuRLqCEHMj9+v4Jo8rSaRh1yDS3ZNtDynf7wUY64C?= =?iso-8859-1?q?AyTHo2+FZCL4Xvg6xgGzNUR6KXyT0buaCHQ4+rK6ow6FVxqo8gc?= =?iso-8859-1?q?OwMmAOvzM2LSeLBviMNN2yH90aBKi21E4U062ck/+DXboIbDN0V?= =?iso-8859-1?q?155uFeUXGcrNX/0NI//yNbfhsjzWRXTRUjx5exIntKk5ht2DEJw?= =?iso-8859-1?q?iQQZ/mQIKNJJ/AYAChFjNpsGDF5OOr1w2EZ8IWt/DJPOTnrz0sg?= =?iso-8859-1?q?EcQy4Ewb4cc3rL/ssHwM320Wp3XEFqDcExbapidroupz/txoSJc?= =?iso-8859-1?q?3vjgh9CQAN8vWdNkpp2VOXg4d+LO0KVzEh+6cYHLdHlDG2CLoCb?= =?iso-8859-1?q?/D9WttT64+lwhSaQ4hkLes1eDYDqaLqll41BvkOsJ+9II2D8pED?= =?iso-8859-1?q?2o5Ukcq2UfzK1RadjIjw0gSQnoM7QXcFphU0BypTBjys/TO+BEu?= =?iso-8859-1?q?ePhENtmBTAFWGppBq7Qf9vgGHBsFkmItI92oUxMjw6BTUL3PdnP?= =?iso-8859-1?q?6zD2UPWt4mJJI86G9aY/c/wpMkSDo2EEDMwC99uZzsJKAVduJu9?= =?iso-8859-1?q?ea0EpAdl9G79g5CO3PWIbS1/tTUwsPKsFptsGV0RihnsaPUI+xi?= =?iso-8859-1?q?VKUjtb0ocf3O1LsQgTydZ2tUSO372dkRDWXRKYKJaT0AzOL7+EV?= =?iso-8859-1?q?ThYlkdkfGp5vNr0BJ4AQu4k7xQzw+KzlLtGX0nQ65qbwIE1FZUE?= =?iso-8859-1?q?q7OFjy1h6by0Jj++1Fn+sWgIVcK9roB66NYRN9hf2sItbP/cMUf?= =?iso-8859-1?q?p586ObrDYQYBpVOvDWGiGrHqT+WYvRI/yhg5nxhBEpLHLvltVya?= =?iso-8859-1?q?uw=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(4744005)(118296001)(50226002)(44832011)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: B8ACzeK0O/8we3Iqop3xIgMWssgkGvCL6Z+1TieHAx3nbJ8M8j3bQ8Qz+gnLktEidbDiWBdWSfTochOR4sQnVAjwGoChZCcHqTQTVRaj2NeiB6MUQraLBCT475XM6PfqnRkMJCzECm02PV3aggvJI6tA2YQiwoOb2KIPJqFD9xRtcqWOH9/VES6BKpgp+JqQBwWOj/hJ6AlLdfLmvujXZZVD9UoNYzbulkbOt6gG8irfnOqq0KoWP35cpIKKBAg6jxFSyir7kWCfZun46dwYS97fG/QKR9bQh1tBJrdKKO+bCdnyES/w1Y2YGoC2U0p9p6WlG+ifOqfxicXDlZ7lvg2ns7jeVnd2RTfY6f5qjgE3eVOiUfv97nBWbJZwVHRbsY/vurPQtObAXYx8VW0besRckZvGOKyhR3SGuzepkVI= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fe9612d-85ea-40cd-17f0-08d69f08226c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:59.4300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 10/10] net/atlantic: fix xstats to return correct number of requested items X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Igor Russkikh Reviewed-by: Rami Rosen --- drivers/net/atlantic/atl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index c2ba19830..d40645283 100644 --- a/drivers/net/atlantic/atl_ethdev.c +++ b/drivers/net/atlantic/atl_ethdev.c @@ -758,7 +758,7 @@ atl_dev_xstats_get_names(struct rte_eth_dev *dev __rte_unused, snprintf(xstats_names[i].name, RTE_ETH_XSTATS_NAME_SIZE, "%s", atl_xstats_tbl[i].name); - return size; + return i; } static int @@ -778,7 +778,7 @@ atl_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats, atl_xstats_tbl[i].offset); } - return n; + return i; } static int