From patchwork Thu Jun 7 16:30:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 40778 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61DEB1B405; Thu, 7 Jun 2018 18:31:16 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0082.outbound.protection.outlook.com [104.47.37.82]) by dpdk.org (Postfix) with ESMTP id F38271B3F2; Thu, 7 Jun 2018 18:31:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tBfm4yiPoBk0DsGpYj+sqW1kSTq068eBTaGZXyykBsg=; b=gZX3/VTlhTOtWWu3f4aT4+6jWmay3nT/DMKHtLhyoEdfOigWtQO1rtHhqiHYcvJUASVtTVelImZJf93U+Z5SNdogKUsVULiBSPpgmF1yxvseEDAmdRVl7ghPSii3b4r6DT76UH0cuOfg3sPfxxCzs+ShAeo24DHTYVlcAyb3/p4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4018.namprd07.prod.outlook.com (2603:10b6:207:4b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 7 Jun 2018 16:31:11 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Thu, 7 Jun 2018 09:30:51 -0700 Message-Id: <1528389052-4875-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR07CA0011.namprd07.prod.outlook.com (2603:10b6:a02:bc::24) To BL0PR07MB4018.namprd07.prod.outlook.com (2603:10b6:207:4b::20) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4018; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 3:iJ9G9q/tOBrH056XUg3d2U+dHjqZEFmLeFv7l2H9czysmyI86TxAHMPShp7iNy0sZo/WUrTWn0F/PzUs/C8JrK6ojgrxR3vTx0XpC6lBrmZKSBIFduioz/8bqyjmVGNANjyz+Dq+/SG9cGM7vTdm6yETdjKxb2vkWLncWuBgxYWNwnUr/J3eAx1Yrm8maZ5oF5MEOq4DjoJCiT89NNFtQRwpWdwRiXRxg+GRcRtyY96NE5ypX6r/yloD/exvAD85; 25:fazXHe6+cxQwLm/fj0HJDNwiWoMkDrLU5cJdGxQi2Hxs8bMgXP1CHOJplBOyR/AFsWaxqfWzenwAN2wLQIgamfrK9VcjGPTz/xk/6BIvu9InCI9Gyk0OplGIs6J7On6EBnEybkjsbqkdr7jY9wasNyHJPRUd1YufYpf/wmTI9okUQLycGFOuFwknmWV5slJdBaWhLAbU+2eEDPZ0hM5epNQytQ3P3qaiEmj+l3FeYqtQ5UdAMYV36AhB3a69N01dMvrc0hR/6d374XVZLBKRZ9rsw+IDd708dU/Y16Bgcz4AJx17/r+e6PAMTcg/XL4jFPNWNzMvgyVY6kRljoXvNw==; 31:rjZyiPlfncbo09sHELvEK1CfPXb4cHkAs9wlqmistXWZ9XYPda+laO7xzuuaiRfhIAuyMvvztBNbTKAernh6zFYQqiI3f1stq/oqsghPM5NGFmA57EsAoT+vtQ1g8sfureInsVdXz1dULqXIcngGqMDrqgdNL0H7ArKhloEcfQqVfHyok10yvKwvhbc3S0+0KA+hKo9GIX7kxjdckMZ/0P2gRxO8u7ohRZjUehlJ/Fc= X-MS-TrafficTypeDiagnostic: BL0PR07MB4018: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 20:V9vZ+LQeTwIBGQLGQid/YPRjw31znb+mqi57jL991O4FwgkUQPXbk508CzqnDCB3yJF2du7gioSEnTI+4ocfwefegUZkb01teEt4PR0Lw5scNTSMS6IyYZauIGE/cyV4HpXab/dDwxnG+X5BWhLet9Ve1Fb5y9mNeBfOY/U5AEJZ4Me++1n+kwN9Ykbp1d7VNB07DV3V7H1JRqwIRcDjPJwEPSYK1dBGb7HVsF/zEqAajLJ0B2KNrFUQQTZenx+Ikk6smJ7ITtJ8jdKHF2Gf0wKfpFD8H35r6YR5pmzxNvn7c4gfpqgUbHm/QzV6xkWEYN1T1lwQyEl4jbmb3xMSS7bM0Zk7fQ89Audk+d/ANwOTzm0yROm4SQnu53rd3nU/GbWb9tX4tbhvMqlf06ogfK82NDQEoCzOVW8S4OQHC6WG5gOUkYTxZgFedrRBLCzQAwlggl/7qVVbsgxRcqckQjjIoutNdTeTR9UiJq94ZqWla4eA1RCx+Jjylbas8p9l; 4:9csAla1piCwkxU0cyLz00bNb0coMrVjbwBXv/eGyFgaG0y/49sNODi9XT55OGNG7tQdi9j8+hpr/4txtIZcsZpOCQkw3Yln7AfK+XBVRzgbEMJU6ap1JbgB4YXOW99G61NNkWCQQcM6jqbDcoP7IYpCRDDT1ODUrzleQ2OmfCIY0azKPQ9uJ44W2SLEbommQ/v705ogLeT7AnTfA5+x45/Ht2oX+628aMShsPaJcT9SXq1cv2iCp4jpBxAbrUPdn7agx8ECltJP3c46xzrPe8Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4018; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4018; X-Forefront-PRVS: 06968FD8C4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(39380400002)(39860400002)(199004)(189003)(478600001)(8936002)(72206003)(5660300001)(51416003)(97736004)(7696005)(52116002)(8676002)(16526019)(36756003)(386003)(59450400001)(68736007)(7736002)(6916009)(6666003)(69596002)(106356001)(66066001)(105586002)(305945005)(47776003)(50466002)(2351001)(25786009)(48376002)(81166006)(81156014)(956004)(2616005)(476003)(16586007)(4326008)(4720700003)(2361001)(86362001)(26005)(6116002)(3846002)(50226002)(55016002)(486006)(316002)(44832011)(2906002)(186003)(53936002)(21086003); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4018; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4018; 23:ImyM60P/zi0hoRdq3IdiIKlMfgc3KibzPkKE8lkkY?= k/+aOja7a3dmU1iVJqM7VNIVSzUte5GYM8+h7KKItci3MDg22UE+2Otp56q3x0D5NsFGirjU8YmdPQ/9fEKxxrxs6xysRKAwgh/px/8XyoLc/cq2OwAKMSM7jnvDg7y51Qw0PItzVC0vVf/OFsNSsNh0RABWbXwun3Bv4OBo3ePsWfiejNINJIufERLUZwGNi9d4uiUgIB07sTatXih864Wyu+kKCZgyxuBu9HyWB9FAg8UO/M79YwYskA8xgbv1SoLEOICQmb59saXLWg8/65jknu9F+c8E/NSiJ+yuv1Ow29H4uLQ9blRZryOTs7xsacU4yqcbj/h0COjMVbaYjkG5Q8PVqCjYWrMwz/Mu6LaMETO26bazZMJjEj2bVWFtn8lNAp/V0YMuWiKFleIr/9lApXhPo/qOMA8rPRo4Zj5x7GHP5w25Hdcrmt6Yc6yDD/oQtvwJAcF53Z+p6Jixlm9mOGRzB3a/9G/lB+MhmvH8J11vcs428t0+ScKisSxJQVS5EcWQz2o+vRAzbYzwhDc+rBCiMp2xa8GhiFugTVTrPDsFvVTPRs2IHFu070rdAw0uckOn24wnNsukX3TpYTQMjEza8v7OtA3/Z6ZxT56yAJku8ilnydfDMFfaCgbo/cCHPsPfMxkjKs5r2y7x7CprN2z8lhNLN2GXLYNxHYoe2dTyob/7DJveEyDeED9fnjRWRsyZ4ckq4jaQ+vj1nD+yHpPrBpvTy381X/1K5bxwauNiTxMpKAOioJqUSkBB+dqMptbYR/G6IUlStMqTymZLg0FhDy/yYc38kOW9De1clqsVix7XbsdkqDUIN7IVazxn0XLOwYS1mTxjRueWHOspiI94/adJUZF98gPK/UdYrZjNnC67ul0b3DDe/MStJiJwBAwLMn7vunh/L2pG5z1ZJnj0xUTVvJmA1zTxU7dsOhie3IBmWVM5XX+XEXnzY0TBKA/eGxTCFL73msJ+IX9b71MBetpQOaa6hLKGP+rEexVcBNYMbKd8dbFSLFFgq4uVldCOailh8UpXFcGvYxZ35htLgRKGBH3RNyZCJSxxab+mfn1KK79uZn0yLGwqEA6EHzgdyAvRzi4cTfy1BSRHVg4hznas9+fpMxM9952yEMYNhsfxSU7v4P5FA29PT2S+3heKw4LhGxgqzy4DHf+aglVF1tuKFrpBcWGVuUgdsGEvXDy9FHOq9OBo/2RiLizapVhSLWBKFVFmX2RgO78b3RNhqJjBVo+jquRBu9qXw== X-Microsoft-Antispam-Message-Info: WogCTrvrTQjzZMFLCzlbBgceZUuafRf0LrGqlMJZ8dHkXJhPjGw91nQ8hCbxxDkh63EGCC/Cw5nJlarGhU/0Ssf0mfhKhEiGlGfk6GBgdRet9+HRTJYTX4DjvX/cKZ6gIw0L2rILkfH1A+NFPjfdhkk9zHiYbPjQgHbrTBcQXlU4lfJMK/9Zhy2eVIB/tvmp X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 6:MJ58xDzGwFOBnD56bOS1v+JCl+xQMIF/SEMp0n3aPNqWjYjJAnDnDzttqYew9uH1fX/9laSCiHQ+Q0+7P/+yKBBsAH8DjtBogmJuhmYSZR+jY5m2JyfNViHPnmGzLdKXV1nkNpByJ8spUPVKB8Nch7HzEpYykv9DB2NG/9iA+UEWJ6Ba6ww6UVNBqslJB93PHstQujfjwAByXiD3cpr0cakn1dRM1zbcB1O/Ey19WwEx/OSBltubPC4rw7kpyRYqVL8u0JOgw0zCwaEXmWEdXMGEAbPEGaNLyfb3Na3pIYHQUfMWQ4h1TuTDeC775B8PHaXGH42NdiQ6xXisXOc1T7QtxjYytTPldUfkYJi34wc8ZyiJj5+w+LIsgS9ecjoMDkQw8y5AX+eOxKuFcZmmGzRPLME7tKdja9ZWLCDd/PT4X9Nd47RXw9CSuBh8loYMiAyDuhcKn1gL/qtQyFLQRw==; 5:eBegJZU9+YyYTCXD8rofaiejwOXNTQJeKRXJuXj58Z7BHcVfpyhuS5rYwTCZaILxWo36C0B6J8nEP3zDSwa/i0w+QraD3IJK26Muw70ofSdrrYNJ2cXnfrmWZK3XEtt3XzWT/IqM959vErSh+Ndi3N/Be3HLuvKp1TBnOnSaze8=; 24:q82BcV+ngJV3S3UkfARS+8hvg2VBO9eHLyjXvCrY3DLUguupmOHiOhhpta2m7bezmdgffaGrCbv9xVFhaTBRfPmWUtlnONQSNxJ95KfLprk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 7:Bo3W9UZDHi6O0otxCmp+Mgi9LPyqht1KBDQCHgcSqXEsWx2h4yacFPgL7SYcuP2a1T1OudJWnwDVv7fRi3YC2VjGZ6NKmkMdNojENbaD5o6nNSyjMViCAC9LY5IUBxXtydIu68e57zWfLADilH/G6FkJyOqDZddKJQSZPrbwM36cwvgsTH/SsjXAmAmpEY5VIx41UizDmwLAG9UqbRru29SwZNd5p7C1WlQCBAmj3zaqwDT9SBa/dpuAeDmDX53B X-MS-Office365-Filtering-Correlation-Id: 9220ab75-941a-4d9b-7bf4-08d5cc9414b4 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2018 16:31:11.0887 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9220ab75-941a-4d9b-7bf4-08d5cc9414b4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4018 Subject: [dpdk-dev] [PATCH 1/2] net/qede: fix incorrect link status update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shahed Shaikh qede_link_update() always returns -1 i.e. link not changed, becasue it compares the variables which always hold same value. Fix this function by using rte_eth_linkstatus_set(). Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index cd9ec10..7a63d05 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1590,18 +1590,20 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = eth_dev->data->dev_private; struct ecore_dev *edev = &qdev->edev; + struct qed_link_output q_link; + struct rte_eth_link link; uint16_t link_duplex; - struct qed_link_output link; - struct rte_eth_link *curr = ð_dev->data->dev_link; - memset(&link, 0, sizeof(struct qed_link_output)); - qdev->ops->common->get_link(edev, &link); + memset(&q_link, 0, sizeof(q_link)); + memset(&link, 0, sizeof(link)); + + qdev->ops->common->get_link(edev, &q_link); /* Link Speed */ - curr->link_speed = link.speed; + link.link_speed = q_link.speed; /* Link Mode */ - switch (link.duplex) { + switch (q_link.duplex) { case QEDE_DUPLEX_HALF: link_duplex = ETH_LINK_HALF_DUPLEX; break; @@ -1612,21 +1614,20 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) default: link_duplex = -1; } - curr->link_duplex = link_duplex; + link.link_duplex = link_duplex; /* Link Status */ - curr->link_status = (link.link_up) ? ETH_LINK_UP : ETH_LINK_DOWN; + link.link_status = q_link.link_up ? ETH_LINK_UP : ETH_LINK_DOWN; /* AN */ - curr->link_autoneg = (link.supported_caps & QEDE_SUPPORTED_AUTONEG) ? + link.link_autoneg = (q_link.supported_caps & QEDE_SUPPORTED_AUTONEG) ? ETH_LINK_AUTONEG : ETH_LINK_FIXED; DP_INFO(edev, "Link - Speed %u Mode %u AN %u Status %u\n", - curr->link_speed, curr->link_duplex, - curr->link_autoneg, curr->link_status); + link.link_speed, link.link_duplex, + link.link_autoneg, link.link_status); - /* return 0 means link status changed, -1 means not changed */ - return ((curr->link_status == link.link_up) ? -1 : 0); + return rte_eth_linkstatus_set(eth_dev, &link); } static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev) From patchwork Thu Jun 7 16:30:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 40779 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE5011B424; Thu, 7 Jun 2018 18:31:19 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0050.outbound.protection.outlook.com [104.47.37.50]) by dpdk.org (Postfix) with ESMTP id 5E2BF1B424; Thu, 7 Jun 2018 18:31:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dxu6v8jp0/9FEhnfPMrF8kjT/d1RPGkcBi7U4T+1ziE=; b=U0n0nbgnIWmeQCvDhO1zltA0zMND+YvHX+QFx8AfBfp3vVmtSqxsgz4K4nwrNwnGVk07tQ3eH/cgKJ1jmgcnn+srKejuRBFZueIrH9zNOKj07RErJ61nlJkzlRNl0G0JOoZAAHcTjWCYwH07+SV61uCjSRoMkQt0Md2mHlGVvpQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4018.namprd07.prod.outlook.com (2603:10b6:207:4b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 7 Jun 2018 16:31:14 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Thu, 7 Jun 2018 09:30:52 -0700 Message-Id: <1528389052-4875-2-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1528389052-4875-1-git-send-email-rasesh.mody@cavium.com> References: <1528389052-4875-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR07CA0011.namprd07.prod.outlook.com (2603:10b6:a02:bc::24) To BL0PR07MB4018.namprd07.prod.outlook.com (2603:10b6:207:4b::20) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4018; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 3:Cct8gLbaoGgFI1lXh2qVNYKtUlrS7s3xkanRfeM3BzSMp8/ix5ePbGaaWLBPsAQnoyEM9cLKmM280MfE0WmZ8x8vLC+VS9KPpOzwyG+vOpefLWZXt7zwjfOGBTGDdFySGuNiwZmm81p/g7Dsx0PD6gqaQSokCl+iuF5MCsNfcPONvtR/Q1TrLPBh8u/X5pDY8QJllAzv4I33QSKfg0VN2nEHm6tR8PZkPQ0B9oChF1Gk4qp2GiiJeAwuRDvOUNTw; 25:lM73jPQDcx73pFhHJ3c5QOZPnnHwwwM92DJ4IAXPMt9JXTsT/HEaWEzkPR0x9ELgSnuE2d/jpTEDQb6cjKCj7p0xbtmn4RbTivx0pmpGp8Auu76A/6LttB+e1wsU1NmxejsvZbPC+oh+uBdmZkr/PqAJp44Qi7L/ES9U4NgVcZUUCj76F+RkZGOg1ajY7oHm+vNtkYg055mHHAzNNu75G6b490QLsz7aefGWyX4CcUKO9pXRXOHly86MHB8SBYG015s8Mow4ufXj4T7rlfwlymrVGxkEjs8Cjxth62dvuM5af0fQ2l/o5iwrNCti9xbSshYBO0NW/ORBjJGZ8IpZGA==; 31:Ou5eJLhOibeU6cU3I2aANvhkTsCeAwNRV64i4pDHjyTG98w2Xy4AJlyrvbXkWQVOaf1tmFQ5l8/vy/RAzEOTpFY/37s3Y1rrfy5KE7F9kZHSGiCzJQjCgkkTAWA5KCet1Ips5YJd6kooIGGnlp/lIBYWG/IMeeIr6m6VcqO55cs7FyZ9Fd3e2IgKyAR18LR4D+MGAkCuk2NlGumXtL2R61oYHvXDfNkKPjWRnSx9PEo= X-MS-TrafficTypeDiagnostic: BL0PR07MB4018: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 20:QDZ/mfSIpLPUk6HkntEjmewe5ek06FkBxRM9MPBV77KNavKTvXRlEGXnkNug7pAyGRmlocHPT1f1Ffamrz0lbr71X/fUp0OJqlq+WcuC44j7MCqFjFLdlw26NpZShItbUYz0S1VRzdkdyLbMpTPE24RGObgZxEjiRaIByBWT1sZUsycIiv3oyxz9Rl3OyLQ8oNEaUWZksNmyGj2NJYoHT/euF+Y7Mr///gumms21gSvsT6jmfrqkZPU2RHirrdPX3WxE3G47ZK193T9EkYzTOwcm46PRpfL1/KlPreh7WrukGe0izfRWG09+IotBpSgYiuQq087snpwfqhfp7thQ2akzWw2mGadrAgCZlU+MivksJJ2crDvfrFG5VGEBhexPQKx7Nm1o9HWKVWKwhEVCK0Tddrh3EJPTb9488ZsWw8S5Qt8geVBpl5Mf6GHNypmavuCPcWF69TGede+KcFOWJ6anOGaQ6P68M1goNcvcaLzqZbcSZJG2JMwhgfcbAmAU; 4:r3/jEATZm0c37yJS9LKGhPxygFFVbW09fLN3rzsDqFkZ+UpqHFZw+OECalUnwRtxpJ2sBlshfSeN/QxCnVQd424wMyLP6FCXvw7edOTwJ8vw5qGsrHc3evLbfvBP01k/5BlVo9i5zVZ4WmOnvT8niivTpKaTpKqs8hNnBjaHepaqq6kW6x6z+UrDol1NDcHZpAPEvB7/51CQAZAJAJeuM9+7NBe3oETukCy9fVq888LR7eYVz0DejedUbxUpn6DHig+T43BveNm6u7NJHgFRen9roiAmuqbgFm1za2+S3z7iTzDqEGFotJ092S723gGE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4018; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4018; X-Forefront-PRVS: 06968FD8C4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(39380400002)(39860400002)(199004)(189003)(478600001)(8936002)(72206003)(5660300001)(51416003)(97736004)(7696005)(52116002)(8676002)(16526019)(36756003)(386003)(59450400001)(76176011)(68736007)(7736002)(6916009)(6666003)(69596002)(106356001)(66066001)(105586002)(305945005)(47776003)(50466002)(2351001)(25786009)(48376002)(81166006)(81156014)(956004)(2616005)(476003)(16586007)(4326008)(4720700003)(2361001)(15650500001)(86362001)(26005)(6116002)(3846002)(50226002)(55016002)(486006)(316002)(446003)(44832011)(11346002)(2906002)(186003)(53936002)(21086003); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4018; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4018; 23:hB+OG9m6/VOpF7RtuAAIuZ8tbLL8kG3pYtQMZwr9f?= K/ZbyC7uFby2Qke23OC926snmnFcEiYyIxFTgFzxS138rFsFHSg/mmviMmCz553ZsNIBjRKe+cDUisO0dmGpOGRg0z5aHhPuKUpLHgHFn1v4JYLHOEZQMpdvnHYVEtlBCovvf1EMHSrdxUwy+N3tKz1WblwgAMwO4iZ1+yCp7QN9nEeWabTqaZrchBVwm0owoWcORG654IDrfT5eo8iHLZUzONAFDCpKrcNYqxfUV2YuKk8XYX7JALNqERRHf9mq4yEu2d3a9jk0Bz49OjXf7ka9ACYN4/OV68sPwNcwUeXA/Tnfh6A0Ninm3okukPAuCLgxNJr8UR4tK1fNKRsLNqMimRHdYzA9EVicmlS0bngQYJzJLTB1ZpTDmos/7iKo6kvXMNFn2ifXSu2JLzkM02RmtDKUUf7i82lI6tWxC44X32Cp2jerdoBXC9Zxj29mKLnmDROmJpPJtgJmVxhshzhjxUnKmgRzXZuspZrTjMVtoda/R+JBUBqWskP67TVLrOGwPnpQ9ver8j/e38bjkBZz1mJKlmlyoTkHxkV09fLayK5gM881bOUkGKkb0A5jEomIX6MehvOyV095e2vAl7WSnykeSgErhnBdTaQGNoE19f3BLaD1IX2eZ3AIEnEXX70AxGiUWEEpX9C+6eOujsGsPp9s0rLp8dDABFG7aaJrJqmhq0thYN0O+QcB6R0AYZwm6RGSBY8f7GErNVSpyhbssreUZymj68Cib6TuulM33A35tJimyvGOtTzRvJKG6SC1pwChC43AjEVSKkPcP4bREJZEn6Kq9aisrzaWN8Wq7PJeBF8cp5kAgxi9nXQah/dioAhdxUxgHh5l4D9SARfA/fBjxS+DIB6CaqFowYFmuqUx5HJmwoLUrLAjH6etBGAf1IU/3M3GaK1qMiYnXVjFP78O6v9p+AhWb6AJToHGFVh8EOyK3ivg+YZSEw6B5FtgHmNhiqS1I1B4FXSaTVyrSF8/tuO1TTb6GaODvs0IRgCnyuq4TbSB6amE/1IHOnJ9lUU9rOlY7Psh5ITJ4Vam3ZzGy+m6827KqmXVRPPkg18OMqzNnlp1mXt+XmaXfA2qlmyGKwJeNnlOBJuux/XVESP41dPxQ5fqmQTomfd1rXX3ZNNiuyx7XDPf3HHuydMbTOBw394verVzTEbTsdfa75H3LU1+wSta7RW1tS+tfXJps8jZJdahzJsIj/v4uCZ0nxV1/WAHitCylZaJ6tn+SPRjc0OGgtjxflVglv0ycXnsIFVsZxXqRWBY9RSI8BWjpMGJ1nQ2h3rBMgHHeuI0lHpoXqPYBGd+8jxHnvw4Q== X-Microsoft-Antispam-Message-Info: oc3AhDMFSVVR6RSj9eycJaUdQLHHna1AP4NgA7qP0Xw8UUzg/qIZDUmqKOBsl9JkNUa5Nl6ddJt4B3UaynDj/CQwLe1mm+tgA1rj152M4rHRZG/xaDwmxtdgr9SGCHC38Wc5RltleFQW6BsZS3yBLeqsVSJWrZKjPBB6hk8WUzSwrfLcNci3cq6KHNBQaCzo X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 6:gkoCfk21KiCIeXvlJNqu82jVJRfygVYQRriy+jAiVcqpLHPSsmUM2NeKszs1ZQ3t8BJ9Y201O4FC299v38aW2kDJ/1N+5TTD+vld1FkS3eYIK3fazfZJkiybh5cXwWEaSx97SBGizC5S/FJOPGi2Bs5B3LmOCQBMrRXr2cwwBqCwbXlc81Xpqlz+USdSG5upZhaRLqrCJT9VTiwX44IKkP/WqKB2QiR9QVhXgO6uhmvsrR2GRXug1czKM0c0+4NYnWCfIMb/OoJdpj4ZC0H/nalZarU44Ap4pnIUfMVSLbzUwjD4s4PdoBmiN1pOXoqaaMCEq349akyHqleg1PJD63g/ERNA3VOGqEDdpsbAV/cINb0rtDRMXjMQtBcOcvUFl7rapHRn+lOsKYopCqoZFLIplMjrm1Qsdc1AoLGdQWTvKuQUUnKZu8qa8uxPU6/cdQsdqsmL6JUMt4WRKnVu/g==; 5:Fj+8TvZfN90Bhb1NWgPyXW7Q/LUj+C+0wG02huLMtV+wZojnuNBOhnSRPk8Sm4sb+FOYGSVX3/BBRVHFs+ZPNYAkGMcxx+2Wcu6WUnL1yUrQKKljAqUrSzpCP2AkufbmAq5VHaOMDhmeXBsAS8Bdrt5N/bLRv1+pe15GYw2u8pk=; 24:SQV0+1/w3leiKQHVkHFE8tb8aNPDQXRPXiFjtchntHylh1JApeaHZ2xI2r0FT8ok+gl885/Oa/GkVYLbH3pXjntHhGvyzraSbrIAORjktYM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4018; 7:SGhHrvC+9IYpre7SKEJRxcy/rUBuFtAxeH7/ReDm+sS2rg4S0M8eTtVVRZecSza+s2y0AEQ3RwThujW0kxf0qJwOjBDC2Rgl1J7lAicMtw/sht6IOtj18Lw4UXOe9AUZTotu5AQVuT9A4Ii7vAD/uWhVdfMKkxATsZ1StE+a8NytLRQc6sQjxJqtkb0BNzR1olTYTUF3iHF1+LlNWMir2gECg/eu4sjWR+3NPWwLuli1dpyG3yxE1/5RsExR9/Vr X-MS-Office365-Filtering-Correlation-Id: 5332125e-1af0-4123-20b9-08d5cc9416d9 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2018 16:31:14.3890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5332125e-1af0-4123-20b9-08d5cc9416d9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4018 Subject: [dpdk-dev] [PATCH 2/2] net/qede: fix link change event notification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shahed Shaikh As per existing behavior, when firmware sends a link change notification, PMD only updates the link structure but does not notify applications about it. This results in application sending packets even when link status is down. Fix this issue by issuing RTE_ETH_EVENT_INTR_LSC. Fixes: ec94dbc57362 ("qede: add base driver") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index c3407fe..de5a7ca 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -634,8 +634,11 @@ void qed_link_update(struct ecore_hwfn *hwfn) { struct ecore_dev *edev = hwfn->p_dev; struct qede_dev *qdev = (struct qede_dev *)edev; + struct rte_eth_dev *dev = (struct rte_eth_dev *)qdev->ethdev; - qede_link_update((struct rte_eth_dev *)qdev->ethdev, 0); + if (!qede_link_update(dev, 0)) + _rte_eth_dev_callback_process(dev, + RTE_ETH_EVENT_INTR_LSC, NULL); } static int qed_drain(struct ecore_dev *edev)