From patchwork Tue Sep 24 10:52:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Li X-Patchwork-Id: 144409 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52AFB45A16; Tue, 24 Sep 2024 12:53:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E94F402E2; Tue, 24 Sep 2024 12:53:42 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45]) by mails.dpdk.org (Postfix) with ESMTP id D85EC4028E; Tue, 24 Sep 2024 12:53:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MjTGpCAXoOYhUKp2XKl7o0S3rTWNY7zxInGaAulaulzc/atFRYR38EtRa6XljHdsnnsBDHOHXyX6IgKHx15dycEirFFkGS/LR3lO21P5YU2bsUg3WS1nmAgh94YO3S3NQONyiLIHdR8IDj/GB9oNBvq6IVAuTsjLrr6iISyJhGfutR0v0HsEGRyq9fO+RbfCDR5/dVJRrkSF4cL57K30bdvHodgtVLQho9F8X05l9lLv6D8A+h6QAoPg+TNJlHBvDDNMuvgtr1IfYe4P3WNaLwRpA6RzxfuSav0HhN19/EnTLMl+f9GfF3S7+grJVP0lV7eClTnj4/mAq6cLo/WnZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aKyuQaC51tP+FD3nlKTijM2LT3ZeIC8y7uHB724M77c=; b=ZaCzz3GslsyIUpK7q9ajjk7Vy7LfBKyRqhADUlZ0vGxpKMpADxIBLF0h6sAHEJ8pSVWoOE38R1BcTrbjZXuYPTwvQ1NifENwxdNAJydFfSCCoNyrWGcvS8BTOSyi95KPWd+6fapGKLS+ibqPwnffv4/fflPa15jsxeIZusWvchj82lYU3oEJ/Vv/ZFodgAKbsUcv6oPWbZQDvLDFN4xTjAUqUnKqvb1bbwJbuvu6CRHzth8Ti2FgP+6OJOjJNuAqIo1Sx409SMBcPsdz7a+BZ1jIYp7IywjGlE1jyHAtdLu+azE7cq6gHAag/UQo8tw27HvscSkOpXLc+1+NhOg65w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aKyuQaC51tP+FD3nlKTijM2LT3ZeIC8y7uHB724M77c=; b=njDE4Q4sJBhrwm+6zJgdkr3/DzMW84T6KunPzXGMEvdgoAdDCl/pgh9PAPHhWhvpa+OwyzVdiq0dZ6XKI021UC35RrhIUHoGsdoVl8tJQOM2RXJ1zeqBA1IXlYSWwSerweKAo3xrod3NE0Rr/Tu+e7Qt2MqHh8H4yq2rKzVqQM5i88dYXh0505NprNaFaq7tPPhO1IMZ57T+ajJ125OOunO7QOgUPAcw6ZmE9fMa5mpbZokTSoOpomHCDwEZT4hSQubcf0TvEonsVb2RKCdN8CdajHKIr8O6P0KmMP7dIttwHTvTXwtijQPWBuNiSGOYxk/rqr3RJv5UxKwxSJh0vA== Received: from BL1PR13CA0187.namprd13.prod.outlook.com (2603:10b6:208:2be::12) by DM6PR12MB4108.namprd12.prod.outlook.com (2603:10b6:5:220::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.28; Tue, 24 Sep 2024 10:53:32 +0000 Received: from BL6PEPF0001AB73.namprd02.prod.outlook.com (2603:10b6:208:2be:cafe::92) by BL1PR13CA0187.outlook.office365.com (2603:10b6:208:2be::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.17 via Frontend Transport; Tue, 24 Sep 2024 10:53:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0001AB73.mail.protection.outlook.com (10.167.242.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 24 Sep 2024 10:53:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:17 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:14 -0700 From: "Minggang Li(Gavin)" To: , , , , Dariusz Sosnowski , Bing Zhao , Suanming Mou , Alexander Kozyrev CC: , , Subject: [PATCH V3 1/3] net/mlx5: set rte errno if malloc failed Date: Tue, 24 Sep 2024 13:52:56 +0300 Message-ID: <20240924105258.58037-2-gavinl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240924105258.58037-1-gavinl@nvidia.com> References: <20240924055938.48374-4-gavinl@nvidia.com> <20240924105258.58037-1-gavinl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB73:EE_|DM6PR12MB4108:EE_ X-MS-Office365-Filtering-Correlation-Id: 8acb129d-9048-4d14-0ebc-08dcdc87216a X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: 8bCN1NLVfC2L801WVtWw5mzzExX4sgBykYaM72fmTN2MysoN8hoyDOOb8UfWRR2RzYMtLI9OdfOYcJezGO/99TACn9GpPazlmyr6+3W9YGjHEvEA5UpWXFFhsx4EjqnOLydOYgS2sLn+Cz0FuW4ONuJUl4jH/GAUWVPPcOQ6i38m7m6aUhtAmN2sqO0RCCMbDE6vtULAYYBCKz4j9jQu9S1bsjRv79JrLzsXbaQcW4BD9rkgdPSVrmAGxxtUv3+WPZNSgVn20RvcfvS9mJjhpd0YsYIDccXTs0LrniBfGhx1OrW2vakb7xwEww9VRLCkPRgdZmYVkcj1PBpQwUrlQ6wlB8/miiIME6yJtgPMbNmo4B1xk93hnr81DhqOKhlI/2kdt1xIzckmkAQwk4P7/CCEWYm8bbEHthjTYhIl3xa2A09KfORiFdxlkTWmqXzoWqm/RnvtxPA9b81Lc2eJ/G2gm++37I9q9yek2HMEFjfF7P6pJfErKYcvFFIOrr8lSsJlVQgNjHALfigth4PMmfEwqhEt6tv+wxg3R6KRi67fCNAzoAlxYy1Kg1TlZUk2Mid22Ev3mcX2qk0CEQZJOd2HUoohwUzOKhr3riWslCUOxF/ehueRg6ZixuSwNjcmQHZfQSBPG15lLis9XADTZmKs4qXmOXNrt71ZTnYR+tFUjVMALp9Dyn2CzfC1lu4nK+X3ofJpeUOZM5q7gRXKZZd6Lmp7RyUKMlQGMCgMij0CIu0FPf6tfK03JeXOcHKwrpK3LJDW0Q0u2AArKT45Za2S45HwbW5n50is+techrucnStvvjjclP4dwzF9iZs883nYN6WZ53zjGuFqGVq/PYjbDvHcGsrSLzAY7rWvHvfsXNs1osvqUAbexx/IVs1FbpfEFMq2sIEUXFg+GoJ2Wyr/0kKaC3Lzv2ePm1vYONbFJhmhjeCfX5e0oSbLc6ZbXXhLmtsln+ZvIXijTsJzvpmxG3fMAUByAAM7CelKWwwCRQCPa2V2SLdH0Gzh57fCuf7iutP3sub6D70Fa/Ln6+iByvUJ/26U78H3JIM1/WoXRoCGcm2oB21d/v4cKqWL8XpLGKn+MyUuXvfdsjJFn3H/bRfw+wVf0HbMN6A3fcUp+01/HAM+qx9Vvqg4Oei28LWrt/MtLEhSTMLihDTPYTd4SStzzF6rWQ9hERNzRlp8sMtquRuNX+RdixqnndFpFBYujeO+OSVsaEr9+MY9TpiNsF19su40YIUkI+Ou6yJ3RCujEDnhcsp6uFDfvbIroP1mItBn2/j/+be2HBvnpfoQVpTTXTqPOasKAqZ5U+tLIo9DW+t1IH98iYG3/GXgpD8JtzHgxV089Bn2zw9oyJqhYGmzoolUuV7uFSPQVG6sbcB8AWxR79qdvUzk/As2c820VFY++V1r5bCnM9X8/jQjQviT92C+Dx2gxOb3SM7M1FURxuI840Nx9mxK3YFC X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2024 10:53:31.7187 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8acb129d-9048-4d14-0ebc-08dcdc87216a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB73.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4108 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org rte_errno should be set if anything wrong happened in under layer so that user can figure out what's going on. There were some cases that did not set it when ipool allocation failed. To fix the issue, set rte_errno to ENOMEM if mlx5_ipool_malloc failed to allocate ID. Fixes: c40c061a022e ("net/mlx5: add basic flow queue operation") Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with HWS") cc: stable@dpdk.org Signed-off-by: Minggang Li(Gavin) Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 31 ++++++++++++++++++++++++------- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index a275154d4b..f34670b3ec 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -1905,7 +1905,7 @@ flow_hw_meter_mark_alloc(struct rte_eth_dev *dev, uint32_t queue, const struct rte_flow_action_meter_mark *meter_mark = action->conf; struct mlx5_aso_mtr *aso_mtr; struct mlx5_flow_meter_info *fm; - uint32_t mtr_id; + uint32_t mtr_id = 0; uintptr_t handle = (uintptr_t)MLX5_INDIRECT_ACTION_TYPE_METER_MARK << MLX5_INDIRECT_ACTION_TYPE_OFFSET; @@ -1917,8 +1917,15 @@ flow_hw_meter_mark_alloc(struct rte_eth_dev *dev, uint32_t queue, if (meter_mark->profile == NULL) return NULL; aso_mtr = mlx5_ipool_malloc(pool->idx_pool, &mtr_id); - if (!aso_mtr) + if (!aso_mtr) { + rte_flow_error_set(error, ENOMEM, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, + "failed to allocate aso meter entry"); + if (mtr_id) + mlx5_ipool_free(pool->idx_pool, mtr_id); return NULL; + } /* Fill the flow meter parameters. */ aso_mtr->type = ASO_METER_INDIRECT; fm = &aso_mtr->fm; @@ -3926,8 +3933,10 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, return NULL; } flow = mlx5_ipool_malloc(table->flow, &flow_idx); - if (!flow) + if (!flow) { + rte_errno = ENOMEM; goto error; + } rule_acts = flow_hw_get_dr_action_buffer(priv, table, action_template_index, queue); /* * Set the table here in order to know the destination table @@ -3938,8 +3947,10 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, flow->idx = flow_idx; if (table->resource) { mlx5_ipool_malloc(table->resource, &res_idx); - if (!res_idx) + if (!res_idx) { + rte_errno = ENOMEM; goto error; + } flow->res_idx = res_idx; } else { flow->res_idx = flow_idx; @@ -4070,8 +4081,10 @@ flow_hw_async_flow_create_by_index(struct rte_eth_dev *dev, return NULL; } flow = mlx5_ipool_malloc(table->flow, &flow_idx); - if (!flow) + if (!flow) { + rte_errno = ENOMEM; goto error; + } rule_acts = flow_hw_get_dr_action_buffer(priv, table, action_template_index, queue); /* * Set the table here in order to know the destination table @@ -4082,8 +4095,10 @@ flow_hw_async_flow_create_by_index(struct rte_eth_dev *dev, flow->idx = flow_idx; if (table->resource) { mlx5_ipool_malloc(table->resource, &res_idx); - if (!res_idx) + if (!res_idx) { + rte_errno = ENOMEM; goto error; + } flow->res_idx = res_idx; } else { flow->res_idx = flow_idx; @@ -4218,8 +4233,10 @@ flow_hw_async_flow_update(struct rte_eth_dev *dev, nf->idx = of->idx; if (table->resource) { mlx5_ipool_malloc(table->resource, &res_idx); - if (!res_idx) + if (!res_idx) { + rte_errno = ENOMEM; goto error; + } nf->res_idx = res_idx; } else { nf->res_idx = of->res_idx; From patchwork Tue Sep 24 10:52:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Li X-Patchwork-Id: 144410 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9C9045A16; Tue, 24 Sep 2024 12:53:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA0E340395; Tue, 24 Sep 2024 12:53:43 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2048.outbound.protection.outlook.com [40.107.92.48]) by mails.dpdk.org (Postfix) with ESMTP id 24D4B4028E for ; Tue, 24 Sep 2024 12:53:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O/S8rPsLm+GplLwAy8ktDeQF1EbHDQmwVtmbIuoLOw0zq7mLcLBJRkyeEWI7uyIzyl4Qkbb4s9jEsGw4yJAC2DnH5Clsj5lasnPZZPX45wc93bjZsz1t6hna99+NLW13Sz4ph/tpXlWwGlr/KyIV9RRtc3l2FJEIg+d8zLzyMj2LroFw6OjRU8gbXc5HnCqntkbMYfEqWICCGohyNPnLIiUpE5qF9qbYhwFnlf5GMZjjKNpTTdh4l30EHOdnaBl2hYgtuJTGJG9/n+hCrW5xD2IOUidioIlQAyxO/Aka5FSn5hCGw8nmF5khzNY+/erbqKGS7KJtq2W6aVRvfw8SYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lhJK3h4GsMWbvN6mDBdIYm/GNgk2VkE6zSp/Pewk+o0=; b=KjR5niHJ9kAeiMw2TDut0rk7TPrQGraqZonNbPL1iCpTl1+Eu+LJO5Etj+uWN9unB1w3I2v+tylCKQfAlwlrXwMpt+eEqk4QDb0Qbjo2ajvZGModHwgK2yOug2YDz2PTErp2my5y01npS/vcRk2UmcHO0drN1KpdfukKvyAuHLEBRp8loyGju63Sub6OAZMUoLr7cialuWM114up6a4vMxVCCmZs0p/RRbLdBd2l71gcWyjmAH0RPt6l1h7juZG9jfahyDRSUnQ9iHEDoXFLJnY/47n3CIakH5iSWDS4wDASqbfX0v8kMw7icqUYJZDDO/6iFKxKKTF6Ak2kf8Bkdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhJK3h4GsMWbvN6mDBdIYm/GNgk2VkE6zSp/Pewk+o0=; b=JsysAIzan/Aydxvcp0x3bzdtS19s078m53UIwjJtH4yIlXOJ6xMo30KMfYupb6+7xTOAlsKpPUNHb0F8Ofx8k9hEVyakTitvYq0833Om3baFI70I72Llnjof5IwnaPqFdeomdDUZ2SV4s/enRHlw3S4YLS56DK+bKtjJlQ54UjGcYVllmvJ6tZthxGPktKxn/wDzKujIsvo9zy0CL5WtMIYNt2SnGr4/A/px07Ai4b4pBG9dMGnf0GvhX+lDujeRIeAjRa5/2QVcnAJcGJHkQgyLQJnLxpPkrHTLO//ySHquqj1XagS/8e5+mdBiGVrgNc2pOXJt5OIrWPh2Ahi0NQ== Received: from BN9PR03CA0126.namprd03.prod.outlook.com (2603:10b6:408:fe::11) by CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.26; Tue, 24 Sep 2024 10:53:34 +0000 Received: from BL6PEPF0001AB77.namprd02.prod.outlook.com (2603:10b6:408:fe:cafe::83) by BN9PR03CA0126.outlook.office365.com (2603:10b6:408:fe::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.27 via Frontend Transport; Tue, 24 Sep 2024 10:53:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0001AB77.mail.protection.outlook.com (10.167.242.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 24 Sep 2024 10:53:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:21 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:18 -0700 From: "Minggang Li(Gavin)" To: , , , , Dariusz Sosnowski , Bing Zhao , Suanming Mou CC: , , Alex Vesker Subject: [PATCH V3 2/3] net/mlx5/hws: add log for failing to create rule in HWS Date: Tue, 24 Sep 2024 13:52:57 +0300 Message-ID: <20240924105258.58037-3-gavinl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240924105258.58037-1-gavinl@nvidia.com> References: <20240924055938.48374-4-gavinl@nvidia.com> <20240924105258.58037-1-gavinl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB77:EE_|CY8PR12MB7705:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c2b7df6-0bab-4796-bee1-08dcdc8722be X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: Jqw7fCzhz18/BzHcXkNG61jefeIG9P+LaX8kDPAJVOKLc8N/ZDMpMYF7dcu9BjjI+wTA/VFkUmxrIHc5cVLaLtl5oH1vncw8PNgSJSWZHfxdQhwg7xkIMR0HMdrVcmerx0OrncSU9Sbvn+c5PkbH9x/0eC9LJWuLzE/psbEWuerstoNh8YoqeMpmxw1hZCYVGH7bTv/LveEM3YVJd9RnrZn9sJfQNLdeAhukK9xcOdzgTfKYH7+o5Ydlzmrr81jd7UrlimE4Ej4j3frmGW9LUs8mgc8TcX6jQ8RZMvBEzfEbTewNDcK/taZhHTAlYPcJY9VTcnXf2Vk2DTGtqSrUrtM2FDmUuz0MbhdS8EyZMohmF+kkqvxQPveks8mS5x5/LI2hJvoj6yiio5wAOXCGjJJGYJvCMM2Yp/hH0YpfTaacexc0/WW9tYOw52qJEO9Lqxsd7Qz0Ke7i5RRxJon9sxl4txlDI9toNGY+ZfINAZaZh860ZxXj2aISPkwBIi2zaueymwNanIwgQEf5foOCp4xnrio68lBdh0E+ysCc6H3shOzuLF1/xvMkNjDHBUgYhL11YNcDTeXhu8wsjEJZJsraGabs6rbPXHUYx0WtwA61aGvv4ydbXmThCRb/E1IoaLhuD5ctHGLzvoU+iSyWVVItpi5pIUNk61QjQv3DLsqKp6Vfxi2p+CbFIJw2kXgqpuBuAMzK5WeWc6qN7H++ohrkCeLBkLc++CnfmEB7+bznQLZKV1SHmr6E6W009W2p3ulQRXJRgVPwkTwMVsKpC7eMsfTyef40dk+rNENIouv5zJ/QzrQb/5cr/u4oV2y9lUmjhTvg55blQLFlsvIsFYqRwhSvV23lCxf3Tzy1X6orAtxcjOolX/dL2QtYhqUMEstCwz01qQ7uUy6wK59dbBxKxkNWRyV5ll5QubZx205zl1h68NAllWcE5MfygvndRmVGzyq2K4W+JNr5RkCi11nAT6fFqAsGv35pBjWwvHtw3O0uPdhbbIezzj3xooxURgkiyZHt86hrcs4cN/8VwspCFIU3slosYmfpdOIu3zbMGLlkrOwTbCw2J125C3sJI2qA/iqIsUhOkQ+Yn+dO2uNS20J2Suk0CKlAdi2Xrs28VCG5lEc0tzlTw02FmUG/N8mVPDKhuGA7YkBgIV98XoRdgweKKW0TH+q1ReUVr+cxedkR2E33IhN7lE+X/taJ8JtQ04KcG2cljyTEhfhDWptDjVusOtecpreToQrqGHjfmKF0FF8PlICVDZkjpxyjpp4YpJwY5NHfcsSSG7JYyuJWaFFwD94/95wm5Wbz+XFSyYhCMp2XFjcXLvEcSumot3o20YyBoSr7mqHdZOwN7trpD1rCdhNFLXDzxZsokIs= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2024 10:53:33.9358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c2b7df6-0bab-4796-bee1-08dcdc8722be X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB77.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7705 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add log messages about the reason why the flow was failed to be created. Signed-off-by: Minggang Li(Gavin) Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_rule.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 1edb7eac74..5d66d81ea5 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -638,6 +638,7 @@ static int mlx5dr_rule_destroy_hws(struct mlx5dr_rule *rule, /* Rule is not completed yet */ if (rule->status == MLX5DR_RULE_STATUS_CREATING) { + DR_LOG(NOTICE, "Cannot destroy, rule creation still in progress"); rte_errno = EBUSY; return rte_errno; } @@ -806,12 +807,14 @@ static int mlx5dr_rule_enqueue_precheck(struct mlx5dr_rule *rule, struct mlx5dr_context *ctx = rule->matcher->tbl->ctx; if (unlikely(!attr->user_data)) { + DR_LOG(DEBUG, "User data must be provided for rule operations"); rte_errno = EINVAL; return rte_errno; } /* Check if there is room in queue */ if (unlikely(mlx5dr_send_engine_full(&ctx->send_queue[attr->queue_id]))) { + DR_LOG(NOTICE, "No room in queue[%d]", attr->queue_id); rte_errno = EBUSY; return rte_errno; } @@ -823,6 +826,7 @@ static int mlx5dr_rule_enqueue_precheck_move(struct mlx5dr_rule *rule, struct mlx5dr_rule_attr *attr) { if (unlikely(rule->status != MLX5DR_RULE_STATUS_CREATED)) { + DR_LOG(DEBUG, "Cannot move, rule status is invalid"); rte_errno = EINVAL; return rte_errno; } @@ -835,6 +839,7 @@ static int mlx5dr_rule_enqueue_precheck_create(struct mlx5dr_rule *rule, { if (unlikely(mlx5dr_matcher_is_in_resize(rule->matcher))) { /* Matcher in resize - new rules are not allowed */ + DR_LOG(NOTICE, "Resizing in progress, cannot create rule"); rte_errno = EAGAIN; return rte_errno; } @@ -1068,6 +1073,7 @@ int mlx5dr_rule_hash_calculate(struct mlx5dr_matcher *matcher, mlx5dr_table_is_root(matcher->tbl) || matcher->tbl->ctx->caps->access_index_mode == MLX5DR_MATCHER_INSERT_BY_HASH || matcher->tbl->ctx->caps->flow_table_hash_type != MLX5_FLOW_TABLE_HASH_TYPE_CRC32) { + DR_LOG(DEBUG, "Matcher is not supported"); rte_errno = ENOTSUP; return -rte_errno; } From patchwork Tue Sep 24 10:52:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Li X-Patchwork-Id: 144411 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01F2E45A16; Tue, 24 Sep 2024 12:53:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 930C640608; Tue, 24 Sep 2024 12:53:50 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2082.outbound.protection.outlook.com [40.107.92.82]) by mails.dpdk.org (Postfix) with ESMTP id A9C52402EA for ; Tue, 24 Sep 2024 12:53:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tf4R+x4PjpgSXG+c+eaLMCGFpvYA1pbMSmuto8xeDGpVXgOghcI2kfN+WxL3SS1ic5/EsthZKHnsYQJVb+Tvc1q94moyAA6iCXWUvZFuG2bB3Cpt3GkKv3ncPMONlso/2DKSvyrViFKi3v3YlBTpO+kMLQtlHyp3x7ui6BqNEXZb1Bwqor5fW9nwI2idAQLlF/048w7lcVf7L+hQbT5u1dd3jorWMMtLlmP9wkxfQxv0JL511IlJTiyu84os+qBjoEIbeeoViLnlVMmTcBp2LI0SlrWrhZnZiPTm2ehN5iaJsFqPNG+CRb9k/QCAOJEE93TjaiftZ2pXXNphIaUY7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rsCLIzkdWOht3PSm5YL37KF55dmpa1iY0n4f/3OMceI=; b=ke6RKhi+q5Fg28974KXMCAcbBaDLEhAtdrTXYFrEyPPeByTUtLkn6MJPryJvY/WkuBD62DKg59afeYQ0AhJLbJjvX2jHGd8F4xqrdJkDuFgnllh/ouspAJ2YGkvFj9llv6KfV5xPRN9PBNFTZJIkS+olXMZeqerEAmb+ODLmkP8ef4R6wlBwfiDbw5q1xplHWrpz2AZJQyd3ew8yYOTtyV3c7XQbFlqIS/HW/jMyhkz4KfDM50nfLJ2Vpbea1DXA6PU0ucmrV8l87Qd4LnfH3H4a8K0UKIiI8JMzfnHaTRfcTSFrVySbbZfLOeHDsSjafWcdppp13QGRApoDEjzZcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rsCLIzkdWOht3PSm5YL37KF55dmpa1iY0n4f/3OMceI=; b=M/IB5/6S61xIjphhxlkJIjRavEnnczTjQb0mBcspgI4JleyeB4e2YAacGMXfLjs2dX+vxM23LuGiktG1NFzTF85sBkKeg61CZZAORMLK9gTsKsROnExW4HF3Qs34HVQopDE9QsBATALe0rbShaYJrmJSM8csp3uZ/U7RhXIHvXwYqo9Da2MnFoT54Riv2ZdWUfGcWEHR4b72bTjrxExeCjDLPhwBOlqz/W+02ytLm9oozCOd7Gju+QKM8ajeat3ck+VTBP8PURyBi3WizMVnpAOVdjzyojq1URTKUkzOgxBfW9Z4tRd/SomyQt+y3ddKjgsPF1FOMeDl5NdOLcn29A== Received: from BL1PR13CA0002.namprd13.prod.outlook.com (2603:10b6:208:256::7) by MW4PR12MB8612.namprd12.prod.outlook.com (2603:10b6:303:1ec::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.24; Tue, 24 Sep 2024 10:53:38 +0000 Received: from BL6PEPF0001AB59.namprd02.prod.outlook.com (2603:10b6:208:256:cafe::b1) by BL1PR13CA0002.outlook.office365.com (2603:10b6:208:256::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.16 via Frontend Transport; Tue, 24 Sep 2024 10:53:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB59.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.15 via Frontend Transport; Tue, 24 Sep 2024 10:53:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:24 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:21 -0700 From: "Minggang Li(Gavin)" To: , , , , Dariusz Sosnowski , Bing Zhao , Suanming Mou CC: , , Alex Vesker Subject: [PATCH V3 3/3] net/mlx5/hws: print CQE error syndrome and more information Date: Tue, 24 Sep 2024 13:52:58 +0300 Message-ID: <20240924105258.58037-4-gavinl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240924105258.58037-1-gavinl@nvidia.com> References: <20240924055938.48374-4-gavinl@nvidia.com> <20240924105258.58037-1-gavinl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB59:EE_|MW4PR12MB8612:EE_ X-MS-Office365-Filtering-Correlation-Id: 63e480d3-22a4-4700-d7e6-08dcdc8724ef X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: xF+cnv3meF31lDpFnvrC6gBeYbSfvEAj8CKa+uF3PEXoJhIcTZaG/++4BtVrzP8mQuhL9hwpB8z/NdXLeFJVwEJas7DF9uZNn+u9+k/iVGqUhkGI1lETGJepkQIHyKbzM6afjI/GDhBmAKK33h3cEvXJt+FIwLSvctD7i4mEHJmx24LqegnKaBeOvzndV2A7Ris2XyQs00Jlqdq+PPGAAZ+IARxSVW7pZSkG1qRCLxGXcCeEcMV7JJjH40+EHQTICDLQcFafauhTlZiO4ahfPkV0FccJbTyAIIVU0S3OnQuDf77kwOKDgAFvWS8z2tQJeA8PPDJhXIpKpv2SH5OdLO/wxpfHg0s5lEaMl4MSb9nsPJMxj/SZ8KLatQtXctXCNz9Xci1T7sz/sZle41+p1SW9clqrzfn2oDrRGBOP8WxXuwt+4k/bXYYIk86KSFwasVpURNo8U21Fv3rn4Zp/9BPbct3NweY9SYScqXlGEe1xJ5lu1qNvxR/0hke6PbYz43v+v0eBnWY7OexIMFgRHTfC/2ovemaHoisGZw0UBzbV7mH7wvrdbASbmyhTdjPrgsF2lFZ4wkLHoJ+lXlvkBkuGGI5AGIUDEs4DxC9Zk/+As1KK6tn8s9Srrsedi/S2KVXJOcMYB0FU5V4M66dPApwHHp3E1Lhoi2xEjr8J03w9ans7+hSZmX74ihrbubjE1Y8L7/q92SEPXerIqVvUOEStzKlOBfxBRz+mLpTdYqbjoOw4MyE67oUBf3PZY/aB9QsMfJliswxX5v0D/YmiFnrf5eRzpAcfEiGnbK4SYBYqwTdXqXeLN39kBc+ubzWDw9i1N8CTsb5HVgSY29kdHDiCYJhwVTcDrifZzzOwI6ZD6ZhnhA8z2rRMJyS4sEWsTwLVIcy1ofIZpeTRJSpQaC5/tYKNT6p+rl89aeLeQ620RqmiNQVVZE3x7CEkahsVMjFWUj8S8BfbsLsrKfDdZyeEwmN3evUqnRukQlb9VQNKsWvqjaFgas45z0otA2+SNnHT54KUxqVAJtMB5iptpne6f6Iy7kq8uH6NbuuaL/G9VJaX21B/+XeR2EBC6pnfW1NTHCzo3lhIUsXgSCP/15qLbDWgXFl3pkVAEQ3l0LEnUupbwdikuCa0iP3tlj0qhr6Qa6BCf09eVo7psCYWU/KyVeB9rKIlAk/FqWFmjuYC1+myy39YVCNVYnkus2/mI4HII1/Sam5oGvcXfSLWyNqWivMomj6vi/kcaN5ZXnTh0g0JEMi8KOWv1FvL3XTJyw5PPgpjpj2XdKU9FrUld9GTILjJ1tpY011NFZeREqW1iVTyelvSzhsvx3Up9VC/LdrSE7jZcBB6so49406SizRVpcjXGkdHWtlq9yZyBuc= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2024 10:53:37.6130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63e480d3-22a4-4700-d7e6-08dcdc8724ef X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB59.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB8612 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Print CQE error syndrome and more information in case of queue error. Signed-off-by: Minggang Li(Gavin) Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index 3022c50260..e9abf3dddb 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -598,8 +598,15 @@ static void mlx5dr_send_engine_poll_cq(struct mlx5dr_send_engine *queue, cqe_owner != sw_own) return; - if (unlikely(cqe_opcode != MLX5_CQE_REQ)) + if (unlikely(cqe_opcode != MLX5_CQE_REQ)) { + struct mlx5_err_cqe *err_cqe = (struct mlx5_err_cqe *)cqe; + + DR_LOG(ERR, "CQE ERR:0x%x, Vendor_ERR:0x%x, OP:0x%x, QPN:0x%x, WQE_CNT:0x%x", + err_cqe->syndrome, err_cqe->vendor_err_synd, cqe_opcode, + (rte_be_to_cpu_32(err_cqe->s_wqe_opcode_qpn) & 0xffffff), + rte_be_to_cpu_16(err_cqe->wqe_counter)); queue->err = true; + } rte_io_rmb();