From patchwork Mon Apr 15 12:35:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Power, Ciara" X-Patchwork-Id: 139281 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3190B43E7A; Mon, 15 Apr 2024 14:36:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7123E4029E; Mon, 15 Apr 2024 14:36:02 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 6D88A400EF; Mon, 15 Apr 2024 14:36:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713184561; x=1744720561; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3MCDL5RpCeIEu9SztzJIAUPyvDSghVkVcXXUzESow6s=; b=Ku7lNnp3YzkMYelUEjAkupG/kmT3lunYF5v614EIMi2kgAEegrwvh+++ gs23CELtkNw40mpX8+zgqlDn1jI08CdKVe6nNcrIsAX/lJJxcQmxsNjwN hHDvWZwSwhqLp/HTW8TJZry5deutvyefWPv1t9RMZi4CiLrZx/yTb4WIU eztf4GdWfzhknJLPqTxerHXpE2U5BlXqpcUFGgigrIZX701OCob8rtttg nD1fWg9Qa9YxDvr/t/QlELwe0O/2N5H8RqUWE17XWZaXjCP9NDxyDeWY8 OoIHXYaJzrMx9cFfDqTADOtxgWRY2VWdPvyIxWvOrEyhT9Al+3fq1MGPT w==; X-CSE-ConnectionGUID: f7EKEpIuRt60QGC6MOWXwg== X-CSE-MsgGUID: xdJyKkdfR96EIuLTB6/LPw== X-IronPort-AV: E=McAfee;i="6600,9927,11044"; a="19964131" X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="19964131" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 05:35:59 -0700 X-CSE-ConnectionGUID: bn5VF0K7SvqyOgNyPy/Jvg== X-CSE-MsgGUID: 8Zs+suXTR7CI5NzUysCKSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,203,1708416000"; d="scan'208";a="26695397" Received: from silpixa00401797.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.113]) by orviesa005.jf.intel.com with ESMTP; 15 Apr 2024 05:35:58 -0700 From: Ciara Power To: dev@dpdk.org Cc: Ciara Power , abhinandan.gujjar@intel.com, stable@dpdk.org, Akhil Goyal , Fan Zhang Subject: [PATCH] crypto: fix crypto callbacks macro Date: Mon, 15 Apr 2024 12:35:48 +0000 Message-Id: <20240415123548.705412-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The crypto callbacks macro is being used with ifdef instead of if, so when the config file value is changed to 0 to disable, the code is still being compiled in. Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks") Cc: abhinandan.gujjar@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power --- lib/cryptodev/rte_cryptodev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h index 00ba6a234a..357d4bcf9c 100644 --- a/lib/cryptodev/rte_cryptodev.h +++ b/lib/cryptodev/rte_cryptodev.h @@ -1909,7 +1909,7 @@ rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id, nb_ops = fp_ops->dequeue_burst(qp, ops, nb_ops); -#ifdef RTE_CRYPTO_CALLBACKS +#if RTE_CRYPTO_CALLBACKS if (unlikely(fp_ops->qp.deq_cb != NULL)) { struct rte_cryptodev_cb_rcu *list; struct rte_cryptodev_cb *cb; @@ -1976,7 +1976,7 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, fp_ops = &rte_crypto_fp_ops[dev_id]; qp = fp_ops->qp.data[qp_id]; -#ifdef RTE_CRYPTO_CALLBACKS +#if RTE_CRYPTO_CALLBACKS if (unlikely(fp_ops->qp.enq_cb != NULL)) { struct rte_cryptodev_cb_rcu *list; struct rte_cryptodev_cb *cb;