From patchwork Thu Mar 14 07:40:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138346 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F2E143CB1; Thu, 14 Mar 2024 08:40:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A68D742E24; Thu, 14 Mar 2024 08:40:48 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 07B1640297; Thu, 14 Mar 2024 08:40:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXADrBlfwWnjUwBjjnyxQkNXE4wzLR1Xwloj1ngNxrbWTTLHeBmb1BpXN38HrCPyGpQ++S6GWU0TJAgO5jTu+GRXaJki3RtN0pZgWK2Pvguo8MSWT4TqO/XLGdgeWiBzS4KgFTYqM7U3YDZb8BHUcmG4tOXi2ObmmSPlqnlVZD9CC7JyX0Hi5/0MK9bUWksglzZi6qxfNVydOqpQQIkngaz/6eaqNyjcmI020MFSLAmgV9xsChRVRNGNBEZ46xkRuq9/tyIysQzHT0y6APdm6ySxD7V5zbcf0esvD6wMJg69tRqV5Aes3m2AA3fVoIYl2bAXjtJrM9T1KR2JGf5BSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1uLu2HW35M23tAbofZLr54h/j0u98gr94LoPFBLAaO4=; b=MVZgZpLi7cwxB1axL579K80Erf1Gc8hSAAyCX+n8U4lQK/AWcR/iuZd1oYY8zKD9qsoyhZSalY6qhS8Uk7hf3FfBX+VwOdcNgUsFpunqt1bFLxJok8dDBXCmqhiqoVD9cKbrBWy7XNnvkad3mPnYwsX+5wZZYwuazbfzrn5AaI7/p7cGNT6qQgJuIvn/77N+nllEJW64r7TwGd/FJ4coqgwaSX+bqiEsJ6xxvbX2CjkFokCoh9aQhjq3M0wLaj0EccqxqRWnkox9e4dRPZNTF4sv6zd6kS0nUjSYFy0anRGqZhA9fLl3WJaSC8wOr/uE6VU6JsmyfiJs4KeddkUsrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1uLu2HW35M23tAbofZLr54h/j0u98gr94LoPFBLAaO4=; b=gaO9C30sSIDMDDeWFSXfXC43IPKf9nnVJNLil1SgJrJIRxtVg8TVsnOG6+qQAU8BhT/sa5f9VdkoytOZWtw4R9KWz2g1Az+kOiwJF4bEOIPnJ7H4lAICRV4GHG7+JW+B40iDoPbKV+F3wmYSon0nULu0tlLDDijY6mSLKIOdQCI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:45 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:45 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , long.wu@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH v2 1/8] net/nfp: fix return value check Date: Thu, 14 Mar 2024 15:40:17 +0800 Message-Id: <20240314074024.3199555-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a53a13f-84f8-4d9e-3234-08dc43fa0eae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 97SDhayxETNk1LseWaYsU3GMwmhyi6V3SVb5lDA5G/GDEtMG8IdeQ+Zw7dLZOWdvG7ZdPEuLuPQFrIIGL1d/XR8UrKCe4N0Y9uAsYoCE3ucmdtUqA68MdtkRg5JnhNJhVZZbu3rkwr72bM61rvwucgQ89T9F5ww+8Q0zX88HKM/Gu6UXmkLZXZQBu1EADUWKBglMoRpCX4sCTKenSCevU0NkxrdZpovKoIXWeoAM1uKbsOQhKhH21gA3Dt1XB+RqjB4/o/tQaOxmUV7vADzRQBzJnfxOJfPKzbXajBBuYc5VAI4q6g6jXuTp2QAmPi0KeokN7DAK8OjEcoYxkQxNBZg+Lenl1yW03NlmLV5vi9RTcO9E9NdXm9rwtms7sE5hU8orZ1iXv2SdmRlhbxAy7UFvUGjjLOvZIM5HqcAHIGRTY3j1qNNKur044ycU3y4SNjn2i9A5/JGh02wQnCWF3Fc6tlPwrh+w0BndL/bPfqfgJzqdTQv2ak4QrdKkr2QB3unhJT/y6JIgkkxvt5g8nTvDTKpNpor3SxoFIf8YWoY+sWcvjIX1bcjjPZkSNTn0Eafcbm1JEZlVWczGn7i7n+6pM667xuvB81kvCJPWgh21UMIIObx88USvSC2tr4X406BiZDsKeBGWWl5Hl4zCfzw97Z+w2x331SvZoaYKoMQ240R8JpAH7n0d76PY7m55YjzgyaE9RSmWghCGND+0O3coqRMchM0yWqOPZMAJQ5E= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QYsUWAkJNEvEGS1Q2aX1qoy2/bxwXEDxEhVhKmF/Y24Ldq7fXNjSgCccAOj745Efmsv0GE/HYaxO14OmThXbtJuUnLjJFr7tjR/T75wttf9znLpKP0TWYrGsl34gHKx+zKMHJb8bjW7AFaIFHldUQnTe5hRO7NB6YZafbN9RYT1DPljn7g9TLhNLtkMN60Br6K9BAjZqdK03gjBGHLJSxYkQ8Ju5af9OJZLxtoC+5M5xRMIJt2TnImlRnhc7FeCaY+mQgggmLrFoIlintSI5NuMB7pGTxFYOsGHLRwpHw39PlCVAA3+BYOircEQgf3RuI7jUdEjBRYwhz9L6rqWieInN6dH6PjJNbtiucyLJ2T/yyDB5ivrw2TeTkpJyaC9W0LjVgcRRX4RdUdWgY0OUr+ZM8Bv46TLfU2dyEaOtSOl/0CQ8MYpTdLeZWzOWcJk/OcMz41WJVT1Bw/IzrG9tDJHrebB9FDWMwS3ZTL19oH+9GHGgOtxFvdY4J8v1tUnavk8hssYTLmUnPaLGgfpDh9EE5Uv8zR8Mbzsy1Dcwan00s6jYXKrUyYctgIGT/Hnm9Ym6SLlooAYy3nAN+Qiw4hgzjmRMK5f3g0eG5txc3rKwb44e08hZAEf82efrZsFf8K2lthWtvfrkGOwvz73BYWmwvXpKLoWK01BmC54sw94WOPQJ1I42fdGHu8KC22MfrDIOkWMjngz2m7v5BlddiNveNIoaoI3okf52iyLpv257FsLn55MlI1uUA7Thgrm7w78/zj+9Akgjd2mSgd848vgkwcLYyOC7d3mNV4qxFMnKq73GlhEXywacBsp1tYzXUSZwL2gCbGQ75fCAtQzPlpXzvcep5+P6aRuSoyyscbN0CQfHE8SCuFT1an3brJMHtNuLghuBIy/2xDBxbJatbBBa7vKer5IQE966ITGeqy67yfUXGRcs8M3jIy7dn561cq5jQce6i6p5P9rb+xGbQ2ox8/8W1r7xBMyDxc/cNK3v+NKNR0R3hzrjO7ElnBkLs/iVcZOEPClti7X4AUF5jUTzykjNRJIJNYt3rHfmgDuqWDvr63D6ElddY42uFKmxVleUOVAwEaENWRNvAyN9p+zKv8o3+toG75dadx9J8mcBPzKS6aQmW50OtiflWaMOjTxSMFH1qm8PGvrF+pasCJl6MLGC5WTMyzE1l+3vdN+Plcwu7uqDmm4EJjQIh8x40eLzR1MQ/k4ylIrxh3XNQqLb4yKiCpAMIJ77Ev3Y3Ro5nr1GjD5LCiYMycmFB4wA5Ulz2fYR5mT/EA21ng4HpnM8Xs/LGk6EK7js5BRJvLW781U2YI5VlkfmFqHBiHdJmhYszOPwQAK4aYXUYxHAFOpQnxZHNGG1WU0i1FYYtLOXLS6yDQq+wFNqrzyKjiZd2BvxvPgmzQAQufpk60UyS/Fd3tZziXEBsf1ZJDdU3xc3paA77bR6ymKX4QgzkFFyGp+nIx5agOcGz7tOrdwnEFYGZ6Q8pHy6TC9R3Z2O8XkF0Ym9OPiqfmjuC/Ec1w8oznbRw26878t16bR/lbLM8URyVMOp97Ma1J+oO8lw09VpojRP7CsxKMlGLAn0y86gy6/Nuwq8Y7wDzr0wPBGawA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a53a13f-84f8-4d9e-3234-08dc43fa0eae X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:44.9727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JjGS+KqGvGMwwq55reGDNkW2BQ5Ml1asebqNI1diGhug/Hh96PHmKI3eu3+bmFGLIBy9wMp/+I5drT/GHtjPrr1dYNyofcNDa2UOnhcYaKM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found calling 'rte_eth_switch_domain_free()' without checking return value. Coverity issue: 414936 Fixes: 20eaa8e2ebae ("net/nfp: free switch domain ID on close") Cc: long.wu@corigine.com Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c index 97219ff379..303f6bd3f6 100644 --- a/drivers/net/nfp/flower/nfp_flower.c +++ b/drivers/net/nfp/flower/nfp_flower.c @@ -793,7 +793,8 @@ nfp_uninit_app_fw_flower(struct nfp_pf_dev *pf_dev) rte_free(app_fw_flower->pf_hw); nfp_mtr_priv_uninit(pf_dev); nfp_flow_priv_uninit(pf_dev); - rte_eth_switch_domain_free(app_fw_flower->switch_domain_id); + if (rte_eth_switch_domain_free(app_fw_flower->switch_domain_id) != 0) + PMD_DRV_LOG(WARNING, "Failed to free switch domain for device"); rte_free(app_fw_flower); } From patchwork Thu Mar 14 07:40:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138347 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49F3A43CAE; Thu, 14 Mar 2024 08:41:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BB7342E5D; Thu, 14 Mar 2024 08:40:51 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 35E99427E3; Thu, 14 Mar 2024 08:40:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=of5NgiWvEIXsM0Oyy17HZQ9Hma63NgQOsbDeVz6u3BTt60CeVV57gQcdHLDPc5rmslRrt0k24rg7eYDf2mxAnwe69JYMzqRxX6pe0lO9oj9VLw7VFlYbYJ3xIwaQi9LEudQlBuTzGhINMYGBy7J9jozlSq8e43M3Z7sF3IjXyPkPpkSNcgOGOl+xtc5WQxBNdd7HyfBvx8HfemlXATlr5fFRYESYQt7GN1ThHTmgO5B9Dhvqfp2ndpQS3kEla8OS+h+R1BpHxqeERSupEOtY++8r5nwWZLOB6ZXa+5+jzp5toxrnExgQcg6R1/XdFA4JZx82AF/q10sUupxVT5pc6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JaFGoOiIoNM8JGn8TyVkhQw/RM+1oIucUqEJ23jhcSA=; b=YxD2yFUbynAFtoKfJmzp5TP0DBJpVwb3og09Oh4Bq/Ce6lHX9oMOHVgBzCFcFKYF5t/FSaeDJPwO8wTF9X62Z2yP5XNPGk766SEJmxFM3A/X9TD5yAwZOSZZr5JpmSCzKU9e6Y6pWKKj56kuQxEwqZKsGoJUl9MtoTY1vT5TIGIGHjAXmE99G+5KqOfIqG4PpoL2THSBtd3HiGPOS1MSfQeylfualdw725T3ZRZTdGjhB3rSUg6GVKFvcDTTk0aLIzAZc3vCVtrkGp0cxc7oDWPB4VzIm2Y1uE15FX+s7v6xSSG+ZMjB6r52Afm62415VeCYqYmeuFwl0YcdRc2TUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JaFGoOiIoNM8JGn8TyVkhQw/RM+1oIucUqEJ23jhcSA=; b=kWtvMkr+P3wPFNycGhaaqkqUXbgGdXPaKmOUwspUWUXcGJRC6E9y7lgTp35ZnOrkl86r8yRSda8FjLDC342FRDv59VPa0wc/L6ndX9Y6qRIxtS1Nr0aLzMYAcyE8CGtUAV0SQ5R7hm087BJs4PLSMHyaSGzuocILoAetNje2fJs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:47 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:47 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , long.wu@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH v2 2/8] net/nfp: fix string overflow Date: Thu, 14 Mar 2024 15:40:18 +0800 Message-Id: <20240314074024.3199555-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: 06a3d704-f8fb-43d9-f492-08dc43fa0fe7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J2fIowVsXldJnVDnDn64T7h1iTmLHGv2rDAbXmdJirxM8l/JKyA9L8qRrjldOcNlBjNkU7IqUMXbjtQiFKjKGWQQ8v2q32Pl/v9R33JV3SmNIzOVk9cYyXfmy3FYs9AhS8s+KfE1/Y+Wz6wqNZNGFPbq6SasSsm0iomK7ypGzJKnLKwxQwcVhNc7I2dpByTjKBsOrtZWa9hngo9szzKaA0vUGd5HzIsrxy3EW2sgagmfKXAgRxaOhWZl0/H8iBrzDbiqA9jFQyNsm7N1Pzq2qhXl5InoPHOmIX2igYuPHMUvmSe3t6PwRhlecvgOkUZjaOIOWaNybpXuF5Ia18GemZFf8Sw/HW0eZ2jPZ6C1UEXLqFjvXNg78CnV8kYf6bj1oPoLV+YRuohwVeAvS7v3WGMXEiNhZ/9wfyLENgpx3li0N0ifZInyd2PggBJ20kjwWanKRiclMhOfc39uU8IGq8GwBJ/Pl3Yf4kgh1dK5upiOo6qznEqugE6cckAof0qu3ZmAE52zwZ8JXGrImFS94ftk4eyvzymxbexlbv5udCDEQpCffin77CKNy+FO39q1jhehy4ZoOgnuhqBtvIRLTXtw6qdYNuHAvRKbB2autERlIGopJ6boeRS2RcB4eWb1dTwu9eG9vaumMPhpFuB8PEs4mf8AhRWZ8bn4HKNnxzlybjzTPrvkbVDoScMnjXePIHEXI+4m3vhBU5RPW2Y0Dw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XhhtdzKl9NaMg2f8ErT1puKLJkr24YGq3gIhen41GgcKrhlC39R8jkQaSDUnYyE9iegbdGi0EyBk56wgUHvI7VYKKjCGWo4TbJi07anHbEuCo5rvw/R0xCF9b31PBt+xtXhBVedrOjjhNEfYwLMsc/yIlWtfGPqZ4InWFqfnQu6KtuLyTWt0bw/6J+9ENG5fMHAW6zsQYCxxW4/rwLioUL8kIub7b8eIbtvc+zeUZGkHkMCLFHxXUsHlf/74qrUqPb1h/Pesolj7//5ScqrcN/SLn5p5npVxEhaCv65/Uhwf6Pkny/tIpKUHFIw0uxOw4yx7leT7K8z265Mi5CVKCglIFvv0gr/BlwYNo9O5aW7giLRklWy1pl4sj8pfBEaOjeTUkeIrwwkMlGc5Ud08av9Yx052eOch+38mumCxiooTX6TrjYJR+0H/XAz2yhXrMwBj0FzkXKQhJczHt9TQqgDBtAQC3TmxopJOBh6dhgWG7X3baglicD6GUFTOSMCHNzL6dcumUfiMnBxpyKfkyiYTYGjKpFQ/2CisNVt14Ns5elfkXjH9GFbhkl/WPfPJl/Nz5ATLa3OA4zgci9eF4UlgPgJm8u6BfZVmf5VUqGglHtR2cQLPGoNLYJjgGaX+xg7BUJvWgs4E6qYm5KKxSTGfNeFRFoZwimEpDEcA41mcZnbNtKLU9YToWpvSmDsIr9v7hMBn5IZB2FGnDJxMz5O8RcENzahV45+TxSjjfR64ZikHV8QPa0Yl0S2nquoHmGpIctavwDl+nWzwgzGJlrf9QCfCOAa37wypfnyT5WQSHzB0KK6SoGkH8M98Vs6xygSXmAmDd/Z8AxiIiCDiBTDHNqSP+ED8AlueMF/Uhj42lL3kzn5+hwvHKTIlGv5vuMWdf3K7yxhNMRPBjlVm7yXPck0a2pwNOaysFvByZD/hoLhwRCxDaobaDv2DjQNxsM7osvZSlmPJLW1ZKpdiTfWDCiUDVHCXdOywrgp12YZ/KHvIZ2GnqDF8U0DFqfNlUI8YNwyzrwMaFjCPNk8srBoCuHWwQ8OQgio2g05FXSKqa13H2En+wnH2SQ/JVAxzyL74MYcAp457JqZ33+v48B76AjP2Un8U1phCP8i4ojL0mXW/y2UepK66NVoZCopLZww1+FsLQyTD4oBQpr4jD/Y26ibyLcNWWouKObJPw2QNiQwZjow2XM0Ye2IUK/O8V1fFzkJVvTmvqtjRBsO5zlXvO6r5bWZRiYcPz3ExQ1uuoUjqKwcy7OeVgW+7lfnyGOcPZBH18LUJd2hj5YGVlbW6Bxjnjcf5O2imC4a3TqvIbMPgUPXSOqYDKdRMFqlY5OzvRHMVINktiLtYGsGn6hoFvJbHapTMAsV14VLXNHJMYj2HNXwcZP4nQgdT5pY8zEVDg5UD/cnFJFnn6U0scL1rVrIuJVks6VbDVa8BMpJ5vPooSMu/bLmTaYSdy/AjR7GBtQrQNsAG+iaDKEDzD4YHMlmk982UCsUHNQMlg9WF5chC/qtXvtK+x4CszkH/NkQuBhdFdsMypGTJqIOPErgzy1+5KZUik7e0FfA4dKDZ16FXol37q8evivMRXiaLV9Wr7EpfIGcUXepbZimYbQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06a3d704-f8fb-43d9-f492-08dc43fa0fe7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:47.0409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B32GmkLoVulohSBCwbWus8RA9bX6mONfcEoI4j09CuVLOybbZGUcPnCTWZeize4t6d0W17UaigmvUJ0HM7PbQiSH/EH+ImWos78v7xl3G3k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found in the logic of 'nfp_sync_pci_inner_handle_alloc()', use 'strcpy()' may cause string overflow, fix it by use 'rte_strlcpy()'. Coverity issue: 414937 Fixes: 6b4273a03779 ("net/nfp: add synchronization module") Cc: long.wu@corigine.com Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfpcore/nfp_sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_sync.c b/drivers/net/nfp/nfpcore/nfp_sync.c index 8bc38d6585..686cdf8eb1 100644 --- a/drivers/net/nfp/nfpcore/nfp_sync.c +++ b/drivers/net/nfp/nfpcore/nfp_sync.c @@ -9,6 +9,7 @@ #include #include #include +#include #include "nfp_logs.h" @@ -266,7 +267,7 @@ nfp_sync_pci_inner_handle_alloc(struct nfp_sync *sync, for (i = 0; i < NFP_SYNC_PCI_MAX; i++) { if (strlen(sync->pci[i].pci_name) == 0) { pci_avail_id = i; - strcpy(sync->pci[pci_avail_id].pci_name, pci_name); + rte_strlcpy(sync->pci[pci_avail_id].pci_name, pci_name, PCI_PRI_STR_SIZE); goto common_alloc; } } From patchwork Thu Mar 14 07:40:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138348 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4168D43CAE; Thu, 14 Mar 2024 08:41:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7D6442E65; Thu, 14 Mar 2024 08:40:52 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 3C4B042E48; Thu, 14 Mar 2024 08:40:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRERu2NsMrZA6KoGP7pI9KoG/mXosMJV7imYXQpWVrF574ljrtY+soNoOaz4R3vN12l7I1U9X/cLZcFizGg+CE4OxtpJKljAhzTwhzl3HyqfVVE9eH/Oc16zOtwgXfNXBnEFTsifyyVPYzGChJN/0B4z+5oc95l590C0SISiYFQ/50fSqBjXZa6tdPlPi/WO7rpwy4RtZkI147YuDwuqE6GlW8s9ZCxTudXzeFZJpKfTv3dGTeuIwhBppU1OnB5aPd+S0iehw5KOYYwjuSQM6cv1fnZtPlwspYOdme2O1sUQl+peXji7b8/IPtSvQn17jmlNWc5+wPsekRJcWfBEIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lYyea+SHyUtstUQBTNwuiaui4P6HKzoY2nH6zaWhB4k=; b=YEXW5MQUYKTKG4eaOm8yVSgm7WtV69iRwUSY0yHJM+qpsnCTFb7LqW+XxDo+sRzzlislk9SVD1AR6PgNCHfd7J34+/NvEDWZXJbdVqwgRKXnQo8rZ3HcKEmqEnFGr7y/LwACA+Ajham5RGGUc6cJjrNeYp6KebhZjaBXAUIOakgKFjhOPau84FhLw56N3DbKDSxcD0vemD1tEl6NmFGiggxLlM8z+o0QCLgnYIFwMnVAI6WLTpFSDywmpzniuVGH/i2BrtvQaQREE+Z3NkHamhr+PsDRr7Naiosjy7N7VSSIFVtMxX0xUrHeSxGWsxExC4Bplljp5kBfNZOTDBmF6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYyea+SHyUtstUQBTNwuiaui4P6HKzoY2nH6zaWhB4k=; b=W9YhWULxHfY9KyqGlVgb2c/FobyltHNoYZXKP7lxXW9Tic6N9eLxeb9uAQESBbxwgKNcpvNDDVvoC+W4EBl+h0XfbpPF/8f0jC7tgPFgz4yRhJ9shPrS2yYcidlEBEgDIKHDh+DuMnn+U/rkcq3vCGcnZqSm2GFZhs8napPr6DI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:49 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:49 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH v2 3/8] net/nfp: fix unreachable control flow Date: Thu, 14 Mar 2024 15:40:19 +0800 Message-Id: <20240314074024.3199555-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b0de7db-c7c3-40e1-f923-08dc43fa1122 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dqnh7OElMrM3s97OLFnTW/jYeEVZGDr7mxz137nt6jM+jupjTZpP8IpbW/UYRFv0UHDGeFZ2XWPskXW0TBrk9TYk5DiHdSSlsymj/JbdDJ7BNqIotAMrMrSZ9UqprEXSlVR3ZsEPl0fhS04FXfZwwWSP8wZOGr3sv1IJtx2ONhmrnAfW6M+Kl3OI/5FqmccZg5Llj4RE/3iAF17wT1gLSt/TP27sdwuC1QXq8ezZfqwLc2sTaCxOL/Gwz9+Nt8ms7+2qq/ZpFMKki6evECIlfAe0gp1oWDpEVkbyPovRnjbxeIphu8lx/aw/02oZcCJb+63Hyhxo5bnbcpRLycbw/1Ao0qaQHE65n6h4WjqR+bh21LBi/D9MYTvS14Zwfb4PEJ++f/LZIAhrcWG6tSSz01vY/3j4UZS7aGqXtmrbkwrrguRLxXDlqVfOrdEespFt/fHq3g3QKy7725LlgfqvOASCVwyoQqA3jb11eNTQmrU78/tAI136X7Az7cGf3viAo0GkPclMphBkClgU8WYjL3lSSG/w0YXEgzgveKYNmomW5v2yS17titaCmC6C8QN9nxcc3SbSo7Jzje+rNIBZptCb5dcQPlgnB4purAwPbHyUvwogNGyUduYsdLjdQ3F40AKxP7VcpVipx62JmEjf8QMq7zLCH5xtIQb1Vgj2t/O3SzoVtr+Zo5mGTKO6oTMBHh7B7SEbGUohct2nsrlwXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JOl2ealmIUDPrbzZFVNU9vDbtiTDNxIjsAbZThh0mCot65Tj/c1KwR8QPm1091IQcjDQ0ymDQ98JRfAonVehVgXgxdZg/YtUBmyKOCIbSin/tP4KYD+zGlIUSJAHGXmmVzrm6+w8iZsA/S4dQn3K5vtN5ZqyoXkLJC65PwQoCH7qKsk8DQVdD6JHJB4Cciv8D+oU3mCojOXWPxWYnqRtRDmbhqIDpwtz7/+Ezvc/LpJ2y8ou9hR4EeZYLi9s4HPGpWL8ZbmQYQ+I0ucrN7iD3ULwKnh8ZyogT4Ccwnpuhu1OEzJwNbx0HZtVeKm3YZTT07a7+g3SlCZCQj5G7GMOixX2QIZz4i0BcGyGZ2RUeZLdB9fpEAPX0iZPLNvxBZsUrb4nAozhyP82LW/DdsJhwHRlH8zRWY41X+Jfq1oNI6JAcgK1JfuSMfzdeqa0VIQREsonVVBzU2S5jh2muz5Sdeaxwh9xU2U/aAQ0/eW4D72QYNloVs6YhGUHjZYI1KjQPduJGAavV8Z0THUYP5dmv3PkDz42XhlmlLbKTdGWDvwz2ZsyHywYnQZxytWdto4cgu0u4eN72x0ADFn0BxzxNcQ1ovWdIJHsaQv5fxlT2sTNALibk+n0o+SJwgMgM0LxWH+7HslOoHgBXwyZl8yMxT0s440m5vCNfbcgO1CSdDF1CyLtQW4C6ughWeVcPmduNX9gXCS8OWkGjB0tFe/4DaPly1zPCsR/Y9hyVV7Zllpdiubl07yW1oLUgAJzOwdGewhN7INPSWHB+xJXtjpRYZJNFtqA/jummlYJutQSh/CAJ2eRAyWFg/4wVpxmQF/qq/vjdeR1XBQQ/p1onMat5o6aUfwPez0fB6lHrqhNHzqTBdTlxYtxFgKqBamxG0LO76ZH4ijknKfCWxBXa7APHTMy9mW88mv3D1+gJwC9O3TtqnTaTeAj7ryzows9C+zvvWruUCct+l6VxRF4nCLcg/bydriwNYvMucggTk9KkL/o4e5TcSGoIaAfZDVsP5LNJ7mO5YdHK8k6yWYXpphTpl+r57KpAImRi4twjoLZteOQ8TUfWKCsjpRgT0uRy0Yq4oeIPZ/NYEKzfdAE8pce3tdnGcIprsqX8q2gYrACrNhvblS6GxWtw70HEHpsK5Bguiq0csYcZcn+38WjqMMZQTQnnTxep0CF7SvfK56AgfVadxsYDJv5TxeN1YKaEFkV5Db73lUrI3rteJcEEBv4wpAWqcFidxNT2b74IzOy2ni5EPcwLgp+BQlyjrKBWhwO18ICplRWK6IVTATJdqiMoOGRRIsEwO6uQ3xjnwS0UJLEITMGOkbQI/bljKyxHJIL7b3q0jTy9jC75jOA5nv1NWXvn/Gs60Fv2RYW09YQdMLzK9CR0+8RBcx9B2ziNeKyannv4l/Pg2ZZLyMqIYggtzz+shTkLiWcf0L4r9xmPAztaaMVGerJNF7I1vt35wnT3Szhuu/6jvHkryk6fwu1EB49Wbz5DNWuDn2+Z1FeLK45RzIEeMlnX3Q2t9IGL7j6wdMFVjjADMKa7rj6Mk6ZIcvBzwjCuCnZslXy67834VhGZnUZzKXFD437EpUlT+xhFwiP6rcs9gHUI9EHeTDGUw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b0de7db-c7c3-40e1-f923-08dc43fa1122 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:49.0960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7KKxoZ0YlbqTk0PZsBX+beTi/RZLOFIi8d2gn8oJ7ykpX5HoP2VtUGnsE0PD7N3yAM7kBX3j18C9C651wKjhSEYa7PNcUKUV1uaAmUoFets= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found there has unreachable control flow, fix it by remove the missing delete 'return' statement. Coverity issue: 414938 Fixes: 369945667251 ("net/nfp: fix resource leak for device initialization") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 31c54a595c..568de1d024 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -936,7 +936,6 @@ nfp_net_init(struct rte_eth_dev *eth_dev) err = nfp_net_tlv_caps_parse(eth_dev); if (err != 0) { PMD_INIT_LOG(ERR, "Failed to parser TLV caps"); - return err; goto free_area; } From patchwork Thu Mar 14 07:40:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138349 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6770443CAE; Thu, 14 Mar 2024 08:41:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E4FA42E6F; Thu, 14 Mar 2024 08:40:54 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 4719142E46; Thu, 14 Mar 2024 08:40:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hHSws3tcMVcdUBrDTbJr0ocyCROpl8Ah+HJ8TLQeVcGYJsQsTxBiycuIF5vQO3iMRgT0PJh9uuULmrOd7GX8cGdC5NQyUy94tbAWVuGjqB++hEuf/9H74RsE9yLX531WXahYnTP+C0qO8RAXsI7bdXpbCJvhfx/9BPP826RY9+nuXIcx69yhJ1BKnSPo5ApQZvjx0ERfnlwXLphBwC6q01VFObXalpfwdvqcAGOwwOGdDT2P+2B3Gk0W5hI0c64w48mDhbNqEFvjDi+v/iW3e4gfBSoP8EfDEp5wds8R8boo0x2+fQSsrHHthdWCGeErlmBNWBvE7jVoJ5sr9ScRrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q2k0o8X3XoDCy1bJmuMyk4XMbq2IWTeaBJNFmegDzN8=; b=BN1oWcDbL8Gz4rku/coLUcHmefvPm3ri65B0UH7zGnF5kj1Tv+Uh9T8nVTBfLP48/BAfVM3NfLFKZCp9zZHxutHOEl9MszH2EijFEYp8ZncpyI6KUa8uJAf9H7hkTUn8d/VhNxyYHhtnOZahApFEbYK8X+k2QRHrsgr1SuRmgGHz2xv4dXTjJyATLk8TYDUr5YmCGnYXMQB860ESu+W2C/UBp0D/loCCRLmlZji7blPz1frFBcgE6PUzo5QCGdRdEtMc6W0UXkj3aYiglBsWDX36W8ue9GCUSBtIXGBDeHeN9xSU96wiUDH04D/GZ37fzKIidsXCvsJi7HCty7EJpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q2k0o8X3XoDCy1bJmuMyk4XMbq2IWTeaBJNFmegDzN8=; b=uYBwzIyO8z0rIAt+1SzPCbWHdQ+rqRQOnP+XJFWfSQxtJOcW98HA/tC0NNYP/YQhngPXd1Gizw3rWILQClNp1pe0wNbYa1tKkkIujYbOpVYDJQbmnQdUYQemTZQfUP7Bmki3TYJ+yGTwL308nVzdptw/DrDZTWlNM5dsEQzig90= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:51 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:51 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , long.wu@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH v2 4/8] net/nfp: fix check return value Date: Thu, 14 Mar 2024 15:40:20 +0800 Message-Id: <20240314074024.3199555-5-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: d734acd4-c9c3-4465-4dea-08dc43fa125f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jITVnz2MzNeKhN4paHueHOG9mfaHPAeKT/kDvxEl0jX3md6JJg1VLc9r4g1/ghOZqHsv2r78WJ4cfxKnY8tZD5YVCQPcRcFsiuLUcDe+d+e1pTSisR3ojcWYLmi6LtuvBL4LQKtOWSSodOJkU6H1nSOkheI1C5kTCxuwtgvG7e5DAMP+/r+TrYjR3u18mdRy4cKGoHx0bYCjWE+tt/hFb3UL1mYMIW0XZHNgjpxnHm4uTX+GiotmAThQfCu4+3N5uzX2vriP4FTweFbnsDv9oyyU4blISpKa+yeiM3H9THmQbdxzAvuTELD9nQA0hbxYy/gG4VnEBOykCnCa1iki2bAJVf99cqUoHdUwONa2Kvu3FZO/ghN+NgqEr20ZRsdbiJoa39JnTtfrLpO3qjFEIXZ8EA5FTCSxER9M0WRcXH4r4mqB8vdAQ8lQixeUZQJxHziht1q2ME9D7rKqKwbawde0axxvowWaeLT+lGZ0asyVipBof+fspdFzNUuoJz684wZabzBrPYVJeqfJdHhu+GJR3FqxdjP+F2TVwWWKoqIJspfFL96bbTLCHAXCLTu2bAJKeFM9Ae0ApYsLWGevave5wt2vkTOOmxYAizNkl0vzq+qC2DMzaSlWo/I0P60AunQexvYr8ESki0GKzycNSNFvpbB/PSZUttaN/cfF5NR2mWGBx14ymhRYJp6+mvRL1tXcRMTPYqcY6WA7Syqnp0QM1c9elRvXJKnzZ0Bwu5g= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XugjIb6oV+yxiSSM5drWdPsDlMwduYaKYkSrHhwHqKzs/fa28MWKlI7vyGauTslDoaYEY7cD3DQLO9CW324DIfcBve3VfQWnfciqnPDonWy9HssIxTUorKHdRe+oKueKgY3eLKtpJO284cQVPcFKlVIpgsFWEGX7zQgUlcImqc6yEaWUtME33gNr0vgHt5DGJ7+j8eNAZFFkeY9tBMSJ1Lgerk3R5MZ6z9TB0Nfhv2yAt3NwEiTltXOhkpt1UGviDfkj/lWBp56Ks4c/5T1ebVDg7DSzAiG+8grOLQmrUeB3j5aTA5J4mUwHUoMLwusqsZldDQC2CV4H8KWxkiOw6psWQcSHiDJ0pDphUDh4Wwfy0jah1iRXiB9YZrq0IYCNIKT+teNPogqDM76vqbeVtdW5r+8XGSVeVBhPtVU3oZR9tdCb499ysIZ1uLliC4edgWd9uxZ60O88JxlRbQhUSJabg3efx1o3BzfvzrJUOeNHxuSLr4a/3q5MVbvYdarfl+hz5XK3nVOIghBbzwpf/PSbjMkFncRGLPsvITukPDJUL1uqU/5sKbGWjzUcaBhYfVIXR+PACqJ88zucz3H7iTeF5LwE7/EMi/tKoTUJu75VT9K7D8r8wjqjz38G0qmiPvJvH2U6WXPpv+Y/EsEv0gZfUw9Nb/CqVsq7EdC+tmuhs9O90erfETM5W7HOVFqTjHpACInrNclfVKZLWGj/168eLFVkSxwdxveo4wrYcHeWEDp0HFjuBlMZ2xe7rmuYrkPkXtsMM3bR9HLdmVzd/uFaR2w1vW098qiLpB02gtfG/UWapg64VVEJy83PlCYX/BOGcMNxLMEABCZQumxzI8wevHZ+rajLK9p1tkCatLP7SmV3GJJYQeh2oY1rznRZXsiSPF6mn5gFZGtqqnxYD8mopoLpx/jRCJnRRCvbSqF53NV3s6DKgNkvAq91ASpOi0rGNCEE1C2tA6b9TnZD4kx7Mbbfte6o70aI9BgyEynGmZ4kC9j4c/C2c0TtkjZtM3KXgphJGWJG6fSzjjgNA/c6zI4yyL46s9NhympFA1gDtg9n0BwdHwpjCsWR7KSC3EHHOvVwFZOXiH/JO4cw0b336ddWOO/nwbrwSN+1aPdfEpFHVOBHwxTQabR9JB1benZE8nxhyBU79t8+CKr2lrFAUy6o608qVGZnye8ZP4JrjFnheEhvNoMmRnysoA89go2uWuGyaQJ0D3IW93WYPrFbArU6VaAcIjx0KNNppTSmBHRn17q+C1B6m2q2EkdZfpdtYLat6K8RdDwfEd20Sa4Hpgzw68u0j7y3nokrZu0mCLIC6caTHI9mFrmaKj6BgH4tcxxaa6y48X1ib2zgDDcaP0jBFvTzFe+QfSpYibmrItnWuDYojCgZmZGk/PsCb6i7hZlSjjTFEtcqvP8ZKxyRUbCHriLlkBYpXCF6pt1i8Wpuz5UJF2xGRDZKPODJC4s3qHsdQJobDu/xOgS/ND06zpmpL2PtjGjgggZpJEIjhrvKK/BKS/kvGGBZfVxle8S1wMfqT/UgvGVHLaHI/kWGlFQho4jrCChFt8daiClCz3hc2bmvrtehHAvyZG6ck8rqzG94eZvJMMTQgVoOTg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: d734acd4-c9c3-4465-4dea-08dc43fa125f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:51.1437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WfXa58hQGwFq3tu4v+KVzXsD+OgKbxhh3AisMGGJH0pHtyDROXvlX4pdbCfY12S6xskwdwJ+thjTj6Fe2MLAXZFiWJn2KTYp3sPOrGTCpM0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found in 'nfp_service_disable()', not check the return value of API 'rte_service_map_lcore_set()'. Coverity issue: 414939 Fixes: 600f6d2c7704 ("net/nfp: add service module") Cc: long.wu@corigine.com Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_service.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_service.c b/drivers/net/nfp/nfp_service.c index f49fa6addf..24d60857ac 100644 --- a/drivers/net/nfp/nfp_service.c +++ b/drivers/net/nfp/nfp_service.c @@ -90,6 +90,7 @@ nfp_service_enable(const struct rte_service_spec *service_spec, int nfp_service_disable(struct nfp_service_info *info) { + int ret; uint32_t i; const char *service_name; @@ -107,10 +108,16 @@ nfp_service_disable(struct nfp_service_info *info) break; rte_delay_ms(1); } + if (i == NFP_SERVICE_DISABLE_WAIT_COUNT) PMD_DRV_LOG(ERR, "Could not stop service %s", service_name); - rte_service_map_lcore_set(info->id, info->lcore, 0); + ret = rte_service_map_lcore_set(info->id, info->lcore, 0); + if (ret != 0) { + PMD_DRV_LOG(DEBUG, "Could not unmap flower service"); + return -ENOENT; + } + rte_service_component_unregister(info->id); return 0; From patchwork Thu Mar 14 07:40:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138350 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F73243CAE; Thu, 14 Mar 2024 08:41:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40EA442E7B; Thu, 14 Mar 2024 08:40:56 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 620F342E6B; Thu, 14 Mar 2024 08:40:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CgTC8izZ3nTjdG+37E9LPcKIuEz2CgJGckSqY7GnN4Uq0ZEdswfSaSi9pBVrxaU83liigOKmObJUQ3cECCYd5UA3QPJkC8+irveGjtjMPMgEuL1HA277xMM7m5dH0xc6AQmaSMyYE1bfl5rOftYZzCIUmXaX6WnLFImL47x2zwk/OLFpFrKsNvz9V74+vIbHeN3vYofEGglgnW8swht/5kVj+uwL4Sa1i9TEqhmmkSUCkvxty5R1EgVobZ5GdVYTCGfnNwUcX9A1W+Y/BHKJ8I8nsIDyZfGwi0xPebDHRwko2+2wwcCaswLSQNM29t9hh5FRnr8aE17eCoSt/nEnTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EB0MocTzMUAcKtnhvet0Pkwim1Lriwxw1GaQzsfmPjg=; b=Xn3Gdh/Psv6hQokr68Gz/JKPuQQS69geTu30jDJjLpIJUsxRQ/OhNEyGhtpiupRcvvIsAQb9UbT/Nr4DNNuuw9/9MxpnUw2jhfLS9Zj+ZC01/QrZdC5QOjD1A97oSTWowRBBg9kMr3eAxPZfM7MpOkFka5+YEr9m0yEQon4cfD/+gcozXNsA8L+/BPYgOj9PTHHzRYAbrmwepI2Zfypf9DqQq7QRE7wT9IzJlwqrIZG/RlxNS/nZeiU2GDrG1ZZVy9Kim/6NVmzSde0INMFSJ00m5K8vkbULMeN4X3W9qgSI8KGUIShWhA2N/ytVmkyj/b9VmZWFEv3J3dam25dlTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EB0MocTzMUAcKtnhvet0Pkwim1Lriwxw1GaQzsfmPjg=; b=ZXLd6Xv9i/H29TDQrojNPlEY9J64TYbCNW/zHcqdk/wMOWjFwjYYWUSq1pqFgFel2hJq23v+7XSrllwyCcHykDD+Yj2xjyexWnNrmBWoWSrHU0d1ncotkBM/BtjgJdgJyZtxUfagH2zKZ1EbT8zHDWlBV7HuSqsBkT3DXXXZJes= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:53 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:53 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH v2 5/8] net/nfp: fix unreachable loop flow Date: Thu, 14 Mar 2024 15:40:21 +0800 Message-Id: <20240314074024.3199555-6-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b628394-ea0f-4883-fc07-08dc43fa1399 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w9VfR/KwEY3E5pl8P/RFNt4isqPly19OHCS5LH1FPaI4/exoXcPDUevdf/luDxnmZc1OKA3U7i8KPPwhBl+N4XDPoLDb3M6oBvJjxKDpSWd6i79iJQeTznOF2XAFuoR4ZUSoB8eRh+vYNjReZ+S7UCfnnLNhnIqj1i4N3kOwdXWCtnSWgLD1T2Ka3JfmHngMWtSlGYlOydLOh4ENvQ49iWUV+woCYHkt56quSwegoIdK+ZX9jY1ZV0/P4kH9qo9O+0JWqVFRTtWE/U9EK0MOhQHqLrukIW33w0MAyFjsrp0Dh8AjrXeks3kc7fb54ouXKgVBJ9qRFGuRywLNBoXqGzjBK7XN4D/n5FIlNo0VO6ngmufr319VsfCgFi2uJHpVv1XNVOtJsJEdVHvr7Wv7FSZMIbwAfExVyFb845j7/h6HpfofVE2FtqBykCEnUhIb3jRRRJ5nX6A84tlfNjOPHQ35g2wFfeivj7BdMncpmhud+gOW4me0X/DxHE1rBzy8ya+vPOcoHkpOkoZFxi63llH6a+lGWZJ74+urgmTRmmthmEpkinvvn5Zt2dtU87foZ0Iv/nKmztp7QLJVR8W8/9oZfzywlJZDgzlFUOuS6yWMywHVWAlVmQrIJMetsbo9Nl2bfKz1AkpYAhgLCJIPzj5eyL3QBTkZiMpODV13yiPg0tX9Kpe4Z+ql37aOUwQN2heGxhbU09v/f9eucbiqsA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5hRaL5K/WnDD+hPdicxOjbP6PHXwsA1W7WBRbnp8jNusgTqq+cBbDaFKfQ9rZwhX0O3vvibewBssUBQjpV3Tivnesc+b50pcC2o8zQNSOLNIv1t4I4ylzh8YV4Wq+5/5Cc0/redj3TOzYoOje3VQb35hYTPoSJYVbcUINCVuCeB0XNr/UeBAgKzqdeepXKuSdVFOLtGD8y0MuR+fM1OSYarKdX9Yo5Yf+0K1PC0ZBbibm1RtjgvGpsVsyupmC12nJzlhl2GyJ4vQCsS2PQk3Ihadtx00421PfpRQGmi8AS6JK91ZubhNxU9SSHyp/1wHGEMTIVVIjxXS5ZO6/TkzUsu0lVw9fgXYeZqSqloptejd8vg8e3fLpigBAONET5S/wIbazE4mtPOBmaX7nXIAzgwlDJMXyE0nd9ezs1lI5vENl5z65+l/7ryjWJVur61Xio+uOI35YtSUdd16BUEfoDGq3N0tM355u8vVVH/dfOTVVB9hWxNWI4x1ZLN6RoM9JlIqF5Q4J2R4Er1PfD8ywBYuo26vLM8WWx9EXh/sGfODrXIo6dQznM3pp6jJTLcb0Ln4y0+YiwPHTbVv87LIIFgvMwPJ3OQW0Unv+gv0J5l4Fq5zFPjccd0+p7RO2esawY0aeNq2CrE4gbZ9BGjMHfhA/RbPBU79MWvChlmzmiD4ccNrq79iIyUIAMgM+RC5MVt9zl5bCNUxAeepnEbsoF7dAkVtmx0nMEgFsyIijvOBjltJK12pJkcvgZKg8pgBZ0XdYh19pZ9zRVArhgpwe9SIauePsd9cttcsYu3Jcj8l/UiLaNbOC0+tSL2SixXtlHti/VkaUkwnfx9AvUyiKGI+ErbBGejJFk8l6fujGtC+c3ilMS503ZAcRqfeexkjTk28nhVXtWxQ+RNxRVcQYXCG27nhAmoEGtH7nL1/4HRrde2lmMKYYgInN+8sptwZbDx8Z3IxVpB8Qw97XSrlvjGsKYtm1XRFnMpDZaeFlZzAn+ZXA13m7MaSwsGp4/TnBAPzhJeT+pPd9EhNX8f5iP6vcf6AGKVZVFOlycvZedYWuWL64DVMXqNI/17S2uwILEb4lMdLLfZOG+FjoarqCvWhQ72E52DcM7M7wPXUwRZW+fpaKELd2BxtBhWWpnO549JV/EoSeZMnFd7gsbMj6sICuOOyY4SwW6bHxNN/34czbzEHL9ePoUk8hwuETdU6PpbppxMiZV5exy7G4okPnm7gprmln/SzNNKd/vwBeJSeitFE6iatGTeD8LpJkrXmmbF7SDfFrAMXTpXuaNZVrMJJ3FPEHegKclReUnSyD/9ATZEmphDoRq4xDDDQDY7T3FCtyAKIkLq36+nlhMJSr2PJ3fuda+Lfq7YyZRjjsconn4fdziFVSkl0EEF+40Fjdm4IWzIj+LPfeY7GAn39dKZXQ0nFxxgREOckokhP4uJ6BSWxyxJOCzbBz2yoz6GCgYwP+PlyOqLYSstjH+3LsCYfWrln8dq0QVZ7Sv+spDQMKk8nBLKnMymmkc2GvZeMNDcJ58ba9WKSJaFC1BhC2rM7Z3jufnjetoAl5soxz6HFuwOHKGyV0zQ4fKm4AzhMVATtEpvp8herESaBKnBTtw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b628394-ea0f-4883-fc07-08dc43fa1399 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:53.2320 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Pypq5yozxVEiRGv20OCMtRCJLjU0OoSVSXmJMQcU0mKpiwmmxE8vRfYTKAwMiPEJmxYBCFdpWmDkO9p1W0ucl/xQ80rNv1TNPcLR8Hw86c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found the loop flow in 'nfp_net_flow_calculate_items()' will never execute more than once. Coverity issue: 414941 Fixes: c91c6512d876 ("net/nfp: support Ethernet flow item") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c index ff6ce3ee45..251974edb4 100644 --- a/drivers/net/nfp/nfp_net_flow.c +++ b/drivers/net/nfp/nfp_net_flow.c @@ -180,6 +180,7 @@ static int nfp_net_flow_calculate_items(const struct rte_flow_item items[], uint32_t *match_len) { + int ret = -EINVAL; const struct rte_flow_item *item; for (item = items; item->type != RTE_FLOW_ITEM_TYPE_END; ++item) { @@ -187,7 +188,8 @@ nfp_net_flow_calculate_items(const struct rte_flow_item items[], case RTE_FLOW_ITEM_TYPE_ETH: PMD_DRV_LOG(DEBUG, "RTE_FLOW_ITEM_TYPE_ETH detected"); *match_len = sizeof(struct nfp_net_cmsg_match_eth); - return 0; + ret = 0; + break; case RTE_FLOW_ITEM_TYPE_IPV4: PMD_DRV_LOG(DEBUG, "RTE_FLOW_ITEM_TYPE_IPV4 detected"); *match_len = sizeof(struct nfp_net_cmsg_match_v4); @@ -203,7 +205,7 @@ nfp_net_flow_calculate_items(const struct rte_flow_item items[], } } - return -EINVAL; + return ret; } static int From patchwork Thu Mar 14 07:40:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138351 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0BE343CAE; Thu, 14 Mar 2024 08:41:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3F5942E8E; Thu, 14 Mar 2024 08:40:59 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id A71B942E7D; Thu, 14 Mar 2024 08:40:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aBVoxwynR7W882wvXoX4xnqVzGMn1Q7KGURpL6YwYbskgAhsc4xXZlrywHYAvQXwpsicwhKUqxcx+zq91JfJFb64majavoVEDi3JYDYusiP7CpOUWiJ8R5bMDJYoxPJ+StApVep4xq95j8il8fLVnN5bw3Fx/qh1tPeEzJ/X17Ww7aND2G1djyoyjrfHEmiL/VZneAWMmpNdfKURFETAN+jO848mOS2PBAuUblsbRTE0/BJNSw9GkhYlPBVl0K4g4exzS/lxpM+qsUU1uhvByO64/SS9dxx4zMCxjRBKx5lzOfd58E9I/plZGutm5Hw5yVXhSY3z0urAuTJqtnifrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R1vFhZO3XcS0xmnG8doqo3d01BUp6K+oMMUU0Cpnai0=; b=kqmLs1x9dB8p6D5ZRben8DpiQyKg4cy8bHQlSmlcHxaf+oeFFUnhvHdmAQRq6xL1sGEMVD6q4jzU6qKQ6Xz6eybVX0DxkeZEZ7OGka0vYodgW5SvzByhnlKn4XZmAQOLsHL8X0vsN6+YYmQqb04NsusmeNpTWR4yNwBygXQVya64jpvV2jYflr79eQ2c7IRriyWJArP1wQ4dfIiFwZuP+Ll7KXxFDBLcGiq5VSrzy5XMp67XMWDAFyBVE8rop1SzfgqeC5xV4GJmTgQpe/uEnEQJ+r+krSxvBAOPlLON4BAItM7BzTlSDU0gWnHe+lyGa3vouLIS0IIDBHl7v8HjqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R1vFhZO3XcS0xmnG8doqo3d01BUp6K+oMMUU0Cpnai0=; b=GWN4Z32fe8vnn7DkqrLPRR2QL5CpcR7HTYhyhiNBUFv0ZaR1zNASeH4QM958S/E1JF5uBbmMXPe0VkVW7whYAU2tRPqeMi/1FDhz2XIpVRnDbA/edZw5FrPMAwH4+RwKCTCnAXcxe0HoIskNo4KPvAtUyVHvKM0IlqQmFzd8CFw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:55 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:55 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH v2 6/8] net/nfp: fix null pointer dereference Date: Thu, 14 Mar 2024 15:40:22 +0800 Message-Id: <20240314074024.3199555-7-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: 1761ee24-ba01-463c-af7e-08dc43fa14d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B4rbOmG/xhxI3sF7mfmtI87Uag207MLilcBqCA/AfszHTZLXEHuTfW+g7U/3uC6SEgym7vttr0h4Y+B3W69SVN4PcBShxnrzWfw0AV/e3CNeO8xjqk52FWxzDXVXgb2DyiZ3VHbgYZYaJBxy/TVJgOE987OtTBbegC8DjcdsL7mjcYioyB+fZ61gvK2c2BgmSPx8t9bdl0AiYcL1K/0TawgaqTAVMUgp6lNxVbzgstanl03D3A/1MlmnHOnZwjj2y+RzWedAzsxbTEis4FAIPmlkABXMsGvqLpYz8gEqJ7/hhMbnYPZTUJ9CCwC4NcnqnH2i7CcLNhfwHuxGAvkMTyOVGulDRuWmL+f0CIOlGlyx9g9xHu86dD1OUgAovPpDQI/BDBp21QX9xt/IsnlQU2dT2NlFgp7z1C/kUa5fIEKQKUw/P/caXcD9sxUXCbgLF2/0ZutgPbTfxcoYZKlEil7/1w8104o/60yoAiokJ5nGpfl+ye8Eke6pdSYKbX0b1iVuG7/xYuiEUcn5CBg9FzK6cxflB7SB+HXViq43VogGPATsp0vSx96oGbd3/zNhSGdrFCCaAs8t/O8SjNdelPEuwtLnF+tjymjfgytikWjyGsTrQ21ef+JtqijI4TBlIqBGFHgF7rntp7v07BN0joHfmWCfdAnoHaDsqKf6LasA5ozjsXW+wD8T43kGP8wZDuV735+A2pe88rLB5++NjU35gKy/xyfSqhS687ME5eI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bt38YTJZ3j0jvpOU4zBh+od9su7bc2jYaE6Sgo1FzStI2b/gEqgP82lCiFOvqnIgrDpoA/mS4Z2RF5wk9gG8zWrlJg/FpoF8m1+d6jtbEl6nXRpiOE6j0qDFkSzWeRc/97mmi7JspNqTmREU+PiMFWkqev5lum/tNGUryx+Y7j+eRCFFWdfL+WPGoHACg6p2lAzJqQj776RtTOWT3tFwAZR8UfGUThBzuD+Bhs+f4/mOOjAEFajtpb+Omok5xxkXtcr9ZSCscj3q4GBYrYHyehA+LYWO0WzT+t054kCuUHYAeIeVbatNcTtTerXIuYvhnjq0LBUXDOG24hMAudkjs2mhMyW/yunlyjkRyhsUqYsQaaa0Kpr355xTvUI5WE7MTHvPgE33dwaMTBDBd9i5ACmb85R4En8qeJkRQ/PGUvFOdgHh/i+cgblvP7fMa8uz88isKOZ22mycKSGe4sjDavYgjg44D9wMoXSZc9cFJ/PLu49Tal0i9aBaVA9mX8UI1aiTh1BbzC25q2Ajae0Mad97wfT1U9zmwkOuGSpvpj6gjizvMIU3SbLM/TsEMzYQ141ey1RluGznJmrtioXdOY7BeuJkNuDI+fDSHemLqZuEK/ihnx8V8RzcD0I377lOLG8c87YGY0CTVvrNVXWWvgngAKz/rI6hLY3+GFd1OhOEjlFHM8hTYQAIeEqHmHX+rK4+MleVGCDRKMRFhFjYIRZVATt+Dj9XBFBlpHlhf9lOA1cJ4HrUM4+XLCSlEOruDjFeJ2q7wUKzemE40spYUAP2thBQXyrw98bgMNCMaJ+jdXarMRppEb6qFOoFxNtkp2D6dx0iLOeqZnCwISwBqoHR3SbPPbjpRoNA2mWb1Bi03QIofNF778kj2H50wVs00Rj2y5uYPPcnWR+ab0k57alCPk3f14L+obKy6teW4CfjFS8hOIhIA4WfdHeJ0iXvT/ZjmQHo9kot4ZK8rXPdXud3Z4rQxfOxQ49C+IC0hMlb9H2Tk116ttP8zTTIqGcnIn97N6yTkaQKFmCmzbcIBcFMR4rT7kIVfTFoR4ox9UGsyNE6qWXzGj4rulbkFzrW+ESfJvSDV9MJwsjTLz8Zyv6X/obA7OKAQg0fm93y71pMykysI+YfbrHSG+MVnJyOZziUgffN7p46pecQWiFA9STUyfTWV7r7ImawQF1NS5FGQwT8hoYRbnYIGq+RjIIk8sZBGhg7C8MPRVEIy3dVp6Ot7j0v6sMJs7sTWh8aRdrGisGLl1sYlwYs/X6Rd8BwVyYvlHmmjF9g97aHeWH5CULLg6H70mktjhLBizFkRF6Zk+yN/F2xuGgWrCin57PjIwAELI2VnA59b8ZZPZe3VZRsIN46KtP9qWb7DVNKQjpO+d/dmohZM0y+R/D3gMt08A+Qj9jWpjulPFA75qXhrLaMjZDDmehRgefizqDxZtkn7ZNvLrskUoEwb/7fXF4gpNuoV7m7qYqP7uysYAwT0yCUSo+1VGUNUJNYaHR/nqaR5RmK8fLrGA24ZylohO3VmiOeKImIpJB7C6fOref/bavWXxieRUp335tkqnIWdQ8XvfD6idxYK1OOY+Rju4GfOyjL71NgpMHUiny6Dbwe/A== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1761ee24-ba01-463c-af7e-08dc43fa14d9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:55.3078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uCquHPDMuPH56vY6bzOGXWpjYkJ9sWrP98rLA/FcOm3kMgTX5eOv/oluc7Z2Y5bGOAGdRFJH4a973Rn2aXcWUcP4y+SZIVaAW7+xELUOr1Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found there are null pointer dereference in 'nfp_flow_merge_l4()'. Coverity issue: 414942 Fixes: 94438b093702 ("net/nfp: support TCP/UDP/SCTP flow items") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c index 251974edb4..ea743eed73 100644 --- a/drivers/net/nfp/nfp_net_flow.c +++ b/drivers/net/nfp/nfp_net_flow.c @@ -349,12 +349,15 @@ nfp_flow_merge_l4(struct rte_flow *nfp_flow, ipv4->src_port = rte_be_to_cpu_16(spec->hdr.src_port); ipv4->dst_port = rte_be_to_cpu_16(spec->hdr.dst_port); - } else { + } else if (ipv6 != NULL) { ipv6->src_port_mask = rte_be_to_cpu_16(mask->hdr.src_port); ipv6->dst_port_mask = rte_be_to_cpu_16(mask->hdr.dst_port); ipv6->src_port = rte_be_to_cpu_16(spec->hdr.src_port); ipv6->dst_port = rte_be_to_cpu_16(spec->hdr.dst_port); + } else { + PMD_DRV_LOG(ERR, "No valid L3 layer pointer."); + return -EINVAL; } return 0; From patchwork Thu Mar 14 07:40:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138352 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95FB843CAE; Thu, 14 Mar 2024 08:41:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 445AB42E86; Thu, 14 Mar 2024 08:41:01 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id B0E3542E85; Thu, 14 Mar 2024 08:40:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CfRjEeQKmFAFaht3yK9uIuxI7Q/wqCxwjTajxm4gD95e6oovFV0WlbsZe2G8PRsVjJQV4WUmi2JZ0rwQMdmOGUgjc3T/yiZ/U8HMxdc654NVVaINTl6rhL/YL8iIH6WkUd6I6HhLT5ksLTWqxflnpzTr8hSskEPd3KM68r98Z3FTmIcWkZsyVWQslDutnCJxcmLVG9XXGHdkCT5y6IEAMU+e/qTKfqZNrvEU3xKhVnYHHRHjJNaeloDuU+zuwj9bhASrmiteev0gCJGNdwadlRacI+Za3MuNWnwmIFPNSHy+IYSavbmOZaT8AcNi+JMVkgK88FioM0C/yiuCjDrYDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=blmJfntqQa/zULAjioHgjzfl6fR2hpSeb7LnNJBRibw=; b=MCzfL74jPCUTkFtU2vwL0HblYv1FwZfa2rvsep+WlnLHLdxg570YOhva25SBYC1SgTwBbn/B+p61eLMqcehfm9uiHc9CSPQikThjkCYQ5Wq8VtS4NdoQHd35ICyZsgVxuutIJ0wA1M/uIcmuBecY1wZQcvEzhuqIaKxhxp3xYVJbmpxFoZs7A4zHIvmHvG1QRJQI5PAEk8LXTkHF131AiXDyDPaeNkd9uevC+jcY7Xnn8LW/mbokncQqYGkb0u7pUNOt91lVh1wDuWxthKZzhW3dQujU+Ros8VNT1a8vBevZvSvQFnVg7qvldN3u1pWgGY5Wkd2OpzvXM/38ukjxQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=blmJfntqQa/zULAjioHgjzfl6fR2hpSeb7LnNJBRibw=; b=v/YizlepkgwZ4kfvoEvn3tQrf/kg64hMFeKqCRnT9Nxo63BwqAnGJB4Uuur7qm453rwDWqQJg8co6U1j4jH4m/S9Raq94t2r2ruFYMdEDLyKyDPNqOZ9M/2w/zpIzrKj47obVx9pWMi5jCG9yiPcffpwGtrXQwacFkH8N7OhsGA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:57 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:57 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , stable@dpdk.org, Chaoyong He Subject: [PATCH v2 7/8] net/nfp: fix dereference after null check Date: Thu, 14 Mar 2024 15:40:23 +0800 Message-Id: <20240314074024.3199555-8-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: f70018bd-2747-463c-743c-08dc43fa15f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eMmAIXMJSsLJa4JbFthxOJLkMwCheLxDmBofRZ1dDmTajhA5TGPsh3AAuOEP1XgJUNwMkNvKv9K8TsPKQQ2jnx6ByW1PFJH0hiTnY4PzZbbOKddK6WDi278+kr5jsOGu/N3pgSOhgszJBc8B7kcIh4B/QcwFFvhcS9A2SL7AO2T6gmBEpRiy2/ad4fyULBGyGzlgrZ+MTwQANHVn/f3nhK7DbSTH5pLt7rplOVF9LnKxoA7nrZQG+v8wG/B0CN6hjNAyWvXpbgjBXlYmTqe2CeZW69wB2acxOdhoDGMeF3ASc8eRIVmdsadZIsiZZ1HbPblUVS5KnEmiaqmU89BlwCqkSdcu5GP/QD6E4AcCaZV05Kda3UyPGjBagcq0KTHW/5LKCnNIdT/p4M8sSELBNw24nvg/MedcR20pgZkw+K6yBitNaRkJhWayzHCgN/jv+GHCuItLkAWS/cDZMW9ZC+71o1qhk9ya4EDp4XQU9mXQrA4FlqUu+ST6WWImGKa8NbEHVBUZufXQ0rAap/lakShNwSXicfW/Rz0Gxlf4lLKP6noLVPr7UOpaevWvD/w+EWXXeorzYPCB7iZ8u9hANNbdnTue9hybPX1cMS9p0Eh6teukZFjPYAuBmTyHDEEM8+zZgqZI/tn16FLqtC6HeFdClGpm+mPhKWdH/Ru4qAy6OP6s7qWL6vdVXD8kBxgJz6wR7JtXGch1SWP8PKzIFUk3SAV94WLEDsMX7BkXBHw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zTst+fKvJyQK5eiiEh4YzraL3C3jpQJUj3kea2Z3SCVR32XaSndvZnR+aJpNYl/q4xTlCqUyCaJQ2iZD1RyQqEMu/EnBULyh3OqLtb6CLRVujpPY71HjTAg10Rggc6D9XqSzXLe7Utq3C5DDaUcLwWsaGfOmbYcWZuT5sgno29vhJUjTTcidWQ7zNvebV+Iu3n5dr6j9+lv3YFgyRYnMfarslq3wOqydfTMcmzeYhJ+L272R4SXbQOhDw+jYmlMrunM0kq9NCDI5c0tfOEBD+tCbOQjPSVWURIWQgmu20XsKVumjDJ2qmEmln9L81Tlszz09efMWI7Sp/2vI9yAUXFNO2HUMBiHhMrn+U1ue99/XBbhy/vcyjRIYTsYuEIE3g6TXVjL8yvVib4ZPY7ke9gOC9fnRDNDfVgtDY7NULFIop+faPyPl+yG2ta89+Vj5NipORRj+CD7wz1ncCA1eyye5W7x5ma2IM0SGHYsjBvABE39QP7V5ZpSf66lpxOHIfsEmz0jzCQqJhvILqvDSTohDwGpe5DbypadoRViAYjTOWhgek+WsfSySinvv5zuYFEP+UhTeCeKctPLz9cNNBDriQ0vlVKn52d9CUn8K6JTz9vt7Ol/5sX9t2JlUlCzXC4g4Zwwz1em1quCMbzApiQp/l64Jm1+CEUGPQO6HwCUo133SNq9HRX2+pN/s3CrYo2I3ohdbfPFmdWClGRzHEYd1ihi/A18M0XlOS7FKUhzxm3HHan8388lsBr1vFE6/UZFF4orC1BW8Hr6pxv172A4rr/+2GimAVpsORtKKXvMQiKe1a0ku3e3PNH04tQlRd6b3cH5V0wE9sT5Vk0q1F3Cdiw8rpJEp4rpjvQOamQHc1KUyRmfWffJqWSbDXFlD6fyhYa3OeRM5FriYBLOcpYlq+mtnvGcbww+ZePlxc91BNPvcrpU8cjzq4+6NlIdKs6qCKwc//38JQSeow3ZVjb185mK/JdfCHALA9Z2bk7VlWC8w9gYpbqK+DnjGplIJOPODoPCRSvA8ovkIv26/1p5bWl+GA25gTPSbg0FxaUpd7XhENyK+koFiPnXo4aUZ4eiOzuYouGcEn3Y+p8paDlsQQrmsYBZJsrciNNCQZ2hjumQkX3s6ZwimkM/8GRzGjhsdPjwiWkD+1GkjsRg0+MBniQpjWWSv7GdgrM4fyNyT35E5wqHzVC5oHXRqjEOj8tZ8hLVKm3wjYTt4CnF+VXhC0brK0PtxYxcWd+5cUqkrgWYFTg7ERcHWiOU9EKlJHuyEd2N9g8z/19uQeLL14ZbCfhUhwQkW6O1v+y3KsPGO/Y4egapURH255iCwo+eI+/BDyyaeKEkPGLvUiDgHj1dfEXXZTGDOgC0EQAOBw/B5V7P+43UKCH+3+AzbCWA1ZrXzrLxbaUtcbtoxGri2xDHJnPTnvv9tFFBqlfDWcey99zegYT4pKutdQKS7PxiicPuklBsbAYHuZE7P9Zsno6wdYB1siFcS6tue+A6xGqjmH8HVZDSyOzp3WXxvQa4CAVl8fn1GuI5fRds21mS+YaLGnwGc+iunfw+6re2ueBdMbFZmIEswrwiMU3lyzKQR4xAt5l+B8WjvMaS2xQalWA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: f70018bd-2747-463c-743c-08dc43fa15f8 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:57.2048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iRXfJt7rnXzYudMB4aYDVLagPB94j6na7COztVGKw6HD+ek2Az8OvMIwlgaj3mMTZioDB1MCz0Vs4XwZ30sydeweTMAIp0sjTNMki6qQdMQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peng Zhang CI found in the logic of 'nfp_elf_read_first_symtab()' has dereference after null check problem. Coverity issue: 415042 Fixes: c82ca09c441c ("net/nfp: add ELF module") Cc: stable@dpdk.org Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfpcore/nfp_elf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfpcore/nfp_elf.c b/drivers/net/nfp/nfpcore/nfp_elf.c index fbd350589b..1bf68ab3e4 100644 --- a/drivers/net/nfp/nfpcore/nfp_elf.c +++ b/drivers/net/nfp/nfpcore/nfp_elf.c @@ -898,9 +898,10 @@ nfp_elf_read_first_symtab(struct nfp_elf *ectx) size_t idx; uint32_t sh_type; uint64_t sh_size; - struct nfp_elf_elf64_shdr *sec; + struct nfp_elf_elf64_shdr *sec = NULL; - for (idx = 0, sec = ectx->shdrs; idx < ectx->shdrs_cnt; idx++, sec++) { + for (idx = 0; idx < ectx->shdrs_cnt; idx++) { + sec = &ectx->shdrs[idx]; if (sec != NULL) { sh_type = rte_le_to_cpu_32(sec->sh_type); if (sh_type == NFP_ELF_SHT_SYMTAB) @@ -908,6 +909,9 @@ nfp_elf_read_first_symtab(struct nfp_elf *ectx) } } + if (sec == NULL) + return -EINVAL; + sh_size = rte_le_to_cpu_64(sec->sh_size); if (idx < ectx->shdrs_cnt && sh_type == NFP_ELF_SHT_SYMTAB) { From patchwork Thu Mar 14 07:40:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138353 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0176E43CAE; Thu, 14 Mar 2024 08:41:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EBB142E96; Thu, 14 Mar 2024 08:41:02 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 6AD6A42E85; Thu, 14 Mar 2024 08:41:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EutW/ewomm3I9e+OoJokiUtJLpZL0a6xCuehxj3/MCgB/FRFg2Pc6JnXWkSqLEDMO7eFd1AmKswjJ3qfbhK2jEY5npZQuRFR98gACymz6hag4Ul8ITJL1kxqbN6yflRaXQzzEiqyFtIzXrdfTDma7jE2mgiPBIulPVW6jR2oNZLyRVdb+Ehfl9vBxDhbSUX29AvJQwrlUMI3zoDbqKKjRfueUSGt2xlluNYQ3li4dfBqYI9p/x8K526OjVthIfXc3FvSxGCPiNc2WDGUaau4rh4WLF2r655jD21WshaQs+eM3myf6M4UUqLqsECy9F2hwGGhI07txRNlrbJrg/Mo/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2mMH5drtNtdQqTuztBvlVEuaMT6t6fMbyiwgFPLQ/X0=; b=jqY9g5MJbRLbtgoqx/UpmOui+33Rx/p+WlXN/VjUanaxCV7SlHFp8G4+r+DY5I1xJeK9Q0op339ETXVUIPf+QMh5iiiu+QqQAbolZx39VHGd761ox3cBWCO1hLK4udP1aywjdU81lrPYOKdW3CZbyeb+NxIwpmhwCUj3d6++EFu4pGqPZIUmOW83FhvC0yoo+koZzlmcoAnP/XX1de8SQUsccrAQS1kzq80u7w0R24rDY287JGV0f6RFncVLKi3X0Zw1RHlCE5jGz4rkOQ0ftM97QbdZgrngW9CPyN1OjcdweDoLK30Vl7/9xAio2pPv1KHB4t9YoqHydW0EafBb8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mMH5drtNtdQqTuztBvlVEuaMT6t6fMbyiwgFPLQ/X0=; b=BZJAGuB56CGDSZAdN/qZK3UJLubu9F8l0fVMxNAxuzMQoDaFf/pD9MflGNczp4BNAOp2sHyOUOWLRGICV3ocHPqTtcP4WhtzDDpCLc1K7wAf9i8dgBslLdcmRFBesX1Pulnz/r3zBpXvEa4CQk8WGQA+4X5idP9EWl8WCKF3LnM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:59 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:59 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , stable@dpdk.org, Chaoyong He Subject: [PATCH v2 8/8] net/nfp: fix tainted scalar Date: Thu, 14 Mar 2024 15:40:24 +0800 Message-Id: <20240314074024.3199555-9-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: 01ec26d3-2260-48db-e49f-08dc43fa171a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NscTN95vjfbq2+fsQuvlg9oy/a1wDotgT0EGq2F8woCmtRDjVANQAT3b0UvSuCD41ONqG258OTrlmDM+py2IFUj2CdqDqv0l7PscEjOCOZnWJR+c/966FTLeAoQh0vfrty2/SPAh1/4R12bVN0q/LD7egM71IVdn+gi9GINGpd824WPlU6DxZTYA9znraaJAjvl1Ju/53rBr1LoV7j4rOPKHGN7oegElTcwcCiA2YTKqsYqxIaAIcU8peB3Oxo6O7D83pwAAf8RvDaoEYUpqelRwZM/lJcFrzfuBX++0TDozGPxRhc/F4oGex/EUzxdNlMOAQM9XoL/IS3t+hgYAVf06v0Tl4mn44bOT+RlPgqwZStUkYzh+jl18dXlkkfWHYK1hH3AT5F41CyIZK+o5BFV/B8L3lqI4VFcWRbPuxtBTnOyAqBSs5Ls3B8Z+8Vgjl1Fs87qUMyUhz2CgZG2X55GpReZMzQS9DUlIbyQYw0SqI2BpHQhJTnyKdEMz4PRAWhiI72GqYRbxjY4nJvw5oQwzDA9SIAih29AqPqS+lW+aCPZSkhqD8cToSe1QT/gxyHxru4aM4qHPgS/JVrVmk263lZkvVE87aOYkCmAy5xt0ANUw0WWqjT+WFU2a68Eyz8DLR+XlErbobRSwPdEt4pdO6ylUFoMQdUih8A5stAoP+5vPCkLYg9FqDGz7vJIsjnH3ptsuVAHHMO+oly9pF3NWhpJKREyohZTSTfZFnPA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GPQ7MdsrwHffbQECsnb8QJrEaMFFS8fOWeeL5Tj3tEgDcjArYxYyTVzGYttvZF2+r9XByJ+p9AkEQ6Ziox1vP2WxrESNruCnm5B7kDvX4VUYXBrFvn0zpAuSu4X0NJKjp0yV4Tr5uUCQrnKK3P9U1Lvzvh/a33E8+6Qmb9fMKv76dpOTy4L72/9sXwzueCJgHu7Vrx5H8M9k2NrrduAvndqX1HXIUVEgj9x5AUMRdbnOZdmHwlXCSowvBFdkUHgOXaC5dkTmiZM21XqL3Bk6ttj9vgm+E8qQMZxbjrgpF4lyde5SnClWOTNyKLIFSRUMqxQdYoFw6ZmJnVzEzysK8l1GQOlgMEVI8RTcqn51IK9It4VK4Fi/meEAebsgiY4nSZexXcZsSf6Jct4y6KiUD4QypbWrYEAOC3lCxlFappqnFixdItvyKsct7XPKOop6/EmoXixlDznq/fA5dtabC/TweabPh+ovlH/EZHviB7lAhlgrnXD5h0UgCNEWugaskP+OTb5t3vNEHNJRl6m+gWy846Vb9DLGbAcOG+3dBIaqzDQEAtxLeUcPBxhOsveiwhK3SAc2I1aYcVRV/+dxLUlR0LlkTZbKlm7wwJYsretc3pROtJHn7zxauCKVcyAH19iekGzmdscVR7SVQ1Chn2a59pDBMiKfTytaM4MbQkxQ5yuISWJnycz4OsqHpvYh1k9Haf9HY5w17PYxphdCjoRsw6tqVt1JJ69teItA8eecPZfgdwnddeZLPgLMeoPcY3JX6cgB4d35pFDndYEVYbD11LYTYR9wrr5apsGZaMqMyHRS/nWOhoeG3xqz7wZPyJOuZAPXwZBouBIZmd1x4skD434JuGoxtzEL6DUFOLMthhiBir0NkckEmTY14pCDCMd9k1JJ1IuNCSf5cPUWHIzqoLMOVHrujKNQdv3F/lSlK/q1t4NDtRQvRsktzA6cn8zSZuPhquMAjIhJ66MSjsFJKF2fS996q5eLD42851HP79+V68mgPJZjrQqyEc3i5X0drjZd2klD69qwP9LNp15rlfF+LoAiQ3ycETxCak0PTGSvmJjFB85EQjm79vN6pQLfWVGjyaTtxAirll5FhlAtflBozixcNghlg0pzOwi/XzEuXBEv+z8pCMR6X0QSMQYHohbmhqIZ4xhZEADkCQu3L+nyJg1iP0gynKxucvclXD+cKLp1x8Dxo87oo8th0g6vJOiQ8ochLesc9ilgcMqODgWnIARcQSOueMJ46nfNJPQb71ZIU6Ahuao2y/1PfTgVY5/NNT6cSFENN1yO4PfWN7+nYOPN7J4j9A0pDM46cbFxCIqGZobHbQdUJz/ueXb/FhBWw+LEpfZ5FMATygoldUghtcImmWpZL0wJrr9ed6vRKEGMOl3rA2h5tBmqosJ6m33HIEqeajdiaX2vyjsUl1mKpJuIVc/17QLsWy5NlKhaKqT27QACZra1GygwE56aKhAQ5sXcgj76LFHFbip1z6axWu1AIJJAcMKMP+X8yNkSNnQh9VYZImUqDO8By4O7RqaUrXq90zJIFfv9NrQ/4rdtXNZFc8m4rMSMDYQy//DKgEQrT3NmpxJDO2nqt5wUDqTIY1+ZA88x+rveZg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01ec26d3-2260-48db-e49f-08dc43fa171a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:59.1103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1DdjOg6EuPxhNFEbCReL84gOIZgMMTgBR3LNidgERZyfwZbhLHdRzP07R8ZmDNrezsDxhMtvxm8gaR6Kl6My7lXQV83EoDqFgF/+SYrln7o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peng Zhang Passing tainted expression 'ectx->fw_info_strtab_sz' to 'nfp_elf_fwinfo_lookup()', which uses it as a loop boundary. Replace tainted expression with a temp variable to avoid the tainted scalar coverity warning. Coverity issue: 415051 Fixes: c82ca09c441c ("net/nfp: add ELF module") Cc: stable@dpdk.org Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfpcore/nfp_elf.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfpcore/nfp_elf.c b/drivers/net/nfp/nfpcore/nfp_elf.c index 1bf68ab3e4..cfa59ed16d 100644 --- a/drivers/net/nfp/nfpcore/nfp_elf.c +++ b/drivers/net/nfp/nfpcore/nfp_elf.c @@ -324,14 +324,13 @@ nfp_elf_fwinfo_next(struct nfp_elf *ectx, } static const char * -nfp_elf_fwinfo_lookup(struct nfp_elf *ectx, +nfp_elf_fwinfo_lookup(const char *strtab, + ssize_t tab_sz, const char *key) { size_t s_len; const char *s; size_t key_len = strlen(key); - const char *strtab = ectx->fw_info_strtab; - ssize_t tab_sz = (ssize_t)ectx->fw_info_strtab_sz; if (strtab == NULL) return NULL; @@ -610,7 +609,9 @@ nfp_elf_populate_fw_mip(struct nfp_elf *ectx, { uint8_t *pu8; const char *nx; + ssize_t tab_sz; uint64_t sh_size; + const char *str_tab; uint64_t sh_offset; uint32_t first_entry; const struct nfp_mip *mip; @@ -662,7 +663,9 @@ nfp_elf_populate_fw_mip(struct nfp_elf *ectx, } } - ectx->fw_mip.fw_typeid = nfp_elf_fwinfo_lookup(ectx, "TypeId"); + str_tab = ectx->fw_info_strtab; + tab_sz = (ssize_t)ectx->fw_info_strtab_sz; + ectx->fw_mip.fw_typeid = nfp_elf_fwinfo_lookup(str_tab, tab_sz, "TypeId"); /* * TypeId will be the last reserved key-value pair, so skip