From patchwork Mon Mar 11 11:44:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Herbelot X-Patchwork-Id: 138149 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D4AF43C87; Mon, 11 Mar 2024 12:44:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE0ED4026B; Mon, 11 Mar 2024 12:44:36 +0100 (CET) Received: from mail-ej1-f99.google.com (mail-ej1-f99.google.com [209.85.218.99]) by mails.dpdk.org (Postfix) with ESMTP id 7B6DA40156 for ; Mon, 11 Mar 2024 12:44:35 +0100 (CET) Received: by mail-ej1-f99.google.com with SMTP id a640c23a62f3a-a460185d1a7so223699666b.0 for ; Mon, 11 Mar 2024 04:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1710157475; x=1710762275; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zSN3tPWNOKfUW9xkumiz04TM8548T+KvY2BcNHDdFoo=; b=Pe1E4ZyqRKpr9FfHwQjzoHrK4OBRiNTt2HSm66awcVFJJhQjwjw607CP37NssZEkqN 0BUqLngnM8f4izKHq6v/Hlw3ahHvBsbp1MdvP7TVheBqpc8HIQ50IPjmIUfReCaFf/ie 3TPWHI/aHZoTtcKf53wgOgjouAYAslgaILi8XIeBHQOMTOLmilp4h3eU0lOUbtHRwxf2 +X3Dp7Lmif2abA1xTjngJxRnXMl4b76xQqaKy7zR3LTCv+bdmXbMsPYp00x6DvZLEzgz Cb3KGPlv7by8d0RETj/QtoOJe/91VpaKiV1bzPk4vax45llilQavD9Kvh8rzUfDZzJSz 93Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710157475; x=1710762275; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zSN3tPWNOKfUW9xkumiz04TM8548T+KvY2BcNHDdFoo=; b=ZvdVoV5yyG4EK0/RjN/Dd2eufvR7kC040/nJuCHKVzQaT6WSBgR3hwVwYtO4Hig5w1 TIy+hN1mRxaVnqJz+wq4SQkq39f9qqgOTsg469kpMh92HijYSyW9lVsUL8Yenb01T8VW /akaWOR0oKVRKu5QgTBKhiI6eYIKPpsIvw/Gmofi4mpH44qfvFO2vrQvw7OLz4fpfupv IZ5reqNqagV4uYTC2wFwHnFUALgPlxor1D0ZOl/V5AThe7owbCBcnUYyCOYutRtQ147N QAs/3Yd9UTy+mNTzEqDSzb5cnlQIEfIiWtfs/YhpsjxgUbG0NFq9vgaU2xs9hjeBTaj8 Ae8A== X-Gm-Message-State: AOJu0YzTuPEGHetaGJdPNHwoBMrJ/waAjI8cJVKwattkLP5205B2zpDG ZGrciK/xPyqU0NihT/erLlQ4zckf6wdzEzhYxrUKfcT0eMFlXZELhvHU+AFeFMKjmKXIs+7RRFS 1ftCO50ePF6BYhDcDp6EV+ZvsiTptNvQ= X-Google-Smtp-Source: AGHT+IFXMj3e3sKp8gLLXuk7azoE5mCEn22DlmnxLvITwh6v3i3DTXPT4P8PccJDAhjrUlwhNxgUzv2CazOY X-Received: by 2002:a17:906:5a98:b0:a46:2c48:6654 with SMTP id l24-20020a1709065a9800b00a462c486654mr1136147ejq.49.1710157474839; Mon, 11 Mar 2024 04:44:34 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id ht17-20020a170907609100b00a45f1938f0csm134095ejc.169.2024.03.11.04.44.34; Mon, 11 Mar 2024 04:44:34 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (vader.dev.6wind.com [10.17.1.39]) by smtpservice.6wind.com (Postfix) with ESMTP id 70DC660235; Mon, 11 Mar 2024 12:44:34 +0100 (CET) From: Thierry Herbelot To: dev@dpdk.org Cc: Thierry Herbelot , Thomas Monjalon , Harman Kalra , Ferruh Yigit Subject: [PATCH] ethdev: restore eth_da init at startup of rte_eth_devargs_parse() Date: Mon, 11 Mar 2024 12:44:20 +0100 Message-Id: <20240311114420.2706521-1-thierry.herbelot@6wind.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Commit 9a9eb104ed ("ethdev: parse multiple representor devargs") removes the following variable initialization in rte_eth_devargs_parse(): memset(eth_da, 0, sizeof(*eth_da)); Restore the memset, as this causes regression in ixgbe PCI probe. Fixes: 9a9eb104ed ("ethdev: parse multiple representor devargs") Signed-off-by: Thierry Herbelot --- lib/ethdev/ethdev_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index 1660dd3f2a46..7513b990157f 100644 --- a/lib/ethdev/ethdev_driver.c +++ b/lib/ethdev/ethdev_driver.c @@ -617,6 +617,8 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_devargs, unsigned int i; int result = 0; + memset(eth_da, 0, sizeof(*eth_da)); + result = eth_dev_devargs_tokenise(&args, dargs); if (result < 0) goto parse_cleanup;