From patchwork Wed Mar 6 14:35:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Szczepanek X-Patchwork-Id: 138047 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D1CF43C5E; Wed, 6 Mar 2024 15:35:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE5EB42E06; Wed, 6 Mar 2024 15:35:55 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 52B6440A6D for ; Wed, 6 Mar 2024 15:35:54 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BE7A4C15; Wed, 6 Mar 2024 06:36:30 -0800 (PST) Received: from ampere-altra-2-1.usa.Arm.com (ampere-altra-2-1.usa.arm.com [10.118.91.158]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 664263F762; Wed, 6 Mar 2024 06:35:53 -0800 (PST) From: Paul Szczepanek To: thomas@monjalon.net Cc: dev@dpdk.org, Paul Szczepanek Subject: [RFC v1 1/1] devtools: allow libraries with no global section Date: Wed, 6 Mar 2024 14:35:39 +0000 Message-Id: <20240306143539.160467-2-paul.szczepanek@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240306143539.160467-1-paul.szczepanek@arm.com> References: <20240306143539.160467-1-paul.szczepanek@arm.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If a library has no global section in the version.map allow it not to have symbols and not report it as an error. This happens if a library doesn't export any functions if they're all inline. Signed-off-by: Paul Szczepanek --- devtools/check-symbol-maps.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index ba2f892f56..380a251aea 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -63,7 +63,9 @@ fi find_empty_maps () { for map in $@ ; do - [ $(buildtools/map-list-symbol.sh $map | wc -l) != '0' ] || echo $map + # ignore maps that do not have a 'global:' section since they are empty by design + [ $(buildtools/map-list-symbol.sh $map | wc -l) != '0' ] || + ! grep -q 'global:' $map || echo $map done }