From patchwork Fri Mar 1 17:57:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137765 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A66D43BCF; Fri, 1 Mar 2024 18:59:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 675774336B; Fri, 1 Mar 2024 18:58:56 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id A8C4B402B8 for ; Fri, 1 Mar 2024 18:58:54 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6e5b1c6daa3so1101553b3a.1 for ; Fri, 01 Mar 2024 09:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315934; x=1709920734; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q4gCPFCZiusU7DXzdmfnugs83wHBC2kZqNKZjHn1Ju0=; b=Hzbe/c5x5mzKiQGdFvi90OLsmU6wjt/MNeuj75F41rzeCZXNNToWFc4XhOP7xpTUha S92EqSWWTkc0Kec2n35Vp0dNBB0ovYmHXpFStRaprCZsO2PEm8w+b43ZqfHXo9+WlKD5 Iv6Q0S6vY6Oc2vnWYKqsGibPOvqvS8r78xt+Pz0iqjdS/Vo3fuycDL0/bIOpJw8Lse6+ Q1jbv7OZDhfyS5CkyYgqzPvDZZOZn9pqz8dy6zsOk4vMTLU4+ZUlW+ELvuZCmxxkf/zF Hgxi+1mHNU0U62lumFmmdT6zE2RK65UwDZ5gOilmfOiVmlDpBMPd0PwG+PbaRVJ05Ema eDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315934; x=1709920734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q4gCPFCZiusU7DXzdmfnugs83wHBC2kZqNKZjHn1Ju0=; b=fTw6MXUYGurr+Lg7mdi2ubE8pdCAaqnd58jLl/citXGd1gKWMLNNIwj/i5nwprzIdP PiuKKmKAbwMJB8XnA37WA4x3L2R2rQ/0zhrRHRrTwFoO1a/EFKl3udYmpQU3njczrEIE sLfC2XU8q2zLvO75FPoFC40iB9FgzKmSamgocpDMgRP+iwKyO69amqwErNsNHQndgN+6 lKmw76QyIHTyPjzq3VsdPQUMs46H/WcT0+unEZx+Ss2psAuPxDyUILLG8AC5mztixZTt hzEsifTxNQywjrc3O7/ZmKUccoKZqhqK3KLxo0MYmjqPvd9QGFgnRQINAcEe1FnXvF7K k0WQ== X-Gm-Message-State: AOJu0Yz241SmgC6/JBw2A4ALkknhTlQSFhnNXtVeJZ5zR4XiV1/4QjFB O65W1ktWU/n92/PNplrBMwx8E/5UVXqWMF0IXmk00sxys9DGC74LXH+kjwjYE2Pq+deeh0HFQgc NoHWMkA== X-Google-Smtp-Source: AGHT+IGEBZSo7z2Mdhxh0HuWYOY8TJyrd8UdI09eI2Nh0VQaOfhU1YFrGeb6RilXhDcOYBr49JfbtA== X-Received: by 2002:a05:6a00:4f94:b0:6e4:ea68:633f with SMTP id ld20-20020a056a004f9400b006e4ea68633fmr2665016pfb.20.1709315933775; Fri, 01 Mar 2024 09:58:53 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:58:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev , Ray Kinsella Subject: [PATCH 1/6] test/bpf: make sure mbuf is initialized Date: Fri, 1 Mar 2024 09:57:06 -0800 Message-ID: <20240301175842.159967-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301175842.159967-1-stephen@networkplumber.org> References: <20240301175842.159967-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The BPF filter test was not initializing off load flags. Coverity issue: 375844 Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- app/test/test_bpf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index f83e72a9adfd..53e3a3112371 100644 --- a/app/test/test_bpf.c +++ b/app/test/test_bpf.c @@ -3341,6 +3341,7 @@ test_bpf_filter_sanity(pcap_t *pcap) struct rte_ipv4_hdr ip_hdr; } *hdr; + memset(&mb, 0, sizeof(mb)); dummy_mbuf_prep(&mb, tbuf, sizeof(tbuf), plen); m = &mb; From patchwork Fri Mar 1 17:57:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137766 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03D5843BCF; Fri, 1 Mar 2024 18:59:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA647433B0; Fri, 1 Mar 2024 18:58:57 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 71CFA43356 for ; Fri, 1 Mar 2024 18:58:55 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5cddfe0cb64so1744800a12.0 for ; Fri, 01 Mar 2024 09:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315934; x=1709920734; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lGQdDTVn0PvkRIF4u+Q6CDCVKPY8i2MnOJieV6tbf/Y=; b=VYHTYTCxWtfYw1AAFi6f0SsLHgc72qAqbs3t/wNd95o2RRazpcQvp/O/GzwkyUNb/L oqBS50A2p9E+YEzPnJxmy5AvR+9+oq4abBN75CogfuEU8Eb4Fw+uV0IYKbcby8OcSBnX aMWJHCeFAnNPihWnw02zAXAWT/WSnTdWp8JONGlCnbwQGx8YDFsQkEDoxs70wsB6jqga FTTZuC9h4cF3kfNmv8qBvu7Y11S2imFKoAwQa5wZ1FTMb60ByoYFRLS90jefv/PlsBtW vskckuuH5JV+MpLeqVSelMm/7Vja9TyHjM9vn6vQqecGt2+DVz11tpGCFx6JYp6IdpA3 JCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315934; x=1709920734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lGQdDTVn0PvkRIF4u+Q6CDCVKPY8i2MnOJieV6tbf/Y=; b=Bl9uclfmlfrPNtcwtn9LepeaVhGu3i6hS99Iw68mIQ69Xgih3q+e+rRm6KkCA+a1Be smFSc6ZmMxipfXuvJFrCc7l5wgH7vcJ8KnSUD07rS5m26q1gnnly8qOFSnxpCpUZxaOR tgHV/V+J7Fn/zfUx895BIuSBU9zCPFdjMHiD2t94zRiF1mogUXZ1D1avlK9Cw2ld5ZZ1 WKnW5G3vNHrQTxmZPaTnG5/eYwOvQ9ZQFdCRoiYI3Dw1HlpowJnGKgQwzHPqwZkiUpwt iipRjsw+7//h1fwCubX1+hLYqFSNFtDAZ1X+ABp7/dPAmblh2YEdF7WWa8ck4XlUMLwF vg1Q== X-Gm-Message-State: AOJu0YyrqELpnN8QC7sa3jinIB/86dI4QYYJt8hEqy7bi6TsX3aCZ3fo QpteFBdCCZ19i1RrJWupGIns53Iqh83sJjb3mHSualmxVBlXMR/Xc12Tf/NiKH0S666q0Y9Bl5v 7V2KKgg== X-Google-Smtp-Source: AGHT+IFbvWZx9n1kOVk+Y8YiRHlmFyCmtA/cf3GnWOflaU51BKAu03doKltUnGV5edZUj0chlDQHxQ== X-Received: by 2002:a05:6a20:7f99:b0:1a0:f3d0:15af with SMTP id d25-20020a056a207f9900b001a0f3d015afmr2182029pzj.34.1709315934607; Fri, 01 Mar 2024 09:58:54 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:58:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Keith Wiles Subject: [PATCH 2/6] net/tap: log if netlink ext ack not possible Date: Fri, 1 Mar 2024 09:57:07 -0800 Message-ID: <20240301175842.159967-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301175842.159967-1-stephen@networkplumber.org> References: <20240301175842.159967-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If kernel doesn't support external ack, log that to aide in any problem diagnosis. Coverity issue: 362848 Fixes: 647909bcf34b ("net/tap: use netlink extended ack support") Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.c index 75af3404b035..d9c260127d52 100644 --- a/drivers/net/tap/tap_netlink.c +++ b/drivers/net/tap/tap_netlink.c @@ -72,7 +72,8 @@ tap_nl_init(uint32_t nl_groups) #ifdef NETLINK_EXT_ACK /* Ask for extended ACK response. on older kernel will ignore request. */ - setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one)); + if (setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one)) < 0) + TAP_LOG(NOTICE, "Unable to request netlink error information"); #endif if (bind(fd, (struct sockaddr *)&local, sizeof(local)) < 0) { From patchwork Fri Mar 1 17:57:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137767 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75FE243BCF; Fri, 1 Mar 2024 18:59:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53E3E433E8; Fri, 1 Mar 2024 18:58:59 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 2E65E4335E for ; Fri, 1 Mar 2024 18:58:56 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6e53f3f1f82so1687456b3a.2 for ; Fri, 01 Mar 2024 09:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315935; x=1709920735; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2d7NCd2qXWnxq7Co6oImJ9oP+LBIrVz9yIEOvUJkAlA=; b=Y1hStP0OCIdqqwGyP6tuFY5q3Xc4j7j0gCcLaL0z2p+i9Ac4iqtyMRdca2iirP18Xl JiJl49jsU1lc/mOpN/UOW1oakkr++ul9Gt5r9RLWupax2xmx5Z02v71oOR0NDBuZwfTQ P8Fd1jzx6g5juCisLDwIgd+JtCwpju1CyrxwbSzMsky/9DXI3g+aHC+5TANzVyRhKcDU v7ovAPF0JY/bVGiUCANHRY2iA3fyBY+VnOT24i57iK7oVzRsA220ZIWHVZag7VNRKohM /GV21o0Iug5/cVE6/q9/OvoqYoc4A8qSsKVBQpwLsEOe1RiLkH93ztnUr4SNNBOPdxNJ 0AEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315935; x=1709920735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2d7NCd2qXWnxq7Co6oImJ9oP+LBIrVz9yIEOvUJkAlA=; b=EHDHRAirERjZReV5XLxa0Wa3+iS99s7urrZ9hEmYSkwvOlpMy9wW1Pl1QxFJAgFJI3 A2zbHZzsJHY7QH09C87wh41u123nods/uoxczm0lukSk/y4+8Eg9HzzRAVA+zFVvyI0K sbxRRodBMxQRxLSEY5o4j1RZriSHqLo6CyPoQFQK/6YuvNwNxN4ejedyuuWxTlSw0JLO Yv7KqLe9QRoisNlnJApUa2BOzxfIO7LQTOnf1+59J+zZ+o8AW2B3NSAf8BsCJHq2+JnO b42ZpcT/r7AAfXxSy0hSPDtMKhZywX8/BEWY0d8TlBD/Xe6eY3FcO1kXbxbER7/Tn/NQ betQ== X-Gm-Message-State: AOJu0YwSAoMR7uasLGXk/9mq7+91yjoYDqOBkkI3/JCsOkSNn9R1LgLY ixBenvDNjXLI7yHcROHd33voKNh5UGnt7kthNAFZq5FMj/KhkkVeCdTLxdQsx7KFJbYAFDrsF8N BD/qDrg== X-Google-Smtp-Source: AGHT+IFFoEnWCYSxuQWEpMIiW28Dle+9Q4kXG2Meg5LvHM9EOgDBR7XBjsdUarDE8a44H0N/u5fyPg== X-Received: by 2002:a05:6a00:4fc4:b0:6e5:7ac8:c27e with SMTP id le4-20020a056a004fc400b006e57ac8c27emr2425827pfb.22.1709315935288; Fri, 01 Mar 2024 09:58:55 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:58:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 3/6] examples/l2fwd-keepalive: use rte_drand_max Date: Fri, 1 Mar 2024 09:57:08 -0800 Message-ID: <20240301175842.159967-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301175842.159967-1-stephen@networkplumber.org> References: <20240301175842.159967-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There is a better way than using rand() to compute a random interval. Signed-off-by: Stephen Hemminger --- examples/l2fwd-keepalive/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index 7e0f99a361bc..c077e7f3d4f0 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -220,7 +221,7 @@ l2fwd_main_loop(void) } uint64_t tsc_initial = rte_rdtsc(); - uint64_t tsc_lifetime = (rand()&0x07) * rte_get_tsc_hz(); + uint64_t tsc_lifetime = rte_rand_max(8 * rte_get_tsc_hz()); while (!terminate_signal_received) { /* Keepalive heartbeat. 8< */ From patchwork Fri Mar 1 17:57:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137768 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2E0143BCF; Fri, 1 Mar 2024 18:59:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82B46433EF; Fri, 1 Mar 2024 18:59:00 +0100 (CET) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by mails.dpdk.org (Postfix) with ESMTP id BA56C4336E for ; Fri, 1 Mar 2024 18:58:56 +0100 (CET) Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3c19bc08f96so1969369b6e.2 for ; Fri, 01 Mar 2024 09:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315936; x=1709920736; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lAKHHOeyOrADvZoZlagpBMrnt1cOInFGnnxvfeaQEQ8=; b=xJrLvunXporpcnLXV+NXYPbl+8AVaAlCpCIVo7WyYu6PSJNY0QJxcImNkM/DjNt22v EhDPxZ0mkgq4QF2M4N6GydXWWb3/V3cxVBlWtQ1ELulqg1FY56oaHIJ9Hoyvr3CFn3V5 ksZDX0S3UpzzKUTRby6l9rjU1v8AxIJd8h0mdCGWgNhk1/mgLvj1TvFj5EWF+1PiLz81 PekPABf6tcYc2WFrkPNzIRpY+1CZB3n8gKEy9/E//2IYr7bx85dUhhE4JLQHo4JHw3Kz CCvv8WB18I4oRV8jrGa2HizW3NRT4mID4Fav5lv0yuyhkMHcntnQgFesN1/NiYg6p6CB 68uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315936; x=1709920736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lAKHHOeyOrADvZoZlagpBMrnt1cOInFGnnxvfeaQEQ8=; b=gGqajXTi/zvvvCzovrtvRa2dQmCVyUKeFTqrPgXZZ5eutCxZXMktA2IMohhFVRMeCQ xRo4p+z/TjK50542oZwdIPrrV0du3gpXFyqrjs00LAVCRcUaNl4f92BT4yXpLez7/DiQ eh4b68sCXexLhpul/qgmnUW64FgcaRQ420enosb9RxiCMlYa389fwvQafuwuDerHkH8j 6rVS/wO5wf8t63ts0gFniZ8sF2haVrna/mTrduHUt0a/r5EybESZIW92TTy0QW5UR5g8 OvASHNm2AUF/xIxX9irZ0Ra05rcedhCQH0RC32levxqvpH3Su4HAV6840AJBwJhsySMU R7dA== X-Gm-Message-State: AOJu0Yy0qhhJEIIF73nh/CKEwamaSyb0XlOS6QVJ+sj+3zwuhSpgZ4ph EV+81HEbmHn5sE4TIEGf944hXX6EZ5bq90zgtR+3TbplIHtE2cKbB+WHnk/3b0PND9Qhclc04vN 8mm7wUg== X-Google-Smtp-Source: AGHT+IHPn9KP0rQzAALHQPlMEkl3YkyF5NusNoK+qwDldg6pQN8dE9YmRibsSsLLZLPQpsUJ+aMArg== X-Received: by 2002:a05:6808:1492:b0:3c1:7c55:3730 with SMTP id e18-20020a056808149200b003c17c553730mr2569537oiw.42.1709315936034; Fri, 01 Mar 2024 09:58:56 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:58:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Devendra Singh Rawat , Alok Prasad Subject: [PATCH 4/6] net/qede: replace use of rand() Date: Fri, 1 Mar 2024 09:57:09 -0800 Message-ID: <20240301175842.159967-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301175842.159967-1-stephen@networkplumber.org> References: <20240301175842.159967-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function of rand() is a weak random number generator. Use the DPDK rte_rand() instead. Note: this doesn't matter for real security, since most drivers use a fixed RSS default key. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- drivers/net/qede/qede_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 254548d40638..bee9fa4f60a1 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -7,6 +7,7 @@ #include "qede_ethdev.h" #include #include +#include #include static const struct qed_eth_ops *qed_ops; @@ -1040,9 +1041,8 @@ static void qede_prandom_bytes(uint32_t *buff) { uint8_t i; - srand((unsigned int)time(NULL)); for (i = 0; i < ECORE_RSS_KEY_SIZE; i++) - buff[i] = rand(); + buff[i] = rte_rand(); } int qede_config_rss(struct rte_eth_dev *eth_dev) From patchwork Fri Mar 1 17:57:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137769 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C72B43BCF; Fri, 1 Mar 2024 18:59:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC63B433D2; Fri, 1 Mar 2024 18:59:01 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 6BDAF4336E for ; Fri, 1 Mar 2024 18:58:57 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5cedfc32250so2055787a12.0 for ; Fri, 01 Mar 2024 09:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315936; x=1709920736; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KYCvu9aiBiBRRtmGA6KeVv0Hp4fBfDKD3E7DVfc8K6c=; b=gn4fGtY05JKZLAs1KUkGrP2YebZoU+K0Yrf0f553xRs8AG431HJ0uab42S9JXA5TMS 5hn58FWIMeaQu1Td8S6KI89tXaSa95vAIsI2FClZIiL4ZpdxaAowXbo5g83//4DEKYbc 4KRELStciFmBro1Rc6hPCMP6Ef3X6QHfFRFqiOswZk5G2afTjcy2MYniON2bAnKTZJbR oYO/ZW1+lOTqUBArpqxtyvRM1FHhDh449v1vh5Iwa6fQyfQTfNXxnAK33c5S153PdCTT HOPW8nF9FGSudruQKJO8ME+4kUF9cpKc2qeDBS7SQhh+1lpEsoVVeCUxUw4agJ0M6mr7 +dFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315936; x=1709920736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KYCvu9aiBiBRRtmGA6KeVv0Hp4fBfDKD3E7DVfc8K6c=; b=d+GQf8ntutLOiw2EyBYJTUEOLzRTSa7uVYXcasKquDvo9DqH09l+Iy5m9CMfel7nbh LqCvXGTvF6pVRx+lACFb4Y2EGtbJdU7i+MNpMARuQ6k8bMHLkutz33hWIQwZAOutBLgG 7J4sfcJTXNpc6BRDtLHPgLwVEo5hcwqlxsHuCeDhCJpBGNd/puStrerSY6qyJM6c2xgh EY0U9a5NcnwHTvaUZqn6CN/UwSaP37sw4tfIzrFyRRLAcHFs8P/GCsac1RnrNyWD92sZ fT8ClmYV0/3xS14GBPLNJzdPxqGEjK5Bwqwooq7jsJRxpyJTxYbvkFfEUHenYCwxExfY SBqQ== X-Gm-Message-State: AOJu0Yx4zqs0glCTkZGEct9EncOXTgl2h9EQQuHkpsJ+yyIXImPF5Png XLmH8dVcjpow9MLirJ4Gqs0RZIJZZRJ7TJVDjv6/riR5ork3SQkIL++8Uk7qnEiqwv7x8Z6JMLN YkOWmhw== X-Google-Smtp-Source: AGHT+IGk253H19Hk53uB5e/WYY37bHt7aSE1woVQzNOwVqhufreRIyMyFrUSHKrfY1J+sqrW2t7Anw== X-Received: by 2002:a05:6a20:d044:b0:1a1:1571:84d8 with SMTP id hv4-20020a056a20d04400b001a1157184d8mr2296290pzb.47.1709315936730; Fri, 01 Mar 2024 09:58:56 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:58:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 5/6] pipeline: replace use of rand() Date: Fri, 1 Mar 2024 09:57:10 -0800 Message-ID: <20240301175842.159967-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301175842.159967-1-stephen@networkplumber.org> References: <20240301175842.159967-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rand() function is weak and using it for salt might be a future security issue. Use rte_rand() which has a bigger period and more secure. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- lib/pipeline/rte_swx_ipsec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_ipsec.c b/lib/pipeline/rte_swx_ipsec.c index 28576c2a4812..eb97b9eb9106 100644 --- a/lib/pipeline/rte_swx_ipsec.c +++ b/lib/pipeline/rte_swx_ipsec.c @@ -7,6 +7,7 @@ #include #include +#include #include #include #include @@ -1453,7 +1454,7 @@ crypto_xform_get(struct rte_swx_ipsec_sa_params *p, switch (p->crypto.cipher_auth.cipher.alg) { case RTE_CRYPTO_CIPHER_AES_CBC: case RTE_CRYPTO_CIPHER_3DES_CBC: - salt = (uint32_t)rand(); + salt = rte_rand(); break; case RTE_CRYPTO_CIPHER_AES_CTR: From patchwork Fri Mar 1 17:57:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137770 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4389543BCF; Fri, 1 Mar 2024 18:59:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E241043400; Fri, 1 Mar 2024 18:59:02 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 79AA2433CA for ; Fri, 1 Mar 2024 18:58:58 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e56787e691so2351448b3a.0 for ; Fri, 01 Mar 2024 09:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315938; x=1709920738; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mWyTkg4hZ5fjAqOOVXuZ7rMRAo8qhuFycorX5UVx1sI=; b=XDcrh9r3ll17Ftvo8dRPYaz/YcSuPGcyuJVqfmRzlqyOd6nSOvTZSQwYpAlsyi181K JiwBTJ/DQI109rG2h0N++Q18x7HbeNRm59xJ3V+ITaStPts4yXje9SB3jVWIvCZ+iQoi FGm6aI0NMTP5P11YxBK8YmY4BwG7yL2f0Xkcy9LP0h1ADBdF3gD5FjHYTKw2IjNLdjWW XVVrl56LQH39ITtajO0CjdSiwCTSBwapAB+/G9lgf5GP/bSPw8BHIJjmy5YYAAG9zsUr aCw9p8Orq62z3qXVHpa7dfDMFTGHlK4MmGU5R7jWFXfzUuHsoQnfZObpmXt/q59ose2v 1vUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315938; x=1709920738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mWyTkg4hZ5fjAqOOVXuZ7rMRAo8qhuFycorX5UVx1sI=; b=A1oGEtP7k6arRZm+pGTyUx/s8jtcSMUeprqoAufhQMYprNOCeDduCVEeLffQQK2cn9 FwbzGk0faXFNGx3TQGEh9bKna7nEJuBHL9YvYiqvYHSR5tq2uK/kCCosGo/T4+PECoXF XNCvAvBJ5kHt82x4fkLSc47jwc9rBcCoF5HRaBkj/945vzHyN7ij7tsTT+ipsUbQFOnO bpq2hkpiDXkbwg6RN4LYgoJWPF3EWaUVZjdAjI33NvTPm/5RAQlS1nsUjevK4wYxpDIK OjEsOivhachuqe5a/vNCWgGqxqes6gkcsyOHE6A2CROC/xmwYS58FYRkHIL9h6Evoeo+ fnqg== X-Gm-Message-State: AOJu0YwHXY5dLaoyHXIq9EI2ZbAlkXbfsexwbiM2VnQo7lmP5nVloKqH 3SdKH644ELxEr8A7nL4CRSQ6cyo5YOa4GbXo1EsNMdHLeubGsvhIQedp9/ElUeV2aaMnVQAkW2L FD+wTcw== X-Google-Smtp-Source: AGHT+IHgd9fis+VHtvDilLw7ziU+eaGLAd0IN5JEY8Q39vWonH4iUeioN2k2kCUUfILNDVCqsUWbng== X-Received: by 2002:a05:6a20:144c:b0:1a0:f3f4:3b1a with SMTP id a12-20020a056a20144c00b001a0f3f43b1amr3080858pzi.10.1709315937715; Fri, 01 Mar 2024 09:58:57 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:58:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , hernan.vargas@intel.com, Nicolas Chautru Subject: [PATCH 6/6] baseband/fpga_5gnr: don't use rand() Date: Fri, 1 Mar 2024 09:57:11 -0800 Message-ID: <20240301175842.159967-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301175842.159967-1-stephen@networkplumber.org> References: <20240301175842.159967-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rand is very weak and should not be used. Use the DPDK rte_rand() which is seeded from entropy instead. Coverity issue: 414987 Fixes: b3d326e438f1 ("baseband/fpga_5gnr_fec: add FPGA mutex") Cc: hernan.vargas@intel.com Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff Acked-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c index efc1d3a7725b..9b253cde280d 100644 --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -1990,7 +1991,7 @@ fpga_5gnr_mutex_acquisition(struct fpga_5gnr_queue *q) { uint32_t mutex_ctrl, mutex_read, cnt = 0; /* Assign a unique id for the duration of the DDR access */ - q->ddr_mutex_uuid = rand(); + q->ddr_mutex_uuid = rte_rand(); /* Request and wait for acquisition of the mutex */ mutex_ctrl = (q->ddr_mutex_uuid << 16) + 1; do {