From patchwork Fri Jan 11 17:35:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pattan, Reshma" X-Patchwork-Id: 49740 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07CF81B9FB; Fri, 11 Jan 2019 18:35:37 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 980EB6904; Fri, 11 Jan 2019 18:35:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 09:35:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,466,1539673200"; d="scan'208";a="126944040" Received: from silpixa00398672.ir.intel.com (HELO silpixa00398672.ger.corp.intel.com) ([10.237.222.112]) by orsmga001.jf.intel.com with ESMTP; 11 Jan 2019 09:35:32 -0800 From: Reshma Pattan To: dev@dpdk.org Cc: reshmapa , stable@dpdk.org, ferruh.yigit@intel.com Date: Fri, 11 Jan 2019 17:35:29 +0000 Message-Id: <20190111173529.39661-1-reshma.pattan@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] pdump: fix vdev cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: reshmapa Virtual devices added in pdump application using rte_eal_hotplug_add should be removed explicitly while existing the pdump application, otherwise the subsequent run of the pdump application will fail with the reason that virtaul devices with the same name already exists in primary. Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev attach") CC: stable@dpdk.org CC: ferruh.yigit@intel.com Signed-off-by: Reshma Pattan --- app/pdump/main.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 9e86bf623..5e183ea90 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -494,6 +494,7 @@ cleanup_pdump_resources(void) { int i; struct pdump_tuples *pt; + char name[RTE_ETH_NAME_MAX_LEN]; /* disable pdump and free the pdump_tuple resources */ for (i = 0; i < num_tuples; i++) { @@ -510,6 +511,14 @@ cleanup_pdump_resources(void) free_ring_data(pt->rx_ring, pt->rx_vdev_id, &pt->stats); if (pt->dir & RTE_PDUMP_FLAG_TX) free_ring_data(pt->tx_ring, pt->tx_vdev_id, &pt->stats); + + /* Remove the vdev created */ + rte_eth_dev_get_name_by_port(pt->rx_vdev_id, name); + rte_eal_hotplug_remove("vdev", name); + + rte_eth_dev_get_name_by_port(pt->tx_vdev_id, name); + rte_eal_hotplug_remove("vdev", name); + } cleanup_rings(); }