From patchwork Tue Feb 13 18:34:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136653 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00BC343B0D; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B646B42E10; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8285542D7B for ; Tue, 13 Feb 2024 19:34:54 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B72D020B2000; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B72D020B2000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849293; bh=8yiQuoaEvsBpgDFmtqB/zCheIza0ZwA+e8VH6vTgRVA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GOJO724DdSB+PMPZ1dDNpJ78nm1IKnu5oEg211vFCpZXgor+w1RpXReQVzQA9XaLU FsaIriPts73m/PJiBgCHGvxzakXBD3LKKAJi4WLVPWzbqN8Ub1dLAGTd2ZCneC8yrT 4FEtDXCLTozkIRYDvYSjR5ZTbgjM43uHa0R/4iLk= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 01/21] ring: use C11 alignof Date: Tue, 13 Feb 2024 10:34:32 -0800 Message-Id: <1707849292-19519-2-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve portability between toolchains Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/ring/rte_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index c59f626..a783299 100644 --- a/lib/ring/rte_ring.c +++ b/lib/ring/rte_ring.c @@ -7,6 +7,7 @@ * Used as BSD-3 Licensed with permission from Kip Macy. */ +#include #include #include #include @@ -288,7 +289,7 @@ struct rte_ring * * rte_errno for us appropriately - hence no check in this function */ mz = rte_memzone_reserve_aligned(mz_name, ring_size, socket_id, - mz_flags, __alignof__(*r)); + mz_flags, alignof(typeof(*r))); if (mz != NULL) { r = mz->addr; /* no need to check return value here, we already checked the From patchwork Tue Feb 13 18:34:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136654 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93B6A43B0D; Tue, 13 Feb 2024 19:35:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF00842E35; Tue, 13 Feb 2024 19:34:58 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BB7E342D9A for ; Tue, 13 Feb 2024 19:34:54 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id C603220B2001; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C603220B2001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849293; bh=O/1nNUiswILQ7lcy2U7+2mVX7mTiO8TDNhha6GqF3fA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SDz1jxarh+ZxtFhIH4vElWw63dWt8jMPWdQ3tyIRS3wBBd9ZUzS9PmOeezalS1CKj sPIwb9yjXBFd/J15sUVZ5uXrtAokT1Xdi4CuHO3F4PII9bivNM55fBM3I6CJ7D+7na Ji/KHc/8LOTq7aP/H4hKv5U8hUJOwtRWcH9fy80g= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 02/21] mbuf: use C11 alignof Date: Tue, 13 Feb 2024 10:34:33 -0800 Message-Id: <1707849292-19519-3-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/mbuf/rte_mbuf_dyn.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/mbuf/rte_mbuf_dyn.c b/lib/mbuf/rte_mbuf_dyn.c index 446018f..1cfb329 100644 --- a/lib/mbuf/rte_mbuf_dyn.c +++ b/lib/mbuf/rte_mbuf_dyn.c @@ -2,6 +2,7 @@ * Copyright 2019 6WIND S.A. */ +#include #include #include #include @@ -585,7 +586,7 @@ void rte_mbuf_dyn_dump(FILE *out) static const struct rte_mbuf_dynfield field_desc = { .name = RTE_MBUF_DYNFIELD_TIMESTAMP_NAME, .size = sizeof(rte_mbuf_timestamp_t), - .align = __alignof__(rte_mbuf_timestamp_t), + .align = alignof(rte_mbuf_timestamp_t), }; struct rte_mbuf_dynflag flag_desc = {}; int offset; From patchwork Tue Feb 13 18:34:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136656 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF2A243B0D; Tue, 13 Feb 2024 19:35:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AADB42E48; Tue, 13 Feb 2024 19:35:01 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BFFEA42E0D for ; Tue, 13 Feb 2024 19:34:54 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id D540C20B2002; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D540C20B2002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849293; bh=3fg7spLC0hngMGZH8xo54JL0NMn3n4tYT3LUwgvaLdY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oaGjQjRV7tsA6L5aUfyiZYE7G+VgUv9QFkg1jek/KOIQJhrxkRsNfX53QO3A/7ZqB fHIYl2KYZRmmXL/M1Gcatt8jRW4OWmiECJMotYdVJybUqF9+14HCpp+Me1fIiikqNa XLqog4c/ZPpi2TL1OZRlISOh5sVzuK9LrHSf3jy4= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 03/21] ethdev: use C11 alignof Date: Tue, 13 Feb 2024 10:34:34 -0800 Message-Id: <1707849292-19519-4-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/ethdev/ethdev_driver.c | 3 ++- lib/ethdev/rte_flow.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index bd917a1..4d45fbd 100644 --- a/lib/ethdev/ethdev_driver.c +++ b/lib/ethdev/ethdev_driver.c @@ -2,6 +2,7 @@ * Copyright(c) 2022 Intel Corporation */ +#include #include #include @@ -633,7 +634,7 @@ struct rte_eth_dev * static const struct rte_mbuf_dynfield field_desc = { .name = RTE_MBUF_DYNFIELD_IP_REASSEMBLY_NAME, .size = sizeof(rte_eth_ip_reassembly_dynfield_t), - .align = __alignof__(rte_eth_ip_reassembly_dynfield_t), + .align = alignof(rte_eth_ip_reassembly_dynfield_t), }; static const struct rte_mbuf_dynflag ip_reassembly_dynflag = { .name = RTE_MBUF_DYNFLAG_IP_REASSEMBLY_INCOMPLETE_NAME, diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index f49d1d3..2cd30d6 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -3,6 +3,7 @@ * Copyright 2016 Mellanox Technologies, Ltd */ +#include #include #include #include @@ -281,7 +282,7 @@ struct rte_flow_desc_data { static const struct rte_mbuf_dynfield desc_offs = { .name = RTE_MBUF_DYNFIELD_METADATA_NAME, .size = sizeof(uint32_t), - .align = __alignof__(uint32_t), + .align = alignof(uint32_t), }; static const struct rte_mbuf_dynflag desc_flag = { .name = RTE_MBUF_DYNFLAG_METADATA_NAME, From patchwork Tue Feb 13 18:34:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136655 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2C2143B0D; Tue, 13 Feb 2024 19:35:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1ED4042E3D; Tue, 13 Feb 2024 19:35:00 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id D26DF42E10 for ; Tue, 13 Feb 2024 19:34:54 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id E3B1D20B2003; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E3B1D20B2003 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849293; bh=VCB2qJF4eQ8ElaPO8anD6pc6rcLW/qpqLK/cdxhK8Lg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rAoiEL2H48Ky4iMTtD3pOLMUPtMv5M6MxseCNL8C4Zx4gnDJMmYPHmXaPCs1r7vTr KgqnUt6ZdLqYUkwGnuRc8qOpy7IAmEKqaqRMtMi1uEGL9O/LxaJXnM71uVaeDp4OcE E62Rw5nU/J8wX/9yR987XbuqUiYTz+KyKskQuN/w= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 04/21] eventdev: use C11 alignof Date: Tue, 13 Feb 2024 10:34:35 -0800 Message-Id: <1707849292-19519-5-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/eventdev/rte_eventdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 94628a6..d494f8f 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.c @@ -2,6 +2,7 @@ * Copyright(c) 2016 Cavium, Inc */ +#include #include #include #include @@ -1405,7 +1406,7 @@ int rte_event_dev_selftest(uint8_t dev_id) static const struct rte_mbuf_dynfield test_seqn_dynfield_desc = { .name = "rte_event_pmd_selftest_seqn_dynfield", .size = sizeof(rte_event_pmd_selftest_seqn_t), - .align = __alignof__(rte_event_pmd_selftest_seqn_t), + .align = alignof(rte_event_pmd_selftest_seqn_t), }; struct rte_eventdev *dev = &rte_eventdevs[dev_id]; From patchwork Tue Feb 13 18:34:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136658 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CC6343B0D; Tue, 13 Feb 2024 19:35:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8524842E5A; Tue, 13 Feb 2024 19:35:03 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4FEBA40A4B for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id F1A6F20B2004; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F1A6F20B2004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=R0/wLVGUxFG4hotAWFMLEmB3y1sIbehgVBDMT7foAgc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g3xEfMGvuAwZwkQN15PI2pPGlUIV0gAVy60jQXGxZpe4AV0rzbrg1j/YrwT4PMaYI /BjKilZUV9erNB1mSXfOoemC5jC2I42qDY+aSHAj0AEDlgeHXp2dmkuUrBcELCDA9z yX4dQBFJBfL8pLFF/PtDskq52x5SQy1fugwhOg4c= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 05/21] stack: use C11 alignof Date: Tue, 13 Feb 2024 10:34:36 -0800 Message-Id: <1707849292-19519-6-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/stack/rte_stack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c index 1dab6d6..7261281 100644 --- a/lib/stack/rte_stack.c +++ b/lib/stack/rte_stack.c @@ -2,6 +2,7 @@ * Copyright(c) 2019 Intel Corporation */ +#include #include #include @@ -90,7 +91,7 @@ struct rte_stack * rte_mcfg_tailq_write_lock(); mz = rte_memzone_reserve_aligned(mz_name, sz, socket_id, - 0, __alignof__(*s)); + 0, alignof(typeof(*s))); if (mz == NULL) { STACK_LOG_ERR("Cannot reserve stack memzone!"); rte_mcfg_tailq_write_unlock(); From patchwork Tue Feb 13 18:34:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136659 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06DA343B0D; Tue, 13 Feb 2024 19:35:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F63E42E62; Tue, 13 Feb 2024 19:35:04 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 5BBB942D9A for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0C25820B2005; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0C25820B2005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=RqVk1elwpHjTZIZqMurqmlU76fUlmtuiBk0OjBmuDIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ed0GWFBp/Kbt6EuC0NWokQCz36zAlTDpqHU98rABz4l7A4FIrT2RESplKNe7bQI5l +QikyuWbRQSXSLOBwCUOY+Vt5kY3sLljYH+/LbheVZGJUgGvnX5xD40kS3jRLalA+q Hsm9/mYTbi+7oBASIwed8IyyT1Zbfg4tLYY45PBc= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 06/21] node: use C11 alignof Date: Tue, 13 Feb 2024 10:34:37 -0800 Message-Id: <1707849292-19519-7-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/node/node_private.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/node/node_private.h b/lib/node/node_private.h index 73563e4..2b9bad1 100644 --- a/lib/node/node_private.h +++ b/lib/node/node_private.h @@ -5,6 +5,8 @@ #ifndef __NODE_PRIVATE_H__ #define __NODE_PRIVATE_H__ +#include + #include #include #include @@ -42,7 +44,7 @@ struct node_mbuf_priv1 { static const struct rte_mbuf_dynfield node_mbuf_priv1_dynfield_desc = { .name = "rte_node_dynfield_priv1", .size = sizeof(struct node_mbuf_priv1), - .align = __alignof__(struct node_mbuf_priv1), + .align = alignof(struct node_mbuf_priv1), }; extern int node_mbuf_priv1_dynfield_offset; From patchwork Tue Feb 13 18:34:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136657 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A20DC43B0D; Tue, 13 Feb 2024 19:35:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E62342E4E; Tue, 13 Feb 2024 19:35:02 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 5B97542D7B for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 1B38D20B2006; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1B38D20B2006 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=jwr0J8lmrTnLFefrF4394gVi45vpvqI+Uz0ZaYS+bf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HZZneZVFSjJILbGro+j/OeqwsDX9/I/WeQnmY4SmJBqGy5r2I9sWeS87rhzYL/sFY +D8yc+GwYcnHjuXGvZd6Q1HC4QCDR462rJ2ELl5RO8RqKBDnQrSd88vq+8MjTNyhFH /2kysN+b4c8P5L6A4Ru6UD7AuXGiGnp+brqvnaNY= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 07/21] pdcp: use C11 alignof Date: Tue, 13 Feb 2024 10:34:38 -0800 Message-Id: <1707849292-19519-8-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Anoob Joseph Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/pdcp/rte_pdcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/pdcp/rte_pdcp.c b/lib/pdcp/rte_pdcp.c index 1c6d246..1c076fb 100644 --- a/lib/pdcp/rte_pdcp.c +++ b/lib/pdcp/rte_pdcp.c @@ -2,6 +2,8 @@ * Copyright(C) 2023 Marvell. */ +#include + #include #include #include @@ -32,7 +34,7 @@ struct entity_layout { const struct rte_mbuf_dynfield dynfield_desc = { .name = RTE_PDCP_DYNFIELD_NAME, .size = sizeof(rte_pdcp_dynfield_t), - .align = __alignof__(rte_pdcp_dynfield_t), + .align = alignof(rte_pdcp_dynfield_t), }; if (rte_pdcp_dynfield_offset != -1) From patchwork Tue Feb 13 18:34:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136660 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5CB743B0D; Tue, 13 Feb 2024 19:35:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA3AD42E70; Tue, 13 Feb 2024 19:35:05 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7D35D42E0D for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 2BA6320B2007; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2BA6320B2007 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=6EfPDCs4DyIDmKm0YCllzoEyE2FNR1490bMv8A4pH5o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bLDcqeTXPvSMuIAV4eXFsf3+npILHZQ3GDuXYJDv9x48BuOzb/i7v4xzHJFfyAy5w rz0jpWGp7Om7wUnKsYiTpbUXo+Y0q9GHqIc/Ml3KiBSzZo8Y336M5jik4B0XDs1Jb3 ks3Wk+dAfiyE4ZSA+SNVp+IHQTvS5aCjWcqjk+j0= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 08/21] reorder: use C11 alignof Date: Tue, 13 Feb 2024 10:34:39 -0800 Message-Id: <1707849292-19519-9-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Volodymyr Fialko Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/reorder/rte_reorder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index ff81544..c080b2c 100644 --- a/lib/reorder/rte_reorder.c +++ b/lib/reorder/rte_reorder.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2014 Intel Corporation */ +#include #include #include @@ -72,7 +73,7 @@ struct rte_reorder_buffer * static const struct rte_mbuf_dynfield reorder_seqn_dynfield_desc = { .name = RTE_REORDER_SEQN_DYNFIELD_NAME, .size = sizeof(rte_reorder_seqn_t), - .align = __alignof__(rte_reorder_seqn_t), + .align = alignof(rte_reorder_seqn_t), }; if (b == NULL) { From patchwork Tue Feb 13 18:34:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136661 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA63143B0D; Tue, 13 Feb 2024 19:36:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D21BD42EB2; Tue, 13 Feb 2024 19:35:06 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8D51742E1B for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 3B02D20B2008; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3B02D20B2008 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=qM7iO9n/W0dsOk1b+267ngHiWtMwZShSvqOJswJ79S0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XYvxT/raylJqzP7a4V97YJZwFsAqZWxmI7WZTZZsAx9UET2suRcpwbCdqqeWV1wsc eu7Wrm+qEs6/DA/UWQf9YqYUMFKtYgKmMeBIcaIAFTj4dQxk/dqIMrVUXVP4KU+em7 H3Ee8UfjZLsUeHro6KcBzbLP1sGbHii8VjucKHw8= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 09/21] security: use C11 alignof Date: Tue, 13 Feb 2024 10:34:40 -0800 Message-Id: <1707849292-19519-10-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Akhil Goyal Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/security/rte_security.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index b082a29..e5c862f 100644 --- a/lib/security/rte_security.c +++ b/lib/security/rte_security.c @@ -4,6 +4,7 @@ * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved */ +#include #include #include @@ -38,7 +39,7 @@ static const struct rte_mbuf_dynfield dynfield_desc = { .name = RTE_SECURITY_DYNFIELD_NAME, .size = sizeof(rte_security_dynfield_t), - .align = __alignof__(rte_security_dynfield_t), + .align = alignof(rte_security_dynfield_t), }; rte_security_dynfield_offset = rte_mbuf_dynfield_register(&dynfield_desc); @@ -51,7 +52,7 @@ static const struct rte_mbuf_dynfield dynfield_desc = { .name = RTE_SECURITY_OOP_DYNFIELD_NAME, .size = sizeof(rte_security_oop_dynfield_t), - .align = __alignof__(rte_security_oop_dynfield_t), + .align = alignof(rte_security_oop_dynfield_t), }; rte_security_oop_dynfield_offset = From patchwork Tue Feb 13 18:34:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136663 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9E9843B0D; Tue, 13 Feb 2024 19:36:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12F5842EC1; Tue, 13 Feb 2024 19:35:09 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 837D742E10 for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 4ACA220B2009; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4ACA220B2009 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=jyenPvEHcrqt6izxlPmNOVHkg7GzKVfzC7TyCETChUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FC98RWQpslWoKgs15JaBUDobbpeSDsxOpTGQr9ve6VuIdnjGuNIhCwb3rG+DSuE4f YfTDxkwIN+bjRx8xe1vIAl+8dFQ5B+58oSKzHcarg7vZtAn9vKH511X9uuLz+2KlZN IDyM85TG6fMC3aDGz4OdBAFBzuPqImaVLKg2F1BU= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 10/21] test: use C11 alignof Date: Tue, 13 Feb 2024 10:34:41 -0800 Message-Id: <1707849292-19519-11-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve portability between toolchains Signed-off-by: Tyler Retzlaff --- app/test/test_distributor.c | 3 ++- app/test/test_graph.c | 3 ++- app/test/test_mbuf.c | 9 +++++---- app/test/test_ring_stress_impl.h | 6 ++++-- 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 6cb27f4..d2037b7 100644 --- a/app/test/test_distributor.c +++ b/app/test/test_distributor.c @@ -5,6 +5,7 @@ #include "test.h" #include +#include #include #include #include @@ -831,7 +832,7 @@ int test_error_distributor_create_numworkers(void) static const struct rte_mbuf_dynfield seq_dynfield_desc = { .name = "test_distributor_dynfield_seq", .size = sizeof(seq_dynfield_t), - .align = __alignof__(seq_dynfield_t), + .align = alignof(seq_dynfield_t), }; seq_dynfield_offset = rte_mbuf_dynfield_register(&seq_dynfield_desc); diff --git a/app/test/test_graph.c b/app/test/test_graph.c index 3dd017e..b8409bc 100644 --- a/app/test/test_graph.c +++ b/app/test/test_graph.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -935,7 +936,7 @@ struct test_node_register { static const struct rte_mbuf_dynfield graph_dynfield_desc = { .name = "test_graph_dynfield", .size = sizeof(graph_dynfield_t), - .align = __alignof__(graph_dynfield_t), + .align = alignof(graph_dynfield_t), }; graph_dynfield_offset = rte_mbuf_dynfield_register(&graph_dynfield_desc); diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index d7393df..51ea6ef 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -5,6 +5,7 @@ #include "test.h" #include +#include #include #include #include @@ -2534,19 +2535,19 @@ struct test_case { const struct rte_mbuf_dynfield dynfield = { .name = "test-dynfield", .size = sizeof(uint8_t), - .align = __alignof__(uint8_t), + .align = alignof(uint8_t), .flags = 0, }; const struct rte_mbuf_dynfield dynfield2 = { .name = "test-dynfield2", .size = sizeof(uint16_t), - .align = __alignof__(uint16_t), + .align = alignof(uint16_t), .flags = 0, }; const struct rte_mbuf_dynfield dynfield3 = { .name = "test-dynfield3", .size = sizeof(uint8_t), - .align = __alignof__(uint8_t), + .align = alignof(uint8_t), .flags = 0, }; const struct rte_mbuf_dynfield dynfield_fail_big = { @@ -2564,7 +2565,7 @@ struct test_case { const struct rte_mbuf_dynfield dynfield_fail_flag = { .name = "test-dynfield", .size = sizeof(uint8_t), - .align = __alignof__(uint8_t), + .align = alignof(uint8_t), .flags = 1, }; const struct rte_mbuf_dynflag dynflag_fail_flag = { diff --git a/app/test/test_ring_stress_impl.h b/app/test/test_ring_stress_impl.h index 62f046a..2dec897 100644 --- a/app/test/test_ring_stress_impl.h +++ b/app/test/test_ring_stress_impl.h @@ -2,6 +2,8 @@ * Copyright(c) 2020 Intel Corporation */ +#include + #include "test_ring_stress.h" /** @@ -285,7 +287,7 @@ struct ring_elem { *data = NULL; sz = num * sizeof(*elm); - elm = rte_zmalloc(NULL, sz, __alignof__(*elm)); + elm = rte_zmalloc(NULL, sz, alignof(typeof(*elm))); if (elm == NULL) { printf("%s: alloc(%zu) for %u elems data failed", __func__, sz, num); @@ -297,7 +299,7 @@ struct ring_elem { /* alloc ring */ nr = 2 * num; sz = rte_ring_get_memsize(nr); - r = rte_zmalloc(NULL, sz, __alignof__(*r)); + r = rte_zmalloc(NULL, sz, alignof(typeof(*r))); if (r == NULL) { printf("%s: alloc(%zu) for FIFO with %u elems failed", __func__, sz, nr); From patchwork Tue Feb 13 18:34:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136662 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5751D43B0D; Tue, 13 Feb 2024 19:36:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0017342EBD; Tue, 13 Feb 2024 19:35:07 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A8F6842E1D for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 592D720B200A; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 592D720B200A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=Kb4aCo4NiLPWNn/YrKEVRDbiaEOLyG2UfPV4Mx/qTtM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E5TvvMXNSNyo4K5HI8GO/nDzmzBH9/mkP1FOlwezpopbs50WY6a6uomx1t1CgAQ51 oUB8XK9BW08jniMpf1fw8E371ZYM091jXulHPmUpO8udBcgo8Jh1rEoJ2td11/DuF0 El1DvoTGq7NhFZTCI0d+3WtQzw9an+03Vin99/Ck= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 11/21] examples: use C11 alignof Date: Tue, 13 Feb 2024 10:34:42 -0800 Message-Id: <1707849292-19519-12-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- examples/bbdev_app/main.c | 3 ++- examples/rxtx_callbacks/main.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index ef9cd29..16599ae 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -2,6 +2,7 @@ * Copyright(c) 2017 Intel Corporation */ +#include #include #include #include @@ -1051,7 +1052,7 @@ uint16_t bbdev_parse_number(const char *mask) static const struct rte_mbuf_dynfield input_dynfield_desc = { .name = "example_bbdev_dynfield_input", .size = sizeof(struct rte_mbuf *), - .align = __alignof__(struct rte_mbuf *), + .align = alignof(struct rte_mbuf *), }; __atomic_store_n(&global_exit_flag, 0, __ATOMIC_RELAXED); diff --git a/examples/rxtx_callbacks/main.c b/examples/rxtx_callbacks/main.c index 59eee49..4682921 100644 --- a/examples/rxtx_callbacks/main.c +++ b/examples/rxtx_callbacks/main.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2015 Intel Corporation */ +#include #include #include #include @@ -292,7 +293,7 @@ static const struct rte_mbuf_dynfield tsc_dynfield_desc = { .name = "example_bbdev_dynfield_tsc", .size = sizeof(tsc_t), - .align = __alignof__(tsc_t), + .align = alignof(tsc_t), }; /* init EAL */ From patchwork Tue Feb 13 18:34:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136665 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 864AB43B0D; Tue, 13 Feb 2024 19:36:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13D2E42ECC; Tue, 13 Feb 2024 19:35:11 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id D57AE40A4B for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 67D9A20B200B; Tue, 13 Feb 2024 10:34:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 67D9A20B200B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=WrI1nGovkHnsKbl/OeMAn0fTxMhG+ik8b4Y5SiWU0aA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WB8VanaVRI7Ycw6RjNkRSlM2VPSYvJqYLLdoJ4sVIqdviLvH18qJHQnPkoSimSSp8 NR5ezDnzrZZ35qq9/U3COl5HgeMujGVIZU9hlrFGI/oFp5OjXqt6YYpQ9XfwUPEQNv cRmQudY7cwYAMT87QZ/AUwzyUeqeYT/R4KHEUL1Q= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 12/21] app/eventdev: use C11 alignof Date: Tue, 13 Feb 2024 10:34:43 -0800 Message-Id: <1707849292-19519-13-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- app/test-eventdev/test_order_common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c index 6f00f24..a9894c6 100644 --- a/app/test-eventdev/test_order_common.c +++ b/app/test-eventdev/test_order_common.c @@ -2,6 +2,8 @@ * Copyright(c) 2017 Cavium, Inc */ +#include + #include "test_order_common.h" int @@ -139,12 +141,12 @@ static const struct rte_mbuf_dynfield flow_id_dynfield_desc = { .name = "test_event_dynfield_flow_id", .size = sizeof(flow_id_t), - .align = __alignof__(flow_id_t), + .align = alignof(flow_id_t), }; static const struct rte_mbuf_dynfield seqn_dynfield_desc = { .name = "test_event_dynfield_seqn", .size = sizeof(seqn_t), - .align = __alignof__(seqn_t), + .align = alignof(seqn_t), }; test_order = rte_zmalloc_socket(test->name, sizeof(struct test_order), From patchwork Tue Feb 13 18:34:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136666 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1DF143B0D; Tue, 13 Feb 2024 19:36:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0554842ED0; Tue, 13 Feb 2024 19:35:12 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E31FB42D9A for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 76E2720B200C; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 76E2720B200C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=uNKomE3RW3FJSMlS/LvHVp+inHbjXucZuXOZX1Kwpk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HiuuHeFem8F0l6LUzBrpCqEum7iwaLQtvYQXf1Qs02WwNoMmhk4j+6wb3qAyOXNxf oe+9Tj8hHsf9bi9V0QaFFqr1APG8TWH+L0CrlwCceLTHh7MWHkVzQS7fdeebTpmcPZ yHxL/YA12Dm/zmnpGgvf3EziF8cnm44rbgMOLSMk= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 13/21] drivers/bus: use C11 alignof Date: Tue, 13 Feb 2024 10:34:44 -0800 Message-Id: <1707849292-19519-14-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- drivers/bus/dpaa/dpaa_bus.c | 3 ++- drivers/bus/fslmc/fslmc_bus.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index e57159f..4647360 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -4,6 +4,7 @@ * */ /* System headers */ +#include #include #include #include @@ -307,7 +308,7 @@ int rte_dpaa_portal_init(void *arg) static const struct rte_mbuf_dynfield dpaa_seqn_dynfield_desc = { .name = DPAA_SEQN_DYNFIELD_NAME, .size = sizeof(dpaa_seqn_t), - .align = __alignof__(dpaa_seqn_t), + .align = alignof(dpaa_seqn_t), }; unsigned int cpu, lcore = rte_lcore_id(); int ret; diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index 57bfb51..b1af47c 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bus.c @@ -6,6 +6,7 @@ #include #include +#include #include #include @@ -395,7 +396,7 @@ static const struct rte_mbuf_dynfield dpaa2_seqn_dynfield_desc = { .name = DPAA2_SEQN_DYNFIELD_NAME, .size = sizeof(dpaa2_seqn_t), - .align = __alignof__(dpaa2_seqn_t), + .align = alignof(dpaa2_seqn_t), }; if (TAILQ_EMPTY(&rte_fslmc_bus.device_list)) From patchwork Tue Feb 13 18:34:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136664 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1843743B0D; Tue, 13 Feb 2024 19:36:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0545042EC6; Tue, 13 Feb 2024 19:35:10 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B527842D7B for ; Tue, 13 Feb 2024 19:34:55 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 8707F20B200D; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8707F20B200D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=qT+NxKpIWPqBaTAcJh9oHOF1JXngElBgfbCdspHd51E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F9LjmByRvGiPeDUJL21NYkyy2fRDF1QL4jovQ0ZcdUW3RNzAaYpebilc7gPGIqYqd P+hocT5q3/ASRDkB0UHDpTGCZdz8K9d2u9rgdbcUEZ1cpFH+ui0mlWxWGycr14EWU/ NsBKJ0gmyIRH0z7gx8tbOgQNkktbzI/1cIN/rXI0= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 14/21] event/sw: use C11 alignof Date: Tue, 13 Feb 2024 10:34:45 -0800 Message-Id: <1707849292-19519-15-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- drivers/event/sw/sw_evdev_selftest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c index e6646e5..a2ce140 100644 --- a/drivers/event/sw/sw_evdev_selftest.c +++ b/drivers/event/sw/sw_evdev_selftest.c @@ -2,6 +2,7 @@ * Copyright(c) 2016-2017 Intel Corporation */ +#include #include #include #include @@ -3201,7 +3202,7 @@ struct test_event_dev_stats { static const struct rte_mbuf_dynfield counter_dynfield_desc = { .name = "rte_event_sw_dynfield_selftest_counter", .size = sizeof(counter_dynfield_t), - .align = __alignof__(counter_dynfield_t), + .align = alignof(counter_dynfield_t), }; counter_dynfield_offset = rte_mbuf_dynfield_register(&counter_dynfield_desc); From patchwork Tue Feb 13 18:34:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136667 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98C8343B0D; Tue, 13 Feb 2024 19:36:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5E7142EE2; Tue, 13 Feb 2024 19:35:13 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4405340A4B for ; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 95ED720B200E; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95ED720B200E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=Iok+CALADMWOxtkU/J3rD4qP67QRX2HfluRFbO0quDw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cFPCK6i7QznsVPzTEzAwzAJg+gLfTugg28GayFf3XXJMNwd5TzFopu0a+X383KlDR 7CRQnYYgE5d6tmlIXPE/04pIyxKDruCfooPaB40HeUonY8sOYHp97KxDl5Q5kfKrSd CBV84Mm784nm9zJOJvotZybU8ZlxVvOtBI+etND4= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 15/21] net/bnxt: use C11 alignof Date: Tue, 13 Feb 2024 10:34:46 -0800 Message-Id: <1707849292-19519-16-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index acf7e6e..45d840d 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4,6 +4,7 @@ */ #include +#include #include #include @@ -5920,7 +5921,7 @@ static int bnxt_drv_init(struct rte_eth_dev *eth_dev) static const struct rte_mbuf_dynfield bnxt_cfa_code_dynfield_desc = { .name = RTE_PMD_BNXT_CFA_CODE_DYNFIELD_NAME, .size = sizeof(bnxt_cfa_code_dynfield_t), - .align = __alignof__(bnxt_cfa_code_dynfield_t), + .align = alignof(bnxt_cfa_code_dynfield_t), }; bnxt_cfa_code_dynfield_offset = rte_mbuf_dynfield_register(&bnxt_cfa_code_dynfield_desc); From patchwork Tue Feb 13 18:34:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136669 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87D2743B0D; Tue, 13 Feb 2024 19:36:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABF2742EED; Tue, 13 Feb 2024 19:35:15 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 75FDB42D7B for ; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id A460720B200F; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A460720B200F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=O8bkFhPgm4S/4VR8bKtzndbu6AVGWZEPijApDmSY9Ng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GF2yZnn/vD9N3VOq8WSZQ2wa8UD5hthTI9k8tiw7upMYQCPSarMeNnWJEB+4HKDCV Ld1EhMS86/pog9k+UMCEFAruXrZU8J5y8gJqTLoURb+OrEBGFz7IUEeLuRlAOK3LuK PfpzAsH5eZZBW93NbQQthHdYdFsA/4GI7IURbPic= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 16/21] net/iavf: use C11 alignof Date: Tue, 13 Feb 2024 10:34:47 -0800 Message-Id: <1707849292-19519-17-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- drivers/net/iavf/iavf_ethdev.c | 3 ++- drivers/net/iavf/iavf_ipsec_crypto.c | 4 +++- drivers/net/iavf/iavf_testpmd.c | 3 ++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 1fb876e..0b350e9 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -4,6 +4,7 @@ #include #include +#include #include #include #include @@ -55,7 +56,7 @@ static const struct rte_mbuf_dynfield iavf_proto_xtr_metadata_param = { .name = "intel_pmd_dynfield_proto_xtr_metadata", .size = sizeof(uint32_t), - .align = __alignof__(uint32_t), + .align = alignof(uint32_t), .flags = 0, }; diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c b/drivers/net/iavf/iavf_ipsec_crypto.c index d6c0180..6fd45ff 100644 --- a/drivers/net/iavf/iavf_ipsec_crypto.c +++ b/drivers/net/iavf/iavf_ipsec_crypto.c @@ -2,6 +2,8 @@ * Copyright(c) 2020 Intel Corporation */ +#include + #include #include #include @@ -1535,7 +1537,7 @@ enum rte_crypto_aead_algorithm aead_maptbl[] = { struct rte_mbuf_dynfield pkt_md_dynfield = { .name = "iavf_ipsec_crypto_pkt_metadata", .size = sizeof(struct iavf_ipsec_crypto_pkt_metadata), - .align = __alignof__(struct iavf_ipsec_crypto_pkt_metadata) + .align = alignof(struct iavf_ipsec_crypto_pkt_metadata) }; struct virtchnl_ipsec_cap capabilities; int rc; diff --git a/drivers/net/iavf/iavf_testpmd.c b/drivers/net/iavf/iavf_testpmd.c index 07aac07..775179f 100644 --- a/drivers/net/iavf/iavf_testpmd.c +++ b/drivers/net/iavf/iavf_testpmd.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2016 Intel Corporation. */ +#include #include #include @@ -41,7 +42,7 @@ struct cmd_enable_tx_lldp_result { const struct rte_mbuf_dynfield iavf_tx_lldp_dynfield = { .name = IAVF_TX_LLDP_DYNFIELD, .size = sizeof(uint8_t), - .align = __alignof__(uint8_t), + .align = alignof(uint8_t), .flags = 0 }; int offset; From patchwork Tue Feb 13 18:34:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136668 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0036343B0D; Tue, 13 Feb 2024 19:36:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADD3742EE8; Tue, 13 Feb 2024 19:35:14 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8501E42D9A for ; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B2F1F20B2010; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B2F1F20B2010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=4o4GUcAKYwq8P+ST8YAdSCGQQef5h047chV4NdOKccE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V/PIt8EZpk0/OEdWDjVqwcpQ4143d9QT66AsCPWJ5/foi6GLQhrCrTxUdoMSSibAE 4EVawmU7Z1DuBSs08UPmp7IQRWmPVdIT6GGlrAqYdDMhjC6khVQymRMx0KD4EWdGuY g5f8Alc0Lxszi5SzZvRQdPz7gFq1WZQdX3wNBAVE= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 17/21] net/nfp: use C11 alignof Date: Tue, 13 Feb 2024 10:34:48 -0800 Message-Id: <1707849292-19519-18-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- drivers/net/nfp/nfp_ipsec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index 4529473..6e9bb06 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -3,6 +3,8 @@ * All rights reserved. */ +#include + #include "nfp_ipsec.h" #include @@ -1348,7 +1350,7 @@ enum nfp_ipsec_df_type { static const struct rte_mbuf_dynfield pkt_md_dynfield = { .name = "nfp_ipsec_crypto_pkt_metadata", .size = sizeof(struct nfp_tx_ipsec_desc_msg), - .align = __alignof__(struct nfp_tx_ipsec_desc_msg), + .align = alignof(struct nfp_tx_ipsec_desc_msg), }; ctx = rte_zmalloc("security_ctx", From patchwork Tue Feb 13 18:34:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136670 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E06F243B0D; Tue, 13 Feb 2024 19:37:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DE2F42EF2; Tue, 13 Feb 2024 19:35:16 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 9990E42E0D for ; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id C12D420B2011; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C12D420B2011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=C1OPwGvuiWFRQx9B8Z3057yJTXlevVl3OMfTo8AP3Jo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kU9VcmQeCJyS7se1Oc4cd2UXyt0gqBfdDMugYV3YUtZCmuutExxY/TcloJT1s4y4d WZtKUXKhn2bl12IfdGuVUVtmj1fxK9A2zqvR8HzdB6g/4E1XB6KboJI36UOj5ERTJX 1a3o4/njcrWPeasdG1VxU3EGK09FOcIO7WPHt9+o= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 18/21] net/sfc: use C11 alignof Date: Tue, 13 Feb 2024 10:34:49 -0800 Message-Id: <1707849292-19519-19-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- drivers/net/sfc/sfc_dp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_dp.c b/drivers/net/sfc/sfc_dp.c index 2b0a1d7..7e2a20e 100644 --- a/drivers/net/sfc/sfc_dp.c +++ b/drivers/net/sfc/sfc_dp.c @@ -8,6 +8,7 @@ */ #include +#include #include #include @@ -91,7 +92,7 @@ struct sfc_dp * static const struct rte_mbuf_dynfield mport = { .name = "rte_net_sfc_dynfield_mport", .size = sizeof(efx_mport_id_t), - .align = __alignof__(efx_mport_id_t), + .align = alignof(efx_mport_id_t), }; static const struct rte_mbuf_dynflag mport_override = { .name = "rte_net_sfc_dynflag_mport_override", @@ -134,7 +135,7 @@ struct sfc_dp * static const struct rte_mbuf_dynfield ft_ctx_id = { .name = "rte_net_sfc_dynfield_ft_ctx_id", .size = sizeof(uint8_t), - .align = __alignof__(uint8_t), + .align = alignof(uint8_t), }; int field_offset; From patchwork Tue Feb 13 18:34:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136671 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6314443B0D; Tue, 13 Feb 2024 19:37:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8A5642EF6; Tue, 13 Feb 2024 19:35:17 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B72C742E1B for ; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id D05C720B2012; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D05C720B2012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=HIDqoatjiMeL04O5I5MaMOHAvXluLbzbiH8rzXAxlQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CRloWS6hq/mhrJbBdFoVDvj/LHQmGlAF1kTOSJgBZPD0YIn6+RM1ULeraxkVBQEy6 lZZjGzpcbxd17W0WVWYc0BWZqFAfMd8d+yoYO2hUyAERiMQK1TL0oTePjpWbKRH0j9 mldFscmy0IGbnLypcHvJGxLpoL37UG+hPM9F3rIU= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 19/21] net/virtio: use C11 alignof Date: Tue, 13 Feb 2024 10:34:50 -0800 Message-Id: <1707849292-19519-20-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- drivers/net/virtio/virtio_rxtx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 99b9519..f69b945 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2014 Intel Corporation */ +#include #include #include #include @@ -1797,7 +1798,7 @@ txm->nb_segs == 1 && rte_pktmbuf_headroom(txm) >= hdr_size && rte_is_aligned(rte_pktmbuf_mtod(txm, char *), - __alignof__(struct virtio_net_hdr_mrg_rxbuf))) + alignof(struct virtio_net_hdr_mrg_rxbuf))) can_push = 1; else if (virtio_with_feature(hw, VIRTIO_RING_F_INDIRECT_DESC) && txm->nb_segs < VIRTIO_MAX_TX_INDIRECT) @@ -1878,7 +1879,7 @@ txm->nb_segs == 1 && rte_pktmbuf_headroom(txm) >= hdr_size && rte_is_aligned(rte_pktmbuf_mtod(txm, char *), - __alignof__(struct virtio_net_hdr_mrg_rxbuf))) + alignof(struct virtio_net_hdr_mrg_rxbuf))) can_push = 1; else if (virtio_with_feature(hw, VIRTIO_RING_F_INDIRECT_DESC) && txm->nb_segs < VIRTIO_MAX_TX_INDIRECT) @@ -1980,7 +1981,7 @@ txm->nb_segs == 1 && rte_pktmbuf_headroom(txm) >= hdr_size && rte_is_aligned(rte_pktmbuf_mtod(txm, char *), - __alignof__(struct virtio_net_hdr_mrg_rxbuf))) { + alignof(struct virtio_net_hdr_mrg_rxbuf))) { inorder_pkts[nb_inorder_pkts] = txm; nb_inorder_pkts++; From patchwork Tue Feb 13 18:34:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136672 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56FE843B0D; Tue, 13 Feb 2024 19:37:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7B1642EFA; Tue, 13 Feb 2024 19:35:18 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E63C642E23 for ; Tue, 13 Feb 2024 19:34:56 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id DF56420B2013; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DF56420B2013 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=2P73+zMGf5mbjnhlz3rGnypizAiiN98r73L0v8wKxrY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=joeo/r4uF5lRxxBGoAodVYdzBuWZ8HUiQRPJSF1IfdBXmsFoRn7hZsMk22q+PO5hS LkLh7pKjFR96UmPL9yH9bl5ZWz+pdASQr7Ej23mHJpmuxQphiumOwS2xtUP0OMGNsQ b9YZiWbkAQwRz0WLv/bJ/RMXJ0nPEIQu5lGbQXYU= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 20/21] net/vmxnet3: use C11 alignof Date: Tue, 13 Feb 2024 10:34:51 -0800 Message-Id: <1707849292-19519-21-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __alignof__(T) with C11 alignof(T) to improve portability between toolchains. Signed-off-by: Tyler Retzlaff --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 4fd7040..b239ea3 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -3,6 +3,7 @@ */ #include +#include #include #include #include @@ -367,7 +368,7 @@ struct vmxnet3_xstats_name_off { static const struct rte_mbuf_dynfield vmxnet3_segs_dynfield_desc = { .name = VMXNET3_SEGS_DYNFIELD_NAME, .size = sizeof(vmxnet3_segs_dynfield_t), - .align = __alignof__(vmxnet3_segs_dynfield_t), + .align = alignof(vmxnet3_segs_dynfield_t), }; PMD_INIT_FUNC_TRACE(); From patchwork Tue Feb 13 18:34:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136673 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF46343B0D; Tue, 13 Feb 2024 19:37:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B617742EFC; Tue, 13 Feb 2024 19:35:19 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1E6F842D7B for ; Tue, 13 Feb 2024 19:34:57 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id EE7ED20B2014; Tue, 13 Feb 2024 10:34:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EE7ED20B2014 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707849294; bh=vAFbWuH3EQmhq208jJcWNqYnzvXlxMwI6iAxf97lD44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mQsAcs7UCQ8YeZO33RddpVZRwhmilSBngwyiQ9EdbuPzIcU25dkQ8qStH7Cn0SJV0 GQKlBCoYcUUU0/wv/GG9E2JavUK+15WG91dqCHHrmp4TZa1twv74Q0s4bTODi34EM5 umZ9fBQQg8JkKzR6wF3nNGFui6b+BNdSxNGclc08= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Akhil Goyal , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Chaoyong He , Chenbo Xia , David Hunt , Ferruh Yigit , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Jerin Jacob , Jingjing Wu , Jochen Behrens , John McNamara , Kiran Kumar K , Konstantin Ananyev , Maxime Coquelin , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pavan Nikhilesh , Sachin Saxena , Somnath Kotur , Thomas Monjalon , Volodymyr Fialko , Zhirun Yan , david.marchand@redhat.com, Tyler Retzlaff Subject: [PATCH v2 21/21] devtools: forbid direct use of compiler alignof and typeof Date: Tue, 13 Feb 2024 10:34:52 -0800 Message-Id: <1707849292-19519-22-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> References: <1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com> <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add 2 checks forbidding direct use of __alignof__ and __typeof__ instead C11 alignof and rte_common.h typeof macros should be used. Signed-off-by: Tyler Retzlaff --- devtools/checkpatches.sh | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index c9e466f..e379700 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -151,6 +151,22 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # forbid use of __alignof__ + awk -v FOLDERS="lib drivers app examples" \ + -v EXPRESSIONS='\\<__alignof__\\>' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using __alignof__, prefer C11 alignof' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + + # forbid use of __typeof__ + awk -v FOLDERS="lib drivers app examples" \ + -v EXPRESSIONS='\\<__typeof__\\>' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using __typeof__, prefer typeof' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # forbid use of non abstracted bit count operations awk -v FOLDERS="lib drivers app examples" \ -v EXPRESSIONS='\\<__builtin_(clz|clzll|ctz|ctzll|popcount|popcountll)\\>' \