From patchwork Wed Feb 7 02:18:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 136446 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B7EE43A1B; Wed, 7 Feb 2024 03:19:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E5D84069F; Wed, 7 Feb 2024 03:19:45 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2050.outbound.protection.outlook.com [40.107.102.50]) by mails.dpdk.org (Postfix) with ESMTP id 4C41442D66 for ; Wed, 7 Feb 2024 03:19:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d6JZemqQYyvaM01+JcQRWuVrJmox3zJRZFXKSAGxIMFqENIPdJjk+JTXacTOrYk1jh8w81LUThmr5dge1RZoPu2/Bf4K1HzCCt6Xb72B0THgmEpxvMf2tPt4MibANYVzjZlu9AKixkgxPjGLTBDK41X4ZjNlGOtPDvqTJaGF4tUpFL9iPqcx1C3tAvKDdONkJwVlFyi9P/TqyH9nwqANmVhKCzTYyZMymF5r1TvlJgvN7rlFEMZHo3w3hvdtNmNoc+v1IW//njFaXSsO5ndsnBmiZbJ2PAv2zzljncgEj+NE50VqS8xaPBICEI7vTmQB2zGdS9/9M9RzENoNopxE3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KZ6oICy5KqkhfY18QjOol/NtvCNsb3uhrZVW/XHP7vw=; b=dAUj4Vx9PX/rOBpuiFgt5nJUGHf3FxJZVos816NxiBthc2bA+kH4hGnuzPAfoPMUQ/iCXd6WVgfddrPCbXw9VwdpofskGDEQIkYbTAFnReKMT1TOf+pQYfmI1ImncNi8WmudewCSxHKP2Y8m7fjVvIB44UsjsOBayG2mUDop4YFHBrdGNLn5NVvUoj9QyFSOIc1rxmBMmzN3Wl0K+w1ZZZhqSlCyF6iLF/YOt0Sd7mNTJZs/jSDI40aLIwPHL3EPWsI/lkNlodnBHQ3X5dgg9ALlJ9dmvIWBgu5JBFjJO7DYBei3+T6KSQUGsFybRE3rYzf3upxsuNODodrpC44nWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZ6oICy5KqkhfY18QjOol/NtvCNsb3uhrZVW/XHP7vw=; b=0tF4bRja6ukmmxLuxc9uNVWDUSN6PCnbYtDq12kATyJ3G2NcOJQLMDiManBhxvZwCX9aXHaqTY+OR98AaEBQYuaSl0cq0VLjjZh+n42PcZ8JwXBc2b7M3x3P4iPD9qujonacpcqTXdLIneosHeemHbbZ5hdXrscwQ2PNE9ClQ5o= Received: from PR3PR09CA0005.eurprd09.prod.outlook.com (2603:10a6:102:b7::10) by SA0PR12MB4528.namprd12.prod.outlook.com (2603:10b6:806:9e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb 2024 02:19:41 +0000 Received: from SA2PEPF000015CC.namprd03.prod.outlook.com (2603:10a6:102:b7:cafe::60) by PR3PR09CA0005.outlook.office365.com (2603:10a6:102:b7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend Transport; Wed, 7 Feb 2024 02:19:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF000015CC.mail.protection.outlook.com (10.167.241.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 02:19:39 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 6 Feb 2024 20:19:37 -0600 From: Andrew Boyer To: CC: Andrew Boyer Subject: [PATCH v2 03/13] net/ionic: don't auto-enable Rx scatter-gather a second time Date: Tue, 6 Feb 2024 18:18:39 -0800 Message-ID: <20240207021849.52988-4-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240202193238.62669-1-andrew.boyer@amd.com> References: <20240202193238.62669-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CC:EE_|SA0PR12MB4528:EE_ X-MS-Office365-Filtering-Correlation-Id: 68dc84c8-9dd1-48f0-0172-08dc27833d20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QBskLPIqwyiXX6uTeD+nczFO945kHkWe6+4p4pIOLqaGzIAN9DRmMI1vDxgwxDgBMi7pxQoNIg+7q4RbgEaAAlGcZ3yR9yVj5NH1YUwwlH3DivGw3VtQKe9pNiPeWiEzmNt5SIuJYxrmBNQbcrmlcIK14fNTSNWKc6XlauRPvp4pegV0V4PumMIV3LkUVxngn+VQKmAzj4Y1G6/3PziLLNUNxJhKsHuYKF63JXc4m3iBnmNNX+JQq50doF0s94OB1nubefGeqMvrgs2DNpdeM8k/ESthtvJNdfQGv3PNjQ2c705Ctv31nCU9U5trq+Nu2zao66jaO14h3E40ghC7YOr4vvDeV5VA/QSZUvXSKWaXwtbW00MsVZJstS14tRdToI5ZwtKrG7nXyS8m4V+Z8WgJF1OSUtS+GKSKmDXi+SqYeOFg5r7Vx+RFndm7sZMExrt/AH6aR4JulKhOp+mdTlDxu14VaDGpsxpeofHZCqQcXVdfnG6JIuetfDT5/39NCt5fPmZPxeU6TTvUIqavMmI+34SChLBuvrFqYUnGS0GuZuDTuQ/RYvhs3kF1Fe/4xovmwGJJpdiQEUW94h46ggcw2nwfIQjinSWB7kTICJWESXIyuWb69bM88DbE+8dJl9YITlx2S5pc5WnbpC+HLHp7m5OSt7O9GQooFrv0vh9kVVr1bhv2VOy/4c2TlwcmlKm8bNiHywO17F2L+u9cgfVHnN5CrUm3s8qM7BzDdT8lGuZ+Eakwlx2iKwSyO40aSysjY53fHkohRMOCPagGKQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(376002)(136003)(39860400002)(346002)(230922051799003)(1800799012)(451199024)(82310400011)(64100799003)(186009)(36840700001)(46966006)(40470700004)(40480700001)(40460700003)(2616005)(1076003)(36860700001)(478600001)(86362001)(82740400003)(41300700001)(426003)(83380400001)(26005)(47076005)(36756003)(336012)(16526019)(81166007)(356005)(2906002)(4744005)(5660300002)(6916009)(8936002)(4326008)(8676002)(70586007)(316002)(44832011)(70206006)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 02:19:39.7443 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68dc84c8-9dd1-48f0-0172-08dc27833d20 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4528 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The receive side will enable scatter-gather if required based on the mbuf size. If the client already enabled it in the config, it does not need to be enabled again. This reduces log output. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 25b490deb6..fe2112c057 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -768,7 +768,8 @@ ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index, max_mtu = rte_le_to_cpu_32(lif->adapter->ident.lif.eth.max_mtu); /* If mbufs are too small to hold received packets, enable SG */ - if (max_mtu > hdr_seg_size) { + if (max_mtu > hdr_seg_size && + !(lif->features & IONIC_ETH_HW_RX_SG)) { IONIC_PRINT(NOTICE, "Enabling RX_OFFLOAD_SCATTER"); lif->eth_dev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_SCATTER;